Refactor RP query param test to include nil rp value

Co-authored-by: Jared Scheib <jared.scheib@gmail.com>
pull/3233/head
Iris Scholten 2018-04-13 16:29:30 -07:00
parent e2c2e846a9
commit 2d31da8b96
1 changed files with 30 additions and 24 deletions

View File

@ -63,36 +63,42 @@ func Test_Influx_MakesRequestsToQueryEndpoint(t *testing.T) {
} }
} }
func Test_Influx_MakesRequestToQueryEndpointWithCustomRP(t *testing.T) { func Test_Influx_MakesRequestToQueryEndpoint_Params_RP(t *testing.T) {
t.Parallel() t.Parallel()
crp := "pineapple" wants := []string{"", "pineapple"}
ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
rw.WriteHeader(http.StatusOK)
rw.Write([]byte(`{}`))
u, _ := url.Parse(r.RequestURI) for _, want := range wants {
q := u.Query() ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
rw.WriteHeader(http.StatusOK)
rw.Write([]byte(`{}`))
if rp := q.Get("rp"); rp != crp { u, _ := url.Parse(r.RequestURI)
t.Fatalf("rp query param: want %s, got: %s", crp, rp) q := u.Query()
if rp := q.Get("rp"); rp != want {
t.Fatalf("rp query param: want %s, got: %s", want, rp)
}
}))
defer ts.Close()
var series chronograf.TimeSeries
series, err := NewClient(ts.URL, log.New(log.DebugLevel))
if err != nil {
t.Fatal("Unexpected error initializing client: err:", err)
} }
})) query := chronograf.Query{
defer ts.Close() Command: "SELECT mean(\"usage_user\") FROM cpu WHERE \"cpu\" = 'cpu-total' AND time > now() - 10m GROUP BY host;",
}
if want != "" {
query.RP = want
}
var series chronograf.TimeSeries _, err = series.Query(context.Background(), query)
series, err := NewClient(ts.URL, log.New(log.DebugLevel)) if err != nil {
if err != nil { t.Fatal("Expected no error but was", err)
t.Fatal("Unexpected error initializing client: err:", err) }
}
query := chronograf.Query{
RP: crp,
Command: "SELECT mean(\"usage_user\") FROM cpu WHERE \"cpu\" = 'cpu-total' AND time > now() - 10m GROUP BY host;",
}
_, err = series.Query(context.Background(), query)
if err != nil {
t.Fatal("Expected no error but was", err)
} }
} }