From 03e966a44aa7de52361bcc105809df77002c5b4d Mon Sep 17 00:00:00 2001 From: Jared Scheib Date: Fri, 2 Mar 2018 17:15:47 -0600 Subject: [PATCH] Log error if Heroku API req responds with non-200-range code --- oauth2/heroku.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/oauth2/heroku.go b/oauth2/heroku.go index 205990de2..13121cbfa 100644 --- a/oauth2/heroku.go +++ b/oauth2/heroku.go @@ -2,6 +2,7 @@ package oauth2 import ( "encoding/json" + "fmt" "net/http" "github.com/influxdata/chronograf" @@ -65,6 +66,15 @@ func (h *Heroku) PrincipalID(provider *http.Client) (string, error) { // Requests fail to Heroku unless this Accept header is set. req.Header.Set("Accept", "application/vnd.heroku+json; version=3") resp, err := provider.Do(req) + if resp.StatusCode/100 != 2 { + err := fmt.Errorf( + "Unable to GET user data from %s. Status: %s", + HerokuAccountRoute, + resp.Status, + ) + h.Logger.Error("", err) + return "", err + } if err != nil { h.Logger.Error("Unable to communicate with Heroku. err:", err) return "", err