Fix issues with develop and serve (#24602)

* fix issues with develop and serve

* fix get image data, use hassUrl

* save picture-upload

* Update bundje.cjs

* Prettier

* Fix profile picture in dev serve mode

* person badge too

---------

Co-authored-by: Wendelin <w@pe8.at>

build-scripts/bundle.cjs

@@ -55,7 +55,7 @@ module.exports.definedVars = ({ isProdBuild, latestBuild, defineOverlay }) => ({
   __STATIC_PATH__: "/static/",
   __HASS_URL__: `\`${
     "HASS_URL" in process.env
-      ? process.env["HASS_URL"]
+      ? process.env.HASS_URL
       : "${location.protocol}//${location.host}"
   }\``,
   "process.env.NODE_ENV": JSON.stringify(

build-scripts/gulp/entry-html.js

@@ -56,6 +56,7 @@ const getCommonTemplateVars = () => {
   );
   return {
     modernRegex: compileRegex(browserRegexes.concat(haMacOSRegex)).toString(),
+    hassUrl: process.env.HASS_URL || "",
   };
 };
 

src/components/ha-hls-player.ts

@@ -123,7 +123,7 @@ class HaHLSPlayer extends LitElement {
     try {
       const { url } = await fetchStreamUrl(this.hass!, this.entityid);
 
-      this._url = url;
+      this._url = this.hass.hassUrl(url);
       this._cleanUp();
       this._resetError();
       this._startHls();
@@ -181,15 +181,7 @@ class HaHLSPlayer extends LitElement {
     let playlist_url: string;
     if (match !== null && matchTwice === null) {
       // Only send the regular playlist url if we match exactly once
-      // In case we arrive here with a relative URL, we need to provide a valid
-      // base/absolute URL to avoid the URL() constructor throwing an error.
-      let base_url: string;
-      try {
-        base_url = new URL(this._url).href;
-      } catch (_error) {
-        base_url = new URL(this._url, window.location.href).href;
-      }
-      playlist_url = new URL(match[3], base_url).href;
+      playlist_url = new URL(match[3], this._url).href;
     } else {
       playlist_url = this._url;
     }
@@ -219,7 +211,7 @@ class HaHLSPlayer extends LitElement {
     await this.hass!.auth.external!.fireMessage({
       type: "exoplayer/play_hls",
       payload: {
-        url: new URL(url, window.location.href).toString(),
+        url,
         muted: this.muted,
       },
     });

src/components/ha-picture-upload.ts

@@ -198,7 +198,7 @@ export class HaPictureUpload extends LitElement {
             const url = generateImageThumbnailUrl(mediaId, undefined, true);
             let data;
             try {
-              data = await getImageData(url);
+              data = await getImageData(this.hass, url);
             } catch (err: any) {
               showAlertDialog(this, {
                 text: err.toString(),

src/components/user/ha-person-badge.ts

@@ -4,9 +4,12 @@ import { classMap } from "lit/directives/class-map";
 import { styleMap } from "lit/directives/style-map";
 import type { BasePerson } from "../../data/person";
 import { computeUserInitials } from "../../data/user";
+import type { HomeAssistant } from "../../types";
 
 @customElement("ha-person-badge")
 class PersonBadge extends LitElement {
+  @property({ attribute: false }) public hass!: HomeAssistant;
+
   @property({ attribute: false }) public person?: BasePerson;
 
   protected render() {
@@ -18,7 +21,9 @@ class PersonBadge extends LitElement {
 
     if (picture) {
       return html`<div
-        style=${styleMap({ backgroundImage: `url(${picture})` })}
+        style=${styleMap({
+          backgroundImage: `url(${this.hass.hassUrl(picture)})`,
+        })}
         class="picture"
       ></div>`;
     }

src/components/user/ha-user-badge.ts

@@ -50,7 +50,9 @@ class UserBadge extends LitElement {
 
     if (picture) {
       return html`<div
-        style=${styleMap({ backgroundImage: `url(${picture})` })}
+        style=${styleMap({
+          backgroundImage: `url(${this.hass.hassUrl(picture)})`,
+        })}
         class="picture"
       ></div>`;
     }

src/data/backup_onboarding.ts

@@ -22,7 +22,7 @@ export interface BackupOnboardingConfig extends BackupOnboardingInfo {
 
 export const fetchBackupOnboardingInfo = async () =>
   handleFetchPromise<BackupOnboardingConfig>(
-    fetch("/api/onboarding/backup/info")
+    fetch(`${__HASS_URL__}/api/onboarding/backup/info`)
   );
 
 export interface RestoreOnboardingBackupParams {
@@ -38,7 +38,7 @@ export const restoreOnboardingBackup = async (
   params: RestoreOnboardingBackupParams
 ) =>
   handleFetchPromise(
-    fetch("/api/onboarding/backup/restore", {
+    fetch(`${__HASS_URL__}/api/onboarding/backup/restore`, {
       method: "POST",
       body: JSON.stringify(params),
     })
@@ -58,7 +58,7 @@ export const uploadOnboardingBackup = async (
   });
 
   return handleFetchPromise(
-    fetch(`/api/onboarding/backup/upload?${params.toString()}`, {
+    fetch(`${__HASS_URL__}/api/onboarding/backup/upload?${params.toString()}`, {
       method: "POST",
       body: fd,
     })

src/data/hassio/backup.ts

@@ -214,7 +214,7 @@ export const uploadBackup = async (
     );
   } else {
     // When called from onboarding we don't have hass
-    resp = await fetch("/api/hassio/backups/new/upload", {
+    resp = await fetch(`${__HASS_URL__}/api/hassio/backups/new/upload`, {
       method: "POST",
       body: fd,
     });

src/data/image_upload.ts

@@ -81,8 +81,8 @@ export const deleteImage = (hass: HomeAssistant, id: string) =>
     image_id: id,
   });
 
-export const getImageData = async (url: string) => {
-  const response = await fetch(url);
+export const getImageData = async (hass: HomeAssistant, url: string) => {
+  const response = await fetch(hass.hassUrl(url));
 
   if (!response.ok) {
     throw new Error(

src/data/onboarding.ts

@@ -37,7 +37,7 @@ export interface OnboardingStep {
 }
 
 export const fetchOnboardingOverview = () =>
-  fetch("/api/onboarding", { credentials: "same-origin" });
+  fetch(`${__HASS_URL__}/api/onboarding`, { credentials: "same-origin" });
 
 export const onboardUserStep = (params: {
   client_id: string;
@@ -47,7 +47,7 @@ export const onboardUserStep = (params: {
   language: string;
 }) =>
   handleFetchPromise<OnboardingUserStepResponse>(
-    fetch("/api/onboarding/users", {
+    fetch(`${__HASS_URL__}/api/onboarding/users`, {
       method: "POST",
       credentials: "same-origin",
       body: JSON.stringify(params),
@@ -74,9 +74,12 @@ export const onboardIntegrationStep = (
   );
 
 export const fetchInstallationType = async (): Promise<InstallationType> => {
-  const response = await fetch("/api/onboarding/installation_type", {
-    method: "GET",
-  });
+  const response = await fetch(
+    `${__HASS_URL__}/api/onboarding/installation_type`,
+    {
+      method: "GET",
+    }
+  );
 
   if (response.status === 401) {
     throw Error("unauthorized");

src/html/_header.html.template

@@ -1,5 +1,5 @@
 <meta charset="utf-8" />
-<link rel="manifest" href="/manifest.json" crossorigin="use-credentials" />
+<link rel="manifest" href="<%= hassUrl %>/manifest.json" crossorigin="use-credentials" />
 <link rel="icon" href="/static/icons/favicon.ico" />
 <% for (const entry of latestEntryJS) { %>
   <link rel="modulepreload" href="<%= entry %>" crossorigin="use-credentials" />

src/html/authorize.html.template

@@ -55,7 +55,7 @@
     <%= renderTemplate("_script_loader.html.template") %>
     <script crossorigin="use-credentials">
       if (window.latestJS) {
-        window.providersPromise = fetch("/auth/providers", {
+        window.providersPromise = fetch("<%= hassUrl %>/auth/providers", {
           credentials: "same-origin",
         });
       }

src/html/index.html.template

@@ -89,11 +89,13 @@
         window.latestJS = true;
       }
     </script>
-    <script>
-    {%- for extra_module in extra_modules -%}
-    import("{{ extra_module }}");
-    {%- endfor -%}
-    </script>
+    <% if (obj.hassUrl === "") { %>
+      <script>
+        {%- for extra_module in extra_modules -%}
+        import("{{ extra_module }}");
+        {%- endfor -%}
+      </script>
+    <% } %>
     <script>
         if (!window.latestJS) {
           window.customPanelJS = "<%= es5CustomPanelJS %>";
@@ -102,12 +104,15 @@
           <% } %>
         }
     </script>
-    <script>
-      if (!window.latestJS) {
-        {%- for extra_script in extra_js_es5 -%}
-        _ls("{{ extra_script }}");
-        {%- endfor -%}
-      }
-    </script>
+
+    <% if (obj.hassUrl === "") { %>
+      <script>
+        if (!window.latestJS) {
+          {%- for extra_script in extra_js_es5 -%}
+          _ls("{{ extra_script }}");
+          {%- endfor -%}
+        }
+      </script>
+    <% } %>
   </body>
 </html>

src/html/onboarding.html.template

@@ -51,7 +51,7 @@
     <%= renderTemplate("_script_loader.html.template") %>
     <script crossorigin="use-credentials">
       if (window.latestJS) {
-        window.stepsPromise = fetch("/api/onboarding", {
+        window.stepsPromise = fetch("<%= hassUrl %>/api/onboarding", {
           credentials: "same-origin",
         });
       }

test/data/image_upload.test.ts

@@ -128,12 +128,15 @@ describe("image_upload", () => {
   });
 
   describe("getImageData", () => {
+    const hass = {
+      hassUrl: vi.fn((url) => url),
+    } as unknown as HomeAssistant;
     it("should fetch image data", async () => {
       global.fetch = vi.fn().mockResolvedValue({
         ok: true,
         blob: vi.fn().mockResolvedValue(new Blob()),
       });
-      const data = await getImageData("http://example.com/image.png");
+      const data = await getImageData(hass, "http://example.com/image.png");
       expect(global.fetch).toHaveBeenCalledWith("http://example.com/image.png");
       expect(data).toBeInstanceOf(Blob);
     });
@@ -143,7 +146,7 @@ describe("image_upload", () => {
         .fn()
         .mockResolvedValue({ ok: false, statusText: "Not Found" });
       await expect(
-        getImageData("http://example.com/image.png")
+        getImageData(hass, "http://example.com/image.png")
       ).rejects.toThrow("Failed to fetch image: Not Found");
     });
   });