Require underscore for private methods (#23138)

demo/src/custom-cards/cast-demo-row.ts

@@ -46,7 +46,6 @@ class CastDemoRow extends LitElement implements LovelaceRow {
           this.requestUpdate();
         });
         mgr.castContext.addEventListener(
-          // eslint-disable-next-line no-undef
           cast.framework.CastContextEventType.SESSION_STATE_CHANGED,
           (ev) => {
             // On Android, opening a new session always results in SESSION_RESUMED.

eslint.config.mjs

@@ -114,13 +114,7 @@ export default [
       "@typescript-eslint/no-shadow": ["error"],
 
       "@typescript-eslint/naming-convention": [
-        "off",
+        "warn",
-        {
-          selector: "default",
-          format: ["camelCase", "snake_case"],
-          leadingUnderscore: "allow",
-          trailingUnderscore: "allow",
-        },
         {
           selector: ["variable"],
           format: ["camelCase", "snake_case", "UPPER_CASE"],
@@ -131,6 +125,18 @@ export default [
           selector: "typeLike",
           format: ["PascalCase"],
         },
+        {
+          selector: "method",
+          modifiers: ["public"],
+          format: ["camelCase"],
+          leadingUnderscore: "forbid",
+        },
+        {
+          selector: "method",
+          modifiers: ["private"],
+          format: ["camelCase"],
+          leadingUnderscore: "require",
+        },
       ],
 
       "@typescript-eslint/no-unused-vars": "off",

gallery/src/pages/automation/editor-condition.ts

@@ -1,4 +1,3 @@
-/* eslint-disable lit/no-template-arrow */
 import type { TemplateResult } from "lit";
 import { LitElement, html, css } from "lit";
 import { customElement, state } from "lit/decorators";

gallery/src/pages/components/ha-selector.ts

@@ -1,4 +1,3 @@
-/* eslint-disable lit/no-template-arrow */
 import "@material/mwc-button";
 import type { TemplateResult } from "lit";
 import { css, html, LitElement } from "lit";

src/common/dom/fire_event.ts

@@ -29,7 +29,6 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 declare global {
-  // eslint-disable-next-line
   interface HASSDomEvents {}
 }
 

src/common/dom/scroll-to-target.ts

@@ -14,10 +14,8 @@ export default function scrollToTarget(element, target) {
   const top = 0;
   const scroller = target;
   const easingFn = function easeOutQuad(t, b, c, d) {
-    /* eslint-disable no-param-reassign, space-infix-ops, no-mixed-operators */
     t /= d;
     return -c * t * (t - 2) + b;
-    /* eslint-enable no-param-reassign, space-infix-ops, no-mixed-operators */
   };
   const animationId = Math.random();
   const duration = 200;

src/components/ha-ansi-to-html.ts

@@ -183,7 +183,7 @@ export class HaAnsiToHtml extends LitElement {
 
     /* eslint-disable no-cond-assign */
     let match;
-    // eslint-disable-next-line
+
     while ((match = re.exec(line)) !== null) {
       const j = match!.index;
       const substring = line.substring(i, j);

src/components/ha-form/ha-form-string.ts

@@ -1,4 +1,3 @@
-/* eslint-disable lit/prefer-static-styles */
 import { mdiEye, mdiEyeOff } from "@mdi/js";
 import type { CSSResultGroup, PropertyValues, TemplateResult } from "lit";
 import { LitElement, css, html, nothing } from "lit";

src/components/ha-navigation-picker.ts

@@ -20,7 +20,6 @@ type NavigationItem = {
 
 const DEFAULT_ITEMS: NavigationItem[] = [];
 
-// eslint-disable-next-line lit/prefer-static-styles
 const rowRenderer: ComboBoxLitRenderer<NavigationItem> = (item) => html`
   <mwc-list-item graphic="icon" .twoline=${!!item.title}>
     <ha-icon .icon=${item.icon} slot="graphic"></ha-icon>

src/data/onboarding.ts

@@ -10,7 +10,6 @@ export interface InstallationType {
     | "Unknown";
 }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface OnboardingCoreConfigStepResponse {}
 
 export interface OnboardingUserStepResponse {
@@ -21,7 +20,6 @@ export interface OnboardingIntegrationStepResponse {
   auth_code: string;
 }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface OnboardingAnalyticsStepResponse {}
 
 export interface OnboardingResponses {

src/dialogs/restart/show-dialog-restart.ts

@@ -1,6 +1,5 @@
 import { fireEvent } from "../../common/dom/fire_event";
 
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface RestartDialogParams {}
 
 export const loadRestartDialog = () => import("./dialog-restart");

src/entrypoints/service-worker.ts

@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/triple-slash-reference */
-// eslint-disable-next-line spaced-comment
+
 /// <reference path="../types/service-worker.d.ts" />
 /* eslint-env serviceworker */
 import type { RouteHandler } from "workbox-core";

src/layouts/home-assistant-main.ts

@@ -1,4 +1,3 @@
-/* eslint-disable lit/prefer-static-styles */
 import type { CSSResultGroup, PropertyValues, TemplateResult } from "lit";
 import { css, html, LitElement } from "lit";
 import { customElement, property, state } from "lit/decorators";

src/panels/config/cloud/account/cloud-remote-pref.ts

@@ -13,7 +13,7 @@ import "../../../../components/ha-radio";
 import "../../../../components/ha-settings-row";
 import "../../../../components/ha-switch";
 import "../../../../components/ha-textfield";
-// eslint-disable-next-line
+
 import { formatDate } from "../../../../common/datetime/format_date";
 import type { HaSwitch } from "../../../../components/ha-switch";
 import type { CloudStatusLoggedIn } from "../../../../data/cloud";

src/panels/lovelace/cards/hui-card.ts

@@ -87,7 +87,7 @@ export class HuiCard extends ReactiveElement {
     }
     if (this._element.getLayoutOptions) {
       // Disabled for now to avoid spamming the console, need to be re-enabled when hui-card performance are fixed
-      // eslint-disable-next-line no-console
+
       // console.warn(
       //   `This card (${this.config?.type}) is using "getLayoutOptions" and it is deprecated, contact the developer to suggest to use "getGridOptions" instead`
       // );

src/panels/lovelace/cards/hui-empty-state-card.ts

@@ -15,9 +15,7 @@ export class HuiEmptyStateCard extends LitElement implements LovelaceCard {
     return 2;
   }
 
-  public setConfig(_config: EmptyStateCardConfig): void {
+  public setConfig(_config: EmptyStateCardConfig): void {}
-    // eslint-disable-next-line
-  }
 
   protected render() {
     if (!this.hass) {

src/panels/lovelace/cards/hui-starting-card.ts

@@ -18,9 +18,7 @@ export class HuiStartingCard extends LitElement implements LovelaceCard {
     return 2;
   }
 
-  public setConfig(_config: LovelaceCardConfig): void {
+  public setConfig(_config: LovelaceCardConfig): void {}
-    // eslint-disable-next-line
-  }
 
   protected updated(changedProperties: PropertyValues) {
     super.updated(changedProperties);

src/panels/lovelace/components/hui-marquee.ts

@@ -14,13 +14,12 @@ class HuiMarquee extends LitElement {
   protected firstUpdated(changedProps) {
     super.firstUpdated(changedProps);
 
-    // eslint-disable-next-line wc/no-self-class
     this.addEventListener("mouseover", () => this.classList.add("hovering"), {
       // Capture because we need to run before a parent sets active on us.
       // Hovering will disable the overflow, allowing us to calc if we overflow.
       capture: true,
     });
-    // eslint-disable-next-line wc/no-self-class
+
     this.addEventListener("mouseout", () => this.classList.remove("hovering"));
   }
 

src/panels/lovelace/elements/hui-image-element.ts

@@ -32,7 +32,6 @@ export class HuiImageElement extends LitElement implements LovelaceElement {
 
     this._config = { hold_action: { action: "more-info" }, ...config };
 
-    // eslint-disable-next-line wc/no-self-class
     this.classList.toggle(
       "clickable",
       this._config.tap_action && this._config.tap_action.action !== "none"

src/panels/media-browser/browser-media-player.ts

@@ -99,7 +99,6 @@ export class BrowserMediaPlayer {
       supported_features:
         // eslint-disable-next-line no-bitwise
         MediaPlayerEntityFeature.PLAY |
-        // eslint-disable-next-line no-bitwise
         MediaPlayerEntityFeature.PAUSE |
         MediaPlayerEntityFeature.VOLUME_SET,
     };

src/state/hass-base-mixin.ts

@@ -18,29 +18,18 @@ export class HassBaseEl extends LitElement {
 
   protected initializeHass(_auth: Auth, _conn: Connection) {
     // implemented in connection-mixin
-    // eslint-disable-next-line
   }
 
   // Exists so all methods can safely call super method
-  protected hassConnected() {
+  protected hassConnected() {}
-    // eslint-disable-next-line
-  }
 
-  protected hassReconnected() {
+  protected hassReconnected() {}
-    // eslint-disable-next-line
-  }
 
-  protected hassDisconnected() {
+  protected hassDisconnected() {}
-    // eslint-disable-next-line
-  }
 
-  protected panelUrlChanged(_newPanelUrl) {
+  protected panelUrlChanged(_newPanelUrl) {}
-    // eslint-disable-next-line
-  }
 
-  protected checkDataBaseMigration() {
+  protected checkDataBaseMigration() {}
-    // eslint-disable-next-line
-  }
 
   protected hassChanged(hass, _oldHass) {
     this.__provideHass.forEach((el) => {

src/state/quick-bar-mixin.ts

@@ -65,11 +65,13 @@ export default <T extends Constructor<HassElement>>(superClass: T) =>
         a: (ev) => this._showVoiceCommandDialog(ev),
         d: (ev) => this._showQuickBar(ev, QuickBarMode.Device),
         // Those are fallbacks for non-latin keyboards that don't have e, c, m keys (qwerty-based shortcuts)
+        /* eslint-disable @typescript-eslint/naming-convention */
         KeyE: (ev) => this._showQuickBar(ev),
         KeyC: (ev) => this._showQuickBar(ev, QuickBarMode.Command),
         KeyM: (ev) => this._createMyLink(ev),
         KeyA: (ev) => this._showVoiceCommandDialog(ev),
         KeyD: (ev) => this._showQuickBar(ev, QuickBarMode.Device),
+        /* eslint-enable @typescript-eslint/naming-convention */
       });
     }
 

src/types.ts

@@ -23,7 +23,7 @@ import type { Themes } from "./data/ws-themes";
 import type { ExternalMessaging } from "./external_app/external_messaging";
 
 declare global {
-  /* eslint-disable no-var */
+  /* eslint-disable no-var, @typescript-eslint/naming-convention */
   var __DEV__: boolean;
   var __DEMO__: boolean;
   var __BUILD__: "modern" | "legacy";
@@ -32,7 +32,7 @@ declare global {
   var __BACKWARDS_COMPAT__: boolean;
   var __SUPERVISOR__: boolean;
   var __HASS_URL__: string;
-  /* eslint-enable no-var, no-redeclare */
+  /* eslint-enable no-var, @typescript-eslint/naming-convention */
 
   interface Window {
     // Custom panel entry point url
@@ -70,6 +70,7 @@ declare global {
   // Intl.DurationFormat is not yet part of the TypeScript standard
   // eslint-disable-next-line @typescript-eslint/no-namespace
   namespace Intl {
+    // eslint-disable-next-line @typescript-eslint/naming-convention
     const DurationFormat: DurationFormatConstructor;
   }
 }