528c206094
Add script specific error messages for `response_variable` ( #95188 )
2023-06-24 21:34:57 -07:00
30e8f806c1
Improve service response data APIs ( #94819 )
...
* Improve service response data APIs
Make the API naming more consistent, and require registration that a
service supports response data so that we can better integrate with
the UI and avoid user confusion with better error messages.
* Improve test coverage
* Add an enum for registering response values
* Assign enum values
* Convert SupportsResponse to StrEnum
* Update service call test docstrings
* Add tiny missing full stop in comment
---------
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
2023-06-20 06:24:31 -07:00
c4284c07b6
Allow scripts to capture service response data in variables ( #94757 )
...
* Allow scripts service actions to save return values
* Simplify script service response data
* Rename result_variable to response_variable based on feedback
2023-06-16 22:59:44 -04:00
12129e9d21
Update service call return values and error handling ( #94657 )
...
* Update return signature of service calls
* Add timeout error handling in websocket api for service calls
* Update recorder tests to remove assertion on service call
* Remove timeout behavior and update callers that depend on it today
* Fix tests
* Add missing else
* await coro directly
* Fix more tests
* Update the intent task to use wait instead of timeout
* Remove script service call limits and limit constants
* Update tests that depend on service call limits
* Use wait instead of wait_for and add test
* Update homeassistant/helpers/intent.py
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
---------
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
2023-06-16 07:01:40 -07:00
913156b0e0
Avoid lingering timer on script shutdown ( #89753 )
2023-03-16 08:00:21 +01:00
e40a9822f5
Fix disabled condition within an automation action ( #87213 )
...
fixes undefined
2023-02-02 22:35:02 +01:00
8abce25948
Update Union typing (4) [Py310] ( #86427 )
2023-01-23 09:04:40 +01:00
79b52a2b41
Stricter pylint message control ( #86154 )
2023-01-20 13:47:55 +01:00
7142b4ecac
Fixes some grammar mistakes ( #84283 )
2022-12-20 11:10:31 +01:00
18033532ca
Fix search throwing on templated services ( #79637 )
2022-10-05 10:59:18 +03:00
d3be06906b
Improve type hints in script helpers ( #78364 )
...
* Improve type hints in script helpers
* Import CONF_SERVICE_DATA from homeassistant.const
* Make data optional
2022-09-13 23:11:29 +02:00
99360ad7f4
Indicate disabled steps in script trace ( #71237 )
2022-05-03 13:04:59 +02:00
92f1855bcf
Fix script conditions ( #71235 )
2022-05-03 11:28:08 +02:00
1931600eac
Isolate parallel subscripts ( #71233 )
2022-05-03 10:36:58 +02:00
f6c2fb088c
Stop script if sub-script stops or aborts ( #71195 )
2022-05-02 14:59:58 +02:00
35687def02
Merge stop & error script actions ( #70109 )
2022-04-20 14:22:37 -07:00
1b48d7eda1
Add for each item support to repeat action ( #70093 )
2022-04-15 19:10:25 +02:00
e04fef3c2d
Allow disabling specific triggers/actions/conditions ( #70082 )
2022-04-15 09:33:09 -07:00
cdabcce83a
Add ability to continue scripts/automations on error ( #70004 )
2022-04-14 13:43:14 -07:00
d704d4f853
Add parallel automation/script actions ( #69903 )
2022-04-13 13:07:44 -07:00
67b200a532
Add if/else automation/script action ( #69811 )
...
Co-authored-by: Erik <erik@montnemery.com>
2022-04-12 15:02:17 +02:00
81d90b1bc7
Add stop/error script/automation action ( #67340 )
2022-04-11 14:22:22 -07:00
46f27fdefd
Don't prevent automations from triggering themselves ( #68178 )
2022-03-15 18:48:54 +01:00
8ea31cea3a
Fix deadlock when stopping queued script ( #68175 )
2022-03-15 08:29:04 -07:00
1a27025793
Prevent spawning script runs when shutting down ( #68170 )
2022-03-15 12:46:58 +01:00
65fbcfa0ba
Prevent recursive script calls from deadlocking ( #67861 )
...
* Prevent recursive script calls from deadlocking
* Address review comments, improve tests
* Tweak comment
2022-03-10 19:28:00 +01:00
c2e62e4d9f
Re-org device automations ( #67064 )
...
Co-authored-by: Franck Nijhof <git@frenck.dev>
2022-02-22 13:15:16 -08:00
efb6fd1569
Fix script / automation repeat with count 0 fails ( #65448 )
...
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Erik Montnemery <erik@montnemery.com>
2022-02-03 08:18:58 -08:00
d3b7bd25ef
Update typing (1) ( #63922 )
2022-01-11 21:26:03 +01:00
40262c4763
Fix exception import locations ( #63454 )
2022-01-05 15:00:49 +01:00
2c904c0974
Bump mypy to 0.930 ( #62642 )
...
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
2021-12-27 17:55:17 +01:00
55f4962c06
Fix pylint plugin which checks relative imports ( #62693 )
2021-12-23 11:14:47 -08:00
e48f567176
Wrap shorthand template conditions during schema validation ( #62485 )
2021-12-21 17:20:15 +01:00
334c6c5c02
Make device automation type an enum ( #62354 )
2021-12-20 19:16:30 +01:00
112e259437
Fix threading error in scripts with repeat or choose actions ( #62168 )
2021-12-17 11:41:54 +01:00
17dc609363
Correct validation of conditions in scripts and automations ( #60890 )
...
* Correct validation of conditions in scripts and automations
* Fix test
2021-12-03 09:08:28 -08:00
caf5ee2fab
Remove optional validation when creating conditions ( #60481 )
2021-11-28 14:54:07 +01:00
ea102f71a6
Correct validation of repeats in scripts and automations ( #60318 )
...
* Correct validation of repeats in scripts and automations
* Improve validation test
2021-11-26 14:12:59 +01:00
ad9c3a47cf
Correct validation of conditions in scripts and automations ( #60403 )
2021-11-26 13:21:11 +01:00
10d6247fee
Bump to aiohttp 3.8.0 ( #58974 )
2021-11-04 10:07:50 -05:00
238b488642
Use assignment expressions 03 ( #57710 )
2021-10-17 20:08:11 +02:00
835e07f63e
Remove debug log ( #57619 )
2021-10-13 13:03:52 -07:00
007af4a7aa
Search for areas, devices and entities in script choose actions ( #57554 )
2021-10-12 08:49:07 -07:00
77ee72cbb9
Import Callable from collections.abc (1) ( #56775 )
2021-09-29 16:32:11 +02:00
46c3495ae0
Update pylint to 2.9.5 ( #53496 )
2021-07-26 16:17:15 +02:00
f6b162bc39
Add pylint CodeStyle extension ( #53147 )
2021-07-19 06:57:06 -07:00
470f2dd73f
Upgrade pyupgrade to 2.21.2, apply its changes ( #52987 )
2021-07-19 10:46:09 +02:00
bef8be9256
Support dynamic schema validation in device conditions and actions ( #52007 )
...
* Allow integrations to provide dynamic schema validation in device conditions and actions
* Add tests
* re-add type
* mypy
2021-06-28 09:23:46 +02:00
1ea0d8ae02
Correct trace of condition actions ( #50800 )
2021-05-17 16:54:17 -07:00
b35f229674
Include _StopScript.__cause__ in trace ( #50441 )
...
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
2021-05-11 22:27:11 -07:00
c07646db5d
Update typing syntax ( #49480 )
...
* Update typing syntax
* Replace typing imports with ones from collections where possible
* Changes after review
2021-04-20 17:40:41 +02:00
a968dea152
Fix deadlock when restarting scripts ( #49410 )
2021-04-19 14:45:01 +02:00
970cbcbe15
Type hint improvements ( #49320 )
2021-04-17 08:35:21 +02:00
2c8b7c56f5
Fix race when restarting script ( #49247 )
2021-04-16 09:03:34 +02:00
ff5fbea1fb
Improve trace of template conditions ( #49101 )
...
* Improve trace of template conditions
* Refactor
* Fix wait_template trace
* Update tests
2021-04-12 20:22:28 +02:00
9f481e1642
Include script script_execution in script and automation traces ( #48576 )
2021-04-01 09:42:23 -07:00
d1a1e70726
Search for areas used in automations and scripts ( #48499 )
...
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
2021-03-30 15:01:56 -07:00
2956eb0902
Update pylint to 2.7.3 ( #48488 )
...
* Update pylint to 2.7.3
* Add class-const-naming-style
* Remove unused-import message
* Additional cleanup
2021-03-29 18:02:56 -10:00
63e3012380
Fix script default trace ( #48390 )
2021-03-26 23:56:40 -07:00
9f8b697e64
Refactor tracing: Prepare for tracing of scripts ( #48231 )
2021-03-23 14:53:38 -07:00
6932cf9534
Use contextlib.suppress where possible ( #48189 )
2021-03-23 14:36:43 +01:00
272dffc384
Improve script tracing ( #48100 )
...
* Improve script tracing
* Fix test
2021-03-22 13:15:45 +01:00
4cb7718192
Update typing 16 ( #48087 )
2021-03-18 22:58:19 +01:00
7b717bc437
Correct trace for repeat script actions ( #48031 )
2021-03-18 13:14:06 -07:00
6fb2e63e49
Update typing 02 ( #48014 )
2021-03-17 18:34:19 +01:00
1cde1074c9
Correct trace for choose and repeat script actions ( #47973 )
...
* Correct trace for choose and repeat script actions
* only choose-wrap the choices
* Update tests
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
2021-03-16 08:49:16 +01:00
f82e59c32a
Make it possible to list debug traces for a specific automation ( #47744 )
2021-03-15 16:51:04 -07:00
a9a9e1f199
Tweak automation tracing ( #47721 )
2021-03-10 14:42:13 -08:00
704000c049
Add support for breakpoints in scripts ( #47632 )
2021-03-09 21:23:11 -08:00
ea4f3e31d5
Include changed variables in automation trace ( #47549 )
...
* Include changed variables in automation trace
* Deduplicate some code
* Tweak
* Apply suggestions from code review
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
* Fix format
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
2021-03-08 22:48:36 +01:00
2f9d03d115
Merge action and condition traces ( #47373 )
...
* Merge action and condition traces
* Update __init__.py
* Add typing to AutomationTrace
* Make trace_get prepare a new trace by default
* Correct typing of trace_cv
* Fix tests
2021-03-06 12:57:21 +01:00
3baeed3684
Clean up constants ( #47323 )
2021-03-05 19:08:04 +01:00
17401cbc29
Initial automation tracing ( #46755 )
...
* Initial prototype of automation tracing
* Small fixes
* Lint
* Move trace helpers to its own file
* Improve trace for state and numeric_state conditions
* Tweaks + apply suggestions from code review
* Index traces by automation_id, trace while script is running
* Refactor condition tracing
* Improve WS API to get traces for single automation
* Add tests
* Fix imports
* Fix imports
* Address review comments
* Cap logging of loops
* Remove unused ContextVar action_config
2021-03-04 14:16:24 +01:00
d33a1a5ff8
Refine printing of ConditionError ( #46838 )
...
* Refine printing of ConditionError
* Improve coverage
* name -> type
2021-02-21 14:54:36 +01:00
2d70806035
Add support for "alias" in script steps device, device_condition, and conditions ( #46647 )
...
Co-authored-by: Donnie <donniekarnsinsb@hotmail.com>
2021-02-20 19:21:09 -08:00
aa061e5818
Fix variable name from script refactoring ( #46503 )
2021-02-14 10:52:18 -10:00
a6358430b4
Fix deprecated asyncio.wait use with coroutines ( #44981 )
...
https://docs.python.org/3/library/asyncio-task.html#asyncio-example-wait-coroutine
2021-02-10 14:16:58 +01:00
4b493c5ab9
Add target to service call API ( #45898 )
...
* Add target to service call API
* Fix _async_call_service_step
* CONF_SERVICE_ENTITY_ID overrules target
* Move merging up before processing schema
* Restore services.yaml
* Add test
2021-02-10 12:42:28 +01:00
82607977ef
Various type hint improvements ( #46144 )
2021-02-08 11:59:46 +01:00
b9b1caf4d7
Raise ConditionError for numeric_state errors ( #45923 )
2021-02-08 10:47:57 +01:00
8a7e0241ab
Fix race in script wait for trigger step ( #46055 )
...
* Fix race in script wait for trigger step
* Update script.py
* Update script.py
2021-02-06 10:01:30 +01:00
7673f57248
Add additional error handling for automation script run ( #45613 )
2021-01-28 09:26:41 +01:00
a7741be9bb
Wait for all triggers when one fails to attach ( #45361 )
2021-01-20 22:13:21 +01:00
3a88a4120e
Helpers type hint improvements ( #44964 )
2021-01-09 00:08:34 +01:00
7c93a11aba
Fix wait_template incorrectly matching falsey values ( #44938 )
2021-01-08 13:07:50 +01:00
2ef25e7414
Fix script wait templates with now/utcnow ( #44717 )
2021-01-01 13:03:34 +01:00
ac2af69d26
Fix extracting entity and device IDs from scripts ( #44048 )
...
* Fix extracting entity and device IDs from scripts
* Fix extracting from data_template
2020-12-08 13:06:29 +01:00
5ebf5996f1
Predetermine listener type for script change listeners ( #41510 )
2020-10-09 08:41:12 +02:00
8ae3f575dd
Add extended validation for script repeat/choose ( #41265 )
2020-10-05 14:03:48 +02:00
38d132addd
Fix referenced entity extraction when service call entity contains a template ( #41107 )
2020-10-03 20:55:59 +02:00
f59e727f16
Set variable values in scripts ( #39915 )
...
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
2020-09-11 13:16:25 +02:00
5117a16841
Extract variable rendering ( #39934 )
2020-09-11 12:24:16 +02:00
aa9dff572e
Add default variables to script helper ( #39895 )
2020-09-10 20:41:42 +02:00
63aa46369b
Copy instead of deepcopy the variables in a wait for trigger ( #39796 )
2020-09-08 15:23:38 +02:00
a3c45a6f89
Add shorthand notation for Template conditions ( #39705 )
2020-09-06 16:55:06 +02:00
4486251382
Add max_exceeded log level option to automations & scripts ( #39448 )
2020-09-02 11:05:14 +02:00
b315df2118
Reduce automation state changes by using script helper's last_triggered attribute ( #39323 )
2020-08-28 14:51:15 -05:00
b4bac0f7a0
Exception chaining and wrapping improvements ( #39320 )
...
* Remove unnecessary exception re-wraps
* Preserve exception chains on re-raise
We slap "from cause" to almost all possible cases here. In some cases it
could conceivably be better to do "from None" if we really want to hide
the cause. However those should be in the minority, and "from cause"
should be an improvement over the corresponding raise without a "from"
in all cases anyway.
The only case where we raise from None here is in plex, where the
exception for an original invalid SSL cert is not the root cause for
failure to validate a newly fetched one.
Follow local convention on exception variable names if there is a
consistent one, otherwise `err` to match with majority of codebase.
* Fix mistaken re-wrap in homematicip_cloud/hap.py
Missed the difference between HmipConnectionError and
HmipcConnectionError.
* Do not hide original error on plex new cert validation error
Original is not the cause for the new one, but showing old in the
traceback is useful nevertheless.
2020-08-28 13:50:32 +02:00
1c2ebdf307
Upgrade black to 20.8b1 ( #39287 )
2020-08-27 13:56:20 +02:00
181709f3d2
Allow templates in data & service parameters (making data_template & service_template obsolete) ( #39210 )
2020-08-24 16:21:48 +02:00
Allen Porter
epenet
Karlie Meads
Marc Mueller
Franck Nijhof
Michaël Arnauts
Erik Montnemery
Paulus Schoutsen
mk-maddin
Tobias Sauerwein
Ruslan Sayfutdinov
Ville Skyttä
J. Nick Koston
Raman Gupta
Bram Kragten
tkdrob
Anders Melchiorsen
Thomas Lovén
Phil Bruckner