33eaf081cd
Apply code review changes for poolsense ( #37817 )
2020-07-13 18:04:10 -05:00
6fe54e31cc
Apply code quality updates to poolsense ( #37781 )
...
* Created a binary sensor and corrected some review comments.
* Updated the poolsense class and its interface to handle credentials better
* Moved the client session to the PoolSense class.
* Apply suggestions from code review
* Update binary_sensor.py
* Update homeassistant/components/poolsense/__init__.py
* Update sensor.py
* Update binary_sensor.py
* Removed unnecessary class variable
* Correcting a merge error.
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
2020-07-12 15:33:30 -05:00
8a2b34cc09
Updates to poolsense integration ( #37613 )
...
* Created a binary sensor and corrected some review comments.
* Updated the poolsense class and its interface to handle credentials better
* Moved the client session to the PoolSense class.
* Apply suggestions from code review
* Update binary_sensor.py
* Update homeassistant/components/poolsense/__init__.py
* Update sensor.py
* Update binary_sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
2020-07-10 21:53:34 -05:00
53545c984b
Log lines do not end with a full stop ( #37527 )
2020-07-05 23:04:19 +02:00
1879183b24
Apply some suggestions from poolsense code review ( #37440 )
2020-07-03 15:38:05 -07:00
10786bbe7f
Create PoolSense integration ( #35561 )
...
* Created integration for PoolSense - a device to maintain your pool
* Updated poolsense integration with changes due to code review comments.
* Update poolsense with lint fix (logging-not-lazy)
* Update poolsense with lint fix (f string missing placeholders)
* Update homeassistant/components/poolsense/config_flow.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Added test for poolsense component. Updated config_flow to better follow the guidelines.
* Update tests/components/poolsense/test_config_flow.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update tests/components/poolsense/test_config_flow.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update tests/components/poolsense/test_config_flow.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update tests/components/poolsense/test_config_flow.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update tests/components/poolsense/test_config_flow.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update tests/components/poolsense/test_config_flow.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update tests/components/poolsense/test_config_flow.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update tests/components/poolsense/test_config_flow.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Removed uneccessary functions.
* Added local venv to gitignore
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update to strings to allow for translations. Also some coding convention updates.
* Removed space in icon return
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Removed space in icon return
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Removed space in icon return
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/__init__.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/__init__.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/__init__.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Update homeassistant/components/poolsense/strings.json
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
* Updated to include some error checks for pypi package
* Apply suggestions from code review
* Apply suggestions from code review
* Apply suggestions from code review
* Update tests/components/poolsense/test_config_flow.py
* Update homeassistant/components/poolsense/sensor.py
* Apply suggestions from code review
* Update homeassistant/components/poolsense/__init__.py
* Apply suggestions from code review
* Apply suggestions from code review
* Apply suggestions from code review
* Update homeassistant/components/poolsense/sensor.py
* Apply suggestions from code review
* Update homeassistant/components/poolsense/__init__.py
* Update homeassistant/components/poolsense/sensor.py
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
2020-07-01 00:44:10 -05:00
Haemish Kyd
Franck Nijhof
Chris Talkington