Ville Skyttä
|
e6388e186c
|
Remove unnecessary string literal concatenations (#30360)
|
2020-01-02 21:17:10 +02:00 |
Bas Nijholt
|
c59bf0bff6
|
`genericpath` is an internal Python module and shouldn't be imported according to core Python devs. (see [this](https://bugs.python.org/msg358136) comment) (#29903)
For a reason unknown to me, @exxamalte introduced this in https://github.com/home-assistant/home-assistant/pull/14342.
The problem is that Linux and macOS implement `os.path` differently, one imports from [`ntpath.py`](https://github.com/python/cpython/blob/master/Lib/ntpath.py) and the other one from [`posixpath.py`](https://github.com/python/cpython/blob/master/Lib/posixpath.py), and both these files use `genericpath.py`.
Somehow, `isort` on macOS will see `genericpath` as a third party library and sort it accordingly.
Other Unix-based OSes will correctly treat `genericpath` as an internal library.
This problem led to a sorting sequence in the following commits:
- ca0fad2cbb
- f5d4878992
- 7d68e88d31
- 1fee400dcd
This supersedes https://github.com/home-assistant/home-assistant/pull/29893.
|
2019-12-13 09:47:09 +01:00 |
Alexei Chetroi
|
1fee400dcd
|
Revert "Sort import for tests/components/feedreader/test_init.… (#29882)
This reverts commit 7d68e88d31.
|
2019-12-12 17:10:43 +01:00 |
|
Bas Nijholt
|
7d68e88d31
|
Sort import for tests/components/feedreader/test_init.py (#29878)
This unblocks https://github.com/home-assistant/home-assistant/pull/29739
|
2019-12-12 15:56:32 +01:00 |
Franck Nijhof
|
f5d4878992
|
Fix isort on a small set of misc files (#29803)
|
2019-12-10 09:25:42 +01:00 |
|
Bas Nijholt
|
ca0fad2cbb
|
Sort imports according to PEP8 for components starting with "F" (#29766)
|
2019-12-09 14:14:40 +01:00 |
Malte Franken
|
d200c2dca2
|
fix feedreader handling unrecognized published date (#28225)
|
2019-10-31 21:05:42 +01:00 |
Paulus Schoutsen
|
4de97abc3a
|
Black
|
2019-07-31 12:25:30 -07:00 |
Paulus Schoutsen
|
b8cc547fa3
|
Move components to folders (#20774)
* Move all components into folders
* Move component tests into folders
* Fix init moving
* Move tests
* Lint
* Update coverage
* Fix service descriptions
* Update CODEOWNERS
|
2019-02-05 19:31:15 -08:00 |