Commit Graph

42489 Commits (9afb4c6c9e64acda62cb4b8c45e6db18500fd63c)

Author SHA1 Message Date
Franck Nijhof 54fb0d7cc2
Fix set humidity in Tuya (#80132) 2022-10-11 22:21:59 +03:00
Aaron Bach b446cab03b
Redact additional sensitive fields in ReCollect Waste diagnostics (#80119)
* Redact additional sensitive fields in ReCollect Waste diagnostics

* One call
2022-10-11 13:14:07 -06:00
Aaron Bach f92da26c04
Add config entry to Ridwell diagnostics (#80120) 2022-10-11 13:03:48 -06:00
kingy444 cc13641f29
Powerview Implement remaining types (#80097) 2022-10-11 08:21:54 -10:00
Aaron Bach 1262c0e221
Use `entry.as_dict()` in SimpliSafe diagnostics (#80121) 2022-10-11 12:15:32 -06:00
Aaron Bach d4465e4e69
Use `entry.as_dict()` in WattTime diagnostics (#80122) 2022-10-11 12:15:21 -06:00
Aaron Bach 687987f05b
Use `entry.as_dict()` in RainMachine diagnostics (#80118)
* Use `entry.as_dict()` in RainMachine diagnostics

* One call
2022-10-11 12:15:07 -06:00
Franck Nijhof 8bc9aa9ea4
Update mutagen to 1.46.0 (#80004)
* Update mutagen to 1.46.0

* Ignore untyped call
2022-10-11 20:49:58 +03:00
Aaron Bach 4ea46bf841
Use `entry.as_dict()` in OpenUV diagnostics (#80115) 2022-10-11 19:17:03 +03:00
Aaron Bach 020b7e9762
Use `entry.as_dict()` in Notion diagnostics (#80114) 2022-10-11 19:14:35 +03:00
Aaron Bach c05390e09b
Use `entry.as_dict()` in IQVIA diagnostics (#80113) 2022-10-11 19:13:58 +03:00
Aaron Bach 0f002e7044
Use `entry.as_dict()` in Guardian diagnostics (#80112) 2022-10-11 19:12:17 +03:00
epenet 5743e9f83d
Use REVOLUTIONS_PER_MINUTE constant in isy994 (#79989) 2022-10-11 17:51:42 +02:00
Martin Hjelmare 030205df8f
Filter out non official zwave_js add-on discovery (#80110)
* Filter out non official zwave_js add-on discovery

* Add test
2022-10-11 17:37:21 +02:00
Aaron Bach b41cd57c33
Use `entry.as_dict()` in AirVisual diagnostics (#80109) 2022-10-11 09:26:57 -06:00
Aaron Bach f2207af1c9
Use `entry.as_dict()` in Ambient PWS diagnostics (#80111) 2022-10-11 09:26:44 -06:00
Martin Hjelmare 62c4cd3c26
Add name and slug to supervisor discovery info (#80094) 2022-10-11 16:56:45 +02:00
epenet e948f49818
Use REVOLUTIONS_PER_MINUTE constant in system_bridge (#79990) 2022-10-11 14:56:55 +02:00
epenet b81c7d7f8e
Use REVOLUTIONS_PER_MINUTE constant in glances (#79988) 2022-10-11 14:56:35 +02:00
epenet b1dd646ed8
Use REVOLUTIONS_PER_MINUTE constant in danfoss_air (#79987) 2022-10-11 14:56:10 +02:00
epenet 2538b9d269
Use REVOLUTIONS_PER_MINUTE constant in baf (#79986) 2022-10-11 14:43:13 +02:00
Sean Vig e7c614a825
Fix audio detection for IP4m-1041 Amcrest camera (#80066) 2022-10-11 14:29:35 +02:00
epenet c9130e2892
Use REVOLUTIONS_PER_MINUTE constant in vallox (#79992) 2022-10-11 14:02:27 +02:00
Erik Montnemery 9aa6043255
Set character set to utf8mb4 when connecting to MySQL or MariaDB databases (#79755) 2022-10-11 14:01:46 +02:00
Erik Montnemery a391b8dd9d
Support correcting sensor volume unit (#80081) 2022-10-11 13:51:28 +02:00
Erik Montnemery c52b900bfe
Minor cleanup of sensor statistics (#80082) 2022-10-11 12:24:52 +02:00
Kevin Stillhammer d01f85b6aa
Remove old import logic for waze_travel_time (#80079)
Remove old import logic
2022-10-11 12:05:53 +03:00
Guido Schmitz 6826f2c291
Add reauth flow for devolo_home_network (#71051)
* Add reauth flow

* Cover cases without existing password

* Add test to verify upgrading from older versions

* Connect to the device first

* Use Mapping for async_step_reauth

* Set empty password for user step and remove unneeded update of unique_id
2022-10-11 10:54:29 +02:00
Jan Bouwhuis 65187ab227
Use selectors for basic broker and options for MQTT config flow (#79791)
Use selectors for basic broker en options
2022-10-11 10:51:35 +02:00
Jan Bouwhuis 8aa30cce26
Fix state saving when sharing topics for MQTT entities (#79421)
* Do not write old state sharing availability topic

* Add a test

* Support for all availability topics

* delay async_write_ha_state till last callback

* Process write req after processing callback jobs

* Do not count subscription callbacks

* Simplify

* Stale docsting

* No topic needed for delays state write

* No need to clear when reloading

* Move test to test_mixins.py

* Only set up sensor platform for test
2022-10-11 10:49:54 +02:00
epenet 6f7cb158d8
Cleanup blockchain sensor (#80077) 2022-10-11 10:40:10 +02:00
Erik Montnemery 69d935b7bd
Teach long term statistics that unit 'rpm' is same as 'RPM' (#80012)
* Teach long term statistics that unit 'rpm' is same as 'RPM'

* Add tests
2022-10-11 10:32:01 +02:00
Kevin Stillhammer edad6d0f26
Remove old import logic for google_travel_time (#80018)
Remove old import logic
2022-10-11 10:49:06 +03:00
Marc Mueller 4e5b5dfb93
Update pyupgrade to 3.1.0 (#80058)
* Update pyupgrade to 3.1.0

* Remove redundant open modes - text is the default
2022-10-11 09:04:52 +02:00
J. Nick Koston fe5534666d
Bump dbus-fast to 1.41.0 (#80062) 2022-10-10 18:52:44 -10:00
Chris Talkington 8aa5a785b5
Improve client info reported to Jellyfin (#79974) 2022-10-10 20:24:00 -05:00
GitHub Action eac1a1e513 [ci skip] Translation update 2022-10-11 00:31:56 +00:00
Garrett 22590bf71d
Bump to subarulink v0.6.1 (#80056) 2022-10-11 01:39:14 +02:00
Austin Brunkhorst 7d097d18b0
Add support for Snooz BLE devices (#78790)
Co-authored-by: J. Nick Koston <nick@koston.org>
2022-10-10 13:14:27 -10:00
epenet 4281384d2a
Move options to SelectEntityDescription in lifx (#80015) 2022-10-10 12:40:40 -10:00
Franck Nijhof ce4d93b0c1
Update google-cloud-texttospeech to 2.12.3 (#80051) 2022-10-11 00:05:23 +03:00
Nathan Spencer 262d1ad2a0
Bump pylitterbot to 2022.10.0 (#80050) 2022-10-10 22:43:49 +02:00
puddly 46aa3b5e3d
Bump ZHA dependencies (#80049) 2022-10-10 22:43:31 +02:00
Robert Svensson 395636dfc2
Bump aiounifi to v39 (#80043) 2022-10-10 22:27:21 +02:00
epenet 65ff7c18d2
Move options to SelectEntityDescription in senseme (#80016) 2022-10-10 22:16:10 +02:00
Steven Looman ac44c8e34d
Update codeowners for upnp component (#80042)
Drop @ehendrix23 from codeowners
2022-10-10 23:15:58 +03:00
J. Nick Koston b3ad0eebcd
Bump pySwitchbot to 0.19.15 (#79972) 2022-10-10 22:10:28 +02:00
Tobias Sauerwein aa58d7fbd6
Fix Netatmo device trigger (#80047) 2022-10-10 22:04:41 +02:00
Erik Montnemery e8af007124
Disable echo for non SQLite databases (#80032)
* Disable echo for non SQLite databases

* Add test
2022-10-10 22:42:38 +03:00
David F. Mulcahey 20d71a869e
Add friendly entity names for ZHA sensors (#80035)
* Add friendly entity names for ZHA sensors

* lowercase 2nd word
2022-10-10 15:40:42 -04:00
Bram Kragten 7e19e56c6b
Update frontend to 20221010.0 (#79994) 2022-10-10 21:40:17 +02:00
Robert Svensson 82d3397a9b
Adapt deCONZ binary sensors to entity descriptions (#79486)
Now typing with lambdas work
2022-10-10 21:18:26 +02:00
kingy444 3ab294e8ef
Powerview refactor prep for all shade types (#79862) 2022-10-10 09:05:04 -10:00
Avi Miller 257ae4d8d3
Add support for the Flame and Morph effects for Tile and Candle (#80014) 2022-10-10 09:01:31 -10:00
Jc2k 117c12d135
Fix Eve Thermo always showing as heating in homekit_controller even when off (#80019) 2022-10-10 08:58:20 -10:00
Khole 1d10822cef
Bump pyhiveapi to 0.5.14 (#79530) 2022-10-10 19:54:31 +02:00
epenet 62b559bf36
Adjust device classes in smartthings (#79283) 2022-10-10 19:36:25 +02:00
rappenze 06b1a4c2b4
Fix armed extra state attribute in fibaro entity (#80034) 2022-10-10 19:14:43 +02:00
Erik Montnemery 7b247a79cf
Correct min/max mireds for lights which use K for color temp (#79998) 2022-10-10 16:45:38 +03:00
Erik Montnemery 2ee6ea9877
Adapt group to color temperature in K (#79719)
* Adapt group to color temperature in K

* Adjust tests

* Adjust tests
2022-10-10 14:57:22 +02:00
Franck Nijhof 1e5908d3a8
Update apprise to 1.1.0 (#80009) 2022-10-10 14:21:30 +02:00
epenet ca9bfc8b86
Add options to SelectEntityDescription (#78882) 2022-10-10 14:20:04 +02:00
Patrick ZAJDA d0bffb6c75
Migrate Switchbot to new entity naming style (#80008)
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
2022-10-10 14:12:50 +02:00
Flemming Sørvollen Skaret c7b56f4079
Clean duplicate nextcloud sensor (#79900)
Update __init__.py

Removed duplicate of  "nextcloud_database_version"
2022-10-10 14:12:37 +02:00
Charles Garwood ffb6434776
Add load_url service to fully_kiosk integration (#79969) 2022-10-10 14:11:55 +02:00
Michael Molisani 8fe504356a
Update to pygtfs 0.1.7 (#79975) 2022-10-10 13:37:02 +02:00
epenet 1744b5fa0a
Add docstring to Sensor enums (#79983)
* Add docstring to Sensor enums

* Adjust MONETARY docstring
2022-10-10 12:38:10 +02:00
Franck Nijhof 907af7ffe4
Remove system marker from Supervisor integration (#79997) 2022-10-10 11:05:28 +02:00
Franck Nijhof 575501d26a
Add select platform to LaMetric (#79803) 2022-10-10 09:28:36 +02:00
Chris Talkington 84acb416b8
Use server name as entry title in Jellyfin (#79965) 2022-10-09 23:50:05 -05:00
J. Nick Koston ef719cf7ef
Bump bluetooth-auto-recovery to 0.3.4 (#79971) 2022-10-09 17:56:11 -10:00
Charles Garwood 58d531841b
Fix typo SIGNAL_BOOTSTRAP_INTEGRATONS -> SIGNAL_BOOTSTRAP_INTEGRATIONS (#79970) 2022-10-09 17:06:28 -10:00
GitHub Action aca340de1c [ci skip] Translation update 2022-10-10 00:34:37 +00:00
Chris Talkington d53499c0bf
Bump jellyfin-apiclient-python to 1.9.2 (#79945) 2022-10-09 14:10:12 -10:00
J. Nick Koston 7a1939c608
Bump dbus-fast to 1.38.0 (#79962) 2022-10-09 14:07:22 -10:00
Avi Miller 41595b0cba
Migrate the LIFX integration to use kelvin for color temp (#79775) 2022-10-09 12:19:50 -10:00
Kevin Addeman 45a30546ec
Add support for Homeowner and Phantom Keypads (#79958) 2022-10-09 12:17:06 -10:00
Franck Nijhof 5a0609ae8b
Add sensor platform to LaMetric (#79935) 2022-10-09 21:28:35 +02:00
Kevin Addeman b7e84543c1
Add support for parent_device field so entities are nested within Keypad Devices (#79513)
Co-authored-by: J. Nick Koston <nick@koston.org>
2022-10-09 08:39:12 -10:00
Jeef 618f259fd8
Add configuration URL to IPP (Printer) (#79313)
switch to 0.12.0 ipp lib
2022-10-09 13:32:03 -05:00
HarvsG b86927a453
Enable strict typing on Bayesian (#79870)
* make bayesian static

* no longer private
2022-10-09 20:30:38 +02:00
G Johansson 77864ad80f
Remove not used string from openexchangerates (#79937) 2022-10-09 16:55:49 +02:00
HarvsG e5dafbc166
Make _TrackTemplateResultInfo not private (#79812) 2022-10-09 15:23:08 +02:00
Ville Skyttä a2ed7f7679
Remove incorrect UpCloud logger from manifest (#79855) 2022-10-09 15:18:10 +02:00
TheJulianJES 3126762707
Add friendly name to ZHA config entities (#79926)
* Add friendly name to ZHA config entities

* Follow HA capitalization conventions

* Change from "Start-up level" to "Start-up current level"

* Remove siren select friendly names (temporarily)

* Change tests to expect new entity ids

* Re-add siren select friendly names

* Change siren tests to expect new entity ids
2022-10-09 09:11:42 -04:00
G Johansson 031370358c
Remove yaml import openexchangerates (#79856)
* Depr openexchangerates yaml

* Remove setup_platform and issue

* Remove schema

* Remove not longer used constant
2022-10-09 14:50:21 +02:00
Maciej Bieniek 8176400cfd
Migrate attributes to separate sensors in Brother integration (#79932)
Migrate attributes to sensors
2022-10-09 14:48:01 +02:00
Jan Bouwhuis 6eb2c96d32
Correct use of ConfigType in MQTT config flow code (#79934)
Correct use of ConfigType
2022-10-09 14:41:30 +02:00
Chris Talkington 5b0a37a447
Use persistent device id for jellyfin requests (#79840) 2022-10-08 21:12:30 -05:00
J. Nick Koston 2decb85ee6
Bump dbus-fast to 1.33.0 (#79921) 2022-10-08 15:51:45 -10:00
GitHub Action ed565a6eb1 [ci skip] Translation update 2022-10-09 00:30:44 +00:00
Tobias Sauerwein d9d614d97f
Bump pyatmo to 7.1.1 (#79918) 2022-10-09 02:30:48 +03:00
Mick Vleeshouwer 132ff2c410
Update Config Flow to show message about unsupported Overkiz hardware (#79503)
* Update Config Flow to show cozytouch unsupported hardware error

* Apply feedback

* Remove vague unknown user exception

* Fix test

* Code coverage back to 100%
2022-10-08 16:37:03 -06:00
puddly e5a5326298
Bump ZHA dependencies (#79898) 2022-10-08 15:40:25 -04:00
Maciej Bieniek 1e13433d4f
Rework Brother sensor platform (#79864)
* Rework BrotherSensorEntityDescription

* Rework state attributes

* Cleaning

* Add _handle_coordinator_update()

* Suggested change

* Re-add consts
2022-10-08 22:25:58 +03:00
Shay Levy 9019fcb5c5
Migrate Shelly to use kelvin for color temperature (#79880) 2022-10-08 22:24:19 +03:00
majuss f65dcf3c35
Bump lupupy to support XT2 and up (#79289)
* Bumped lupupy to support XT2 and up

* requirements script
2022-10-08 12:59:59 -06:00
starkillerOG c81bf1103f
Add supported brands for Motion Blinds (#79301)
* Add ScreenAway

* Add aditional brands
2022-10-08 12:57:57 -06:00
starkillerOG 7bc2d97aca
Add Roborock as supported brand of xiaomi miio (#79312)
* Add Roborock as supported brand

* Update supported_brands.py
2022-10-08 12:55:56 -06:00
Daniel Hjelseth Høyer d06e064e9e
Correct unit for Opengarage rssi sensor (#79403)
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
2022-10-08 12:54:37 -06:00
Ville Skyttä 6010672e2f
Add syncthru active alerts sensor, set default manufacturer (#79418)
* Use Samsung as default manufacturer

* Sensor docstring fixes

* Add active alerts sensor
2022-10-08 12:54:16 -06:00
John Levermore 506695fdc5
Fix london_underground TUBE_LINES to match current API output (#79410)
Fix: Update london_underground component with updated TUBE_LINES list to match current API output
2022-10-08 12:53:32 -06:00
Patrick ZAJDA 4baba77780
Add state class measurement to SwitchBot signal strength sensors (#79886) 2022-10-08 08:02:26 -10:00
Marc Mueller 647a4ac131
Update typing-extensions constraint to >=4.4.0 (#79860) 2022-10-08 18:32:46 +03:00
G Johansson 5dde93b429
Bump pytrafikverket to 0.2.1 (#79872) 2022-10-08 09:13:00 -06:00
Bert Melis 6546bba233
Process abbreviated availability options in mqtt discovery payload (#79712)
Expand availability in mqtt discovery payload
2022-10-08 15:36:49 +02:00
Marc Mueller c6df823b35
Use value_fn in WLED number (#79865) 2022-10-08 12:34:41 +02:00
Robert Svensson e7b550685e
Fix POE control port_idx error in UniFi (#79838)
Bump UniFi dependency
2022-10-08 08:49:24 +02:00
spycle e2b7e79ccb
Fix keymitt_ble discovery (#79809)
* Fix keymitt_ble discovery

* Update tests

* Up version

* Up version keymitt_ble

* Up version keymitt_ble
2022-10-08 08:19:40 +02:00
Robert Hillis c6f28f6d59
Migrate Sonarr to new entity naming style (#79844) 2022-10-07 19:53:48 -06:00
GitHub Action f58e1513e2 [ci skip] Translation update 2022-10-08 00:29:46 +00:00
Henne e00f04c2c3
Add state class to bosch_shc energy sensor (#79470)
Make That energy sensor works in Dashbord
2022-10-07 17:54:50 -06:00
Garrett 62aa013097
Add vehicle model/year to subaru device (#79484) 2022-10-07 17:54:05 -06:00
Maciej Bieniek 5abff31437
Use new device classes in Accuweather integration (#79717)
* Add new device classes

* Update tests
2022-10-07 17:52:36 -06:00
Philippe Schenker 24e9f6285d
Change shelly trv precision to what is supported (#79672)
change shelly trv precision to what is supported

Shelly TRVs do support half-degree steps, change this accordingly.
2022-10-07 17:51:54 -06:00
Brandon Rothweiler 2452e70e29
Add Mazda brand (#79683) 2022-10-07 17:49:47 -06:00
Lennart 7132fe0ae7
Fix realtime option for hvv_departures (#79799) 2022-10-07 17:47:24 -06:00
Robert Hillis 87a22fbcca
Move Sonarr API calls to coordinators (#79826) 2022-10-08 00:25:16 +02:00
Julian Einwag 61901a1a60
Add device trigger for Lidl Silvercrest switch to deCONZ (#79839)
* add deconz support for Lidl Silvercrest switch

* Update homeassistant/components/deconz/device_trigger.py

Co-authored-by: Robert Svensson <Kane610@users.noreply.github.com>

* Update homeassistant/components/deconz/device_trigger.py

Co-authored-by: Robert Svensson <Kane610@users.noreply.github.com>

* clarify it's a button, remove turn on event

Co-authored-by: Robert Svensson <Kane610@users.noreply.github.com>
2022-10-07 23:56:45 +02:00
J. Nick Koston fca8586fb6
Bump dbus-fast to 1.29.1 (#79787)
* Bump dbus-fast to 1.28.0

Performance improvements

changelog: https://github.com/Bluetooth-Devices/dbus-fast/compare/v1.26.0...v1.28.0

* bump again

* bump for cleanups
2022-10-07 23:50:50 +03:00
HarvsG 9d351a3c10
Improve typing and code quality in beyesian (#79603)
* strict typing

* Detail implication

* adds newline

* don't change indenting

* really dont change indenting

* Update homeassistant/components/bayesian/binary_sensor.py

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* typing in async_setup_platform() + remove arg

* less ambiguity

* mypy thinks Literal[False] otherwise

* clearer log

* don't use `and` assignments

* observations not values

* clarify can be None

* observation can't be none

* assert we have at least one

* make it clearer where we're using UUIDs

* remove unnecessary bool

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Unnecessary None handling

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Better type setting

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Reccomended changes.

* remove if statement not needed

* Not strict until _TrackTemplateResultInfo fixed

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
2022-10-07 22:23:25 +02:00
Maikel Punie a18a0b39dd
Bumb velbusaio to 2022.10.3 (#79821)
* Bumb velbusaio to 2022.10.3

* Handle the possibility that get_cover position is None (unknown) in previous versions this was always 0
2022-10-07 22:00:01 +03:00
Bouwe Westerdijk 447b71341f
Bump plugwise to v0.21.4 (#79831) 2022-10-07 21:57:12 +03:00
Marc Mueller 33c94b0052
Add strict typing for WLED (#79822)
* Add strict typing for WLED

* Update backoff constraint
2022-10-07 21:56:29 +03:00
Marc Mueller 14d2bbfcd6
Add strict typing for lidarr (#79241) 2022-10-07 20:54:29 +02:00
Marc Mueller a809f645a7
Add strict typing for radarr (#79242) 2022-10-07 20:53:34 +02:00
Robert Hillis 5981864992
Add strict typing to Sonarr (#79802) 2022-10-07 19:08:08 +02:00
Jeef 04f07cecba
IntelliFire Fan - Bug fix on off funciton (#79819)
fix: Fan was double calling off as well as calling an async without an await
2022-10-07 10:37:00 -06:00
Robert Hillis 9850709b37
Add strict typing to Skybell (#79800) 2022-10-07 16:28:05 +02:00
borky e1d3ba6ff1
Add xiaomi miio airpurifier 4 led brightness (#78793)
Fixed Led Brightness not available
2022-10-07 16:03:34 +02:00
Marc Mueller f9aa7c5808
Update pyoverkiz to 1.5.5 (#79798) 2022-10-07 10:03:24 -04:00
Aaron Bach e45701fe89
Add @bachya as a LaMetric codeowner (#79772) 2022-10-07 15:33:53 +02:00
Franck Nijhof 0b9d029350
Add switch platform to LaMetric (#79759)
* Add switch platform to LaMetric

* Little naming tweak
2022-10-07 15:03:58 +02:00
starkillerOG b450514fb3
Add Roborock S7 MaxV for xiaomi_miio (#79477) 2022-10-07 14:57:48 +02:00
Erik Montnemery 43091a9856
Revert "Improve device_automation trigger validation" (#79778)
Revert "Improve device_automation trigger validation (#75044)"

This reverts commit 55b036ec5e.
2022-10-07 08:23:53 -04:00
Alejandro Del Rincón López b51c434b9d
Add support for Xiaomi Purifier 4 Lite (#79758)
* Added support for Xiaomi Purifier 4 Lite

* Remove favorite level from Xiaomi purifier 4 lite.

* Fix linting

Co-authored-by: borky-git <borky-git@protonmail.com>
2022-10-07 13:48:05 +02:00
Ville Skyttä 9b44cf0127
Add Huawei LTE reauth flow (#78005)
* Add Huawei LTE reauth flow

* Upgrade huawei-lte-api to 1.6.3, use LoginErrorInvalidCredentialsException
2022-10-07 12:24:09 +02:00
Jan Bouwhuis aee82e2b3b
De-duplicate MQTT config_flow code (#79369)
* De-duplicate config_flow code

* De duplicate code birth and will
2022-10-07 10:12:19 +02:00
Franck Nijhof 633ffad443
Add diagnostics to LaMetric (#79757)
* Add diagnostics to LaMetric

* Add return value typing

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
2022-10-07 08:07:59 +02:00
jjlawren 5694a4bfc8
Fix state updating for crossfade switch on Sonos (#79776) 2022-10-07 06:29:34 +02:00
J. Nick Koston 07d4ac42d4
Fix Bluetooth failover when esphome device unexpectedly disconnects (#79769) 2022-10-06 16:40:40 -10:00
Jeef 22d6ce967d
Add Flume binary sensors (#77327)
Co-authored-by: J. Nick Koston <nick@koston.org>
2022-10-06 15:09:38 -10:00
GitHub Action e1047320a9 [ci skip] Translation update 2022-10-07 00:38:36 +00:00
Joakim Plate 7b2cad388e
Show all valid heatpump selections (#79756)
Iterate over the keys of the member dunder
2022-10-07 02:22:15 +03:00
Fredrik Erlandsson eb19927df6
Bump pydaikin version (#79761)
bump pydaikin version
2022-10-07 02:18:13 +03:00
Jesse Hills bc1941717c
Bump aioesphomeapi to 11.1.1 (#79762) 2022-10-07 02:17:31 +03:00
Sebastian Lövdahl bba7b3b2be
Fix broken URLs in KNX service descriptions (#79752) 2022-10-06 23:47:50 +02:00
Dave T 6040c30b45
Add visual image preview during generic camera config flow (#71269)
* Add visual preview during setup of generic camera

* Code review: standardize preview  url

* Fix slug test

* Refactor to use HomeAssistantView

* Code review: simplify

* Update manifest

* Don't illegally access protected member

* Increase test coverage

* Prevent browser caching of preview images.

* Code review:move incrementor to ?t=X + simplify

* Discard old flow preview data

* Increase test coverage

* Code review: rename variables for clarity

* Add timeout for image previews

* Fix preview timeout tests

* Simplify: store cam image preview in config_flow

* Call step method to transition between flow steps

* Only store user_input in flow, not CameraObject

* Fix problem where test wouldn't run in isolation.

* Simplify test

* Don't move directly to another step's form

* Remove unused constant

* Simplify test

Co-authored-by: Dave T <davet2001@users.noreply.github.com>
2022-10-06 22:24:19 +02:00
Franck Nijhof 6111fb38a7
Add translations to Plugwise regulation mode (#79597) 2022-10-06 22:16:41 +02:00
Erik Montnemery 51e6d49451
Adapt homekit to color temperatures in K (#79713) 2022-10-06 09:20:10 -10:00
Erik Montnemery aa5575ba65
Only validate sensors in sensor.recorder.validate_statistics (#79749) 2022-10-06 21:17:46 +02:00
Erik Montnemery 96a8beb29f
Tweak comment in LightEntity (#79750) 2022-10-06 21:17:24 +02:00
Glenn Waters d3fee8aad9
Add supported brands to UPB integration (#79619) 2022-10-06 20:33:37 +02:00
Vincent Knoop Pathuis 28df576e51
Update ultraheat api to 0.5.0 (#79666) 2022-10-06 20:06:52 +02:00
puddly 2dab9073fe
ZHA radio migration: reset the old adapter (#79663) 2022-10-06 14:02:24 -04:00
Erik Montnemery 0a59d37e62
Correct how unit used for statistics is determined (#79725) 2022-10-06 14:01:54 -04:00
Bram Kragten e2c1a36e24
Update frontend to 20221006.0 (#79745) 2022-10-06 14:01:18 -04:00
Lars 61deb54ec8
Fix max_color_temp_kelvin (#79738)
fix max_color_temp_kelvin
2022-10-06 19:21:57 +02:00
Chris Talkington 00029ca344
Bump pyipp to 0.12.0 (#79687)
* update pyipp to 0.12.0

* Update requirements_all.txt

* Update requirements_test_all.txt
2022-10-06 17:11:38 +02:00
Matthew Simpson df7b8f419e
Bump btsmarthub_devicelist to 0.2.3 (#79705)
* Bump btsmarthub_devicelist

This PR bumps the btsmarthub_devicelist version to correct an issue
experienced by a recent firmware upgrade to the SmartHub2.

* Bump btsmarthub_devicelist to 0.2.3

This version bump fixes an issue where BT SmartHub2 devices cannot be
correctly autodetected. The current workaround is to specifiy it
manually, which isn't great UX (and did previously work until a recent
firmware upgrade).

I've also taken the opportunity to reassign ownership of the component
to myself as @jxwolstenholme no longer has a SmartHub so cannot do
manual testing and also has no need to use the component anymore.
2022-10-06 17:01:27 +02:00
epenet aa0bb9c3d2
Improve precision in pressure conversion (#79362)
* Improve precision in pressure conversion

* Use _STANDARD_GRAVITY

* Add again pytest.approx
2022-10-06 12:48:31 +02:00
Erik Montnemery 47d0598e75
Use Kelvin as the preferred color temperature unit (#79591)
* Use Kelvin as the preferred white temperature unit

* Update homekit

* Adjust tests
2022-10-06 12:22:39 +02:00
Tom Matheussen 1e39f42df5
Add default ports for Nibe heatpump (#79695) 2022-10-06 11:55:17 +02:00
Shay Levy 93b2a6cc26
Refactor Shelly to use data class for ConfigEntry data (#79671)
* Refactor Shelly to use data class for ConfigEntry data

* Apply suggestions from code review

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Update homeassistant/components/shelly/__init__.py

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Optimize usage of shelly_entry_data in _async_setup_block_entry

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
2022-10-06 10:10:58 +03:00
J. Nick Koston 9b4c7f5dc5
Bump dbus-fast to 1.26.0 (#79684) 2022-10-05 19:17:10 -10:00
Shay Levy ce6ccffd9c
Fix Switcher breeze fan mode and swing control (#79676) 2022-10-06 08:10:04 +03:00
J. Nick Koston c798723c27
Fix bluetooth diagnostics on macos (#79680)
* Fix bluetooth diagnostics on macos

The pyobjc objects cannot be pickled which cases dataclasses
asdict to raise an exception when trying to do the deepcopy

We now implement our own as_dict to avoid this problem

* add cover
2022-10-06 04:32:29 +02:00
GitHub Action 558b327928 [ci skip] Translation update 2022-10-06 00:31:54 +00:00
Yuval Aboulafia 5674295b3c
Add clicksend to strict typing (#79544)
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
2022-10-05 22:18:41 +02:00
Bram Kragten 41d2ab5b37
Update frontend to 20221005.0 (#79656) 2022-10-05 17:38:32 +02:00
Maikel Punie 0eb1101de8
Velbus split of entity in its own file (#79653)
* Velbus split of entity in its own file

* Update coveragerc
2022-10-05 17:03:23 +02:00
Erik Montnemery 5d7756885b
Normalize to kWh when handling WS energy/fossil_energy_consumption (#79649)
* Normalize to kWh when handling WS energy/fossil_energy_consumption

* Improve test
2022-10-05 16:27:08 +02:00
Robert Hillis 312770dbac
Change Lidarr device name to entry title (#79630) 2022-10-05 15:57:36 +03:00
Shay Levy 22c68b95bf
Refactor Shelly wrapper to coordinator (#79628) 2022-10-05 14:39:58 +02:00
Jafar Atili 4d3d22320f
Enhanced switchbee device naming (#79641) 2022-10-05 14:19:03 +03:00
Erik Montnemery 59d9d3de69
Add at_started helper (#79577) 2022-10-05 12:24:51 +02:00
Maciej Bieniek 9dd9147343
Use HA `uuid` as `client_id` in BraviaTV (#79618)
* Use uuid as clientid/nickname

* Fixes after rebase

* Move gen_instance_ids() to utils

* Store client_id and nickname in config_entry

* Update tests

* Clean names

* Rename consts
2022-10-05 11:24:52 +03:00
Robert Hillis 33bdc67a61
Remove superfluous strings from Lidarr (#79631) 2022-10-05 11:17:13 +03:00
Erik Montnemery 18033532ca
Fix search throwing on templated services (#79637) 2022-10-05 10:59:18 +03:00
Jafar Atili 92c9ddf3e3
Add supported brands for switchbee (#79595) 2022-10-05 09:25:46 +02:00
Tobias Sauerwein 905950f341
Netatmo add supported brands (#79563) 2022-10-05 08:58:24 +02:00
kpine bcbce6f159
Allow picking multiple entity targets for zwave_js.refresh_value service (#79634)
Allow selection of multiple entities for zwave_js.refresh_value service
2022-10-05 08:30:34 +02:00
Mike Degatano 416c10a793
Supervisor update entity auto update from api (#79611)
* Supervisor update entity auto update from api

* Update api mocks in tests
2022-10-05 08:27:56 +02:00
Robert Svensson 214c2934de
Bump UniFi dependency to v37 (#79617) 2022-10-05 08:20:37 +02:00
GitHub Action 8d28da83ca [ci skip] Translation update 2022-10-05 00:36:50 +00:00
epenet f3e05534ee
Use VOLUME device_class in flume (#79585) 2022-10-04 12:49:54 -10:00
puddly 253f6616cf
Bump ZHA dependencies (#79623) 2022-10-04 17:17:48 -04:00
Shay Levy 8faecae34d
Shelly - move coordinators to coordinator.py (#79616) 2022-10-04 22:29:07 +03:00
J. Nick Koston 89c4bf6536
Bump dbus-fast to 1.24.0 (#79608) 2022-10-04 08:55:28 -10:00
Mike Degatano 051374d73e
Handle state is None in InfluxDB (#79609) 2022-10-04 21:43:57 +03:00
Bram Kragten 9c97ebbcfe
Update frontend to 20221004.0 (#79602) 2022-10-04 11:51:12 -04:00
Paulus Schoutsen abc80d8245
Add a couple more brands (#79600) 2022-10-04 11:45:40 -04:00
HarvsG dd1463da28
Refactor bayesian observations using dataclass (#79590)
* refactor

* remove some changes

* remove typehint

* improve codestyle

* move docstring to comment

* < 88 chars

* avoid short var names

* more readable

* fix rename

* Update homeassistant/components/bayesian/helpers.py

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Update homeassistant/components/bayesian/binary_sensor.py

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Update homeassistant/components/bayesian/binary_sensor.py

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* no intermediate

* comment why set before list

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
2022-10-04 17:16:39 +02:00
Raman Gupta 27413cee19
Bump zwave_js lib to 0.43.0 and fix multi-file firmware updates (#79342) 2022-10-04 10:40:49 -04:00
Franck Nijhof 2b27cfdabb
Set system & entity integration types (#79593) 2022-10-04 10:36:42 -04:00
Franck Nijhof 74a8472eed
Collect all brands (#79579) 2022-10-04 09:24:55 -04:00
epenet 2fd62b571d
Add docstring to US volume constants (#79582)
* Add docstring to US volume constants

* A blank line separation
2022-10-04 14:47:57 +02:00
Jafar Atili d0f1cba4ea
Fix Thermostat not showing up in SwitchBee integration (#79592)
Fixed Thermostat not showing up in SwitchBee
2022-10-04 14:47:30 +02:00
Nathan Broadbent 1907b87666
Add unique ID to fitbit (#79587)
* Set unique ID for fitbit sensors, including the user ID

* Remove fitbit_ from unique ids (see: https://developers.home-assistant.io/docs/entity_registry_index/#unique-id)

* change fitbit user_profile type to dict[str, Any]

* Fitbit: define a default unique ID, and add battery info if present

* No need for trailing _battery in unique ID, since it already contains "devices/battery_"
2022-10-04 14:28:00 +02:00
Nathan Broadbent 9d2ba7c008
Use constant in fitbit messages (#79586)
Use FITBIT_CONFIG_FILE constant in configurator messages and buttons
2022-10-04 12:13:40 +02:00
kpine c040a7a152
Set zwave_js climate entity target temp attributes based on current mode (#79575)
* Report temperature correctly

* DRY

* Add test assertions

* Don't catch TypeError (revert)
2022-10-04 11:54:13 +02:00
MrAliFu 8d3e3ee6e9
Add new Islamic prayer times calculation method (#79278)
* Adding new calculation method

Adding calculation method Turkey.
islamic_prayer_times 0.0.6 already have turkey as a calc_method, bringing that into here.

* Update const.py

Updated with the feedback

* Importing PrayerTimesCalculator

* Update const.py
2022-10-04 06:36:06 +02:00
J. Nick Koston a3989b90fe
Bump dbus-fast to 1.23.0 (#79570) 2022-10-03 16:44:54 -10:00
Erik Montnemery e93deaa8aa
Simplify long term statistics by always supporting unit conversion (#79557) 2022-10-03 21:50:05 -04:00
Nathan Spencer eda6f13f8a
Remove repairs issue per PR review request (#79561) 2022-10-03 21:17:47 -04:00
J. Nick Koston 2768b2445a
Remove call to deprecated bleak register_detection_callback (#79558) 2022-10-03 21:15:09 -04:00
Erik Montnemery 92ca95ca81
Fix preserving long term statistics when entity_id is changed (#79556) 2022-10-03 21:13:48 -04:00
Allen Porter 90637a721c
Add option to set a stun server for RTSPtoWebRTC (#72574) 2022-10-03 21:10:28 -04:00
puddly 3c07d40fe7
Bump ZHA dependencies (#79565)
Bump all ZHA dependencies
2022-10-03 20:58:53 -04:00
GitHub Action 7eb101b0c7 [ci skip] Translation update 2022-10-04 00:37:13 +00:00
Tobias Sauerwein 27effc93ad
Netatmo bump pyatmo to 7.1.0 (#79562)
Bump pyatmo to 7.1.0
2022-10-04 01:45:31 +03:00
Yuval Aboulafia d08f7f9526
Add clickatell to strict typing (#79497)
* type clickatell

* follow review
2022-10-04 01:02:20 +03:00
mbo18 cfda36ef36
Use device_class duration for NUT sensors (#79353) 2022-10-03 10:12:30 -10:00
Bram Kragten bbaac01da5
Update frontend to 20221003.0 (#79551) 2022-10-03 21:45:28 +02:00
Erik Montnemery a2e3978d53
Don't normalize units of long term statistics (#79320)
* Don't normalize units of long term statistics

* Update statistics.py
2022-10-03 21:42:44 +02:00
Jafar Atili e8650dd4b7
Add climate platform to switchbee integration (#78385)
* Added Climate platform to switchbee integration

* uploaded missing file

* Applied code review feedback from other PR

* Addressed comments from previous PRs

* fixed misspell error

* fixed mistake in the code

* added type hints

* fixes

* fixes

* Update homeassistant/components/switchbee/climate.py

Co-authored-by: Shay Levy <levyshay1@gmail.com>

* Update homeassistant/components/switchbee/entity.py

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* Update homeassistant/components/switchbee/climate.py

Co-authored-by: Shay Levy <levyshay1@gmail.com>

* Update homeassistant/components/switchbee/climate.py

Co-authored-by: Shay Levy <levyshay1@gmail.com>

* Update homeassistant/components/switchbee/climate.py

Co-authored-by: Shay Levy <levyshay1@gmail.com>

* Update homeassistant/components/switchbee/climate.py

Co-authored-by: Shay Levy <levyshay1@gmail.com>

* Update homeassistant/components/switchbee/climate.py

Co-authored-by: Shay Levy <levyshay1@gmail.com>

* Update homeassistant/components/switchbee/climate.py

Co-authored-by: Shay Levy <levyshay1@gmail.com>

* fixes

* Update homeassistant/components/switchbee/climate.py

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* fixes

* Update homeassistant/components/switchbee/climate.py

* Update homeassistant/components/switchbee/climate.py

Co-authored-by: Shay Levy <levyshay1@gmail.com>

* more fixes

Co-authored-by: Shay Levy <levyshay1@gmail.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
2022-10-03 21:34:02 +03:00
Raman Gupta 9b7eb6b5a1
Reduce coverage gaps for zwave_js (#79520)
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
2022-10-03 20:24:11 +02:00
Petro31 f3007b22c4
Allow setting set_percentage and set_preset_mode of template fan without turning on (#75656)
* decouple set_percentage and set_preset_mode from entity state

* correct set_percent self._state logic

* Add tests

* remove _VALUD_STATES

* decouple percent and preset_mode
2022-10-03 20:22:05 +02:00
Ben Randall 55b036ec5e
Improve device_automation trigger validation (#75044)
* improve device_automation trigger validation

Validates the trigger configuration against the device_trigger schema before trying to access any of the properties in order to provide better error messages.
Updates the error message to include an explicit indication that the error is coming from a trigger configuration.  The inner error message from the validator can be accessed by viewing the stack trace.
Add test case for trigger missing domain.

Make action and condition validation consistent with trigger.  This is not strictly necessary, but should be helpful for certain use cases that bypass some of the outer validation.

Removed redundant schema elements from humidifier device_trigger.

**Blueprint with missing `domain`**
```
2022-07-12 06:02:18.351 ERROR (MainThread) [homeassistant.setup] Error during setup of component automation
Traceback (most recent call last):
  File "/workspaces/core/homeassistant/setup.py", line 235, in _async_setup_component
    result = await task
  File "/workspaces/core/homeassistant/components/automation/__init__.py", line 241, in async_setup
    if not await _async_process_config(hass, config, component):
  File "/workspaces/core/homeassistant/components/automation/__init__.py", line 648, in _async_process_config
    await async_validate_config_item(hass, raw_config),
  File "/workspaces/core/homeassistant/components/automation/config.py", line 74, in async_validate_config_item
    config[CONF_TRIGGER] = await async_validate_trigger_config(
  File "/workspaces/core/homeassistant/helpers/trigger.py", line 59, in async_validate_trigger_config
    conf = await platform.async_validate_trigger_config(hass, conf)
  File "/workspaces/core/homeassistant/components/device_automation/trigger.py", line 67, in async_validate_trigger_config
    hass, config[CONF_DOMAIN], DeviceAutomationType.TRIGGER
KeyError: 'domain'
```

**Blueprint with missing `property` (specific to zwave_js event schema)**
```
2022-07-12 06:09:54.206 ERROR (MainThread) [homeassistant.components.automation] Blueprint Missing Property generated invalid automation with inputs OrderedDict([('control_switch', '498be56d796836a67406e9ad373d23db')]): required key not provided @ data['property']. Got None
```

**Blueprint with missing `domain`**
```
2022-07-12 06:12:16.080 ERROR (MainThread) [homeassistant.components.automation] Blueprint Missing Domain generated invalid automation with inputs OrderedDict([('control_switch', '498be56d796836a67406e9ad373d23db')]): invalid trigger configuration: required key not provided @ data['domain']. Got <homeassistant.components.blueprint.models.BlueprintInputs object at 0x7f581e097820>
```

**Blueprint with missing `property` (specific to zwave_js event schema)**
```
2022-07-12 06:12:16.680 ERROR (MainThread) [homeassistant.components.automation] Blueprint Missing Property generated invalid automation with inputs OrderedDict([('control_switch', '498be56d796836a67406e9ad373d23db')]): invalid trigger configuration: required key not provided @ data['property']. Got <homeassistant.components.blueprint.models.BlueprintInputs object at 0x7f581c0dc9d0>
```

* Revert humifidier TRIGGER_SCHEMA change.
2022-10-03 16:42:57 +02:00
Maikel Punie 40bdcc3ea7
Bump velbusaio to 2022.10.2 (#79537) 2022-10-03 16:17:08 +02:00
J. Nick Koston aa3aa91358
Bump dbus-fast to 1.22.0 (#79527)
Performance improvements
https://github.com/Bluetooth-Devices/dbus-fast/compare/v1.21.17...v1.22.0
2022-10-03 15:11:51 +02:00
Maikel Punie cb909b4b05
Bumb velbusaio to 2022.10.1 (#79471) 2022-10-03 11:44:20 +02:00
Erik Montnemery 0fdb7052e9
Add comment in recorder about dropping column (#79523)
Add comment in recorder
2022-10-03 11:40:11 +02:00
Hans Oischinger 125c037def
Address late review of ViCare (#79458)
Runn blocking I/O of button entity creation in async_add_executor_job
2022-10-03 11:10:25 +02:00
Robert Svensson c05d3c10db
Address late comment to deCONZ climate (#79485)
Fix late comment to deCONZ climate #59989
2022-10-03 11:06:13 +02:00
epenet 825f9502ad
Align temperature conversion with other converters (#79521)
* Align temperature conversion with other converters

* Add comments and docstring

* Align tests
2022-10-03 10:09:55 +02:00
ehendrix23 47b40e1e61
Add optional default value to average template function/filter (#77499)
* Return None on empty list

* Updated to use default value

* Update comment.
2022-10-03 10:07:19 +02:00
Paulus Schoutsen 61f0d0ea15
Update Nest string (#79516) 2022-10-02 18:51:46 -07:00
Nyro 0431575199
Fix overkiz entity name (#79229) 2022-10-02 21:22:20 -04:00
Michael d7be3c8780
Set Synology DSM update entity to unavailable in case no data from api gathered (#79508) 2022-10-02 21:19:37 -04:00
IceBotYT d6a6d0d754
Fix LaCrosse View not updating (#79474) 2022-10-02 21:14:02 -04:00
J. Nick Koston da960f6ed4
Bump bluetooth dependencies (#79514) 2022-10-02 21:12:14 -04:00
Michael 790eb9e72d
Remove deprecated update binary sensor from Synology DSM (#79509) 2022-10-02 21:11:45 -04:00
Jesse Hills 8676012204
Bump aioesphomeapi to 11.1.0 (#79515) 2022-10-02 21:11:18 -04:00
GitHub Action 12358f2446 [ci skip] Translation update 2022-10-03 00:31:05 +00:00
Raman Gupta 3a8282d0c5
Improve zwave_js service error (#79504) 2022-10-02 23:24:06 +02:00
Maciej Bieniek 3b794038b1
Add reauth flow to BraviaTV integration (#79405)
* Raise ConfigEntryAuthFailed

* Add reauth flow

* Add tests

* Patch pair() method to avoid IO

* Remove unused errors dict
2022-10-02 13:07:57 -07:00
Bram Kragten f28e3fb46c
Update frontend to 20221002.0 (#79491) 2022-10-02 21:30:54 +02:00
Robert Svensson 14f60dc871
Fix missing string message in UniFi (#79487) 2022-10-02 14:50:01 -04:00
zbeky 81b940ec17
Add EVOLVEO Heat M30v2 TRV (#79462) 2022-10-02 14:34:53 -04:00
TheJulianJES d58e16b990
Fix empty default ZHA configuration (#79475)
* Also add 0 as a default for transition in const.py

This is the same default transition (none) that is used in ZHA's light.py

* Send default values for unconfigured options in ZHA's configuration API

* Remove options that match defaults values before saving
2022-10-02 14:34:15 -04:00
Hung Nguyen 069818940e
Skip parsing Flume sensors without location (#79456) 2022-10-02 12:47:07 -04:00
J. Nick Koston 653620345c
Bump dbus-fast to 1.20.0 (#79465) 2022-10-02 12:46:01 -04:00
Maximilian 7aacdec8e1
Address late review of nina (#79467)
* Address review

* Remove unused attribute
2022-10-02 08:57:32 -07:00
David F. Mulcahey 547a63e314
Remove unnecessary config entity from ZHA (#79472) 2022-10-02 11:07:19 -04:00
Ryan Fleming 2ea9732419
Support reauth for octoprint (#77213)
* Add reauth flow to octoprint

* Add unit tests around octoprint reauth

* Add missing strings

* Fix unit test mocks
2022-10-02 08:08:45 +02:00
Allen Porter 28809fc7fd
Remove dead code code in calendar (#79450) 2022-10-01 23:07:27 -07:00
Ryan Fleming 229e387a1d
Bump pyoctoprintapi to version 1.9 (#79449)
Bump to version 1.9
2022-10-01 22:05:53 -07:00
Marc Mueller 89d0b434bc
Use explicit return value in azure_event_hub (#79315)
* Use explicit return value in azure_event_hub

* Use abstractmethod
2022-10-01 21:24:25 -07:00
Maximilian 7ae942a62b
Fix nina warning state (#76354)
* Fix warning state

* Improve data handling

* Remove duplicate code
2022-10-01 21:22:18 -07:00