0fbd947426
Test Honeywell Round thermostat
...
This includes two changes to the round code:
- Return True on setup success
- Break out the default away temp into a constant
2016-02-14 01:05:18 +00:00
5921e65d83
Allow specifying location and/or thermostat for Honeywell US
...
This lets you optionally only add thermostats by location or
specific device id, instead of all the thermostats in your
account. This would be helpful if you have two devices in different
houses (i.e vacation home), etc.
2016-02-13 23:13:38 +00:00
c51dd64bd8
Convert Honeywell platform to use somecomfort library
2016-02-13 23:13:33 +00:00
bf0b453677
Merge branch 'hotfix/state-as-number' into dev
...
Conflicts:
homeassistant/const.py
tests/helpers/test_state.py
2016-02-13 08:32:06 -08:00
00afaac54c
Update for file header, docstrings, and PEP8/PEP257
2016-02-13 14:19:11 +01:00
1571b33e4a
Fix: state_as_number always return float
2016-02-13 00:08:32 -08:00
61e2da8827
Add tests for influxdb and fix a bug
...
This adds tests for the influxdb component. It also fixes a bug,
where username and password are required, but not gracefully
handled if they're missing from config.
2016-02-12 05:34:13 +00:00
484b7b64d7
Re-allow splunk to report string states
...
Splunk *can* take string states, so un-fix that wrong fix.
2016-02-12 02:20:15 +00:00
7241762bcc
Merge pull request #1209 from kk7ds/abstract-numeric-state
...
Abstract numeric state
2016-02-11 18:16:57 -08:00
0a904acd4d
Add some tests for splunk
...
This also fixes issue #1214 , and I think another bug. The splunk
code will just take the value of state.state and try to serialize
it to json if it can't make it into a number. It did this before
I generalized that code. Since json.dumps() will fail on most anything
complicated, I think the right thing to do is *not* try to do that.
2016-02-12 01:45:30 +00:00
76df759f4c
Add simple statsd tests
...
These are not very amazing, but at least exercise the code a little
to make sure I didn't break anything. Hopefully they're useful in the
future too.
2016-02-12 01:45:30 +00:00
4a2b956493
Convert statsd, influx, splunk, and graphite to use state_as_number()
...
Fixes #1205
2016-02-12 01:45:25 +00:00
3aa34deaa2
Add state_as_number() helper
...
This adds state_as_number(), a helper method that tries to interpret
state as a number, for cases we can predict. It's a generalization of
what is copy-and-paste-ed into multiple other places.
2016-02-12 00:41:32 +00:00
2e75a58372
Fix outtracks bug with passive zones.
2016-02-11 20:28:02 +00:00
4ce1a67c13
Merge pull request #1077 from xrolfex/wink_garage_door_support
...
Wink Garage Door Support
2016-02-11 07:59:57 -08:00
cca6b0c287
Test Fix.
2016-02-11 10:16:57 -05:00
cc4fa6cd38
Merge pull request #1194 from kk7ds/add-graphite-feeder
...
Add graphite feeder component
2016-02-11 06:36:19 -08:00
175b49236c
Fixed style attribute with redefined built in method names.
2016-02-11 09:20:47 -05:00
fd0afaa204
Fixed Test Case Logic
2016-02-11 09:12:28 -05:00
034cec7152
Fixed Demo Test Cases
2016-02-11 09:06:35 -05:00
0da09b85de
refactored test case
2016-02-11 08:37:17 -05:00
6b962a2207
Updated coveragec, cleaned up constants, added test for demo.
2016-02-11 08:37:16 -05:00
7478c36b27
Add graphite feeder component
...
Like recorder, this component listens to all events and reports any
that it can to a graphite installation. This makes it easy to use
graphite for all your data collection and analysis. If you run
carbon-cache (the backend for graphite) on the local machine, no
configuration is required other than enabling the component.
For more info on graphite: http://graphite.wikidot.com/
2016-02-11 05:28:40 +00:00
1a38354ed5
Merge pull request #1138 from flyte/mqtt-publish-template
...
Add template support to mqtt.publish service payload.
2016-02-10 21:13:02 -08:00
e83f8da342
Merge pull request #1185 from balloob/perf-states
...
Make State class more immutable
2016-02-10 18:53:02 -08:00
4e0c7f8a3d
Create additional mqtt helper function for using template payload.
2016-02-10 22:38:33 +00:00
d52e2019c0
Update mqtt.publish() function to use template_payload. Reorganise publish service. Use mqtt.publish() in tests.
2016-02-10 11:11:02 +00:00
af8f6bcaba
Remove deprecated methods from core
2016-02-09 23:59:31 -08:00
b0948bef5f
Make State class immutable
2016-02-09 23:27:01 -08:00
dc44ef7356
Support expanding nested groups
2016-02-09 22:43:07 -08:00
26fc637ab5
Add payload_template to mqtt 'publish' service call.
2016-02-09 15:41:31 +00:00
b17df44402
Add tests for mFi switches
2016-02-09 03:03:26 +00:00
895ddc8433
Add tests for mFi sensors
...
Note that some of the indirection here is so that I can reuse
a few things for mFi switch tests to follow.
2016-02-09 02:59:34 +00:00
0d2891ebcc
Test file for the proximity component
2016-02-07 08:51:21 +00:00
dde80850a6
Merge pull request #1112 from balloob/switch-template
...
First cut of switch.template
2016-02-06 09:12:13 -08:00
2622cf2e53
Use available, remove state, improve true,false tests.
2016-02-05 11:18:50 +00:00
a5db23afa4
Mock util.location by default
2016-02-04 22:26:02 -08:00
abc253c4c5
implement get_significant_states
...
This adds a new function to history module which returns significant
states. For most domains this is the list of state changes. For the
thermostat domain this also includes attribute changes, so that
changes in the current_temperature are exposed to the graphing layer.
Closes #881
2016-02-03 15:05:43 -05:00
5521096c02
Add actions.
2016-02-03 14:29:25 +00:00
9a9dbcfaea
Refactor, support template logic values, add tests.
2016-02-03 13:16:13 +00:00
61630783f1
Disable location queries
2016-02-02 21:33:59 -08:00
b14f7f7ed0
Merge pull request #1099 from balloob/sensor_template_startup_error
...
Sensor template startup error
2016-02-02 18:32:09 -08:00
a955f3db08
WIP commit - template state working, on / off still to do.
2016-02-02 19:25:17 +00:00
2da422fd77
Merge pull request #1098 from balloob/media-player-test
...
Clean up and test media player
2016-02-02 08:09:40 -08:00
93a38d39ef
Add test for missimng attributes.
2016-02-02 14:15:06 +00:00
1a5d18fd66
Merge pull request #1012 from balloob/restart-service
...
Restart service
2016-02-02 07:15:40 -05:00
e7e540d4bb
Clean up and test media player
2016-02-02 00:31:36 -08:00
00d1cab091
add test for unsafe yaml
2016-02-02 08:41:18 +01:00
26efaa91a3
Merge pull request #1090 from balloob/fix_sensor_template_entity_id
...
Fix bug in sensor.template entity_id
2016-02-01 21:21:57 -08:00
c8bfd27182
No longer ignore ports for Chromecasts
2016-02-01 21:07:33 -08:00
7c1241c1f8
Add another test, revise another. Improve coverage.
2016-02-01 18:30:39 +00:00
d54e10e54a
Improve test coverage of error conditions.
2016-02-01 18:18:51 +00:00
5005b20122
Added and fixed yr tests
2016-02-01 15:50:17 +01:00
e29a2fa45a
Fix typo
2016-02-01 11:49:44 +01:00
96710ad410
Add input_select component
2016-01-31 12:52:51 -08:00
1789a08d21
Merge pull request #1065 from kennedyshead/weblink
...
Weblink component
2016-01-31 09:20:17 -08:00
de4dab74b1
Adding weblink component
...
Adding weblink component tests
2016-01-31 18:13:04 +01:00
fce8815ab4
Support custom interval for platforms
2016-01-31 01:01:23 -08:00
90e17fc77f
Add tests for entity component
2016-01-31 01:01:23 -08:00
6418634f3a
Merge pull request #1049 from balloob/new-tests
...
Adding more unit tests
2016-01-30 23:32:34 -08:00
a230d00ed0
Added test for Introduction component
...
This test may seem useless, but it is good to ensure that default
components don’t ever crash HASS.
2016-01-30 22:50:56 -05:00
5fdbe5fd9a
More tests for Binary Command Sensor
...
1. Added a test for detecting STATE_OFF
2. Fixed tests for detecting STATE_ON
2016-01-30 22:41:29 -05:00
283d621e90
Added tests for Binary Command Sensor
2016-01-30 22:32:25 -05:00
2d0004f46a
Another test for for command sensor
...
Added a test for command sensors with bad configurations.
2016-01-30 22:16:22 -05:00
6a08f14120
Additional tests for Command Sensor.
...
1. Moved template testing out of main test.
2. Added test for bad command.
2016-01-30 22:13:42 -05:00
97e867052d
Added tests for command sensor
...
Added tests to create and check basic functionality of command sensor.
2016-01-30 22:01:10 -05:00
2651021461
Added test for entity customization
...
Added test for entity customization from configuration. Processes a
sample configuration to hide an entity, creates the entity, updates ha
state, and then verifies customization made it through.
2016-01-30 21:27:00 -05:00
b7722ec452
Allow usage of words domain, service, call_id in service data
2016-01-30 15:18:26 -08:00
fd6086a5d6
Testing logbook service
2016-01-30 15:18:26 -08:00
56ac4281c7
Better tear down of util/package tests
...
Explicitly removed temp directory at the end of util/package unit tests.
2016-01-30 14:39:17 -05:00
b8e149fe7d
Cleaned up universal MP tests
...
Changed all assertEquals in universal media player tests to have
assumed value first.
2016-01-30 14:38:27 -05:00
4a8f55e630
Revised package util tests
...
The package util tests were revised to pull the external library
pyhelloworld3 from an internal source rather than external. This speeds
up tests, makes tests more reliable, and removes dependency on internet
connection.
2016-01-30 14:08:32 -05:00
de61bcb80e
Additional testing for logger component
...
Added an additional test for the logger component the validates the
filtering logic of the filters that were created during setup.
2016-01-30 13:23:35 -05:00
4cc9606bcc
Added test for logger component.
2016-01-30 13:03:46 -05:00
8ac763c6f6
Added test for universal mp service routing.
...
Added tests to ensure that the Universal Media Player is routing
service calls correctly.
2016-01-30 12:26:28 -05:00
c1d057407b
Fixed typo in universal media player test.
2016-01-30 11:53:15 -05:00
c396dbb570
Added tests to check setup and config of universal media player.
2016-01-30 07:18:37 -05:00
0631f5c59d
Added tests for package utilities
2016-01-30 06:44:22 -05:00
106c53abf1
Revised HASS Core test
...
Changed the HASS Core test that tested KeyboardInterrupt handling to
now test SIGTERM handling. KeyboardInterrupts are no longer handled in
the HASS application process as they are handled in the HASS parent
process. SIGTERM is the proper way to now stop HASS.
2016-01-29 22:42:39 -05:00
ef132e4583
Add tests for color util
2016-01-29 18:44:21 -08:00
a3abd8bb08
Revise tracked beacon name.
2016-01-29 22:11:00 +00:00
80d2f35cc5
First cut mobile beacon tracking.
2016-01-29 22:11:00 +00:00
468a8a1013
Improve owntracks events, add support for stationary ibeacons.
2016-01-29 09:39:00 +00:00
0a4e857901
And a test just to see if nothing works if not providing any vars
2016-01-26 21:21:54 +01:00
d4b444823c
Tests for time and a fix for wrong access of _LOGGER
2016-01-26 21:11:30 +01:00
2382dffbf4
pushed test code :) fixed now
2016-01-26 20:49:51 +01:00
33b0f4d05d
Fixes bug in time trigger and adds test for ex. /two
2016-01-26 20:43:29 +01:00
cff77a175d
Year periodic test (just to trigger travis but should maybe be here anyway)
2016-01-26 18:44:41 +01:00
726637b867
New and improved handling of the matching! Kudos to @balloob
2016-01-26 18:37:19 +01:00
a918be517d
test past midnight support for hours
2016-01-26 17:13:18 +01:00
ec5d88b98e
hourly periodic task
2016-01-26 17:06:50 +01:00
13fbefcdf8
Running periodic tasks
2016-01-26 10:28:31 +01:00
6c91831baa
Hide groups when they are views or auto defined
2016-01-24 23:45:06 -08:00
bb3dd47088
Merge pull request #992 from balloob/sections
...
Add support for sections in the frontend [Fixes #100705168 ]
2016-01-24 22:58:27 -08:00
f6c53896e3
Allow groups to be used as views
2016-01-24 22:54:45 -08:00
60dd2d441d
Merge remote-tracking branch 'balloob/dev' into automation-decorator
...
# Conflicts:
# homeassistant/helpers/service.py
# tests/helpers/test_service.py
2016-01-24 22:51:00 -05:00
5830da63b1
Moved service decorator to service helpers
...
Moved the service decorator to the service helpers module and moved the
associated tests.
2016-01-24 22:46:30 -05:00
f66aeb2e73
Added event helper tests
...
1. Added tests for all event decorators
2. Added tests for sunrise and sunset event helpers
2016-01-24 22:23:56 -05:00
de79a46d43
Move extract_entity_id to service helpers
2016-01-23 22:57:14 -08:00
bc19ef66bf
Move split_entity_id to helpers
2016-01-23 22:49:49 -08:00
de08f0afaa
Load YAML config into an ordered dict
2016-01-23 22:41:01 -08:00
048ec0aa66
Merge pull request #964 from balloob/passive-zones
...
Allow passive zones
2016-01-23 18:15:06 -08:00
ad62591f43
Change error state to be 'error' rather than 'unknown', trace error.
2016-01-22 16:30:02 +00:00
b1f7b5c6d7
Tidy, add test for ValueException logic.
2016-01-22 09:37:20 +00:00
bb97af1504
Allow passive zones
2016-01-22 00:00:36 -08:00
c615272c06
Tidy.
2016-01-21 23:17:19 +00:00
92afcae9be
Add test.
2016-01-21 18:31:44 +00:00
8fbb585874
Fix MQTT reconnecting
2016-01-17 21:39:25 -08:00
027d97321f
Merge pull request #911 from rmkraus/service-toggle
...
Added toggle service
2016-01-17 21:11:35 -05:00
0624445627
Added tests for toggle service.
...
1) Added tests to toggle service.
2) Removed color_util import in light tests. It was not being used.
2016-01-17 16:42:18 -05:00
09973abe8a
Merge pull request #897 from balloob/input-boolean
...
New component: input_boolean
2016-01-16 08:47:29 -08:00
f96c5aa62f
Fix bug in locative logic
2016-01-15 13:19:53 -07:00
6b899ddc1d
100% test coverage for input_boolean
2016-01-14 23:25:25 -08:00
475b631d9c
Initial version input_boolean
2016-01-14 23:18:52 -08:00
57c0f96118
Renamed update_state to update in universal media player
...
Renamed update_state method in universal media player to update so that
it would be called by HA when the state was being published. Moved the
update_ha_state to a function inside of __init__. Updated the tests
accordingly.
2016-01-12 22:15:23 -08:00
07953fb7e3
Removed dependencies property from universal media player
...
The dependencies property was only being called once by the __init__
method so it was removed and the code was moved to the __init__ method.
The tests were updated to reflect this.
2016-01-12 22:15:23 -08:00
12da6f531e
Removed property from universal media player
...
The active_child_state property was unnecessary as it was not being
referenced outside the class. This commit removes it and updates the
tests accordingly.
2016-01-12 22:15:22 -08:00
a8d5b0e5ec
Made universal media player cache active player
...
Revised universal media player to cache the active player when updating
the state when any of the children change. Revised tests to accommodate
this change.
2016-01-12 22:15:22 -08:00
85d732a45a
Streamlined child state lookups in universal media player
...
1) Removed children property because it was only being used by one
method.
2) Removed option to return state as object from _entity_lkp as it was
no longer needed.
3) Used hass.states.get to get entity state objects.
4) Revised test to remove children property.
2016-01-12 22:15:22 -08:00
8f3e8d29f0
Renamed SUPPORT_VOLUME_STEP flag in media_player
...
1) Renamed SUPPORT_VOLUME_BUTTONS to SUPPORT_VOLUME_STEP
2) Removed unused imports from tests.
2016-01-12 22:15:22 -08:00
59456f20fb
Added tests to universal media player and fixed bug
...
1) Fixed universal media player to maintain specified child order when
checking for active child.
2) Added many tests to universal media player.
2016-01-12 22:15:22 -08:00
60f40800c4
Use mock HA for locative tests
2016-01-12 21:56:09 -08:00
8ace656657
Create mqtt eventstream component
2016-01-12 22:56:26 -05:00
73cdf00512
More service helper tests
2016-01-09 16:01:27 -08:00
12b5caed70
ps - strip entity IDs in service call
2016-01-09 15:51:51 -08:00
825c91f0c3
Add calling service functionality to Alexa
2016-01-08 18:54:28 -08:00
3db6faab4d
Fix yr test
2016-01-08 13:30:16 -07:00
8983a97c70
Fix calling turn_on for groups with mixed content
2016-01-03 21:25:15 -08:00
2478623ebc
Merge pull request #840 from balloob/reproduce-group
...
Reproduce state upgrades
2016-01-03 11:36:45 -08:00
736183e6f5
Fix bug in reproduce_state with complex state attributes
2016-01-03 11:27:30 -08:00
f8b2570cb3
Group entities when reproducing a state
2016-01-03 02:32:09 -08:00
c9ff0ab7eb
Fix for sun if condition
2016-01-03 01:03:53 -07:00
9e83a80215
Merge pull request #788 from happyleavesaoc/command_switch_state
...
add statecmd to command_switch
2015-12-31 18:43:02 -05:00
11f32d0500
Add is_state_attr method.
...
Returns True if the entity exists and has an attribute with the given
name and value.
2015-12-31 14:58:18 -06:00
326e26fbeb
Merge pull request #825 from philipbl/locative
...
Update Locative component
2015-12-31 13:10:11 -07:00
ce152e9c94
Simplify logic
2015-12-31 12:39:36 -07:00
1bcca8cba1
Fix problem with test
2015-12-31 11:56:27 -07:00
55d1ad94ef
Add tests for Locative
2015-12-31 11:56:27 -07:00
e9059a3ed9
added test; addressed comments
2015-12-27 22:51:37 -05:00
c1eaf60461
VCR YR sensor test
2015-12-27 17:37:32 -08:00
7b00b19223
Merge pull request #807 from andythigpen/scene-fix
...
Fix issue with scene component when using YAML aliases.
2015-12-27 15:39:19 -08:00
d4b6a7343f
Fix issue with scene component when using YAML aliases.
...
YAML aliases/anchors can make repetitive configuration sections easier
to deal with. However when dealing with dictionaries, care needs to be
taken to not modify the original anchor since PyYAML utilizes a
reference when encountering an alias instead of a copy of the
dictionary.
2015-12-27 13:24:34 -06:00
ab5a3f9de3
Clean up YR sensor
2015-12-27 11:07:25 -08:00
9e1ecd7124
Fix flaky history test
2015-12-27 10:38:27 -08:00
384f1344fd
Merge branch 'pr/792' into dev
2015-12-26 17:48:29 -08:00
add24915a3
ps - clean up sun automation tests
2015-12-26 17:48:20 -08:00
d191635fd8
Merge branch 'yr_no' into dev
2015-12-22 18:53:27 -08:00
9876a2a081
Fix Alexa bug if no value for slots
2015-12-22 02:08:46 -08:00
ff8f22854c
Add test
2015-12-21 16:28:26 -07:00
110d721c76
Add tests
2015-12-21 16:09:51 -07:00
1c08923ffc
Last test for 100% coverage of mqtt light
2015-12-19 19:36:38 -08:00
90c705354a
Add template support to MQTT lights
2015-12-19 19:15:05 -08:00
80d3552960
Add template editor
2015-12-17 23:33:09 -08:00
4c33eba378
Prevent triggering twice
2015-12-16 15:24:09 -07:00
fe2ae16210
Add tests for template automation
2015-12-16 15:24:09 -07:00
66fca475c6
Merge pull request #745 from philipbl/numeric_trigger
...
Template support for numeric state
2015-12-15 10:18:22 -07:00
9fa8b27d65
Change from `value` to `state`
2015-12-15 10:12:43 -07:00
4029d149fb
Weird travis fix for api
2015-12-14 23:27:22 -08:00
027b891052
Add tests for API.stream
2015-12-14 23:20:43 -08:00
cec62bdf87
Add tests
2015-12-14 14:47:32 -07:00
729c24d59b
Add Alexa component
2015-12-12 22:29:02 -08:00
f73f824e0e
Make template states var callable
2015-12-12 22:19:37 -08:00
360b99be59
Add template is_state method
2015-12-12 22:19:12 -08:00
2b975c8620
Add flexible error value for value template parsing
2015-12-12 10:35:15 -08:00
b1bf6a609e
Catch exceptions when error rendering templates
2015-12-11 19:07:03 -08:00
5c63862054
Fix template rounding
2015-12-11 18:45:53 -08:00
9a9ecb5916
Migrate MQTT from jsonpath to templates
2015-12-10 21:39:01 -08:00
d55fda28c2
Add value renderer helper method
2015-12-10 21:38:35 -08:00
7acef84aad
Add variable support to template rendering
2015-12-10 21:16:05 -08:00
0dcc69d800
Fix template rounding
2015-12-10 20:47:06 -08:00
47b5fbfaf3
Add template API endpoint
2015-12-10 20:47:06 -08:00
d1383ac94d
Add template parsing to notify
2015-12-10 20:47:06 -08:00
af09a305cf
Add multiply template filter
2015-12-10 20:47:06 -08:00
de68d3355a
Add template support
2015-12-10 20:47:05 -08:00
39e3a3c463
Bugfix: Allow accessing API via api_password in url
2015-12-06 21:09:49 -08:00
f8668075d0
Fix State.copy()
2015-12-06 09:12:36 -08:00
71bf707bcf
fix tests in yr sensor
2015-12-02 13:32:52 +01:00
9d8865ad4d
adjust rollershutter after rename
2015-12-02 12:18:49 +00:00
21ee621aec
rename motor component back to rollershutter
2015-12-02 12:15:00 +00:00
ff15fea9f8
Added units to sensor yr
2015-12-01 13:31:55 +01:00
2dc9bc98f7
Tests for yr sensor
2015-12-01 13:24:03 +01:00
0025e67b05
Added test to heat control
2015-12-01 11:09:22 +01:00
90eab17ea6
Fix MQTT light bugs
2015-11-29 23:23:27 -08:00
a3981be501
Merge pull request #681 from pavoni/add_solar_elevation
...
Add automations based on Solar Elevation
2015-11-29 14:14:26 -08:00
cb0eb2df7d
Add tests
2015-11-29 21:37:08 +00:00
01203c7c4c
Add updater tests
2015-11-29 12:13:06 -08:00
8841eef2b7
Add tests for lock component
2015-11-29 11:44:27 -08:00
0016ff6acc
Merge pull request #678 from balloob/mqtt-light
...
Fixes for MQTT light with RGB colors
2015-11-28 23:22:57 -08:00
e84ef2d2d7
API to fetch Error log is no longer cached.
2015-11-28 14:08:01 -08:00
957b09707d
Fixes for MQTT light with RGB colors
2015-11-28 12:46:35 -08:00
6809a881fa
Tweak MQTT Motor component
2015-11-28 01:02:35 -08:00
9f01d7abca
Merge branch 'pr/655' into dev
2015-11-28 00:55:22 -08:00
ad3f96fa25
Merge pull request #672 from balloob/some-cleanup
...
Make component dependencies optional
2015-11-27 15:08:22 -08:00
2861bbb02c
Warn if config invalid shape for script
2015-11-26 13:08:13 -08:00
341c3a8fcd
Fix tests for mqtt publish with retain.
2015-11-26 21:03:21 +01:00
08ba71a359
rename component to motor and services to open/close/stop
2015-11-25 18:13:39 +00:00
351430c1b3
move current_position to RollershutterDevice class
2015-11-24 10:41:39 +00:00
e001ea913a
add __init__.py to test folder
2015-11-24 08:03:02 +00:00
8269e843f2
Initial commit for rollershutter component
2015-11-23 00:22:43 +00:00
1bda0bd73b
Add some MQTT tests
2015-11-22 16:04:16 -08:00
Dan Smith
Paulus Schoutsen
Fabian Affolter
pavoni
Eric Rolf
Eric Rolf
Flyte
Nick Waring
Sean Dague
Ryan Kraus
Erik
Daniel
magnusknutas
Ryan Kraus
Paulus Schoutsen
Philip Lundrigan
Moonshot
happyleavesaoc
Andrew Thigpen
Daniel Hoyer Iversen
sfam
pavoni
Pascal Bach