* fix
* Fix
* Fix
* Update homeassistant/helpers/config_validation.py
Co-authored-by: Erik Montnemery <erik@montnemery.com>
* Fix
* Fix
* Fix
* Fix
* Add more tests
* Fix
* Fix tests
* Add tests
* Let's see what the CI does
* It fails on the code that tested the thing ofc
* It fails on the code that tested the thing ofc
* Revert test thingy
* Now the test works again, lovely
* Another one
* Fix websocket thingy
* Only copy when needed
* Improve comment
* Remove test
* Fix docstring
* I think this now also work since this transforms trigger to platform
* Add comment
* Update homeassistant/helpers/config_validation.py
Co-authored-by: Erik Montnemery <erik@montnemery.com>
* Update homeassistant/helpers/config_validation.py
Co-authored-by: Erik Montnemery <erik@montnemery.com>
* Update homeassistant/helpers/config_validation.py
Co-authored-by: Erik Montnemery <erik@montnemery.com>
* Check for mapping
* Add test
* Update homeassistant/helpers/config_validation.py
Co-authored-by: Erik Montnemery <erik@montnemery.com>
* Update test to also test for trigger keys
---------
Co-authored-by: Erik Montnemery <erik@montnemery.com>
Co-authored-by: Sid <27780930+autinerd@users.noreply.github.com>
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
* improve device_automation trigger validation
Validates the trigger configuration against the device_trigger schema before trying to access any of the properties in order to provide better error messages.
Updates the error message to include an explicit indication that the error is coming from a trigger configuration. The inner error message from the validator can be accessed by viewing the stack trace.
Add test case for trigger missing domain.
Make action and condition validation consistent with trigger. This is not strictly necessary, but should be helpful for certain use cases that bypass some of the outer validation.
Removed redundant schema elements from humidifier device_trigger.
**Blueprint with missing `domain`**
```
2022-07-12 06:02:18.351 ERROR (MainThread) [homeassistant.setup] Error during setup of component automation
Traceback (most recent call last):
File "/workspaces/core/homeassistant/setup.py", line 235, in _async_setup_component
result = await task
File "/workspaces/core/homeassistant/components/automation/__init__.py", line 241, in async_setup
if not await _async_process_config(hass, config, component):
File "/workspaces/core/homeassistant/components/automation/__init__.py", line 648, in _async_process_config
await async_validate_config_item(hass, raw_config),
File "/workspaces/core/homeassistant/components/automation/config.py", line 74, in async_validate_config_item
config[CONF_TRIGGER] = await async_validate_trigger_config(
File "/workspaces/core/homeassistant/helpers/trigger.py", line 59, in async_validate_trigger_config
conf = await platform.async_validate_trigger_config(hass, conf)
File "/workspaces/core/homeassistant/components/device_automation/trigger.py", line 67, in async_validate_trigger_config
hass, config[CONF_DOMAIN], DeviceAutomationType.TRIGGER
KeyError: 'domain'
```
**Blueprint with missing `property` (specific to zwave_js event schema)**
```
2022-07-12 06:09:54.206 ERROR (MainThread) [homeassistant.components.automation] Blueprint Missing Property generated invalid automation with inputs OrderedDict([('control_switch', '498be56d796836a67406e9ad373d23db')]): required key not provided @ data['property']. Got None
```
**Blueprint with missing `domain`**
```
2022-07-12 06:12:16.080 ERROR (MainThread) [homeassistant.components.automation] Blueprint Missing Domain generated invalid automation with inputs OrderedDict([('control_switch', '498be56d796836a67406e9ad373d23db')]): invalid trigger configuration: required key not provided @ data['domain']. Got <homeassistant.components.blueprint.models.BlueprintInputs object at 0x7f581e097820>
```
**Blueprint with missing `property` (specific to zwave_js event schema)**
```
2022-07-12 06:12:16.680 ERROR (MainThread) [homeassistant.components.automation] Blueprint Missing Property generated invalid automation with inputs OrderedDict([('control_switch', '498be56d796836a67406e9ad373d23db')]): invalid trigger configuration: required key not provided @ data['property']. Got <homeassistant.components.blueprint.models.BlueprintInputs object at 0x7f581c0dc9d0>
```
* Revert humifidier TRIGGER_SCHEMA change.
* Add turned on or off device trigger to toggle entity
* Renamed changed_states trigger to toggled
* Adjust tests
* Fix homekit triggers test
* Add tests
* Adjust tests after rebase
Co-authored-by: J. Nick Koston <nick@koston.org>
* Unused pylint suppression cleanups
* Remove outdated pylint bug references
* Add flake8-noqa config and note to run it every now and then
* Add codes to noqa's
* Unused noqa cleanups
Joost Lekkerkerker
Franck Nijhof
epenet
Sid
Marc Mueller
J. Nick Koston
Erik Montnemery
Jan Bouwhuis
Ben Randall
Paulus Schoutsen
Ville Skyttä
posixx
Joakim Sørensen
Ruslan Sayfutdinov
Bas Nijholt
Christian Clauss