Scott K Logan
eb81599400
Fix some handle leaks in rainforest_raven ( #113035 )
...
There were leaks when
* The component was shutdown
* There was a timeout during the initial device opening
Additionally, the device was not closed/reopened when there was a
timeout reading regular data.
2024-03-12 12:43:25 -04:00
Maciej Bieniek
f01095fb66
Fix availability for GIOS index sensors ( #113021 )
...
* Fix availability for index sensors
* Improve test_availability()
---------
Co-authored-by: Maciej Bieniek <478555+bieniu@users.noreply.github.com>
2024-03-12 12:41:16 -04:00
Steven Looman
cd4e8707ea
Improve discovering upnp/igd device by always using the SSDP-discovery for the Unique Device Name ( #111487 )
...
* Always use the UDN found in the SSDP discovery, instead of the device description
* Ensure existing DeviceEntries are still matched
2024-03-12 12:38:09 -04:00
Jan-Philipp Benecke
3b1ab6436d
Remove deprecated `hass.components` usage in service tests ( #111883 )
2024-03-12 17:27:44 +01:00
Steven B
5e530fc42e
Add motion detection enable/disable to ring camera platform ( #108789 )
...
* Add motion detection enable/disable to ring camera platform
* Write ha state directly
Co-authored-by: J. Nick Koston <nick@koston.org>
* Parametrize on off state tests
* Add tests for errors on setting motion detection
---------
Co-authored-by: J. Nick Koston <nick@koston.org>
2024-03-12 16:05:14 +01:00
Michael Hansen
556855f54e
Add device_id to sentence trigger and external conversation APIs ( #113094 )
...
* Add device_id to sentence trigger and external conversation APIs
* Remove device_id from external API
* Update tests/components/conversation/snapshots/test_init.ambr
---------
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
2024-03-12 08:50:06 -04:00
J. Nick Koston
120525e94f
Add the ability to create Debouncer tasks as background tasks ( #113128 )
...
* Add the ability to Debouncer tasks in the background
This is a more general solution as a followup to
https://github.com/home-assistant/core/pull/112652#discussion_r1517159607
* Add the ability to Debouncer tasks in the background
This is a more general solution as a followup to
https://github.com/home-assistant/core/pull/112652#discussion_r1517159607
* fix
2024-03-12 08:41:12 -04:00
Jan Bouwhuis
e28d4f0eae
Validate state_class with last_reset_value_template for mqtt sensors ( #113099 )
2024-03-12 09:08:03 +01:00
Jan Bouwhuis
012291a1f3
Fix google_asssistant sensor state reporting ( #112838 )
...
* Fix post google_assistant sensor values as float not string
* Fix aqi reporting and improve tests
* Fix _air_quality_description_for_aqi and test
2024-03-12 09:07:20 +01:00
Erik Montnemery
d039bd654b
Add reconfigure flow to homeworks ( #112419 )
...
* Add reconfigure flow to homeworks
* Fix tests
* Use async_update_reload_and_abort helper
* Try to fix test shutdown
2024-03-12 08:47:44 +01:00
Thomas55555
4f4391bd09
Add missing device info to Husqvarna Automower ( #113090 )
...
* Add missing DeviceInfo to Husqvarna Automower
* add a test
* Adress review
* Update homeassistant/components/husqvarna_automower/entity.py
* fix url
---------
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
2024-03-12 08:25:35 +01:00
definitio
6f19744469
Add A6 family code for DS2438 1-Wire sensor ( #112844 )
...
* Add A6 family code for DS2438
* Add tests
* Fix switch
* Apply code review suggestion
* Add comments
2024-03-12 08:06:02 +01:00
J. Nick Koston
3f72fae60b
Migrate remaining call in check_config helper to use async_get_component ( #113123 )
2024-03-11 15:56:24 -10:00
J. Nick Koston
17b202d8cf
Await discovery_function in the DiscoveryFlowHandler instead of wrapping it in a task ( #113115 )
...
Await discovery_function in the DiscoveryFlowHandler instead of wrapping
This function was always a coro so it can be awaited
directly instead of wrapping it in add_job
2024-03-11 21:37:03 -04:00
J. Nick Koston
6e59d1cb29
Migrate homekit to use async_at_started ( #113102 )
2024-03-11 20:08:02 -04:00
J. Nick Koston
620433a79d
Run coroutines as eager tasks in async_run_hass_job ( #111683 )
...
* Run coroutines as eager tasks in async_run_hass_job
Note that this does not change async_add_hass_job
Do not merge this. For test run only
* Phase out periodic tasks
* false by default or some tests will block forever, will need to fix each one manually
* kwarg works
* kwarg works
* kwarg works
* fixes
* fix more tests
* fix more tests
* fix lifx
* opensky
* pvpc_hourly_pricing
* adjust more
* adjust more
* smarttub
* adjust more
* adjust more
* adjust more
* adjust more
* adjust
* no eager executor
* zha
* qnap_qsw
* fix more
* fix fix
* docs
* its a wrapper now
* add more coverage
* coverage
* cover all combos
* more fixes
* more fixes
* more fixes
* remaining issues are legit bugs in tests
* make tplink test more predictable
* more fixes
* feedreader
* grind out some more
* make test race safe
* limit first scope to triggers
* one more
* Start tasks eagerly in for async_at_start(ed)
A few of these can avoid being scheduled on the loop
during startup
* fix cloud
* Revert "fix cloud"
This reverts commit 5eb3ce695d
.
* fix test to do what start does
* flip flag
* flip flag
* Fix here_travel_time creating many refresh requests at startup
- Each entity would try to refresh the coordinator which
created many tasks. Move the refresh to a single
async_at_started
- The tests fired the EVENT_HOMEASSISTANT_START event
but the code used async_at_started which only worked
because the tests did not set CoreState to not_running
* fix azure
* remove kw
* remove kw
* rip
* cover
* more rips
* more rips
* more rips
2024-03-11 20:05:08 -04:00
J. Nick Koston
53c3e27ed9
Add support for run_immediately to async_listen_once ( #113020 )
2024-03-11 13:51:03 -10:00
J. Nick Koston
6ff8d7d2b9
Make sonos ssdp discovery callback a callback function ( #113107 )
2024-03-11 13:50:04 -10:00
J. Nick Koston
77cdecf0f1
Migrate async_run_job to use eager_start for tasks ( #113011 )
2024-03-11 11:30:46 -10:00
J. Nick Koston
e29b012eba
Fix failing google diagnostics test ( #113095 )
2024-03-11 11:05:49 -10:00
J. Nick Koston
324266a4e6
Fix race in script stop that could cause async_stop to hang forever ( #113089 )
2024-03-11 10:48:11 -10:00
Steven B
eff0aac586
Ensure that the ring integration always raises HomeAssistantError for user actions ( #109893 )
...
* Wrap library exceptions in HomeAssistantErrors
* Remove commented
* Update post review
* Update post second review
2024-03-11 20:23:49 +01:00
Paulus Schoutsen
145657dc21
Only load services.yaml for integrations that have it ( #112732 )
...
Co-authored-by: J. Nick Koston <nick@koston.org>
2024-03-11 19:05:32 +01:00
Joost Lekkerkerker
c75342bd9a
Improve lists in integrations [C-D] ( #113072 )
2024-03-11 18:58:35 +01:00
Joost Lekkerkerker
690ba103ed
Improve lists in integrations [A] ( #113006 )
...
* Use list comprehension [A]
* Use list comprehension [A]
* Update homeassistant/components/aws/notify.py
2024-03-11 16:17:44 +01:00
Joost Lekkerkerker
bf40b33117
Remove fixtures from global fixtures folder ( #113060 )
...
Remove fixtures
2024-03-11 10:19:54 -04:00
J. Nick Koston
d939c48b4a
Fix here_travel_time creating many refresh requests at startup ( #113041 )
2024-03-11 15:11:33 +01:00
Marcel van der Veldt
0eb1adccf8
Fix for Hue not applying effect in scene ( #113057 )
2024-03-11 15:08:00 +01:00
Joost Lekkerkerker
2792a5f016
Enable even more SIM ruff rules ( #113017 )
...
* SIM202 SIM211 SIM220 SIM221 SIM222 SIM223
* SIM910 SIM911
* SIM
* Update homeassistant/components/mqtt/siren.py
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
* Update homeassistant/components/mqtt/siren.py
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
---------
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
2024-03-11 14:23:52 +01:00
Steven B
48cb09a4a8
Prepare ring update service for deprecation ( #108781 )
...
* Prepare ring update service for deprecation
* Update service removal release number
2024-03-11 13:42:52 +01:00
Joost Lekkerkerker
f8d1232598
Move HomematicIP Cloud fixture to integration test ( #112987 )
...
* Move HomematicIP Cloud fixture to integration test
* Update tests/components/homematicip_cloud/helper.py
* Update tests/components/homematicip_cloud/helper.py
---------
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
2024-03-11 13:26:44 +01:00
Shai Ungar
3c06fbbd82
Add ConfigFlow for seventeentrack integration ( #111196 )
...
* Add config flow to 17Track
* Import config from configuration.yaml
* 1. move import to async_setup_platform
2. add USERNAME (email) in title for uniqueness
* Add options flow
* Add tests
* Add CONF_SHOW_ARCHIVED and CONF_SHOW_DELIVERED to data from options
* Update homeassistant/components/seventeentrack/__init__.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update homeassistant/components/seventeentrack/__init__.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update homeassistant/components/seventeentrack/config_flow.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update homeassistant/components/seventeentrack/manifest.json
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update homeassistant/components/seventeentrack/config_flow.py
Co-authored-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
* Update homeassistant/components/seventeentrack/__init__.py
Co-authored-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
* Update homeassistant/components/seventeentrack/sensor.py
Co-authored-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
* 1. Added repair issues
2. _async_validate_input inlined
3. added unique id
4. take default scan interval
* fix
* 1. move async_create_issue to async_setup_platform
2. fix tests
3. black + pylint
* combine USER_SCHEMA and OPTIONS_SCHEMA
* small fix
* remove async_setup
* fix tests and add 100% coverage
* 1. remove CONFIG_SCHEMA
2. remove error log
3. add issue with more description when import issues happen
4. some linting
* Update homeassistant/components/seventeentrack/config_flow.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update homeassistant/components/seventeentrack/sensor.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update homeassistant/components/seventeentrack/sensor.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update homeassistant/components/seventeentrack/sensor.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* use freezer
use AsyncMock
fix tests
* add test_flow_fails
parametrize tests where needed
test_import_flow_already_configured - where a unique id already configured (abort flow)
* lint
* fix rebase issues
* some more fix
* 17Track revert tests and put them in a different PR
* adapt tests to MockConfigEntry
* Update tests/components/seventeentrack/test_sensor.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update homeassistant/components/seventeentrack/sensor.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update homeassistant/components/seventeentrack/sensor.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update tests/components/seventeentrack/__init__.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* 1. create fixture for config and another with options
2. set options with default values
3. remove CONFIG_SCHEMA
* Update tests/components/seventeentrack/conftest.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Update tests/components/seventeentrack/conftest.py
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* 1. get options from import data and default if not present
2. rename mock_config_entry_no_options -> mock_config_entry_with_default_options
* move ACCOUNT_ID to mock_seventeentrack_api.return_value.profile.account_id
* Apply suggestions from code review
* Update tests/components/seventeentrack/test_config_flow.py
---------
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
2024-03-11 12:47:39 +01:00
Marcel van der Veldt
a7a30581fc
Fix adding Hue bridge manually by IP ( #113055 )
2024-03-11 12:35:41 +01:00
Sid
c60aed3012
Bump webmin-xmlrpc to 0.0.2 ( #113004 )
2024-03-11 11:44:21 +01:00
Joost Lekkerkerker
3b0b729557
Remove YAML configuration from WAQI ( #113027 )
2024-03-11 11:41:49 +01:00
Joost Lekkerkerker
2349ce1abd
Move yandex transport fixture to integration test ( #112988 )
...
* Move yandex transport fixture to integration test
* Update tests/components/yandex_transport/test_sensor.py
* Ran ruff
---------
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Franck Nijhof <git@frenck.dev>
2024-03-11 11:28:30 +01:00
Brett Adams
6d440e36ad
Add tests for Aussie Broadband diagnostics ( #113049 )
...
* Add tests for diag
* Fix docstring
* Spelling
2024-03-11 10:54:12 +01:00
Simone Chemelli
4095de0566
Allow Shelly CoAP to honour default network adapter ( #110997 )
...
* Allow Shelly CoAP to honor default network adapter
* apply review comment
* 1 more debug log line
* adapt code to library changes
* test
* improve test
* one more test
2024-03-11 09:52:15 +01:00
J. Nick Koston
30c3174498
Fix CoreState in cloud google assistant tests ( #113045 )
2024-03-10 22:50:09 -10:00
J. Nick Koston
fd8ee6c857
Fix google assistant cloud sync test ( #113044 )
2024-03-10 22:44:21 -10:00
Yuxin Wang
405bf076b2
Remove a redundant check in APCUPSD's config flow ( #113032 )
...
Remove a redundant check that is impossible to happen in practice
2024-03-11 08:38:44 +01:00
Joost Lekkerkerker
b914ac3185
Move openhardwaremonitor fixture to integration tests ( #112982 )
...
* Move openhardwaremonitor fixture
* Update tests/components/openhardwaremonitor/test_sensor.py
---------
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
2024-03-11 08:30:22 +01:00
J. Nick Koston
3387892f59
Schedule tasks eagerly when called from hass.add_job ( #113014 )
2024-03-10 21:19:49 -10:00
Joost Lekkerkerker
cede16fc40
Move Feedreader fixture to integration test ( #112989 )
2024-03-10 23:27:38 -04:00
Joost Lekkerkerker
d528378f5d
Move london_air fixture to integration test ( #112991 )
...
* Move london_air fixture to integration test
* Fix
2024-03-10 23:27:20 -04:00
Joost Lekkerkerker
812bd4af65
Move metoffice fixture to integration test ( #112992 )
...
* Move metoffice fixture to integration test
* Fix
* Update tests/components/metoffice/test_config_flow.py
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
* Fix
---------
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
2024-03-10 23:27:00 -04:00
Joost Lekkerkerker
a78e389d9b
Move Microsoft face fixture to integration test ( #112993 )
...
* Move Microsoft face fixture to integration test
* Update tests/components/microsoft_face/test_init.py
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
* Fix
---------
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
2024-03-10 23:26:37 -04:00
Joost Lekkerkerker
cddce0ce0d
Enable more SIM ruff rules ( #113015 )
...
* SIM101 SIM103
* SIM107 SIM109
* SIM110
* SIM112 SIM113
* SIM115
* SIM116
* Fix
* Fix
* Fix
2024-03-10 23:20:37 -04:00
J. Nick Koston
7ea79148ba
Ignore logging events in zha websocket tests ( #113031 )
2024-03-10 13:13:26 -10:00
Yuxin Wang
db31afe019
Migrate APCUPSD to has entity name ( #112997 )
...
* Properly set entity names for APCUPSD
* Add test cases to prevent future regressions
* Fix tests due to the updated entity IDs
* Prettify code
* Remove redundant translation key
2024-03-10 23:56:25 +01:00