From f930a1fb0694586782f3977020539e80be3ecd73 Mon Sep 17 00:00:00 2001 From: Aaron Bach Date: Fri, 29 Oct 2021 23:17:15 -0600 Subject: [PATCH] Fix bug with volumes in SimpliSafe set_system_properties service (#58721) Co-authored-by: Paulus Schoutsen --- homeassistant/components/simplisafe/__init__.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/simplisafe/__init__.py b/homeassistant/components/simplisafe/__init__.py index ae5c3cd9527..b3bb850244e 100644 --- a/homeassistant/components/simplisafe/__init__.py +++ b/homeassistant/components/simplisafe/__init__.py @@ -118,7 +118,12 @@ PLATFORMS = ( "sensor", ) -VOLUMES = [VOLUME_OFF, VOLUME_LOW, VOLUME_MEDIUM, VOLUME_HIGH] +VOLUME_MAP = { + "high": VOLUME_HIGH, + "low": VOLUME_LOW, + "medium": VOLUME_MEDIUM, + "off": VOLUME_OFF, +} SERVICE_BASE_SCHEMA = vol.Schema({vol.Required(ATTR_SYSTEM_ID): cv.positive_int}) @@ -137,8 +142,8 @@ SERVICE_SET_SYSTEM_PROPERTIES_SCHEMA = SERVICE_BASE_SCHEMA.extend( lambda value: value.total_seconds(), vol.Range(min=30, max=480), ), - vol.Optional(ATTR_ALARM_VOLUME): vol.All(vol.Coerce(int), vol.In(VOLUMES)), - vol.Optional(ATTR_CHIME_VOLUME): vol.All(vol.Coerce(int), vol.In(VOLUMES)), + vol.Optional(ATTR_ALARM_VOLUME): vol.All(vol.In(VOLUME_MAP), VOLUME_MAP.get), + vol.Optional(ATTR_CHIME_VOLUME): vol.All(vol.In(VOLUME_MAP), VOLUME_MAP.get), vol.Optional(ATTR_ENTRY_DELAY_AWAY): vol.All( cv.time_period, lambda value: value.total_seconds(), @@ -157,7 +162,7 @@ SERVICE_SET_SYSTEM_PROPERTIES_SCHEMA = SERVICE_BASE_SCHEMA.extend( ), vol.Optional(ATTR_LIGHT): cv.boolean, vol.Optional(ATTR_VOICE_PROMPT_VOLUME): vol.All( - vol.Coerce(int), vol.In(VOLUMES) + vol.In(VOLUME_MAP), VOLUME_MAP.get ), } )