Remove set default doorbell text service from unifiprotect (#119695)

UI has removed this functionality in UI Protect 4.x

discovered via https://github.com/uilibs/uiprotect/issues/57
pull/119720/head
J. Nick Koston 2024-06-14 14:25:14 -05:00 committed by GitHub
parent 6b8bddf6e3
commit f8bf357811
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 0 additions and 59 deletions

View File

@ -2,7 +2,6 @@
"services": {
"add_doorbell_text": "mdi:message-plus",
"remove_doorbell_text": "mdi:message-minus",
"set_default_doorbell_text": "mdi:message-processing",
"set_chime_paired_doorbells": "mdi:bell-cog",
"remove_privacy_zone": "mdi:eye-minus"
}

View File

@ -32,13 +32,11 @@ SERVICE_ADD_DOORBELL_TEXT = "add_doorbell_text"
SERVICE_REMOVE_DOORBELL_TEXT = "remove_doorbell_text"
SERVICE_SET_PRIVACY_ZONE = "set_privacy_zone"
SERVICE_REMOVE_PRIVACY_ZONE = "remove_privacy_zone"
SERVICE_SET_DEFAULT_DOORBELL_TEXT = "set_default_doorbell_text"
SERVICE_SET_CHIME_PAIRED = "set_chime_paired_doorbells"
ALL_GLOBAL_SERIVCES = [
SERVICE_ADD_DOORBELL_TEXT,
SERVICE_REMOVE_DOORBELL_TEXT,
SERVICE_SET_DEFAULT_DOORBELL_TEXT,
SERVICE_SET_CHIME_PAIRED,
SERVICE_REMOVE_PRIVACY_ZONE,
]
@ -145,12 +143,6 @@ async def remove_doorbell_text(hass: HomeAssistant, call: ServiceCall) -> None:
await _async_service_call_nvr(hass, call, "remove_custom_doorbell_message", message)
async def set_default_doorbell_text(hass: HomeAssistant, call: ServiceCall) -> None:
"""Set the default doorbell text message."""
message: str = call.data[ATTR_MESSAGE]
await _async_service_call_nvr(hass, call, "set_default_doorbell_message", message)
async def remove_privacy_zone(hass: HomeAssistant, call: ServiceCall) -> None:
"""Remove privacy zone from camera."""
@ -231,11 +223,6 @@ def async_setup_services(hass: HomeAssistant) -> None:
functools.partial(remove_doorbell_text, hass),
DOORBELL_TEXT_SCHEMA,
),
(
SERVICE_SET_DEFAULT_DOORBELL_TEXT,
functools.partial(set_default_doorbell_text, hass),
DOORBELL_TEXT_SCHEMA,
),
(
SERVICE_SET_CHIME_PAIRED,
functools.partial(set_chime_paired_doorbells, hass),

View File

@ -22,18 +22,6 @@ remove_doorbell_text:
required: true
selector:
text:
set_default_doorbell_text:
fields:
device_id:
required: true
selector:
device:
integration: unifiprotect
message:
example: Welcome!
required: true
selector:
text:
set_chime_paired_doorbells:
fields:
device_id:

View File

@ -168,20 +168,6 @@
}
}
},
"set_default_doorbell_text": {
"name": "Set default doorbell text",
"description": "Sets the default doorbell message. This will be the message that is automatically selected when a message \"expires\".",
"fields": {
"device_id": {
"name": "[%key:component::unifiprotect::services::add_doorbell_text::fields::device_id::name%]",
"description": "[%key:component::unifiprotect::services::add_doorbell_text::fields::device_id::description%]"
},
"message": {
"name": "Default message",
"description": "The default message for your doorbell. Must be less than 30 characters."
}
}
},
"set_chime_paired_doorbells": {
"name": "Set chime paired doorbells",
"description": "Use to set the paired doorbell(s) with a smart chime.",

View File

@ -15,7 +15,6 @@ from homeassistant.components.unifiprotect.services import (
SERVICE_REMOVE_DOORBELL_TEXT,
SERVICE_REMOVE_PRIVACY_ZONE,
SERVICE_SET_CHIME_PAIRED,
SERVICE_SET_DEFAULT_DOORBELL_TEXT,
)
from homeassistant.config_entries import ConfigEntryDisabler
from homeassistant.const import ATTR_DEVICE_ID, ATTR_ENTITY_ID, ATTR_NAME
@ -125,24 +124,6 @@ async def test_remove_doorbell_text(
nvr.remove_custom_doorbell_message.assert_called_once_with("Test Message")
async def test_set_default_doorbell_text(
hass: HomeAssistant, device: dr.DeviceEntry, ufp: MockUFPFixture
) -> None:
"""Test set_default_doorbell_text service."""
nvr = ufp.api.bootstrap.nvr
nvr.__fields__["set_default_doorbell_message"] = Mock(final=False)
nvr.set_default_doorbell_message = AsyncMock()
await hass.services.async_call(
DOMAIN,
SERVICE_SET_DEFAULT_DOORBELL_TEXT,
{ATTR_DEVICE_ID: device.id, ATTR_MESSAGE: "Test Message"},
blocking=True,
)
nvr.set_default_doorbell_message.assert_called_once_with("Test Message")
async def test_add_doorbell_text_disabled_config_entry(
hass: HomeAssistant, device: dr.DeviceEntry, ufp: MockUFPFixture
) -> None: