Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only log exception in GitHub when something unexpected raised (#64974)

pull/64990/head
Joakim Sørensen 2022-01-26 18:11:40 +01:00 committed by GitHub
parent d14fbf40c8
commit f23277a187
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/github/coordinator.py
View File

@ -6,8 +6,10 @@ from typing import Literal, TypedDict
from aiogithubapi import ( from aiogithubapi import (
GitHubAPI, GitHubAPI,
GitHubCommitModel, GitHubCommitModel,
GitHubConnectionException,
GitHubException, GitHubException,
GitHubNotModifiedException, GitHubNotModifiedException,
GitHubRatelimitException,
GitHubReleaseModel, GitHubReleaseModel,
GitHubRepositoryModel, GitHubRepositoryModel,
GitHubResponseModel, GitHubResponseModel,
@ -69,7 +71,11 @@ class GitHubBaseDataUpdateCoordinator(DataUpdateCoordinator[T]):
) )
# Return the last known data if the request result was not modified # Return the last known data if the request result was not modified
return self.data return self.data
except (GitHubConnectionException, GitHubRatelimitException) as exception:
# These are expected and we dont log anything extra
raise UpdateFailed(exception) from exception
except GitHubException as exception: except GitHubException as exception:
# These are unexpected and we log the trace to help with troubleshooting
LOGGER.exception(exception) LOGGER.exception(exception)
raise UpdateFailed(exception) from exception raise UpdateFailed(exception) from exception
else: else: