From f052c3ca7469d94e21881b96aac75300fa4bc915 Mon Sep 17 00:00:00 2001 From: Aaron Bach Date: Wed, 13 Jul 2022 12:52:13 -0600 Subject: [PATCH] Ensure SimpliSafe diagnostics redact the `code` option (#75137) --- homeassistant/components/simplisafe/diagnostics.py | 3 ++- tests/components/simplisafe/conftest.py | 4 +++- tests/components/simplisafe/test_diagnostics.py | 4 +++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/simplisafe/diagnostics.py b/homeassistant/components/simplisafe/diagnostics.py index dac89715c10..cd6e4ca52be 100644 --- a/homeassistant/components/simplisafe/diagnostics.py +++ b/homeassistant/components/simplisafe/diagnostics.py @@ -5,7 +5,7 @@ from typing import Any from homeassistant.components.diagnostics import async_redact_data from homeassistant.config_entries import ConfigEntry -from homeassistant.const import CONF_ADDRESS, CONF_LOCATION +from homeassistant.const import CONF_ADDRESS, CONF_CODE, CONF_LOCATION from homeassistant.core import HomeAssistant from . import SimpliSafe @@ -23,6 +23,7 @@ CONF_WIFI_SSID = "wifi_ssid" TO_REDACT = { CONF_ADDRESS, + CONF_CODE, CONF_CREDIT_CARD, CONF_EXPIRES, CONF_LOCATION, diff --git a/tests/components/simplisafe/conftest.py b/tests/components/simplisafe/conftest.py index 56967ac24c5..82bd04a7349 100644 --- a/tests/components/simplisafe/conftest.py +++ b/tests/components/simplisafe/conftest.py @@ -43,7 +43,9 @@ def api_fixture(api_auth_state, data_subscription, system_v3, websocket): @pytest.fixture(name="config_entry") def config_entry_fixture(hass, config, unique_id): """Define a config entry.""" - entry = MockConfigEntry(domain=DOMAIN, unique_id=unique_id, data=config) + entry = MockConfigEntry( + domain=DOMAIN, unique_id=unique_id, data=config, options={CONF_CODE: "1234"} + ) entry.add_to_hass(hass) return entry diff --git a/tests/components/simplisafe/test_diagnostics.py b/tests/components/simplisafe/test_diagnostics.py index 13d5c778e89..446d9d5e9e3 100644 --- a/tests/components/simplisafe/test_diagnostics.py +++ b/tests/components/simplisafe/test_diagnostics.py @@ -8,7 +8,9 @@ async def test_entry_diagnostics(hass, config_entry, hass_client, setup_simplisa """Test config entry diagnostics.""" assert await get_diagnostics_for_config_entry(hass, hass_client, config_entry) == { "entry": { - "options": {}, + "options": { + "code": REDACTED, + }, }, "subscription_data": { "system_123": {