Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make services yield (#4187) 

* Make services yield

* Disable pylint abstract-method check

* add input_select

* add input_slider

* change to async vers.

* fix lint

* yield on add_entities as other components does
pull/4209/head
Paulus Schoutsen 2016-11-03 18:32:14 -07:00 committed by GitHub
parent 15dde7925a
commit ee5f228309
75 changed files with 108 additions and 131 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
homeassistant/components/alarm_control_panel/alarmdotcom.py
View File

@ -42,7 +42,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices([AlarmDotCom(hass, name, code, username, password)])
# pylint: disable=abstract-method
class AlarmDotCom(alarm.AlarmControlPanel):
"""Represent an Alarm.com status."""

1
homeassistant/components/alarm_control_panel/manual.py
View File

@ -50,7 +50,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
)])
# pylint: disable=abstract-method
class ManualAlarm(alarm.AlarmControlPanel):
"""
Represents an alarm status.

1
homeassistant/components/alarm_control_panel/mqtt.py
View File

@ -55,7 +55,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
config.get(CONF_CODE))])
# pylint: disable=abstract-method
class MqttAlarm(alarm.AlarmControlPanel):
"""Representation of a MQTT alarm status."""

1
homeassistant/components/alarm_control_panel/simplisafe.py
View File

@ -41,7 +41,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices([SimpliSafeAlarm(name, username, password, code)])
# pylint: disable=abstract-method
class SimpliSafeAlarm(alarm.AlarmControlPanel):
"""Representation a SimpliSafe alarm."""

1
homeassistant/components/alarm_control_panel/verisure.py
View File

@ -28,7 +28,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices(alarms)
# pylint: disable=abstract-method
class VerisureAlarm(alarm.AlarmControlPanel):
"""Represent a Verisure alarm status."""

11
homeassistant/components/automation/__init__.py
View File

@ -218,7 +218,6 @@ def async_setup(hass, config):
class AutomationEntity(ToggleEntity):
"""Entity to show status of entity."""
# pylint: disable=abstract-method
def __init__(self, name, async_attach_triggers, cond_func, async_action,
hidden):
"""Initialize an automation entity."""
@ -265,7 +264,7 @@ class AutomationEntity(ToggleEntity):
return
yield from self.async_enable()
self.hass.loop.create_task(self.async_update_ha_state())
yield from self.async_update_ha_state()
@asyncio.coroutine
def async_turn_off(self, **kwargs) -> None:
@ -276,8 +275,6 @@ class AutomationEntity(ToggleEntity):
self._async_detach_triggers()
self._async_detach_triggers = None
self._enabled = False
# It's important that the update is finished before this method
# ends because async_remove depends on it.
yield from self.async_update_ha_state()
@asyncio.coroutine
@ -289,7 +286,7 @@ class AutomationEntity(ToggleEntity):
if skip_condition or self._cond_func(variables):
yield from self._async_action(self.entity_id, variables)
self._last_triggered = utcnow()
self.hass.loop.create_task(self.async_update_ha_state())
yield from self.async_update_ha_state()
@asyncio.coroutine
def async_remove(self):
@ -352,7 +349,7 @@ def _async_process_config(hass, config, component):
entities.append(entity)
yield from asyncio.gather(*tasks, loop=hass.loop)
hass.loop.create_task(component.async_add_entities(entities))
yield from component.async_add_entities(entities)
return len(entities) > 0
@ -367,7 +364,7 @@ def _async_get_action(hass, config, name):
_LOGGER.info('Executing %s', name)
logbook.async_log_entry(
hass, name, 'has been triggered', DOMAIN, entity_id)
hass.loop.create_task(script_obj.async_run(variables))
yield from script_obj.async_run(variables)
return action

2
homeassistant/components/camera/__init__.py
View File

@ -133,7 +133,7 @@ class Camera(Entity):
yield from asyncio.sleep(.5)
finally:
self.hass.loop.create_task(response.write_eof())
yield from response.write_eof()
@property
def state(self):

2
homeassistant/components/camera/ffmpeg.py
View File

@ -87,7 +87,7 @@ class FFmpegCamera(Camera):
response.write(data)
finally:
self.hass.loop.create_task(stream.close())
self.hass.loop.create_task(response.write_eof())
yield from response.write_eof()
@property
def name(self):

2
homeassistant/components/camera/generic.py
View File

@ -114,7 +114,7 @@ class GenericCamera(Camera):
auth=self._auth
)
self._last_image = yield from respone.read()
self.hass.loop.create_task(respone.release())
yield from respone.release()
except asyncio.TimeoutError:
_LOGGER.error('Timeout getting camera image')
return self._last_image

2
homeassistant/components/camera/mjpeg.py
View File

@ -124,7 +124,7 @@ class MjpegCamera(Camera):
response.write(data)
finally:
self.hass.loop.create_task(stream.release())
self.hass.loop.create_task(response.write_eof())
yield from response.write_eof()
@property
def name(self):

2
homeassistant/components/camera/synology.py
View File

@ -284,7 +284,7 @@ class SynologyCamera(Camera):
response.write(data)
finally:
self.hass.loop.create_task(stream.release())
self.hass.loop.create_task(response.write_eof())
yield from response.write_eof()
@property
def name(self):

1
homeassistant/components/climate/ecobee.py
View File

@ -72,7 +72,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
schema=SET_FAN_MIN_ON_TIME_SCHEMA)
# pylint: disable=abstract-method
class Thermostat(ClimateDevice):
"""A thermostat class for Ecobee."""

2
homeassistant/components/climate/eq3btsmart.py
View File

@ -42,7 +42,7 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices(devices)
# pylint: disable=import-error, abstract-method
# pylint: disable=import-error
class EQ3BTSmartThermostat(ClimateDevice):
"""Representation of a eQ-3 Bluetooth Smart thermostat."""

1
homeassistant/components/climate/generic_thermostat.py
View File

@ -62,7 +62,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
target_temp, ac_mode, min_cycle_duration)])
# pylint: disable=abstract-method
class GenericThermostat(ClimateDevice):
"""Representation of a GenericThermostat device."""

1
homeassistant/components/climate/heatmiser.py
View File

@ -56,7 +56,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class HeatmiserV3Thermostat(ClimateDevice):
"""Representation of a HeatmiserV3 thermostat."""
# pylint: disable=abstract-method
def __init__(self, heatmiser, device, name, serport):
"""Initialize the thermostat."""
self.heatmiser = heatmiser

1
homeassistant/components/climate/homematic.py
View File

@ -36,7 +36,6 @@ def setup_platform(hass, config, add_callback_devices, discovery_info=None):
)
# pylint: disable=abstract-method
class HMThermostat(homematic.HMDevice, ClimateDevice):
"""Representation of a Homematic thermostat."""

2
homeassistant/components/climate/honeywell.py
View File

@ -100,7 +100,6 @@ def _setup_us(username, password, config, add_devices):
class RoundThermostat(ClimateDevice):
"""Representation of a Honeywell Round Connected thermostat."""
# pylint: disable=abstract-method
def __init__(self, device, zone_id, master, away_temp):
"""Initialize the thermostat."""
self.device = device
@ -197,7 +196,6 @@ class RoundThermostat(ClimateDevice):
self._is_dhw = False
# pylint: disable=abstract-method
class HoneywellUSThermostat(ClimateDevice):
"""Representation of a Honeywell US Thermostat."""

1
homeassistant/components/climate/nest.py
View File

@ -30,7 +30,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
for structure, device in nest.devices()])
# pylint: disable=abstract-method
class NestThermostat(ClimateDevice):
"""Representation of a Nest thermostat."""

1
homeassistant/components/climate/netatmo.py
View File

@ -54,7 +54,6 @@ def setup_platform(hass, config, add_callback_devices, discovery_info=None):
return None
# pylint: disable=abstract-method
class NetatmoThermostat(ClimateDevice):
"""Representation a Netatmo thermostat."""

1
homeassistant/components/climate/proliphix.py
View File

@ -36,7 +36,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices([ProliphixThermostat(pdp)])
# pylint: disable=abstract-method
class ProliphixThermostat(ClimateDevice):
"""Representation a Proliphix thermostat."""

1
homeassistant/components/climate/radiotherm.py
View File

@ -58,7 +58,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices(tstats)
# pylint: disable=abstract-method
class RadioThermostat(ClimateDevice):
"""Representation of a Radio Thermostat."""

1
homeassistant/components/climate/vera.py
View File

@ -31,7 +31,6 @@ def setup_platform(hass, config, add_devices_callback, discovery_info=None):
device in VERA_DEVICES['climate'])
# pylint: disable=abstract-method
class VeraThermostat(VeraDevice, ClimateDevice):
"""Representation of a Vera Thermostat."""

1
homeassistant/components/climate/zwave.py
View File

@ -69,7 +69,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
discovery_info, zwave.NETWORK)
# pylint: disable=abstract-method
class ZWaveClimate(ZWaveDeviceEntity, ClimateDevice):
"""Represents a ZWave Climate device."""

1
homeassistant/components/cover/homematic.py
View File

@ -31,7 +31,6 @@ def setup_platform(hass, config, add_callback_devices, discovery_info=None):
)
# pylint: disable=abstract-method
class HMCover(homematic.HMDevice, CoverDevice):
"""Represents a Homematic Cover in Home Assistant."""

1
homeassistant/components/cover/rfxtrx.py
View File

@ -40,7 +40,6 @@ def setup_platform(hass, config, add_devices_callback, discovery_info=None):
rfxtrx.RECEIVED_EVT_SUBSCRIBERS.append(cover_update)
# pylint: disable=abstract-method
class RfxtrxCover(rfxtrx.RfxtrxDevice, CoverDevice):
"""Representation of an rfxtrx cover."""

1
homeassistant/components/cover/rpi_gpio.py
View File

@ -63,7 +63,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices(covers)
# pylint: disable=abstract-method
class RPiGPIOCover(CoverDevice):
"""Representation of a Raspberry GPIO cover."""

1
homeassistant/components/cover/vera.py
View File

@ -22,7 +22,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
device in VERA_DEVICES['cover'])
# pylint: disable=abstract-method
class VeraCover(VeraDevice, CoverDevice):
"""Represents a Vera Cover in Home Assistant."""

8
homeassistant/components/emulated_hue.py
View File

@ -86,19 +86,19 @@ def setup(hass, yaml_config):
upnp_listener = UPNPResponderThread(
config.host_ip_addr, config.listen_port)
@core.callback
@asyncio.coroutine
def stop_emulated_hue_bridge(event):
"""Stop the emulated hue bridge."""
upnp_listener.stop()
hass.loop.create_task(server.stop())
yield from server.stop()
@core.callback
@asyncio.coroutine
def start_emulated_hue_bridge(event):
"""Start the emulated hue bridge."""
hass.loop.create_task(server.start())
upnp_listener.start()
hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP,
stop_emulated_hue_bridge)
yield from server.start()
hass.bus.listen_once(EVENT_HOMEASSISTANT_START, start_emulated_hue_bridge)

2
homeassistant/components/fan/__init__.py
View File

@ -196,7 +196,7 @@ def setup(hass, config: dict) -> None:
class FanEntity(ToggleEntity):
"""Representation of a fan."""
# pylint: disable=no-self-use, abstract-method
# pylint: disable=no-self-use
def set_speed(self: ToggleEntity, speed: str) -> None:
"""Set the speed of the fan."""

15
homeassistant/components/group.py
View File

@ -175,15 +175,16 @@ def async_setup(hass, config):
conf = yield from component.async_prepare_reload()
if conf is None:
return
hass.loop.create_task(_async_process_config(hass, conf, component))
yield from _async_process_config(hass, conf, component)
@callback
@asyncio.coroutine
def visibility_service_handler(service):
"""Change visibility of a group."""
visible = service.data.get(ATTR_VISIBLE)
for group in component.async_extract_from_service(
service, expand_group=False):
group.async_set_visible(visible)
tasks = [group.async_set_visible(visible) for group
in component.async_extract_from_service(service,
expand_group=False)]
yield from asyncio.gather(*tasks, loop=hass.loop)
hass.services.async_register(
DOMAIN, SERVICE_SET_VISIBILITY, visibility_service_handler,
@ -291,12 +292,12 @@ class Group(Entity):
"""Return the icon of the group."""
return self._icon
@callback
@asyncio.coroutine
def async_set_visible(self, visible):
"""Change visibility of the group."""
if self._visible != visible:
self._visible = visible
self.hass.loop.create_task(self.async_update_ha_state())
yield from self.async_update_ha_state()
@property
def hidden(self):

10
homeassistant/components/http.py
View File

@ -22,7 +22,7 @@ from aiohttp.web_exceptions import (
HTTPUnauthorized, HTTPMovedPermanently, HTTPNotModified)
from aiohttp.web_urldispatcher import StaticRoute
from homeassistant.core import callback, is_callback
from homeassistant.core import is_callback
import homeassistant.remote as rem
from homeassistant import util
from homeassistant.const import (
@ -141,16 +141,16 @@ def setup(hass, config):
trusted_networks=trusted_networks
)
@callback
@asyncio.coroutine
def stop_server(event):
"""Callback to stop the server."""
hass.loop.create_task(server.stop())
yield from server.stop()
@callback
@asyncio.coroutine
def start_server(event):
"""Callback to start the server."""
hass.loop.create_task(server.start())
hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP, stop_server)
yield from server.start()
hass.bus.listen_once(EVENT_HOMEASSISTANT_START, start_server)

29
homeassistant/components/input_boolean.py
View File

@ -9,7 +9,6 @@ import logging
import voluptuous as vol
from homeassistant.core import callback
from homeassistant.const import (
ATTR_ENTITY_ID, CONF_ICON, CONF_NAME, SERVICE_TURN_OFF, SERVICE_TURN_ON,
SERVICE_TOGGLE, STATE_ON)
@ -77,18 +76,20 @@ def async_setup(hass, config):
if not entities:
return False
@callback
@asyncio.coroutine
def async_handler_service(service):
"""Handle a calls to the input boolean services."""
target_inputs = component.async_extract_from_service(service)
for input_b in target_inputs:
if service.service == SERVICE_TURN_ON:
input_b.turn_on()
elif service.service == SERVICE_TURN_OFF:
input_b.turn_off()
else:
input_b.toggle()
if service.service == SERVICE_TURN_ON:
attr = 'async_turn_on'
elif service.service == SERVICE_TURN_OFF:
attr = 'async_turn_off'
else:
attr = 'async_toggle'
tasks = [getattr(input_b, attr)() for input_b in target_inputs]
yield from asyncio.gather(*tasks, loop=hass.loop)
hass.services.async_register(
DOMAIN, SERVICE_TURN_OFF, async_handler_service, schema=SERVICE_SCHEMA)
@ -131,12 +132,14 @@ class InputBoolean(ToggleEntity):
"""Return true if entity is on."""
return self._state
def turn_on(self, **kwargs):
@asyncio.coroutine
def async_turn_on(self, **kwargs):
"""Turn the entity on."""
self._state = True
self.hass.loop.create_task(self.async_update_ha_state())
yield from self.async_update_ha_state()
def turn_off(self, **kwargs):
@asyncio.coroutine
def async_turn_off(self, **kwargs):
"""Turn the entity off."""
self._state = False
self.hass.loop.create_task(self.async_update_ha_state())
yield from self.async_update_ha_state()

32
homeassistant/components/input_select.py
View File

@ -9,7 +9,6 @@ import logging
import voluptuous as vol
from homeassistant.core import callback
from homeassistant.const import ATTR_ENTITY_ID, CONF_ICON, CONF_NAME
import homeassistant.helpers.config_validation as cv
from homeassistant.helpers.entity import Entity
@ -105,37 +104,40 @@ def async_setup(hass, config):
if not entities:
return False
@callback
@asyncio.coroutine
def async_select_option_service(call):
"""Handle a calls to the input select option service."""
target_inputs = component.async_extract_from_service(call)
for input_select in target_inputs:
input_select.select_option(call.data[ATTR_OPTION])
tasks = [input_select.async_select_option(call.data[ATTR_OPTION])
for input_select in target_inputs]
yield from asyncio.gather(*tasks, loop=hass.loop)
hass.services.async_register(
DOMAIN, SERVICE_SELECT_OPTION, async_select_option_service,
schema=SERVICE_SELECT_OPTION_SCHEMA)
@callback
@asyncio.coroutine
def async_select_next_service(call):
"""Handle a calls to the input select next service."""
target_inputs = component.async_extract_from_service(call)
for input_select in target_inputs:
input_select.offset_index(1)
tasks = [input_select.async_offset_index(1)
for input_select in target_inputs]
yield from asyncio.gather(*tasks, loop=hass.loop)
hass.services.async_register(
DOMAIN, SERVICE_SELECT_NEXT, async_select_next_service,
schema=SERVICE_SELECT_NEXT_SCHEMA)
@callback
@asyncio.coroutine
def async_select_previous_service(call):
"""Handle a calls to the input select previous service."""
target_inputs = component.async_extract_from_service(call)
for input_select in target_inputs:
input_select.offset_index(-1)
tasks = [input_select.async_offset_index(-1)
for input_select in target_inputs]
yield from asyncio.gather(*tasks, loop=hass.loop)
hass.services.async_register(
DOMAIN, SERVICE_SELECT_PREVIOUS, async_select_previous_service,
@ -183,18 +185,20 @@ class InputSelect(Entity):
ATTR_OPTIONS: self._options,
}
def select_option(self, option):
@asyncio.coroutine
def async_select_option(self, option):
"""Select new option."""
if option not in self._options:
_LOGGER.warning('Invalid option: %s (possible options: %s)',
option, ', '.join(self._options))
return
self._current_option = option
self.hass.loop.create_task(self.async_update_ha_state())
yield from self.async_update_ha_state()
def offset_index(self, offset):
@asyncio.coroutine
def async_offset_index(self, offset):
"""Offset current index."""
current_index = self._options.index(self._current_option)
new_index = (current_index + offset) % len(self._options)
self._current_option = self._options[new_index]
self.hass.loop.create_task(self.async_update_ha_state())
yield from self.async_update_ha_state()

13
homeassistant/components/input_slider.py
View File

@ -9,7 +9,6 @@ import logging
import voluptuous as vol
from homeassistant.core import callback
from homeassistant.const import (
ATTR_ENTITY_ID, ATTR_UNIT_OF_MEASUREMENT, CONF_ICON, CONF_NAME)
import homeassistant.helpers.config_validation as cv
@ -95,13 +94,14 @@ def async_setup(hass, config):
if not entities:
return False
@callback
@asyncio.coroutine
def async_select_value_service(call):
"""Handle a calls to the input slider services."""
target_inputs = component.async_extract_from_service(call)
for input_slider in target_inputs:
input_slider.select_value(call.data[ATTR_VALUE])
tasks = [input_slider.async_select_value(call.data[ATTR_VALUE])
for input_slider in target_inputs]
yield from asyncio.gather(*tasks, loop=hass.loop)
hass.services.async_register(
DOMAIN, SERVICE_SELECT_VALUE, async_select_value_service,
@ -160,7 +160,8 @@ class InputSlider(Entity):
ATTR_STEP: self._step
}
def select_value(self, value):
@asyncio.coroutine
def async_select_value(self, value):
"""Select new value."""
num_value = float(value)
if num_value < self._minimum or num_value > self._maximum:
@ -168,4 +169,4 @@ class InputSlider(Entity):
num_value, self._minimum, self._maximum)
return
self._current_value = num_value
self.hass.loop.create_task(self.async_update_ha_state())
yield from self.async_update_ha_state()

2
homeassistant/components/light/__init__.py
View File

@ -265,7 +265,7 @@ def setup(hass, config):
class Light(ToggleEntity):
"""Representation of a light."""
# pylint: disable=no-self-use, abstract-method
# pylint: disable=no-self-use
@property
def brightness(self):

2
homeassistant/components/light/limitlessled.py
View File

@ -4,7 +4,7 @@ Support for LimitlessLED bulbs.
For more details about this platform, please refer to the documentation at
https://home-assistant.io/components/light.limitlessled/
"""
# pylint: disable=abstract-method
import logging
import voluptuous as vol

2
homeassistant/components/light/mysensors.py
View File

@ -4,7 +4,7 @@ Support for MySensors lights.
For more details about this platform, please refer to the documentation at
https://home-assistant.io/components/light.mysensors/
"""
# pylint: disable=abstract-method
import logging
from homeassistant.components import mysensors

1
homeassistant/components/lock/verisure.py
View File

@ -27,7 +27,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices(locks)
# pylint: disable=abstract-method
class VerisureDoorlock(LockDevice):
"""Representation of a Verisure doorlock."""

2
homeassistant/components/media_player/__init__.py
View File

@ -710,7 +710,7 @@ def _async_fetch_image(hass, url):
if response.status == 200:
content = yield from response.read()
content_type = response.headers.get(CONTENT_TYPE_HEADER)
hass.loop.create_task(response.release())
yield from response.release()
except asyncio.TimeoutError:
pass

1
homeassistant/components/media_player/braviatv.py
View File

@ -180,7 +180,6 @@ def request_configuration(config, hass, add_devices):
)
# pylint: disable=abstract-method
class BraviaTVDevice(MediaPlayerDevice):
"""Representation of a Sony Bravia TV."""

1
homeassistant/components/media_player/cast.py
View File

@ -88,7 +88,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class CastDevice(MediaPlayerDevice):
"""Representation of a Cast device on the network."""
# pylint: disable=abstract-method
def __init__(self, chromecast):
"""Initialize the Cast device."""
self.cast = chromecast

2
homeassistant/components/media_player/cmus.py
View File

@ -58,7 +58,7 @@ def setup_platform(hass, config, add_devices, discover_info=None):
class CmusDevice(MediaPlayerDevice):
"""Representation of a running cmus."""
# pylint: disable=no-member, abstract-method
# pylint: disable=no-member
def __init__(self, server, password, port, name):
"""Initialize the CMUS device."""
from pycmus import remote

8
homeassistant/components/media_player/demo.py
View File

@ -42,7 +42,7 @@ class AbstractDemoPlayer(MediaPlayerDevice):
"""A demo media players."""
# We only implement the methods that we support
# pylint: disable=abstract-method
def __init__(self, name):
"""Initialize the demo device."""
self._name = name
@ -110,7 +110,7 @@ class DemoYoutubePlayer(AbstractDemoPlayer):
"""A Demo media player that only supports YouTube."""
# We only implement the methods that we support
# pylint: disable=abstract-method
def __init__(self, name, youtube_id=None, media_title=None):
"""Initialize the demo device."""
super().__init__(name)
@ -162,7 +162,7 @@ class DemoMusicPlayer(AbstractDemoPlayer):
"""A Demo media player that only supports YouTube."""
# We only implement the methods that we support
# pylint: disable=abstract-method
tracks = [
('Technohead', 'I Wanna Be A Hippy (Flamman & Abraxas Radio Mix)'),
('Paul Elstak', 'Luv U More'),
@ -269,7 +269,7 @@ class DemoTVShowPlayer(AbstractDemoPlayer):
"""A Demo media player that only supports YouTube."""
# We only implement the methods that we support
# pylint: disable=abstract-method
def __init__(self):
"""Initialize the demo device."""
super().__init__('Lounge room')

1
homeassistant/components/media_player/denon.py
View File

@ -45,7 +45,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class DenonDevice(MediaPlayerDevice):
"""Representation of a Denon device."""
# pylint: disable=abstract-method
def __init__(self, name, host):
"""Initialize the Denon device."""
self._name = name

1
homeassistant/components/media_player/directv.py
View File

@ -65,7 +65,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class DirecTvDevice(MediaPlayerDevice):
"""Representation of a DirecTV reciever on the network."""
# pylint: disable=abstract-method
def __init__(self, name, host, port):
"""Initialize the device."""
from DirectPy import DIRECTV

2
homeassistant/components/media_player/emby.py
View File

@ -110,7 +110,7 @@ class EmbyClient(MediaPlayerDevice):
"""Representation of a Emby device."""
# pylint: disable=too-many-arguments, too-many-public-methods,
# pylint: disable=abstract-method
def __init__(self, client, device, emby_sessions, update_devices,
update_sessions):
"""Initialize the Emby device."""

1
homeassistant/components/media_player/firetv.py
View File

@ -104,7 +104,6 @@ class FireTV(object):
class FireTVDevice(MediaPlayerDevice):
"""Representation of an Amazon Fire TV device on the network."""
# pylint: disable=abstract-method
def __init__(self, host, port, device, name):
"""Initialize the FireTV device."""
self._firetv = FireTV(host, port, device)

1
homeassistant/components/media_player/gpmdp.py
View File

@ -170,7 +170,6 @@ def setup_platform(hass, config, add_devices_callback, discovery_info=None):
class GPMDP(MediaPlayerDevice):
"""Representation of a GPMDP."""
# pylint: disable=abstract-method
def __init__(self, name, url, code):
"""Initialize the media player."""
from websocket import create_connection

1
homeassistant/components/media_player/itunes.py
View File

@ -153,7 +153,6 @@ class Itunes(object):
return self._request('PUT', path, {'level': level})
# pylint: disable=unused-argument, abstract-method
def setup_platform(hass, config, add_devices, discovery_info=None):
"""Setup the iTunes platform."""
add_devices([

1
homeassistant/components/media_player/kodi.py
View File

@ -63,7 +63,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class KodiDevice(MediaPlayerDevice):
"""Representation of a XBMC/Kodi device."""
# pylint: disable=abstract-method
def __init__(self, name, url, auth=None, turn_off_action=None):
"""Initialize the Kodi device."""
import jsonrpc_requests

1
homeassistant/components/media_player/lg_netcast.py
View File

@ -52,7 +52,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices([LgTVDevice(client, config[CONF_NAME])])
# pylint: disable=abstract-method
class LgTVDevice(MediaPlayerDevice):
"""Representation of a LG TV."""

1
homeassistant/components/media_player/mpchc.py
View File

@ -43,7 +43,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices([MpcHcDevice(name, url)])
# pylint: disable=abstract-method
class MpcHcDevice(MediaPlayerDevice):
"""Representation of a MPC-HC server."""

2
homeassistant/components/media_player/mpd.py
View File

@ -77,7 +77,7 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class MpdDevice(MediaPlayerDevice):
"""Representation of a MPD server."""
# pylint: disable=no-member, abstract-method
# pylint: disable=no-member
def __init__(self, server, port, location, password):
"""Initialize the MPD device."""
import mpd

1
homeassistant/components/media_player/onkyo.py
View File

@ -68,7 +68,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class OnkyoDevice(MediaPlayerDevice):
"""Representation of an Onkyo device."""
# pylint: disable=abstract-method
def __init__(self, receiver, sources, name=None):
"""Initialize the Onkyo Receiver."""
self._receiver = receiver

1
homeassistant/components/media_player/panasonic_viera.py
View File

@ -68,7 +68,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
return True
# pylint: disable=abstract-method
class PanasonicVieraTVDevice(MediaPlayerDevice):
"""Representation of a Panasonic Viera TV."""

1
homeassistant/components/media_player/pandora.py
View File

@ -63,7 +63,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class PandoraMediaPlayer(MediaPlayerDevice):
"""A media player that uses the Pianobar interface to Pandora."""
# pylint: disable=abstract-method
def __init__(self, name):
"""Initialize the demo device."""
MediaPlayerDevice.__init__(self)

1
homeassistant/components/media_player/philips_js.py
View File

@ -50,7 +50,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices([PhilipsTV(tvapi, name)])
# pylint: disable=abstract-method
class PhilipsTV(MediaPlayerDevice):
"""Representation of a Philips TV exposing the JointSpace API."""

1
homeassistant/components/media_player/pioneer.py
View File

@ -54,7 +54,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class PioneerDevice(MediaPlayerDevice):
"""Representation of a Pioneer device."""
# pylint: disable=abstract-method
def __init__(self, name, host, port, timeout):
"""Initialize the Pioneer device."""
self._name = name

1
homeassistant/components/media_player/plex.py
View File

@ -60,7 +60,6 @@ def config_from_file(filename, config=None):
return {}
# pylint: disable=abstract-method
def setup_platform(hass, config, add_devices_callback, discovery_info=None):
"""Setup the Plex platform."""
config = config_from_file(hass.config.path(PLEX_CONFIG_FILE))

2
homeassistant/components/media_player/roku.py
View File

@ -34,7 +34,6 @@ PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
})
# pylint: disable=abstract-method
def setup_platform(hass, config, add_devices, discovery_info=None):
"""Setup the Roku platform."""
hosts = []
@ -65,7 +64,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class RokuDevice(MediaPlayerDevice):
"""Representation of a Roku device on the network."""
# pylint: disable=abstract-method
def __init__(self, host):
"""Initialize the Roku device."""
from roku import Roku

1
homeassistant/components/media_player/russound_rnet.py
View File

@ -72,7 +72,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
_LOGGER.error('Not connected to %s:%s', host, port)
# pylint: disable=abstract-method
class RussoundRNETDevice(MediaPlayerDevice):
"""Representation of a Russound RNET device."""

1
homeassistant/components/media_player/samsungtv.py
View File

@ -56,7 +56,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
add_devices([SamsungTVDevice(name, remote_config)])
# pylint: disable=abstract-method
class SamsungTVDevice(MediaPlayerDevice):
"""Representation of a Samsung TV."""

1
homeassistant/components/media_player/snapcast.py
View File

@ -52,7 +52,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class SnapcastDevice(MediaPlayerDevice):
"""Representation of a Snapcast client device."""
# pylint: disable=abstract-method
def __init__(self, client):
"""Initialize the Snapcast device."""
self._client = client

1
homeassistant/components/media_player/sonos.py
View File

@ -248,7 +248,6 @@ class _ProcessSonosEventQueue():
self._sonos_device.process_sonos_event(item)
# pylint: disable=abstract-method
class SonosDevice(MediaPlayerDevice):
"""Representation of a Sonos device."""

1
homeassistant/components/media_player/squeezebox.py
View File

@ -174,7 +174,6 @@ class LogitechMediaServer(object):
class SqueezeBoxDevice(MediaPlayerDevice):
"""Representation of a SqueezeBox device."""
# pylint: disable=abstract-method
def __init__(self, lms, player_id):
"""Initialize the SqeezeBox device."""
super(SqueezeBoxDevice, self).__init__()

1
homeassistant/components/media_player/webostv.py
View File

@ -141,7 +141,6 @@ def request_configuration(host, name, customize, hass, add_devices):
)
# pylint: disable=abstract-method
class LgWebOSDevice(MediaPlayerDevice):
"""Representation of a LG WebOS TV."""

1
homeassistant/components/media_player/yamaha.py
View File

@ -85,7 +85,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class YamahaDevice(MediaPlayerDevice):
"""Representation of a Yamaha device."""
# pylint: disable=abstract-method
def __init__(self, name, receiver, source_ignore, source_names):
"""Initialize the Yamaha Receiver."""
self._receiver = receiver

1
homeassistant/components/sensor/lastfm.py
View File

@ -40,7 +40,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class LastfmSensor(Entity):
"""A class for the Last.fm account."""
# pylint: disable=abstract-method
def __init__(self, user, lastfm):
"""Initialize the sensor."""
self._user = lastfm.get_user(user)

1
homeassistant/components/sensor/steam_online.py
View File

@ -37,7 +37,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class SteamSensor(Entity):
"""A class for the Steam account."""
# pylint: disable=abstract-method
def __init__(self, account, steamod):
"""Initialize the sensor."""
self._steamod = steamod

1
homeassistant/components/sensor/supervisord.py
View File

@ -43,7 +43,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class SupervisorProcessSensor(Entity):
"""Representation of a supervisor-monitored process."""
# pylint: disable=abstract-method
def __init__(self, info, server):
"""Initialize the sensor."""
self._info = info

1
homeassistant/components/sensor/twitch.py
View File

@ -42,7 +42,6 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
class TwitchSensor(Entity):
"""Representation of an Twitch channel."""
# pylint: disable=abstract-method
def __init__(self, channel):
"""Initialize the sensor."""
self._channel = channel

2
homeassistant/components/switch/__init__.py
View File

@ -108,7 +108,7 @@ def setup(hass, config):
class SwitchDevice(ToggleEntity):
"""Representation of a switch."""
# pylint: disable=no-self-use, abstract-method
# pylint: disable=no-self-use
@property
def current_power_mwh(self):
"""Return the current power usage in mWh."""

2
homeassistant/components/switch/arest.py
View File

@ -4,7 +4,7 @@ Support for an exposed aREST RESTful API of a device.
For more details about this platform, please refer to the documentation at
https://home-assistant.io/components/switch.arest/
"""
# pylint: disable=abstract-method
import logging
import requests

28
homeassistant/helpers/entity.py
View File

@ -306,16 +306,36 @@ class ToggleEntity(Entity):
raise NotImplementedError()
def turn_on(self, **kwargs) -> None:
"""Turn the entity on."""
run_coroutine_threadsafe(self.async_turn_on(**kwargs),
self.hass.loop).result()
@asyncio.coroutine
def async_turn_on(self, **kwargs):
"""Turn the entity on."""
raise NotImplementedError()
def turn_off(self, **kwargs) -> None:
"""Turn the entity off."""
run_coroutine_threadsafe(self.async_turn_off(**kwargs),
self.hass.loop).result()
@asyncio.coroutine
def async_turn_off(self, **kwargs):
"""Turn the entity off."""
raise NotImplementedError()
def toggle(self, **kwargs) -> None:
"""Toggle the entity off."""
def toggle(self) -> None:
"""Toggle the entity."""
if self.is_on:
self.turn_off(**kwargs)
self.turn_off()
else:
self.turn_on(**kwargs)
self.turn_on()
@asyncio.coroutine
def async_toggle(self):
"""Toggle the entity."""
if self.is_on:
yield from self.async_turn_off()
else:
yield from self.async_turn_on()

2
pylintrc
View File

@ -12,6 +12,7 @@ reports=no
# redefined-variable-type - this is Python, we're duck typing!
# too-many-* - are not enforced for the sake of readability
# too-few-* - same as too-many-*
# abstract-method - with intro of async there are always methods missing
disable=
locally-disabled,
@ -30,6 +31,7 @@ disable=
too-many-return-statements,
too-many-statements,
too-few-public-methods,
abstract-method
[EXCEPTIONS]
overgeneral-exceptions=Exception,HomeAssistantError