From e8af0071243cb4eb239ba0744cafae54a0d3618b Mon Sep 17 00:00:00 2001
From: Erik Montnemery <erik@montnemery.com>
Date: Mon, 10 Oct 2022 21:42:38 +0200
Subject: [PATCH] Disable echo for non SQLite databases (#80032)

* Disable echo for non SQLite databases

* Add test
---
 homeassistant/components/recorder/core.py |  4 ++-
 tests/components/recorder/test_init.py    | 30 +++++++++++++++++++++++
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/homeassistant/components/recorder/core.py b/homeassistant/components/recorder/core.py
index c0f19f2e864..0511b42ebe4 100644
--- a/homeassistant/components/recorder/core.py
+++ b/homeassistant/components/recorder/core.py
@@ -1122,7 +1122,9 @@ class Recorder(threading.Thread):
             # it tried to import it below.
             with contextlib.suppress(ImportError):
                 kwargs["connect_args"] = {"conv": build_mysqldb_conv()}
-        else:
+
+        # Disable extended logging for non SQLite databases
+        if not self.db_url.startswith(SQLITE_URL_PREFIX):
             kwargs["echo"] = False
 
         if self._using_file_sqlite:
diff --git a/tests/components/recorder/test_init.py b/tests/components/recorder/test_init.py
index 05ae1f1a372..4a801574ebb 100644
--- a/tests/components/recorder/test_init.py
+++ b/tests/components/recorder/test_init.py
@@ -1596,3 +1596,33 @@ async def test_async_block_till_done(hass, async_setup_recorder_instance):
     states = await instance.async_add_executor_job(_fetch_states)
     assert len(states) == 2
     await hass.async_block_till_done()
+
+
+@pytest.mark.parametrize(
+    "db_url, echo",
+    (
+        ("sqlite://blabla", None),
+        ("mariadb://blabla", False),
+        ("mysql://blabla", False),
+        ("mariadb+pymysql://blabla", False),
+        ("mysql+pymysql://blabla", False),
+        ("postgresql://blabla", False),
+    ),
+)
+async def test_disable_echo(hass, db_url, echo, caplog):
+    """Test echo is disabled for non sqlite databases."""
+    recorder_helper.async_initialize_recorder(hass)
+
+    class MockEvent:
+        def listen(self, _, _2, callback):
+            callback(None, None)
+
+    mock_event = MockEvent()
+    with patch(
+        "homeassistant.components.recorder.core.create_engine"
+    ) as create_engine_mock, patch(
+        "homeassistant.components.recorder.core.sqlalchemy_event", mock_event
+    ):
+        await async_setup_component(hass, DOMAIN, {DOMAIN: {CONF_DB_URL: db_url}})
+        create_engine_mock.assert_called_once()
+        assert create_engine_mock.mock_calls[0][2].get("echo") == echo