Remove redundant value test in KNX Number entity (#58455)

* remove redundant test for out of bound value

* increase test coverage for number
pull/58449/head
Matthias Alphart 2021-10-26 10:42:42 +02:00 committed by GitHub
parent d16304a201
commit d0cc2a530a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 84 additions and 12 deletions

View File

@ -97,9 +97,4 @@ class KNXNumber(KnxEntity, NumberEntity, RestoreEntity):
async def async_set_value(self, value: float) -> None:
"""Set new value."""
if value < self.min_value or value > self.max_value:
raise ValueError(
f"Invalid value for {self.entity_id}: {value} "
f"(range {self.min_value} - {self.max_value})"
)
await self._device.set(value)

View File

@ -1,23 +1,100 @@
"""Test KNX number."""
from homeassistant.components.knx.const import KNX_ADDRESS
from unittest.mock import patch
import pytest
from homeassistant.components.knx.const import CONF_RESPOND_TO_READ, KNX_ADDRESS
from homeassistant.components.knx.schema import NumberSchema
from homeassistant.const import CONF_NAME, CONF_TYPE
from homeassistant.core import HomeAssistant
from homeassistant.core import HomeAssistant, State
from .conftest import KNXTestKit
async def test_number_unit_of_measurement(hass: HomeAssistant, knx: KNXTestKit):
"""Test simple KNX number."""
async def test_number_set_value(hass: HomeAssistant, knx: KNXTestKit):
"""Test KNX number with passive_address and respond_to_read restoring state."""
test_address = "1/1/1"
await knx.setup_integration(
{
NumberSchema.PLATFORM_NAME: {
CONF_NAME: "test",
KNX_ADDRESS: test_address,
CONF_TYPE: "illuminance",
CONF_TYPE: "percent",
}
}
)
assert len(hass.states.async_all()) == 1
assert hass.states.get("number.test").attributes.get("unit_of_measurement") == "lx"
# set value
await hass.services.async_call(
"number",
"set_value",
{"entity_id": "number.test", "value": 4.0},
blocking=True,
)
await knx.assert_write(test_address, (0x0A,))
state = hass.states.get("number.test")
assert state.state == "4"
assert state.attributes.get("unit_of_measurement") == "%"
# set value out of range
with pytest.raises(ValueError):
await hass.services.async_call(
"number",
"set_value",
{"entity_id": "number.test", "value": 101.0},
blocking=True,
)
with pytest.raises(ValueError):
await hass.services.async_call(
"number",
"set_value",
{"entity_id": "number.test", "value": -1},
blocking=True,
)
await knx.assert_no_telegram()
state = hass.states.get("number.test")
assert state.state == "4"
# update from KNX
await knx.receive_write(test_address, (0xE6,))
state = hass.states.get("number.test")
assert state.state == "90"
async def test_number_restore_and_respond(hass: HomeAssistant, knx: KNXTestKit):
"""Test KNX number with passive_address and respond_to_read restoring state."""
test_address = "1/1/1"
test_passive_address = "3/3/3"
fake_state = State("number.test", "160")
with patch(
"homeassistant.helpers.restore_state.RestoreEntity.async_get_last_state",
return_value=fake_state,
):
await knx.setup_integration(
{
NumberSchema.PLATFORM_NAME: {
CONF_NAME: "test",
KNX_ADDRESS: [test_address, test_passive_address],
CONF_RESPOND_TO_READ: True,
CONF_TYPE: "illuminance",
}
}
)
# restored state - doesn't send telegram
state = hass.states.get("number.test")
assert state.state == "160.0"
assert state.attributes.get("unit_of_measurement") == "lx"
await knx.assert_telegram_count(0)
# respond with restored state
await knx.receive_read(test_address)
await knx.assert_response(test_address, (0x1F, 0xD0))
# don't respond to passive address
await knx.receive_read(test_passive_address)
await knx.assert_no_telegram()
# update from KNX passive address
await knx.receive_write(test_passive_address, (0x4E, 0xDE))
state = hass.states.get("number.test")
assert state.state == "9000.96"