Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only declare powerwall login failure after 5 attempts (#53635)

pull/53638/head
J. Nick Koston 2021-07-28 14:09:08 -05:00 committed by GitHub
parent 0e1eef5737
commit c53e7bc8c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
homeassistant/components/powerwall/__init__.py
View File

@ -41,6 +41,8 @@ PLATFORMS = ["binary_sensor", "sensor"]
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
MAX_LOGIN_FAILURES = 5
async def _migrate_old_unique_ids(hass, entry_id, powerwall_data): async def _migrate_old_unique_ids(hass, entry_id, powerwall_data):
serial_numbers = powerwall_data[POWERWALL_API_SERIAL_NUMBERS] serial_numbers = powerwall_data[POWERWALL_API_SERIAL_NUMBERS]
@ -111,17 +113,19 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
raise ConfigEntryAuthFailed from err raise ConfigEntryAuthFailed from err
await _migrate_old_unique_ids(hass, entry_id, powerwall_data) await _migrate_old_unique_ids(hass, entry_id, powerwall_data)
login_failed_count = 0
async def async_update_data(): async def async_update_data():
"""Fetch data from API endpoint.""" """Fetch data from API endpoint."""
# Check if we had an error before # Check if we had an error before
nonlocal login_failed_count
_LOGGER.debug("Checking if update failed") _LOGGER.debug("Checking if update failed")
if hass.data[DOMAIN][entry.entry_id][POWERWALL_API_CHANGED]: if hass.data[DOMAIN][entry.entry_id][POWERWALL_API_CHANGED]:
return hass.data[DOMAIN][entry.entry_id][POWERWALL_COORDINATOR].data return hass.data[DOMAIN][entry.entry_id][POWERWALL_COORDINATOR].data
_LOGGER.debug("Updating data") _LOGGER.debug("Updating data")
try: try:
return await _async_update_powerwall_data(hass, entry, power_wall) data = await _async_update_powerwall_data(hass, entry, power_wall)
except AccessDeniedError as err: except AccessDeniedError as err:
if password is None: if password is None:
raise ConfigEntryAuthFailed from err raise ConfigEntryAuthFailed from err
@ -131,7 +135,15 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
await hass.async_add_executor_job(power_wall.login, "", password) await hass.async_add_executor_job(power_wall.login, "", password)
return await _async_update_powerwall_data(hass, entry, power_wall) return await _async_update_powerwall_data(hass, entry, power_wall)
except AccessDeniedError as ex: except AccessDeniedError as ex:
raise ConfigEntryAuthFailed from ex login_failed_count += 1
if login_failed_count == MAX_LOGIN_FAILURES:
raise ConfigEntryAuthFailed from ex
raise UpdateFailed(
f"Login attempt {login_failed_count}/{MAX_LOGIN_FAILURES} failed, will retry"
) from ex
else:
login_failed_count = 0
return data
coordinator = DataUpdateCoordinator( coordinator = DataUpdateCoordinator(
hass, hass,