From 01d9e6cdfe611ce3eb6477679c15d955aaeda5e9 Mon Sep 17 00:00:00 2001 From: freol35241 Date: Sun, 15 Jan 2017 20:53:46 +0100 Subject: [PATCH 1/2] Removing throttle decorator Removing redundant throttle decorator on update method. This ensures the existing 'cache-value' config option is respected. Also, UPDATE_INTERVAL is renamed to DEFAULT_UPDATE_INTERVAL for clarity. --- homeassistant/components/sensor/miflora.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/homeassistant/components/sensor/miflora.py b/homeassistant/components/sensor/miflora.py index a519d97a855..155808f702f 100644 --- a/homeassistant/components/sensor/miflora.py +++ b/homeassistant/components/sensor/miflora.py @@ -12,7 +12,6 @@ import voluptuous as vol from homeassistant.components.sensor import PLATFORM_SCHEMA from homeassistant.helpers.entity import Entity import homeassistant.helpers.config_validation as cv -from homeassistant.util import Throttle from homeassistant.const import ( CONF_MONITORED_CONDITIONS, CONF_NAME, CONF_MAC) @@ -31,9 +30,7 @@ DEFAULT_MEDIAN = 3 DEFAULT_NAME = 'Mi Flora' DEFAULT_RETRIES = 2 DEFAULT_TIMEOUT = 10 - -UPDATE_INTERVAL = 1200 -MIN_TIME_BETWEEN_UPDATES = timedelta(seconds=UPDATE_INTERVAL) +DEFAULT_UPDATE_INTERVAL = 1200 # Sensor types are defined like: Name, units SENSOR_TYPES = { @@ -53,7 +50,7 @@ PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ vol.Optional(CONF_FORCE_UPDATE, default=DEFAULT_FORCE_UPDATE): cv.boolean, vol.Optional(CONF_TIMEOUT, default=DEFAULT_TIMEOUT): cv.positive_int, vol.Optional(CONF_RETRIES, default=DEFAULT_RETRIES): cv.positive_int, - vol.Optional(CONF_CACHE, default=UPDATE_INTERVAL): cv.positive_int, + vol.Optional(CONF_CACHE, default=DEFAULT_UPDATE_INTERVAL): cv.positive_int, }) @@ -122,7 +119,6 @@ class MiFloraSensor(Entity): """Force update.""" return self._force_update - @Throttle(MIN_TIME_BETWEEN_UPDATES) def update(self): """ Update current conditions. From c8cf952e2190b70eb1fed2ee89dace23d1f91bd4 Mon Sep 17 00:00:00 2001 From: freol35241 Date: Sun, 15 Jan 2017 21:10:02 +0100 Subject: [PATCH 2/2] Remove import of datetime module --- homeassistant/components/sensor/miflora.py | 1 - 1 file changed, 1 deletion(-) diff --git a/homeassistant/components/sensor/miflora.py b/homeassistant/components/sensor/miflora.py index 155808f702f..1922d4832ee 100644 --- a/homeassistant/components/sensor/miflora.py +++ b/homeassistant/components/sensor/miflora.py @@ -4,7 +4,6 @@ Support for Xiaomi Mi Flora BLE plant sensor. For more details about this platform, please refer to the documentation at https://home-assistant.io/components/sensor.miflora/ """ -from datetime import timedelta import logging import voluptuous as vol