Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix ruff manual-dict-comprehension PERF403 in tests (#120738) 

Fix PERF403 in tests
pull/120743/head
Joost Lekkerkerker 2024-06-28 12:14:24 +02:00 committed by GitHub
parent 6f8c9c28e7
commit c13786c952
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/components/recorder/test_init.py
View File

@ -905,16 +905,19 @@ async def test_saving_event_with_oversized_data(
hass.bus.async_fire("test_event", event_data) hass.bus.async_fire("test_event", event_data)
hass.bus.async_fire("test_event_too_big", massive_dict) hass.bus.async_fire("test_event_too_big", massive_dict)
await async_wait_recording_done(hass) await async_wait_recording_done(hass)
events = {}
with session_scope(hass=hass, read_only=True) as session: with session_scope(hass=hass, read_only=True) as session:
events = {
event_type: data
for _, data, event_type in ( for _, data, event_type in (
session.query(Events.event_id, EventData.shared_data, EventTypes.event_type) session.query(
Events.event_id, EventData.shared_data, EventTypes.event_type
)
.outerjoin(EventData, Events.data_id == EventData.data_id) .outerjoin(EventData, Events.data_id == EventData.data_id)
.outerjoin(EventTypes, Events.event_type_id == EventTypes.event_type_id) .outerjoin(EventTypes, Events.event_type_id == EventTypes.event_type_id)
.where(EventTypes.event_type.in_(["test_event", "test_event_too_big"])) .where(EventTypes.event_type.in_(["test_event", "test_event_too_big"]))
): )
events[event_type] = data }
assert "test_event_too_big" in caplog.text assert "test_event_too_big" in caplog.text
@ -932,16 +935,19 @@ async def test_saving_event_invalid_context_ulid(
event_data = {"test_attr": 5, "test_attr_10": "nice"} event_data = {"test_attr": 5, "test_attr_10": "nice"}
hass.bus.async_fire("test_event", event_data, context=Context(id="invalid")) hass.bus.async_fire("test_event", event_data, context=Context(id="invalid"))
await async_wait_recording_done(hass) await async_wait_recording_done(hass)
events = {}
with session_scope(hass=hass, read_only=True) as session: with session_scope(hass=hass, read_only=True) as session:
events = {
event_type: data
for _, data, event_type in ( for _, data, event_type in (
session.query(Events.event_id, EventData.shared_data, EventTypes.event_type) session.query(
Events.event_id, EventData.shared_data, EventTypes.event_type
)
.outerjoin(EventData, Events.data_id == EventData.data_id) .outerjoin(EventData, Events.data_id == EventData.data_id)
.outerjoin(EventTypes, Events.event_type_id == EventTypes.event_type_id) .outerjoin(EventTypes, Events.event_type_id == EventTypes.event_type_id)
.where(EventTypes.event_type.in_(["test_event"])) .where(EventTypes.event_type.in_(["test_event"]))
): )
events[event_type] = data }
assert "invalid" in caplog.text assert "invalid" in caplog.text