Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix EntityComponent lingering timer in helper tests (#89801) 

* Fix lingering timer in entity platform tests

* Tweak

* Fix entity and entity_component also

* Remove async_shutdown

* Adjust

* Adjust
pull/89847/head^2
epenet 2023-03-17 10:26:05 +01:00 committed by GitHub
parent abd91dd934
commit ab6e929443
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/helpers/test_entity_component.py
View File

@ -168,6 +168,7 @@ async def test_set_entity_namespace_via_config(hass: HomeAssistant) -> None:
async def test_extract_from_service_available_device(hass: HomeAssistant) -> None:
"""Test the extraction of entity from service and device is available."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities(
[
MockEntity(name="test_1"),
@ -236,6 +237,7 @@ async def test_platform_not_ready(hass: HomeAssistant) -> None:
async def test_extract_from_service_fails_if_no_entity_id(hass: HomeAssistant) -> None:
"""Test the extraction of everything from service."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities(
[MockEntity(name="test_1"), MockEntity(name="test_2")]
)
@ -262,6 +264,7 @@ async def test_extract_from_service_filter_out_non_existing_entities(
) -> None:
"""Test the extraction of non existing entities from service."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities(
[MockEntity(name="test_1"), MockEntity(name="test_2")]
)
@ -280,6 +283,7 @@ async def test_extract_from_service_filter_out_non_existing_entities(
async def test_extract_from_service_no_group_expand(hass: HomeAssistant) -> None:
"""Test not expanding a group."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities([MockEntity(entity_id="group.test_group")])
call = ServiceCall("test", "service", {"entity_id": ["group.test_group"]})
@ -395,6 +399,7 @@ async def test_unload_entry_fails_if_never_loaded(hass: HomeAssistant) -> None:
async def test_update_entity(hass: HomeAssistant) -> None:
"""Test that we can update an entity with the helper."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
entity = MockEntity()
entity.async_write_ha_state = Mock()
entity.async_update_ha_state = AsyncMock(return_value=None)
@ -422,6 +427,7 @@ async def test_set_service_race(hass: HomeAssistant) -> None:
await async_setup_component(hass, "group", {})
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
for _ in range(2):
hass.async_create_task(component.async_add_entities([MockEntity()]))
@ -435,6 +441,7 @@ async def test_extract_all_omit_entity_id(
) -> None:
"""Test extract all with None and *."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities(
[MockEntity(name="test_1"), MockEntity(name="test_2")]
)
@ -451,6 +458,7 @@ async def test_extract_all_use_match_all(
) -> None:
"""Test extract all with None and *."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities(
[MockEntity(name="test_1"), MockEntity(name="test_2")]
)
@ -477,6 +485,7 @@ async def test_register_entity_service(hass: HomeAssistant) -> None:
entity.async_called_by_service = appender
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities([entity])
component.async_register_entity_service(

22
tests/helpers/test_entity_platform.py
View File

@ -46,6 +46,7 @@ async def test_polling_only_updates_entities_it_should_poll(
) -> None:
"""Test the polling of only updated entities."""
component = EntityComponent(_LOGGER, DOMAIN, hass, timedelta(seconds=20))
await component.async_setup({})
no_poll_ent = MockEntity(should_poll=False)
no_poll_ent.async_update = Mock()
@ -78,6 +79,7 @@ async def test_polling_disabled_by_config_entry(hass: HomeAssistant) -> None:
async def test_polling_updates_entities_with_exception(hass: HomeAssistant) -> None:
"""Test the updated entities that not break with an exception."""
component = EntityComponent(_LOGGER, DOMAIN, hass, timedelta(seconds=20))
await component.async_setup({})
update_ok = []
update_err = []
@ -115,6 +117,7 @@ async def test_polling_updates_entities_with_exception(hass: HomeAssistant) -> N
async def test_update_state_adds_entities(hass: HomeAssistant) -> None:
"""Test if updating poll entities cause an entity to be added works."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
ent1 = MockEntity()
ent2 = MockEntity(should_poll=True)
@ -134,6 +137,7 @@ async def test_update_state_adds_entities_with_update_before_add_true(
) -> None:
"""Test if call update before add to state machine."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
ent = MockEntity()
ent.update = Mock(spec_set=True)
@ -150,6 +154,7 @@ async def test_update_state_adds_entities_with_update_before_add_false(
) -> None:
"""Test if not call update before add to state machine."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
ent = MockEntity()
ent.update = Mock(spec_set=True)
@ -199,6 +204,7 @@ async def test_adding_entities_with_generator_and_thread_callback(
it into an async context.
"""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
def create_entity(number: int) -> MockEntity:
"""Create entity helper."""
@ -259,6 +265,7 @@ async def test_platform_error_slow_setup(
async def test_updated_state_used_for_entity_id(hass: HomeAssistant) -> None:
"""Test that first update results used for entity ID generation."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
class MockEntityNameFetcher(MockEntity):
"""Mock entity that fetches a friendly name."""
@ -407,6 +414,7 @@ async def test_raise_error_on_update(hass: HomeAssistant) -> None:
"""Test the add entity if they raise an error on update."""
updates = []
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
entity1 = MockEntity(name="test_1")
entity2 = MockEntity(name="test_2")
@ -431,6 +439,7 @@ async def test_raise_error_on_update(hass: HomeAssistant) -> None:
async def test_async_remove_with_platform(hass: HomeAssistant) -> None:
"""Remove an entity from a platform."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
entity1 = MockEntity(name="test_1")
await component.async_add_entities([entity1])
assert len(hass.states.async_entity_ids()) == 1
@ -441,6 +450,7 @@ async def test_async_remove_with_platform(hass: HomeAssistant) -> None:
async def test_async_remove_with_platform_update_finishes(hass: HomeAssistant) -> None:
"""Remove an entity when an update finishes after its been removed."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
entity1 = MockEntity(name="test_1")
async def _delayed_update(*args, **kwargs):
@ -471,6 +481,7 @@ async def test_not_adding_duplicate_entities_with_unique_id(
"""
caplog.set_level(logging.ERROR)
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
ent1 = MockEntity(name="test1", unique_id="not_very_unique")
await component.async_add_entities([ent1])
@ -504,6 +515,7 @@ async def test_not_adding_duplicate_entities_with_unique_id(
async def test_using_prescribed_entity_id(hass: HomeAssistant) -> None:
"""Test for using predefined entity ID."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities(
[MockEntity(name="bla", entity_id="hello.world")]
)
@ -513,6 +525,7 @@ async def test_using_prescribed_entity_id(hass: HomeAssistant) -> None:
async def test_using_prescribed_entity_id_with_unique_id(hass: HomeAssistant) -> None:
"""Test for amending predefined entity ID because currently exists."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities([MockEntity(entity_id="test_domain.world")])
await component.async_add_entities(
@ -527,6 +540,7 @@ async def test_using_prescribed_entity_id_which_is_registered(
) -> None:
"""Test not allowing predefined entity ID that already registered."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
# Register test_domain.world
entity_registry.async_get_or_create(
DOMAIN, "test", "1234", suggested_object_id="world"
@ -543,6 +557,7 @@ async def test_name_which_conflict_with_registered(
) -> None:
"""Test not generating conflicting entity ID based on name."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
# Register test_domain.world
entity_registry.async_get_or_create(
@ -559,6 +574,7 @@ async def test_entity_with_name_and_entity_id_getting_registered(
) -> None:
"""Ensure that entity ID is used for registration."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities(
[MockEntity(unique_id="1234", name="bla", entity_id="test_domain.world")]
)
@ -568,6 +584,7 @@ async def test_entity_with_name_and_entity_id_getting_registered(
async def test_overriding_name_from_registry(hass: HomeAssistant) -> None:
"""Test that we can override a name via the Entity Registry."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
mock_registry(
hass,
{
@ -625,6 +642,7 @@ async def test_unique_id_conflict_has_priority_over_disabled_entity(
) -> None:
"""Test that an entity that is not unique has priority over a disabled entity."""
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
entity1 = MockEntity(
name="test1", unique_id="not_very_unique", enabled_by_default=False
)
@ -1192,6 +1210,7 @@ async def test_device_info_change_to_no_url(
async def test_entity_disabled_by_integration(hass: HomeAssistant) -> None:
"""Test entity disabled by integration."""
component = EntityComponent(_LOGGER, DOMAIN, hass, timedelta(seconds=20))
await component.async_setup({})
entity_default = MockEntity(unique_id="default")
entity_disabled = MockEntity(
@ -1254,6 +1273,7 @@ async def test_entity_disabled_by_device(hass: HomeAssistant) -> None:
async def test_entity_hidden_by_integration(hass: HomeAssistant) -> None:
"""Test entity hidden by integration."""
component = EntityComponent(_LOGGER, DOMAIN, hass, timedelta(seconds=20))
await component.async_setup({})
entity_default = MockEntity(unique_id="default")
entity_hidden = MockEntity(
@ -1273,6 +1293,7 @@ async def test_entity_hidden_by_integration(hass: HomeAssistant) -> None:
async def test_entity_info_added_to_entity_registry(hass: HomeAssistant) -> None:
"""Test entity info is written to entity registry."""
component = EntityComponent(_LOGGER, DOMAIN, hass, timedelta(seconds=20))
await component.async_setup({})
entity_default = MockEntity(
capability_attributes={"max": 100},
@ -1323,6 +1344,7 @@ async def test_override_restored_entities(
hass.states.async_set("test_domain.world", "unavailable", {"restored": True})
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
await component.async_add_entities(
[MockEntity(unique_id="1234", state="on", entity_id="test_domain.world")], True