Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove icon where device_class is defined. (#54323)

pull/54343/head
jan iversen 2021-08-09 13:13:11 +02:00 committed by GitHub
parent 608f406a2c
commit 9b7b787fe4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
homeassistant/components/arlo/sensor.py
View File

@ -38,7 +38,6 @@ SENSOR_TYPES = (
key="battery_level", key="battery_level",
name="Battery Level", name="Battery Level",
unit_of_measurement=PERCENTAGE, unit_of_measurement=PERCENTAGE,
icon="mdi:battery-50",
device_class=DEVICE_CLASS_BATTERY, device_class=DEVICE_CLASS_BATTERY,
), ),
SensorEntityDescription( SensorEntityDescription(
@ -48,14 +47,12 @@ SENSOR_TYPES = (
key="temperature", key="temperature",
name="Temperature", name="Temperature",
unit_of_measurement=TEMP_CELSIUS, unit_of_measurement=TEMP_CELSIUS,
icon="mdi:thermometer",
device_class=DEVICE_CLASS_TEMPERATURE, device_class=DEVICE_CLASS_TEMPERATURE,
), ),
SensorEntityDescription( SensorEntityDescription(
key="humidity", key="humidity",
name="Humidity", name="Humidity",
unit_of_measurement=PERCENTAGE, unit_of_measurement=PERCENTAGE,
icon="mdi:water-percent",
device_class=DEVICE_CLASS_HUMIDITY, device_class=DEVICE_CLASS_HUMIDITY,
), ),
SensorEntityDescription( SensorEntityDescription(

13
tests/components/arlo/test_sensor.py
View File

@ -8,6 +8,7 @@ from homeassistant.components.arlo import DATA_ARLO, sensor as arlo
from homeassistant.components.arlo.sensor import SENSOR_TYPES from homeassistant.components.arlo.sensor import SENSOR_TYPES
from homeassistant.const import ( from homeassistant.const import (
ATTR_ATTRIBUTION, ATTR_ATTRIBUTION,
DEVICE_CLASS_BATTERY,
DEVICE_CLASS_HUMIDITY, DEVICE_CLASS_HUMIDITY,
DEVICE_CLASS_TEMPERATURE, DEVICE_CLASS_TEMPERATURE,
PERCENTAGE, PERCENTAGE,
@ -161,14 +162,14 @@ def test_sensor_state_default(default_sensor):
assert default_sensor.state is None assert default_sensor.state is None
def test_sensor_icon_battery(battery_sensor): def test_sensor_device_class__battery(battery_sensor):
"""Test the battery icon.""" """Test the battery device_class."""
assert battery_sensor.icon == "mdi:battery-50" assert battery_sensor.device_class == DEVICE_CLASS_BATTERY
def test_sensor_icon(temperature_sensor): def test_sensor_device_class(temperature_sensor):
"""Test the icon property.""" """Test the device_class property."""
assert temperature_sensor.icon == "mdi:thermometer" assert temperature_sensor.device_class == DEVICE_CLASS_TEMPERATURE
def test_unit_of_measure(default_sensor, battery_sensor): def test_unit_of_measure(default_sensor, battery_sensor):