Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove use of HVAC_MODE_OFF in plugwise climate, it's not implemented (#69094)

pull/68033/head^2
Bouwe Westerdijk 2022-04-01 20:53:09 +02:00 committed by GitHub
parent 4f49939bc0
commit 9902ecb417
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/plugwise/climate.py
View File

@ -12,7 +12,6 @@ from homeassistant.components.climate.const import (
HVAC_MODE_AUTO,
HVAC_MODE_COOL,
HVAC_MODE_HEAT,
HVAC_MODE_OFF,
SUPPORT_PRESET_MODE,
SUPPORT_TARGET_TEMPERATURE,
)
@ -64,7 +63,7 @@ class PlugwiseClimateEntity(PlugwiseEntity, ClimateEntity):
self._attr_preset_modes = list(presets)
# Determine hvac modes and current hvac mode
self._attr_hvac_modes = [HVAC_MODE_HEAT, HVAC_MODE_OFF]
self._attr_hvac_modes = [HVAC_MODE_HEAT]
if self.coordinator.data.gateway.get("cooling_present"):
self._attr_hvac_modes.append(HVAC_MODE_COOL)
if self.device.get("available_schedules") != ["None"]:
@ -90,7 +89,7 @@ class PlugwiseClimateEntity(PlugwiseEntity, ClimateEntity):
def hvac_mode(self) -> str:
"""Return HVAC operation ie. heat, cool mode."""
if (mode := self.device.get("mode")) is None or mode not in self.hvac_modes:
return HVAC_MODE_OFF
return HVAC_MODE_HEAT
return mode
@property

4
tests/components/plugwise/test_climate.py
View File

@ -9,7 +9,6 @@ from homeassistant.components.climate.const import (
HVAC_MODE_AUTO,
HVAC_MODE_COOL,
HVAC_MODE_HEAT,
HVAC_MODE_OFF,
)
from homeassistant.core import HomeAssistant
from homeassistant.exceptions import HomeAssistantError
@ -26,7 +25,6 @@ async def test_adam_climate_entity_attributes(
assert state
assert state.attributes["hvac_modes"] == [
HVAC_MODE_HEAT,
HVAC_MODE_OFF,
HVAC_MODE_AUTO,
]
@ -47,7 +45,6 @@ async def test_adam_climate_entity_attributes(
assert state.attributes["hvac_modes"] == [
HVAC_MODE_HEAT,
HVAC_MODE_OFF,
HVAC_MODE_AUTO,
]
@ -161,7 +158,6 @@ async def test_anna_climate_entity_attributes(
assert state.state == HVAC_MODE_HEAT
assert state.attributes["hvac_modes"] == [
HVAC_MODE_HEAT,
HVAC_MODE_OFF,
HVAC_MODE_COOL,
]
assert "no_frost" in state.attributes["preset_modes"]