Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

handle timeout errors without logging.exception when updating hue lights; double quotes in log msgs (#8524)

pull/8535/head
Eugenio Panadero 2017-07-17 22:16:18 +02:00 committed by Fabian Affolter
parent 95e0027924
commit 8c9b3898fc
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
homeassistant/components/light/hue.py
View File

@ -115,7 +115,7 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
if discovery_info is not None: if discovery_info is not None:
if "HASS Bridge" in discovery_info.get('name', ''): if "HASS Bridge" in discovery_info.get('name', ''):
_LOGGER.info('Emulated hue found, will not add') _LOGGER.info("Emulated hue found, will not add")
return False return False
host = discovery_info.get('host') host = discovery_info.get('host')
@ -126,7 +126,7 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
host = _find_host_from_config(hass, filename) host = _find_host_from_config(hass, filename)
if host is None: if host is None:
_LOGGER.error('No host found in configuration') _LOGGER.error("No host found in configuration")
return False return False
# Only act if we are not already configuring this host # Only act if we are not already configuring this host
@ -180,6 +180,12 @@ def setup_bridge(host, hass, add_devices, filename, allow_unreachable,
try: try:
api = bridge.get_api() api = bridge.get_api()
except phue.PhueRequestTimeout:
_LOGGER.warning("Timeout trying to reach the bridge")
return
except ConnectionRefusedError:
_LOGGER.error("The bridge refused the connection")
return
except socket.error: except socket.error:
# socket.error when we cannot reach Hue # socket.error when we cannot reach Hue
_LOGGER.exception("Cannot reach the bridge") _LOGGER.exception("Cannot reach the bridge")
@ -221,8 +227,8 @@ def setup_bridge(host, hass, add_devices, filename, allow_unreachable,
for lightgroup_id, info in api_groups.items(): for lightgroup_id, info in api_groups.items():
if 'state' not in info: if 'state' not in info:
_LOGGER.warning('Group info does not contain state. ' _LOGGER.warning("Group info does not contain state. "
'Please update your hub.') "Please update your hub.")
skip_groups = True skip_groups = True
break break