Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Copy callbacks instead of slice for event dispatch (#109711) 

We established copy is faster in
https://github.com/home-assistant/core/pull/108428#discussion_r1466932262
pull/109731/head
J. Nick Koston 2024-02-05 10:07:21 -06:00 committed by GitHub
parent 8df305c881
commit 6f28d79651
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/helpers/event.py
View File

@ -291,7 +291,7 @@ def _async_dispatch_entity_id_event(
"""Dispatch to listeners.""" """Dispatch to listeners."""
if not (callbacks_list := callbacks.get(event.data["entity_id"])): if not (callbacks_list := callbacks.get(event.data["entity_id"])):
return return
for job in callbacks_list[:]: for job in callbacks_list.copy():
try: try:
hass.async_run_hass_job(job, event) hass.async_run_hass_job(job, event)
except Exception: # pylint: disable=broad-except except Exception: # pylint: disable=broad-except
@ -428,7 +428,7 @@ def _async_dispatch_old_entity_id_or_entity_id_event(
) )
): ):
return return
for job in callbacks_list[:]: for job in callbacks_list.copy():
try: try:
hass.async_run_hass_job(job, event) hass.async_run_hass_job(job, event)
except Exception: # pylint: disable=broad-except except Exception: # pylint: disable=broad-except
@ -499,7 +499,7 @@ def _async_dispatch_device_id_event(
"""Dispatch to listeners.""" """Dispatch to listeners."""
if not (callbacks_list := callbacks.get(event.data["device_id"])): if not (callbacks_list := callbacks.get(event.data["device_id"])):
return return
for job in callbacks_list[:]: for job in callbacks_list.copy():
try: try:
hass.async_run_hass_job(job, event) hass.async_run_hass_job(job, event)
except Exception: # pylint: disable=broad-except except Exception: # pylint: disable=broad-except