Improve `lookin` generic typing (#84636)

homeassistant/components/lookin/__init__.py

@@ -102,7 +102,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
     push_coordinator = LookinPushCoordinator(entry.title)
 
     if lookin_device.model >= 2:
-        meteo_coordinator: LookinDataUpdateCoordinator = LookinDataUpdateCoordinator(
+        meteo_coordinator = LookinDataUpdateCoordinator[MeteoSensor](
             hass,
             push_coordinator,
             name=entry.title,
@@ -113,7 +113,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
         )
         await meteo_coordinator.async_config_entry_first_refresh()
 
-    device_coordinators: dict[str, LookinDataUpdateCoordinator] = {}
+    device_coordinators: dict[str, LookinDataUpdateCoordinator[Remote]] = {}
     for remote in devices:
         if (platform := TYPE_TO_PLATFORM.get(remote["Type"])) is None:
             continue

homeassistant/components/lookin/climate.py

@@ -4,7 +4,7 @@ from __future__ import annotations
 import logging
 from typing import Any, Final, cast
 
-from aiolookin import Climate, MeteoSensor
+from aiolookin import Climate, MeteoSensor, Remote
 from aiolookin.models import UDPCommandType, UDPEvent
 
 from homeassistant.components.climate import (
@@ -75,7 +75,7 @@ async def async_setup_entry(
             continue
         uuid = remote["UUID"]
         coordinator = lookin_data.device_coordinators[uuid]
-        device: Climate = coordinator.data
+        device = cast(Climate, coordinator.data)
         entities.append(
             ConditionerEntity(
                 uuid=uuid,
@@ -110,7 +110,7 @@ class ConditionerEntity(LookinCoordinatorEntity, ClimateEntity):
         uuid: str,
         device: Climate,
         lookin_data: LookinData,
-        coordinator: LookinDataUpdateCoordinator,
+        coordinator: LookinDataUpdateCoordinator[Remote],
     ) -> None:
         """Init the ConditionerEntity."""
         super().__init__(coordinator, uuid, device, lookin_data)

homeassistant/components/lookin/coordinator.py

@@ -5,12 +5,13 @@ from collections.abc import Awaitable, Callable
 from datetime import timedelta
 import logging
 import time
-from typing import cast
+from typing import TypeVar
 
 from homeassistant.core import HomeAssistant, callback
 from homeassistant.helpers.update_coordinator import DataUpdateCoordinator
 
 _LOGGER = logging.getLogger(__name__)
+_DataT = TypeVar("_DataT")
 
 NEVER_TIME = -120.0  # Time that will never match time.monotonic()
 ACTIVE_UPDATES_INTERVAL = 3  # Consider active for 3x the update interval
@@ -43,7 +44,7 @@ class LookinPushCoordinator:
         return is_active
 
 
-class LookinDataUpdateCoordinator(DataUpdateCoordinator):
+class LookinDataUpdateCoordinator(DataUpdateCoordinator[_DataT]):
     """DataUpdateCoordinator to gather data for a specific lookin devices."""
 
     def __init__(
@@ -52,7 +53,7 @@ class LookinDataUpdateCoordinator(DataUpdateCoordinator):
         push_coordinator: LookinPushCoordinator,
         name: str,
         update_interval: timedelta | None = None,
-        update_method: Callable[[], Awaitable[dict]] | None = None,
+        update_method: Callable[[], Awaitable[_DataT]] | None = None,
     ) -> None:
         """Initialize DataUpdateCoordinator to gather data for specific device."""
         self.push_coordinator = push_coordinator
@@ -65,12 +66,12 @@ class LookinDataUpdateCoordinator(DataUpdateCoordinator):
         )
 
     @callback
-    def async_set_updated_data(self, data: dict) -> None:
+    def async_set_updated_data(self, data: _DataT) -> None:
         """Manually update data, notify listeners and reset refresh interval, and remember."""
         self.push_coordinator.update()
         super().async_set_updated_data(data)
 
-    async def _async_update_data(self) -> dict:
+    async def _async_update_data(self) -> _DataT:
         """Fetch data only if we have not received a push inside the interval."""
         interval = self.update_interval
         if (
@@ -82,4 +83,4 @@ class LookinDataUpdateCoordinator(DataUpdateCoordinator):
             data = self.data
         else:
             data = await super()._async_update_data()
-        return cast(dict, data)
+        return data

homeassistant/components/lookin/entity.py

@@ -3,9 +3,15 @@ from __future__ import annotations
 
 from abc import abstractmethod
 import logging
-from typing import cast
 
-from aiolookin import POWER_CMD, POWER_OFF_CMD, POWER_ON_CMD, Climate, Remote
+from aiolookin import (
+    POWER_CMD,
+    POWER_OFF_CMD,
+    POWER_ON_CMD,
+    Climate,
+    MeteoSensor,
+    Remote,
+)
 from aiolookin.models import Device, UDPCommandType, UDPEvent
 
 from homeassistant.helpers.entity import DeviceInfo
@@ -53,7 +59,7 @@ class LookinDeviceMixIn:
 
 
 class LookinDeviceCoordinatorEntity(
-    LookinDeviceMixIn, CoordinatorEntity[LookinDataUpdateCoordinator]
+    LookinDeviceMixIn, CoordinatorEntity[LookinDataUpdateCoordinator[MeteoSensor]]
 ):
     """A lookin device entity on the device itself that uses the coordinator."""
 
@@ -86,7 +92,9 @@ class LookinEntityMixIn:
 
 
 class LookinCoordinatorEntity(
-    LookinDeviceMixIn, LookinEntityMixIn, CoordinatorEntity[LookinDataUpdateCoordinator]
+    LookinDeviceMixIn,
+    LookinEntityMixIn,
+    CoordinatorEntity[LookinDataUpdateCoordinator[Remote]],
 ):
     """A lookin device entity for an external device that uses the coordinator."""
 
@@ -95,7 +103,7 @@ class LookinCoordinatorEntity(
 
     def __init__(
         self,
-        coordinator: LookinDataUpdateCoordinator,
+        coordinator: LookinDataUpdateCoordinator[Remote],
         uuid: str,
         device: Remote | Climate,
         lookin_data: LookinData,
@@ -122,7 +130,7 @@ class LookinPowerEntity(LookinCoordinatorEntity):
 
     def __init__(
         self,
-        coordinator: LookinDataUpdateCoordinator,
+        coordinator: LookinDataUpdateCoordinator[Remote],
         uuid: str,
         device: Remote | Climate,
         lookin_data: LookinData,
@@ -142,7 +150,7 @@ class LookinPowerPushRemoteEntity(LookinPowerEntity):
 
     def __init__(
         self,
-        coordinator: LookinDataUpdateCoordinator,
+        coordinator: LookinDataUpdateCoordinator[Remote],
         uuid: str,
         device: Remote,
         lookin_data: LookinData,
@@ -154,7 +162,7 @@ class LookinPowerPushRemoteEntity(LookinPowerEntity):
 
     @property
     def _remote(self) -> Remote:
-        return cast(Remote, self.coordinator.data)
+        return self.coordinator.data
 
     @abstractmethod
     def _update_from_status(self, status: str) -> None:

homeassistant/components/lookin/light.py

@@ -4,8 +4,6 @@ from __future__ import annotations
 import logging
 from typing import Any
 
-from aiolookin import Remote
-
 from homeassistant.components.light import ColorMode, LightEntity
 from homeassistant.config_entries import ConfigEntry
 from homeassistant.const import Platform
@@ -33,7 +31,7 @@ async def async_setup_entry(
             continue
         uuid = remote["UUID"]
         coordinator = lookin_data.device_coordinators[uuid]
-        device: Remote = coordinator.data
+        device = coordinator.data
         entities.append(
             LookinLightEntity(
                 coordinator=coordinator,

homeassistant/components/lookin/models.py

@@ -4,7 +4,13 @@ from __future__ import annotations
 from dataclasses import dataclass
 from typing import Any
 
-from aiolookin import Device, LookInHttpProtocol, LookinUDPSubscriptions
+from aiolookin import (
+    Device,
+    LookInHttpProtocol,
+    LookinUDPSubscriptions,
+    MeteoSensor,
+    Remote,
+)
 
 from .coordinator import LookinDataUpdateCoordinator
 
@@ -16,7 +22,7 @@ class LookinData:
     host: str
     lookin_udp_subs: LookinUDPSubscriptions
     lookin_device: Device
-    meteo_coordinator: LookinDataUpdateCoordinator | None
+    meteo_coordinator: LookinDataUpdateCoordinator[MeteoSensor] | None
     devices: list[dict[str, Any]]
     lookin_protocol: LookInHttpProtocol
-    device_coordinators: dict[str, LookinDataUpdateCoordinator]
+    device_coordinators: dict[str, LookinDataUpdateCoordinator[Remote]]