From 4cf1b1a707e1c47851926de42cd3f0c5dd9c380c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=85ke=20Strandberg?= <ake@strandberg.eu>
Date: Thu, 23 Jan 2025 18:04:00 +0100
Subject: [PATCH] Avoid keyerror on incomplete api data in myuplink (#136333)

* Avoid keyerror

* Inject erroneous value in device point fixture

* Update diagnostics snapshot
---
 homeassistant/components/myuplink/sensor.py               | 4 ++--
 .../myuplink/fixtures/device_points_nibe_f730.json        | 2 +-
 tests/components/myuplink/snapshots/test_diagnostics.ambr | 4 ++--
 tests/components/myuplink/snapshots/test_sensor.ambr      | 8 ++++----
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/homeassistant/components/myuplink/sensor.py b/homeassistant/components/myuplink/sensor.py
index ef827fc1fb1..fa50e8a7001 100644
--- a/homeassistant/components/myuplink/sensor.py
+++ b/homeassistant/components/myuplink/sensor.py
@@ -325,10 +325,10 @@ class MyUplinkEnumSensor(MyUplinkDevicePointSensor):
         }
 
     @property
-    def native_value(self) -> str:
+    def native_value(self) -> str | None:
         """Sensor state value for enum sensor."""
         device_point = self.coordinator.data.points[self.device_id][self.point_id]
-        return self.options_map[str(int(device_point.value))]  # type: ignore[no-any-return]
+        return self.options_map.get(str(int(device_point.value)))
 
 
 class MyUplinkEnumRawSensor(MyUplinkDevicePointSensor):
diff --git a/tests/components/myuplink/fixtures/device_points_nibe_f730.json b/tests/components/myuplink/fixtures/device_points_nibe_f730.json
index 0a61ab05f21..795a89e7e13 100644
--- a/tests/components/myuplink/fixtures/device_points_nibe_f730.json
+++ b/tests/components/myuplink/fixtures/device_points_nibe_f730.json
@@ -822,7 +822,7 @@
     "parameterUnit": "",
     "writable": false,
     "timestamp": "2024-02-08T19:13:05+00:00",
-    "value": 30,
+    "value": 31,
     "strVal": "Heating",
     "smartHomeCategories": [],
     "minValue": null,
diff --git a/tests/components/myuplink/snapshots/test_diagnostics.ambr b/tests/components/myuplink/snapshots/test_diagnostics.ambr
index 6fe6becff11..521823e282d 100644
--- a/tests/components/myuplink/snapshots/test_diagnostics.ambr
+++ b/tests/components/myuplink/snapshots/test_diagnostics.ambr
@@ -883,7 +883,7 @@
                     "parameterUnit": "",
                     "writable": false,
                     "timestamp": "2024-02-08T19:13:05+00:00",
-                    "value": 30,
+                    "value": 31,
                     "strVal": "Heating",
                     "smartHomeCategories": [],
                     "minValue": null,
@@ -2045,7 +2045,7 @@
                     "parameterUnit": "",
                     "writable": false,
                     "timestamp": "2024-02-08T19:13:05+00:00",
-                    "value": 30,
+                    "value": 31,
                     "strVal": "Heating",
                     "smartHomeCategories": [],
                     "minValue": null,
diff --git a/tests/components/myuplink/snapshots/test_sensor.ambr b/tests/components/myuplink/snapshots/test_sensor.ambr
index a5469dc9a77..34acbbb8785 100644
--- a/tests/components/myuplink/snapshots/test_sensor.ambr
+++ b/tests/components/myuplink/snapshots/test_sensor.ambr
@@ -3396,7 +3396,7 @@
     'last_changed': <ANY>,
     'last_reported': <ANY>,
     'last_updated': <ANY>,
-    'state': 'Heating',
+    'state': 'unknown',
   })
 # ---
 # name: test_sensor_states[sensor.gotham_city_priority_2-entry]
@@ -3462,7 +3462,7 @@
     'last_changed': <ANY>,
     'last_reported': <ANY>,
     'last_updated': <ANY>,
-    'state': 'Heating',
+    'state': 'unknown',
   })
 # ---
 # name: test_sensor_states[sensor.gotham_city_priority_raw-entry]
@@ -3508,7 +3508,7 @@
     'last_changed': <ANY>,
     'last_reported': <ANY>,
     'last_updated': <ANY>,
-    'state': '30',
+    'state': '31',
   })
 # ---
 # name: test_sensor_states[sensor.gotham_city_priority_raw_2-entry]
@@ -3554,7 +3554,7 @@
     'last_changed': <ANY>,
     'last_reported': <ANY>,
     'last_updated': <ANY>,
-    'state': '30',
+    'state': '31',
   })
 # ---
 # name: test_sensor_states[sensor.gotham_city_r_start_diff_additional_heat-entry]