Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unknown attribute instead of marking STATE_UNKNOWN (#60325)

pull/60337/head
Thomas Dietrich 2021-11-25 15:13:55 +01:00 committed by GitHub
parent 8b001fd54d
commit 4c0d90ed41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
homeassistant/components/statistics/sensor.py
View File

@ -177,9 +177,9 @@ class StatisticsSensor(SensorEntity):
self.states = deque(maxlen=self._samples_max_buffer_size)
self.ages = deque(maxlen=self._samples_max_buffer_size)
self.attributes = {
STAT_AGE_COVERAGE_RATIO: STATE_UNKNOWN,
STAT_BUFFER_USAGE_RATIO: STATE_UNKNOWN,
STAT_SOURCE_VALUE_VALID: STATE_UNKNOWN,
STAT_AGE_COVERAGE_RATIO: None,
STAT_BUFFER_USAGE_RATIO: None,
STAT_SOURCE_VALUE_VALID: None,
}
self._state_characteristic_fn = getattr(
self, f"_stat_{self._state_characteristic}"
@ -319,15 +319,8 @@ class StatisticsSensor(SensorEntity):
@property
def extra_state_attributes(self):
"""Return the state attributes of the sensor."""
extra_attr = {}
if self._samples_max_age is not None:
extra_attr = {
STAT_AGE_COVERAGE_RATIO: self.attributes[STAT_AGE_COVERAGE_RATIO]
}
return {
**extra_attr,
STAT_BUFFER_USAGE_RATIO: self.attributes[STAT_BUFFER_USAGE_RATIO],
STAT_SOURCE_VALUE_VALID: self.attributes[STAT_SOURCE_VALUE_VALID],
key: value for key, value in self.attributes.items() if value is not None
}
@property
@ -449,7 +442,7 @@ class StatisticsSensor(SensorEntity):
2,
)
else:
self.attributes[STAT_AGE_COVERAGE_RATIO] = STATE_UNKNOWN
self.attributes[STAT_AGE_COVERAGE_RATIO] = None
def _update_value(self):
"""Front to call the right statistical characteristics functions.

2
tests/components/statistics/test_sensor.py
View File

@ -328,7 +328,7 @@ class TestStatisticsSensor(unittest.TestCase):
state = self.hass.states.get("sensor.test")
assert state.state == STATE_UNKNOWN
assert state.attributes.get("buffer_usage_ratio") == round(0 / 20, 2)
assert state.attributes.get("age_coverage_ratio") == STATE_UNKNOWN
assert state.attributes.get("age_coverage_ratio") is None
def test_precision_0(self):
"""Test correct result with precision=0 as integer."""