Add a debounce to ld2410 to prevent it from overwhelming the state machine with many devices (#93819)
* Add a debounce to ld2410 to prevent it from overwhelming the state machine fixes #86665 * set time on debouncepull/93841/head
parent
049582ec50
commit
466eec2f04
|
@ -2,7 +2,7 @@
|
||||||
|
|
||||||
import logging
|
import logging
|
||||||
|
|
||||||
from bleak_retry_connector import BleakError, get_device
|
from bleak_retry_connector import BleakError, close_stale_connections, get_device
|
||||||
from ld2410_ble import LD2410BLE
|
from ld2410_ble import LD2410BLE
|
||||||
|
|
||||||
from homeassistant.components import bluetooth
|
from homeassistant.components import bluetooth
|
||||||
|
@ -31,6 +31,9 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
|
||||||
raise ConfigEntryNotReady(
|
raise ConfigEntryNotReady(
|
||||||
f"Could not find LD2410B device with address {address}"
|
f"Could not find LD2410B device with address {address}"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
await close_stale_connections(ble_device)
|
||||||
|
|
||||||
ld2410_ble = LD2410BLE(ble_device)
|
ld2410_ble = LD2410BLE(ble_device)
|
||||||
|
|
||||||
coordinator = LD2410BLECoordinator(hass, ld2410_ble)
|
coordinator = LD2410BLECoordinator(hass, ld2410_ble)
|
||||||
|
|
|
@ -1,16 +1,22 @@
|
||||||
"""Data coordinator for receiving LD2410B updates."""
|
"""Data coordinator for receiving LD2410B updates."""
|
||||||
|
|
||||||
|
from datetime import datetime
|
||||||
import logging
|
import logging
|
||||||
|
import time
|
||||||
|
|
||||||
from ld2410_ble import LD2410BLE, LD2410BLEState
|
from ld2410_ble import LD2410BLE, LD2410BLEState
|
||||||
|
|
||||||
from homeassistant.core import HomeAssistant, callback
|
from homeassistant.core import CALLBACK_TYPE, HassJob, HomeAssistant, callback
|
||||||
|
from homeassistant.helpers.event import async_call_later
|
||||||
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator
|
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator
|
||||||
|
|
||||||
from .const import DOMAIN
|
from .const import DOMAIN
|
||||||
|
|
||||||
_LOGGER = logging.getLogger(__name__)
|
_LOGGER = logging.getLogger(__name__)
|
||||||
|
|
||||||
|
NEVER_TIME = -86400.0
|
||||||
|
DEBOUNCE_SECONDS = 1.0
|
||||||
|
|
||||||
|
|
||||||
class LD2410BLECoordinator(DataUpdateCoordinator[None]):
|
class LD2410BLECoordinator(DataUpdateCoordinator[None]):
|
||||||
"""Data coordinator for receiving LD2410B updates."""
|
"""Data coordinator for receiving LD2410B updates."""
|
||||||
|
@ -26,15 +32,43 @@ class LD2410BLECoordinator(DataUpdateCoordinator[None]):
|
||||||
ld2410_ble.register_callback(self._async_handle_update)
|
ld2410_ble.register_callback(self._async_handle_update)
|
||||||
ld2410_ble.register_disconnected_callback(self._async_handle_disconnect)
|
ld2410_ble.register_disconnected_callback(self._async_handle_disconnect)
|
||||||
self.connected = False
|
self.connected = False
|
||||||
|
self._last_update_time = NEVER_TIME
|
||||||
|
self._debounce_cancel: CALLBACK_TYPE | None = None
|
||||||
|
self._debounced_update_job = HassJob(
|
||||||
|
self._async_handle_debounced_update,
|
||||||
|
f"LD2410 {ld2410_ble.address} BLE debounced update",
|
||||||
|
)
|
||||||
|
|
||||||
|
@callback
|
||||||
|
def _async_handle_debounced_update(self, _now: datetime) -> None:
|
||||||
|
"""Handle debounced update."""
|
||||||
|
self._debounce_cancel = None
|
||||||
|
self._last_update_time = time.monotonic()
|
||||||
|
self.async_set_updated_data(None)
|
||||||
|
|
||||||
@callback
|
@callback
|
||||||
def _async_handle_update(self, state: LD2410BLEState) -> None:
|
def _async_handle_update(self, state: LD2410BLEState) -> None:
|
||||||
"""Just trigger the callbacks."""
|
"""Just trigger the callbacks."""
|
||||||
self.connected = True
|
self.connected = True
|
||||||
self.async_set_updated_data(None)
|
previous_last_updated_time = self._last_update_time
|
||||||
|
self._last_update_time = time.monotonic()
|
||||||
|
if self._last_update_time - previous_last_updated_time >= DEBOUNCE_SECONDS:
|
||||||
|
self.async_set_updated_data(None)
|
||||||
|
return
|
||||||
|
if self._debounce_cancel is None:
|
||||||
|
self._debounce_cancel = async_call_later(
|
||||||
|
self.hass, DEBOUNCE_SECONDS, self._debounced_update_job
|
||||||
|
)
|
||||||
|
|
||||||
@callback
|
@callback
|
||||||
def _async_handle_disconnect(self) -> None:
|
def _async_handle_disconnect(self) -> None:
|
||||||
"""Trigger the callbacks for disconnected."""
|
"""Trigger the callbacks for disconnected."""
|
||||||
self.connected = False
|
self.connected = False
|
||||||
self.async_update_listeners()
|
self.async_update_listeners()
|
||||||
|
|
||||||
|
async def async_shutdown(self) -> None:
|
||||||
|
"""Shutdown the coordinator."""
|
||||||
|
if self._debounce_cancel is not None:
|
||||||
|
self._debounce_cancel()
|
||||||
|
self._debounce_cancel = None
|
||||||
|
await super().async_shutdown()
|
||||||
|
|
Loading…
Reference in New Issue