Remove zwave_js transition on individual color channels (#54303)

pull/54343/head
Chris 2021-08-09 04:21:41 -07:00 committed by GitHub
parent 9b7b787fe4
commit 3742333a89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 15 deletions

View File

@ -301,7 +301,7 @@ class ZwaveLight(ZWaveBaseEntity, LightEntity):
# fallback to setting the color(s) one by one if multicolor fails
# not sure this is needed at all, but just in case
for color, value in colors.items():
await self._async_set_color(color, value, zwave_transition)
await self._async_set_color(color, value)
async def _async_set_color(
self,

View File

@ -1021,8 +1021,7 @@ async def test_multicast_set_value_options(
],
ATTR_COMMAND_CLASS: 51,
ATTR_PROPERTY: "targetColor",
ATTR_PROPERTY_KEY: 2,
ATTR_VALUE: 2,
ATTR_VALUE: '{ "warmWhite": 0, "coldWhite": 0, "red": 255, "green": 0, "blue": 0 }',
ATTR_OPTIONS: {"transitionDuration": 1},
},
blocking=True,
@ -1038,9 +1037,11 @@ async def test_multicast_set_value_options(
assert args["valueId"] == {
"commandClass": 51,
"property": "targetColor",
"propertyKey": 2,
}
assert args["value"] == 2
assert (
args["value"]
== '{ "warmWhite": 0, "coldWhite": 0, "red": 255, "green": 0, "blue": 0 }'
)
assert args["options"] == {"transitionDuration": 1}
client.async_send_command.reset_mock()

View File

@ -267,8 +267,7 @@
"min": 0,
"max": 255,
"label": "Target value (Warm White)",
"description": "The target value of the Warm White color.",
"valueChangeOptions": ["transitionDuration"]
"description": "The target value of the Warm White color."
}
},
{
@ -286,8 +285,7 @@
"min": 0,
"max": 255,
"label": "Target value (Cold White)",
"description": "The target value of the Cold White color.",
"valueChangeOptions": ["transitionDuration"]
"description": "The target value of the Cold White color."
}
},
{
@ -305,8 +303,7 @@
"min": 0,
"max": 255,
"label": "Target value (Red)",
"description": "The target value of the Red color.",
"valueChangeOptions": ["transitionDuration"]
"description": "The target value of the Red color."
}
},
{
@ -324,8 +321,7 @@
"min": 0,
"max": 255,
"label": "Target value (Green)",
"description": "The target value of the Green color.",
"valueChangeOptions": ["transitionDuration"]
"description": "The target value of the Green color."
}
},
{
@ -343,8 +339,7 @@
"min": 0,
"max": 255,
"label": "Target value (Blue)",
"description": "The target value of the Blue color.",
"valueChangeOptions": ["transitionDuration"]
"description": "The target value of the Blue color."
}
},
{