Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Migrate condition/state/trigger helper to use async_get_platform (#112144) 

Currently these would always load the platform in the loop
if it was not already loaded
pull/112156/head
J. Nick Koston 2024-03-03 16:20:47 -10:00 committed by GitHub
parent f1eab3f11f
commit 331989de4c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/helpers/condition.py
View File

@ -197,7 +197,7 @@ async def _async_get_condition_platform(
f'Invalid condition "{platform}" specified {config}' f'Invalid condition "{platform}" specified {config}'
) from None ) from None
try: try:
return integration.get_platform("condition") return await integration.async_get_platform("condition")
except ImportError: except ImportError:
raise HomeAssistantError( raise HomeAssistantError(
f"Integration '{platform}' does not provide condition support" f"Integration '{platform}' does not provide condition support"

4
homeassistant/helpers/state.py
View File

@ -53,7 +53,9 @@ async def async_reproduce_state(
return return
try: try:
platform: ModuleType = integration.get_platform("reproduce_state") platform: ModuleType = await integration.async_get_platform(
"reproduce_state"
)
except ImportError: except ImportError:
_LOGGER.warning("Integration %s does not support reproduce state", domain) _LOGGER.warning("Integration %s does not support reproduce state", domain)
return return

2
homeassistant/helpers/trigger.py
View File

@ -222,7 +222,7 @@ async def _async_get_trigger_platform(
except IntegrationNotFound: except IntegrationNotFound:
raise vol.Invalid(f"Invalid platform '{platform}' specified") from None raise vol.Invalid(f"Invalid platform '{platform}' specified") from None
try: try:
return integration.get_platform("trigger") return await integration.async_get_platform("trigger")
except ImportError: except ImportError:
raise vol.Invalid( raise vol.Invalid(
f"Integration '{platform}' does not provide trigger support" f"Integration '{platform}' does not provide trigger support"

3
tests/helpers/test_trigger.py
View File

@ -33,7 +33,8 @@ async def test_bad_trigger_platform(hass: HomeAssistant) -> None:
async def test_trigger_subtype(hass: HomeAssistant) -> None: async def test_trigger_subtype(hass: HomeAssistant) -> None:
"""Test trigger subtypes.""" """Test trigger subtypes."""
with patch( with patch(
"homeassistant.helpers.trigger.async_get_integration", return_value=MagicMock() "homeassistant.helpers.trigger.async_get_integration",
return_value=MagicMock(async_get_platform=AsyncMock()),
) as integration_mock: ) as integration_mock:
await _async_get_trigger_platform(hass, {"platform": "test.subtype"}) await _async_get_trigger_platform(hass, {"platform": "test.subtype"})
assert integration_mock.call_args == call(hass, "test") assert integration_mock.call_args == call(hass, "test")