Small refactor to cleanup unnecessary returns (#121653)

pull/121665/head
epenet 2024-07-10 09:34:48 +02:00 committed by GitHub
parent 86f7718c1f
commit 30b5297fde
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 10 additions and 16 deletions

View File

@ -140,10 +140,8 @@ class HMThermostat(HMDevice, ClimateEntity):
def set_temperature(self, **kwargs: Any) -> None:
"""Set new target temperature."""
if (temperature := kwargs.get(ATTR_TEMPERATURE)) is None:
return None
self._hmdevice.writeNodeData(self._state, float(temperature))
if (temperature := kwargs.get(ATTR_TEMPERATURE)) is not None:
self._hmdevice.writeNodeData(self._state, float(temperature))
def set_hvac_mode(self, hvac_mode: HVACMode) -> None:
"""Set new target hvac mode."""

View File

@ -227,10 +227,9 @@ class NestEventMediaStore(EventMediaStore):
filename = self.get_media_filename(media_key)
def remove_media(filename: str) -> None:
if not os.path.exists(filename):
return None
_LOGGER.debug("Removing event media from disk store: %s", filename)
os.remove(filename)
if os.path.exists(filename):
_LOGGER.debug("Removing event media from disk store: %s", filename)
os.remove(filename)
try:
await self._hass.async_add_executor_job(remove_media, filename)

View File

@ -142,10 +142,9 @@ class TelnetSwitch(SwitchEntity):
response = self._telnet_command(self._command_state)
if response and self._value_template:
rendered = self._value_template.render_with_possible_json_value(response)
self._attr_is_on = rendered == "True"
else:
_LOGGER.warning("Empty response for command: %s", self._command_state)
return None
self._attr_is_on = rendered == "True"
def turn_on(self, **kwargs: Any) -> None:
"""Turn the device on."""

View File

@ -72,12 +72,10 @@ class TradfriSwitch(TradfriBaseEntity, SwitchEntity):
async def async_turn_off(self, **kwargs: Any) -> None:
"""Instruct the switch to turn off."""
if not self._device_control:
return None
await self._api(self._device_control.set_state(False))
if self._device_control:
await self._api(self._device_control.set_state(False))
async def async_turn_on(self, **kwargs: Any) -> None:
"""Instruct the switch to turn on."""
if not self._device_control:
return None
await self._api(self._device_control.set_state(True))
if self._device_control:
await self._api(self._device_control.set_state(True))