Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use shorthand attributes in SharkIQ (#99836)

pull/99844/head
Joost Lekkerkerker 2023-09-07 16:08:44 +02:00 committed by GitHub
parent 114b5bd1f0
commit 2a3ebbc26c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
homeassistant/components/sharkiq/vacuum.py
View File

@ -88,7 +88,13 @@ class SharkVacuumEntity(CoordinatorEntity[SharkIqUpdateCoordinator], StateVacuum
super().__init__(coordinator) super().__init__(coordinator)
self.sharkiq = sharkiq self.sharkiq = sharkiq
self._attr_unique_id = sharkiq.serial_number self._attr_unique_id = sharkiq.serial_number
self._serial_number = sharkiq.serial_number self._attr_device_info = DeviceInfo(
identifiers={(DOMAIN, sharkiq.serial_number)},
manufacturer=SHARK,
model=self.model,
name=sharkiq.name,
sw_version=sharkiq.get_property_value(Properties.ROBOT_FIRMWARE_VERSION),
)
def clean_spot(self, **kwargs: Any) -> None: def clean_spot(self, **kwargs: Any) -> None:
"""Clean a spot. Not yet implemented.""" """Clean a spot. Not yet implemented."""
@ -106,7 +112,7 @@ class SharkVacuumEntity(CoordinatorEntity[SharkIqUpdateCoordinator], StateVacuum
@property @property
def is_online(self) -> bool: def is_online(self) -> bool:
"""Tell us if the device is online.""" """Tell us if the device is online."""
return self.coordinator.device_is_online(self._serial_number) return self.coordinator.device_is_online(self.sharkiq.serial_number)
@property @property
def model(self) -> str: def model(self) -> str:
@ -115,19 +121,6 @@ class SharkVacuumEntity(CoordinatorEntity[SharkIqUpdateCoordinator], StateVacuum
return self.sharkiq.vac_model_number return self.sharkiq.vac_model_number
return self.sharkiq.oem_model_number return self.sharkiq.oem_model_number
@property
def device_info(self) -> DeviceInfo:
"""Device info dictionary."""
return DeviceInfo(
identifiers={(DOMAIN, self._serial_number)},
manufacturer=SHARK,
model=self.model,
name=self.sharkiq.name,
sw_version=self.sharkiq.get_property_value(
Properties.ROBOT_FIRMWARE_VERSION
),
)
@property @property
def error_code(self) -> int | None: def error_code(self) -> int | None:
"""Return the last observed error code (or None).""" """Return the last observed error code (or None)."""