Add parallel-updates rule to quality_scale validation (#132041)

homeassistant/components/acaia/binary_sensor.py

@@ -16,6 +16,9 @@ from homeassistant.helpers.entity_platform import AddEntitiesCallback
 from .coordinator import AcaiaConfigEntry
 from .entity import AcaiaEntity
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 @dataclass(kw_only=True, frozen=True)
 class AcaiaBinarySensorEntityDescription(BinarySensorEntityDescription):

homeassistant/components/acaia/sensor.py

@@ -21,6 +21,9 @@ from homeassistant.helpers.entity_platform import AddEntitiesCallback
 from .coordinator import AcaiaConfigEntry
 from .entity import AcaiaEntity
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 @dataclass(kw_only=True, frozen=True)
 class AcaiaSensorEntityDescription(SensorEntityDescription):

homeassistant/components/elgato/quality_scale.yaml

@@ -33,7 +33,10 @@ rules:
   entity-unavailable: done
   integration-owner: done
   log-when-unavailable: done
-  parallel-updates: done
+  parallel-updates:
+    status: todo
+    comment: |
+      Does not set parallel-updates on button/switch action calls.
   reauthentication-flow:
     status: exempt
     comment: |

homeassistant/components/elgato/sensor.py

@@ -25,6 +25,9 @@ from . import ElgatorConfigEntry
 from .coordinator import ElgatoData, ElgatoDataUpdateCoordinator
 from .entity import ElgatoEntity
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 @dataclass(frozen=True, kw_only=True)
 class ElgatoSensorEntityDescription(SensorEntityDescription):

homeassistant/components/husqvarna_automower/binary_sensor.py

@@ -30,6 +30,8 @@ from .coordinator import AutomowerDataUpdateCoordinator
 from .entity import AutomowerBaseEntity
 
 _LOGGER = logging.getLogger(__name__)
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
 
 
 def entity_used_in(hass: HomeAssistant, entity_id: str) -> list[str]:

homeassistant/components/husqvarna_automower/calendar.py

@@ -15,6 +15,8 @@ from .coordinator import AutomowerDataUpdateCoordinator
 from .entity import AutomowerBaseEntity
 
 _LOGGER = logging.getLogger(__name__)
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
 
 
 async def async_setup_entry(

homeassistant/components/husqvarna_automower/device_tracker.py

@@ -8,6 +8,9 @@ from . import AutomowerConfigEntry
 from .coordinator import AutomowerDataUpdateCoordinator
 from .entity import AutomowerBaseEntity
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 async def async_setup_entry(
     hass: HomeAssistant,

homeassistant/components/husqvarna_automower/sensor.py

@@ -35,6 +35,8 @@ from .entity import (
 )
 
 _LOGGER = logging.getLogger(__name__)
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
 
 ATTR_WORK_AREA_ID_ASSIGNMENT = "work_area_id_assignment"
 

homeassistant/components/imap/sensor.py

@@ -17,6 +17,9 @@ from . import ImapConfigEntry
 from .const import DOMAIN
 from .coordinator import ImapDataUpdateCoordinator
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 IMAP_MAIL_COUNT_DESCRIPTION = SensorEntityDescription(
     key="imap_mail_count",
     entity_category=EntityCategory.DIAGNOSTIC,

homeassistant/components/iron_os/sensor.py

@@ -30,6 +30,9 @@ from . import IronOSConfigEntry
 from .const import OHM
 from .entity import IronOSBaseEntity
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 class PinecilSensor(StrEnum):
     """Pinecil Sensors."""

homeassistant/components/ista_ecotrend/sensor.py

@@ -40,6 +40,8 @@ from .coordinator import IstaCoordinator
 from .util import IstaConsumptionType, IstaValueType, get_native_value, get_statistics
 
 _LOGGER = logging.getLogger(__name__)
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
 
 
 @dataclass(kw_only=True, frozen=True)

homeassistant/components/lamarzocco/binary_sensor.py

@@ -17,6 +17,9 @@ from homeassistant.helpers.entity_platform import AddEntitiesCallback
 from .coordinator import LaMarzoccoConfigEntry
 from .entity import LaMarzoccoEntity, LaMarzoccoEntityDescription
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 @dataclass(frozen=True, kw_only=True)
 class LaMarzoccoBinarySensorEntityDescription(

homeassistant/components/lamarzocco/calendar.py

@@ -13,6 +13,9 @@ from homeassistant.util import dt as dt_util
 from .coordinator import LaMarzoccoConfigEntry, LaMarzoccoUpdateCoordinator
 from .entity import LaMarzoccoBaseEntity
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 CALENDAR_KEY = "auto_on_off_schedule"
 
 DAY_OF_WEEK = [

homeassistant/components/lamarzocco/sensor.py

@@ -19,6 +19,9 @@ from homeassistant.helpers.entity_platform import AddEntitiesCallback
 from .coordinator import LaMarzoccoConfigEntry
 from .entity import LaMarzoccoEntity, LaMarzoccoEntityDescription
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 @dataclass(frozen=True, kw_only=True)
 class LaMarzoccoSensorEntityDescription(

homeassistant/components/mastodon/quality_scale.yaml

@@ -39,7 +39,10 @@ rules:
   entity-unavailable: done
   integration-owner: done
   log-when-unavailable: done
-  parallel-updates: done
+  parallel-updates:
+    status: todo
+    comment: |
+      Does not set parallel-updates on notify platform.
   reauthentication-flow:
     status: todo
     comment: |

homeassistant/components/mastodon/sensor.py

@@ -23,6 +23,9 @@ from .const import (
 )
 from .entity import MastodonEntity
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 @dataclass(frozen=True, kw_only=True)
 class MastodonSensorEntityDescription(SensorEntityDescription):

homeassistant/components/tedee/binary_sensor.py

@@ -18,6 +18,9 @@ from homeassistant.helpers.entity_platform import AddEntitiesCallback
 from .coordinator import TedeeConfigEntry
 from .entity import TedeeDescriptionEntity
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 @dataclass(frozen=True, kw_only=True)
 class TedeeBinarySensorEntityDescription(

homeassistant/components/tedee/sensor.py

@@ -18,6 +18,9 @@ from homeassistant.helpers.entity_platform import AddEntitiesCallback
 from .coordinator import TedeeConfigEntry
 from .entity import TedeeDescriptionEntity
 
+# Coordinator is used to centralize the data updates
+PARALLEL_UPDATES = 0
+
 
 @dataclass(frozen=True, kw_only=True)
 class TedeeSensorEntityDescription(SensorEntityDescription):

script/hassfest/quality_scale.py

@@ -18,6 +18,7 @@ from .quality_scale_validation import (
     config_flow,
     diagnostics,
     discovery,
+    parallel_updates,
     reauthentication_flow,
     reconfiguration_flow,
     runtime_data,
@@ -67,7 +68,7 @@ ALL_RULES = [
     Rule("entity-unavailable", ScaledQualityScaleTiers.SILVER),
     Rule("integration-owner", ScaledQualityScaleTiers.SILVER),
     Rule("log-when-unavailable", ScaledQualityScaleTiers.SILVER),
-    Rule("parallel-updates", ScaledQualityScaleTiers.SILVER),
+    Rule("parallel-updates", ScaledQualityScaleTiers.SILVER, parallel_updates),
     Rule(
         "reauthentication-flow", ScaledQualityScaleTiers.SILVER, reauthentication_flow
     ),

script/hassfest/quality_scale_validation/parallel_updates.py

@@ -0,0 +1,35 @@
+"""Enforce that the integration sets PARALLEL_UPDATES constant.
+
+https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/parallel-updates
+"""
+
+import ast
+
+from homeassistant.const import Platform
+from script.hassfest.model import Integration
+
+
+def _has_parallel_updates_defined(module: ast.Module) -> bool:
+    """Test if the module defines `PARALLEL_UPDATES` constant."""
+    return any(
+        type(item) is ast.Assign and item.targets[0].id == "PARALLEL_UPDATES"
+        for item in module.body
+    )
+
+
+def validate(integration: Integration) -> list[str] | None:
+    """Validate that the integration sets PARALLEL_UPDATES constant."""
+
+    errors = []
+    for platform in Platform:
+        module_file = integration.path / f"{platform}.py"
+        if not module_file.exists():
+            continue
+        module = ast.parse(module_file.read_text())
+
+        if not _has_parallel_updates_defined(module):
+            errors.append(
+                f"Integration does not set `PARALLEL_UPDATES` in {module_file}"
+            )
+
+    return errors