Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix verisure deadlock (#48691)

pull/48699/head
Paulus Schoutsen 2021-04-05 03:22:25 -07:00 committed by GitHub
parent 0544d94bd0
commit 0f757c3db2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
homeassistant/components/verisure/camera.py
View File

@ -36,7 +36,7 @@ async def async_setup_entry(
assert hass.config.config_dir assert hass.config.config_dir
async_add_entities( async_add_entities(
VerisureSmartcam(hass, coordinator, serial_number, hass.config.config_dir) VerisureSmartcam(coordinator, serial_number, hass.config.config_dir)
for serial_number in coordinator.data["cameras"] for serial_number in coordinator.data["cameras"]
) )
@ -48,7 +48,6 @@ class VerisureSmartcam(CoordinatorEntity, Camera):
def __init__( def __init__(
self, self,
hass: HomeAssistant,
coordinator: VerisureDataUpdateCoordinator, coordinator: VerisureDataUpdateCoordinator,
serial_number: str, serial_number: str,
directory_path: str, directory_path: str,
@ -60,7 +59,6 @@ class VerisureSmartcam(CoordinatorEntity, Camera):
self._directory_path = directory_path self._directory_path = directory_path
self._image = None self._image = None
self._image_id = None self._image_id = None
hass.bus.listen_once(EVENT_HOMEASSISTANT_STOP, self.delete_image)
@property @property
def name(self) -> str: def name(self) -> str:
@ -126,7 +124,7 @@ class VerisureSmartcam(CoordinatorEntity, Camera):
self._image_id = new_image_id self._image_id = new_image_id
self._image = new_image_path self._image = new_image_path
def delete_image(self) -> None: def delete_image(self, _=None) -> None:
"""Delete an old image.""" """Delete an old image."""
remove_image = os.path.join( remove_image = os.path.join(
self._directory_path, "{}{}".format(self._image_id, ".jpg") self._directory_path, "{}{}".format(self._image_id, ".jpg")
@ -145,3 +143,8 @@ class VerisureSmartcam(CoordinatorEntity, Camera):
LOGGER.debug("Capturing new image from %s", self.serial_number) LOGGER.debug("Capturing new image from %s", self.serial_number)
except VerisureError as ex: except VerisureError as ex:
LOGGER.error("Could not capture image, %s", ex) LOGGER.error("Could not capture image, %s", ex)
async def async_added_to_hass(self) -> None:
"""Entity added to Home Assistant."""
await super().async_added_to_hass()
self.hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP, self.delete_image)