Home-Assistant
/
core
mirror of https://github.com/home-assistant/core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove battery charge sensor from powerwall (#109271)

pull/109329/head
Josh Pettersen 2024-02-01 12:01:05 -08:00 committed by GitHub
parent c2c98bd04c
commit 0cc8b2edf9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
homeassistant/components/powerwall/sensor.py
View File

@ -113,12 +113,6 @@ POWERWALL_INSTANT_SENSORS = (
) )
def _get_battery_charge(battery_data: BatteryResponse) -> float:
"""Get the current value in %."""
ratio = float(battery_data.energy_remaining) / float(battery_data.capacity)
return round(100 * ratio, 1)
BATTERY_INSTANT_SENSORS: list[PowerwallSensorEntityDescription] = [ BATTERY_INSTANT_SENSORS: list[PowerwallSensorEntityDescription] = [
PowerwallSensorEntityDescription[BatteryResponse, int]( PowerwallSensorEntityDescription[BatteryResponse, int](
key="battery_capacity", key="battery_capacity",
@ -202,16 +196,6 @@ BATTERY_INSTANT_SENSORS: list[PowerwallSensorEntityDescription] = [
suggested_display_precision=1, suggested_display_precision=1,
value_fn=lambda battery_data: battery_data.energy_remaining, value_fn=lambda battery_data: battery_data.energy_remaining,
), ),
PowerwallSensorEntityDescription[BatteryResponse, float](
key="charge",
translation_key="charge",
entity_category=EntityCategory.DIAGNOSTIC,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.BATTERY,
native_unit_of_measurement=PERCENTAGE,
suggested_display_precision=0,
value_fn=_get_battery_charge,
),
PowerwallSensorEntityDescription[BatteryResponse, str]( PowerwallSensorEntityDescription[BatteryResponse, str](
key="grid_state", key="grid_state",
translation_key="grid_state", translation_key="grid_state",

2
tests/components/powerwall/test_sensor.py
View File

@ -157,7 +157,6 @@ async def test_sensors(
float(hass.states.get("sensor.mysite_tg0123456789ab_battery_remaining").state) float(hass.states.get("sensor.mysite_tg0123456789ab_battery_remaining").state)
== 14.715 == 14.715
) )
assert float(hass.states.get("sensor.mysite_tg0123456789ab_charge").state) == 100.0
assert ( assert (
str(hass.states.get("sensor.mysite_tg0123456789ab_grid_state").state) str(hass.states.get("sensor.mysite_tg0123456789ab_grid_state").state)
== "grid_compliant" == "grid_compliant"
@ -187,7 +186,6 @@ async def test_sensors(
float(hass.states.get("sensor.mysite_tg9876543210ba_battery_remaining").state) float(hass.states.get("sensor.mysite_tg9876543210ba_battery_remaining").state)
== 15.137 == 15.137
) )
assert float(hass.states.get("sensor.mysite_tg9876543210ba_charge").state) == 100.0
assert ( assert (
str(hass.states.get("sensor.mysite_tg9876543210ba_grid_state").state) str(hass.states.get("sensor.mysite_tg9876543210ba_grid_state").state)
== "grid_compliant" == "grid_compliant"