From 04c0bca487550d91ea8d8b8430d5a1c3b4b9ee90 Mon Sep 17 00:00:00 2001 From: Guido Schmitz Date: Mon, 23 Oct 2023 14:00:47 +0200 Subject: [PATCH] Remove name from device info in devolo Home Network (#102585) --- .../components/devolo_home_network/entity.py | 1 - .../snapshots/test_init.ambr | 29 +++++++++++++++++++ .../devolo_home_network/test_init.py | 24 ++++++++++----- 3 files changed, 45 insertions(+), 9 deletions(-) create mode 100644 tests/components/devolo_home_network/snapshots/test_init.ambr diff --git a/homeassistant/components/devolo_home_network/entity.py b/homeassistant/components/devolo_home_network/entity.py index ff0b2ba2c48..53c502dc811 100644 --- a/homeassistant/components/devolo_home_network/entity.py +++ b/homeassistant/components/devolo_home_network/entity.py @@ -52,7 +52,6 @@ class DevoloEntity(Entity): identifiers={(DOMAIN, str(device.serial_number))}, manufacturer="devolo", model=device.product, - name=entry.title, serial_number=device.serial_number, sw_version=device.firmware_version, ) diff --git a/tests/components/devolo_home_network/snapshots/test_init.ambr b/tests/components/devolo_home_network/snapshots/test_init.ambr new file mode 100644 index 00000000000..f2c27183945 --- /dev/null +++ b/tests/components/devolo_home_network/snapshots/test_init.ambr @@ -0,0 +1,29 @@ +# serializer version: 1 +# name: test_setup_entry + DeviceRegistryEntrySnapshot({ + 'area_id': None, + 'config_entries': , + 'configuration_url': 'http://192.0.2.1', + 'connections': set({ + }), + 'disabled_by': None, + 'entry_type': None, + 'hw_version': None, + 'id': , + 'identifiers': set({ + tuple( + 'devolo_home_network', + '1234567890', + ), + }), + 'is_new': False, + 'manufacturer': 'devolo', + 'model': 'dLAN pro 1200+ WiFi ac', + 'name': 'Mock Title', + 'name_by_user': None, + 'serial_number': '1234567890', + 'suggested_area': None, + 'sw_version': '5.6.1', + 'via_device_id': None, + }) +# --- diff --git a/tests/components/devolo_home_network/test_init.py b/tests/components/devolo_home_network/test_init.py index 3c207a1aaef..e34af0dcbaf 100644 --- a/tests/components/devolo_home_network/test_init.py +++ b/tests/components/devolo_home_network/test_init.py @@ -3,6 +3,7 @@ from unittest.mock import patch from devolo_plc_api.exceptions.device import DeviceNotFound import pytest +from syrupy.assertion import SnapshotAssertion from homeassistant.components.binary_sensor import DOMAIN as BINARY_SENSOR from homeassistant.components.button import DOMAIN as BUTTON @@ -15,6 +16,7 @@ from homeassistant.components.update import DOMAIN as UPDATE from homeassistant.config_entries import ConfigEntryState from homeassistant.const import CONF_IP_ADDRESS, EVENT_HOMEASSISTANT_STOP from homeassistant.core import HomeAssistant +from homeassistant.helpers import device_registry as dr from homeassistant.helpers.entity_platform import async_get_platforms from . import configure_integration @@ -24,16 +26,22 @@ from .mock import MockDevice from tests.common import MockConfigEntry -@pytest.mark.usefixtures("mock_device") -async def test_setup_entry(hass: HomeAssistant) -> None: +async def test_setup_entry( + hass: HomeAssistant, + mock_device: MockDevice, + device_registry: dr.DeviceRegistry, + snapshot: SnapshotAssertion, +) -> None: """Test setup entry.""" entry = configure_integration(hass) - with patch( - "homeassistant.config_entries.ConfigEntries.async_forward_entry_setup", - return_value=True, - ), patch("homeassistant.core.EventBus.async_listen_once"): - assert await hass.config_entries.async_setup(entry.entry_id) - assert entry.state is ConfigEntryState.LOADED + assert await hass.config_entries.async_setup(entry.entry_id) + await hass.async_block_till_done() + assert entry.state is ConfigEntryState.LOADED + + device_info = device_registry.async_get_device( + {(DOMAIN, mock_device.serial_number)} + ) + assert device_info == snapshot @pytest.mark.usefixtures("mock_device")