core/tests/components/onvif/test_config_flow.py

952 lines
35 KiB
Python
Raw Normal View History

2020-05-01 06:15:40 +00:00
"""Test ONVIF config flow."""
import logging
from unittest.mock import MagicMock, patch
2021-01-01 21:31:56 +00:00
import pytest
2020-05-01 06:15:40 +00:00
from homeassistant import config_entries, data_entry_flow
from homeassistant.components import dhcp
from homeassistant.components.onvif import DOMAIN, config_flow
from homeassistant.config_entries import SOURCE_DHCP
from homeassistant.const import CONF_HOST, CONF_USERNAME
from homeassistant.core import HomeAssistant
from homeassistant.data_entry_flow import FlowResultType
from homeassistant.helpers import device_registry as dr
2020-05-01 06:15:40 +00:00
from . import (
HOST,
MAC,
NAME,
PASSWORD,
PORT,
URN,
USERNAME,
setup_mock_device,
setup_mock_onvif_camera,
setup_onvif_integration,
)
2020-05-01 06:15:40 +00:00
DISCOVERY = [
{
"EPR": URN,
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
"MAC": MAC,
"HARDWARE": "IPC model",
2020-05-01 06:15:40 +00:00
},
{
"EPR": "urn:uuid:987654321",
config_flow.CONF_NAME: "TestCamera2",
config_flow.CONF_HOST: "5.6.7.8",
config_flow.CONF_PORT: PORT,
"MAC": "ff:ee:dd:cc:bb:aa",
2020-05-01 06:15:40 +00:00
},
]
DHCP_DISCOVERY = dhcp.DhcpServiceInfo(
hostname="any", ip="5.6.7.8", macaddress=MAC.lower().replace(":", "")
)
DHCP_DISCOVERY_SAME_IP = dhcp.DhcpServiceInfo(
hostname="any", ip="1.2.3.4", macaddress=MAC.lower().replace(":", "")
)
2020-05-01 06:15:40 +00:00
def setup_mock_discovery(
mock_discovery,
with_name=False,
with_mac=False,
two_devices=False,
with_hardware=True,
no_devices=False,
2020-05-01 06:15:40 +00:00
):
"""Prepare mock discovery result."""
services = []
for item in DISCOVERY:
if no_devices:
continue
2020-05-01 06:15:40 +00:00
service = MagicMock()
service.getXAddrs = MagicMock(
return_value=[
f"http://{item[config_flow.CONF_HOST]}:{item[config_flow.CONF_PORT]}/onvif/device_service"
]
)
service.getEPR = MagicMock(return_value=item["EPR"])
scopes = []
if with_name:
scope = MagicMock()
scope.getValue = MagicMock(
return_value=f"onvif://www.onvif.org/name/{item[config_flow.CONF_NAME]}"
)
scopes.append(scope)
if with_mac:
scope = MagicMock()
scope.getValue = MagicMock(
return_value=f"onvif://www.onvif.org/mac/{item['MAC']}"
)
scopes.append(scope)
if with_hardware and "HARDWARE" in item:
scope = MagicMock()
scope.getValue = MagicMock(
return_value=f"onvif://www.onvif.org/hardware/{item['HARDWARE']}"
)
scopes.append(scope)
2020-05-01 06:15:40 +00:00
service.getScopes = MagicMock(return_value=scopes)
services.append(service)
mock_ws_discovery = MagicMock()
mock_ws_discovery.searchServices = MagicMock(return_value=services)
mock_discovery.return_value = mock_ws_discovery
2020-05-01 06:15:40 +00:00
async def test_flow_discovered_devices(hass: HomeAssistant) -> None:
2020-05-01 06:15:40 +00:00
"""Test that config flow works for discovered devices."""
logging.getLogger("homeassistant.components.onvif").setLevel(logging.DEBUG)
2020-05-01 06:15:40 +00:00
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
2020-05-01 06:15:40 +00:00
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
2020-05-01 06:15:40 +00:00
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
2020-05-06 16:29:59 +00:00
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
2020-05-01 06:15:40 +00:00
) as mock_discovery, patch(
2020-05-06 16:29:59 +00:00
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(mock_onvif_camera)
2020-05-01 06:15:40 +00:00
setup_mock_discovery(mock_discovery)
2020-05-06 16:29:59 +00:00
setup_mock_device(mock_device)
2020-05-01 06:15:40 +00:00
result = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={"auto": True}
2020-05-01 06:15:40 +00:00
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
2020-05-01 06:15:40 +00:00
assert result["step_id"] == "device"
container = result["data_schema"].schema[config_flow.CONF_HOST].container
assert len(container) == 3
assert container == {
"Manually configure ONVIF device": "Manually configure ONVIF device",
"1.2.3.4": "urn:uuid:123456789 (1.2.3.4) [IPC model]",
"5.6.7.8": "urn:uuid:987654321 (5.6.7.8)",
}
2020-05-01 06:15:40 +00:00
result = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={config_flow.CONF_HOST: HOST}
2020-05-01 06:15:40 +00:00
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
2020-05-01 06:15:40 +00:00
2020-10-15 07:19:08 +00:00
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
2020-05-01 06:15:40 +00:00
2020-10-15 07:19:08 +00:00
await hass.async_block_till_done()
assert len(mock_setup_entry.mock_calls) == 1
2020-05-01 06:15:40 +00:00
assert result["type"] == data_entry_flow.FlowResultType.CREATE_ENTRY
2020-05-01 06:15:40 +00:00
assert result["title"] == f"{URN} - {MAC}"
assert result["data"] == {
config_flow.CONF_NAME: URN,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
}
async def test_flow_discovered_devices_ignore_configured_manual_input(
hass: HomeAssistant,
) -> None:
2020-05-01 06:15:40 +00:00
"""Test that config flow discovery ignores configured devices."""
logging.getLogger("homeassistant.components.onvif").setLevel(logging.DEBUG)
2020-05-01 06:15:40 +00:00
await setup_onvif_integration(hass)
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
2020-05-01 06:15:40 +00:00
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
2020-05-01 06:15:40 +00:00
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
2020-05-06 16:29:59 +00:00
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
2020-05-01 06:15:40 +00:00
) as mock_discovery, patch(
2020-05-06 16:29:59 +00:00
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(mock_onvif_camera)
2020-05-01 06:15:40 +00:00
setup_mock_discovery(mock_discovery, with_mac=True)
2020-05-06 16:29:59 +00:00
setup_mock_device(mock_device)
2020-05-01 06:15:40 +00:00
result = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={"auto": True}
2020-05-01 06:15:40 +00:00
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
2020-05-01 06:15:40 +00:00
assert result["step_id"] == "device"
assert len(result["data_schema"].schema[config_flow.CONF_HOST].container) == 2
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={config_flow.CONF_HOST: config_flow.CONF_MANUAL_INPUT},
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
async def test_flow_discovered_no_device(hass: HomeAssistant) -> None:
"""Test that config flow discovery no device."""
await setup_onvif_integration(hass)
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
) as mock_discovery, patch(
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(mock_onvif_camera)
setup_mock_discovery(mock_discovery, no_devices=True)
setup_mock_device(mock_device)
result = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={"auto": True}
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
2020-05-01 06:15:40 +00:00
async def test_flow_discovery_ignore_existing_and_abort(hass: HomeAssistant) -> None:
2020-05-01 06:15:40 +00:00
"""Test that config flow discovery ignores setup devices."""
logging.getLogger("homeassistant.components.onvif").setLevel(logging.DEBUG)
2020-05-01 06:15:40 +00:00
await setup_onvif_integration(hass)
await setup_onvif_integration(
hass,
config={
config_flow.CONF_NAME: DISCOVERY[1]["EPR"],
config_flow.CONF_HOST: DISCOVERY[1][config_flow.CONF_HOST],
config_flow.CONF_PORT: DISCOVERY[1][config_flow.CONF_PORT],
config_flow.CONF_USERNAME: "",
config_flow.CONF_PASSWORD: "",
},
unique_id=DISCOVERY[1]["MAC"],
entry_id="2",
)
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
2020-05-01 06:15:40 +00:00
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
2020-05-01 06:15:40 +00:00
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
2020-05-06 16:29:59 +00:00
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
2020-05-01 06:15:40 +00:00
) as mock_discovery, patch(
2020-05-06 16:29:59 +00:00
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(mock_onvif_camera)
2020-05-01 06:15:40 +00:00
setup_mock_discovery(mock_discovery, with_name=True, with_mac=True)
2020-05-06 16:29:59 +00:00
setup_mock_device(mock_device)
2020-05-01 06:15:40 +00:00
result = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={"auto": True}
2020-05-01 06:15:40 +00:00
)
# It should skip to manual entry if the only devices are already configured
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
2020-05-01 06:15:40 +00:00
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
# It should abort if already configured and entered manually
assert result["type"] == data_entry_flow.FlowResultType.ABORT
2020-05-01 06:15:40 +00:00
async def test_flow_manual_entry(hass: HomeAssistant) -> None:
2020-05-01 06:15:40 +00:00
"""Test that config flow works for discovered devices."""
logging.getLogger("homeassistant.components.onvif").setLevel(logging.DEBUG)
2020-05-01 06:15:40 +00:00
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
2020-05-01 06:15:40 +00:00
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
2020-05-01 06:15:40 +00:00
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
2020-05-06 16:29:59 +00:00
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
2020-05-01 06:15:40 +00:00
) as mock_discovery, patch(
2020-05-06 16:29:59 +00:00
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(mock_onvif_camera, two_profiles=True)
2020-05-01 06:15:40 +00:00
# no discovery
mock_discovery.return_value = []
2020-05-06 16:29:59 +00:00
setup_mock_device(mock_device)
2020-05-01 06:15:40 +00:00
result = await hass.config_entries.flow.async_configure(
2020-08-27 11:56:20 +00:00
result["flow_id"],
user_input={"auto": False},
2020-05-01 06:15:40 +00:00
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
2020-05-01 06:15:40 +00:00
2020-10-15 07:19:08 +00:00
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
2020-10-15 07:19:08 +00:00
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
2020-05-01 06:15:40 +00:00
2020-10-15 07:19:08 +00:00
await hass.async_block_till_done()
assert len(mock_setup_entry.mock_calls) == 1
2020-05-01 06:15:40 +00:00
assert result["type"] == data_entry_flow.FlowResultType.CREATE_ENTRY
2020-05-01 06:15:40 +00:00
assert result["title"] == f"{NAME} - {MAC}"
assert result["data"] == {
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
}
async def test_flow_manual_entry_no_profiles(hass: HomeAssistant) -> None:
"""Test that config flow when no profiles are returned."""
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
) as mock_discovery, patch(
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(mock_onvif_camera, no_profiles=True)
# no discovery
mock_discovery.return_value = []
setup_mock_device(mock_device)
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={"auto": False},
)
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
assert result["type"] == data_entry_flow.FlowResultType.ABORT
assert result["reason"] == "no_h264"
async def test_flow_manual_entry_no_mac(hass: HomeAssistant) -> None:
"""Test that config flow when no mac address is returned."""
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
) as mock_discovery, patch(
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(
mock_onvif_camera, with_serial=False, with_interfaces=False
)
# no discovery
mock_discovery.return_value = []
setup_mock_device(mock_device)
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={"auto": False},
)
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
assert result["type"] == data_entry_flow.FlowResultType.ABORT
assert result["reason"] == "no_mac"
async def test_flow_manual_entry_fails(hass: HomeAssistant) -> None:
"""Test that we get a good error when manual entry fails."""
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
) as mock_discovery, patch(
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(
mock_onvif_camera, two_profiles=True, profiles_transient_failure=True
)
# no discovery
mock_discovery.return_value = []
setup_mock_device(mock_device)
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={"auto": False},
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
await hass.async_block_till_done()
assert len(mock_setup_entry.mock_calls) == 0
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
assert result["errors"] == {"base": "onvif_error"}
assert result["description_placeholders"] == {"error": "camera not ready"}
setup_mock_onvif_camera(
mock_onvif_camera, two_profiles=True, update_xaddrs_fail=True
)
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
await hass.async_block_till_done()
assert len(mock_setup_entry.mock_calls) == 0
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
assert result["errors"] == {"base": "onvif_error"}
assert result["description_placeholders"] == {
"error": "Unknown error: camera not ready"
}
setup_mock_onvif_camera(mock_onvif_camera, two_profiles=True)
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
await hass.async_block_till_done()
assert len(mock_setup_entry.mock_calls) == 1
assert result["title"] == f"{NAME} - {MAC}"
assert result["data"] == {
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
}
async def test_flow_manual_entry_wrong_password(hass: HomeAssistant) -> None:
"""Test that we get a an auth error with the wrong password."""
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
) as mock_discovery, patch(
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(mock_onvif_camera, two_profiles=True, auth_fail=True)
# no discovery
mock_discovery.return_value = []
setup_mock_device(mock_device)
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={"auto": False},
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
await hass.async_block_till_done()
assert len(mock_setup_entry.mock_calls) == 0
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
assert result["errors"] == {"password": "auth_failed"}
assert result["description_placeholders"] == {"error": "Authority failure"}
setup_mock_onvif_camera(mock_onvif_camera, two_profiles=True)
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
await hass.async_block_till_done()
assert len(mock_setup_entry.mock_calls) == 1
assert result["title"] == f"{NAME} - {MAC}"
assert result["data"] == {
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
}
@pytest.mark.parametrize("option_value", [True, False])
async def test_option_flow(hass: HomeAssistant, option_value: bool) -> None:
2020-05-01 06:15:40 +00:00
"""Test config flow options."""
entry, _, _ = await setup_onvif_integration(hass)
2020-05-01 06:15:40 +00:00
result = await hass.config_entries.options.async_init(
entry.entry_id, context={"show_advanced_options": True}
)
2020-05-01 06:15:40 +00:00
assert result["type"] == data_entry_flow.FlowResultType.FORM
2020-05-01 06:15:40 +00:00
assert result["step_id"] == "onvif_devices"
result = await hass.config_entries.options.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_EXTRA_ARGUMENTS: "",
config_flow.CONF_RTSP_TRANSPORT: list(config_flow.RTSP_TRANSPORTS)[1],
config_flow.CONF_USE_WALLCLOCK_AS_TIMESTAMPS: option_value,
config_flow.CONF_ENABLE_WEBHOOKS: option_value,
2020-05-01 06:15:40 +00:00
},
)
assert result["type"] == data_entry_flow.FlowResultType.CREATE_ENTRY
2020-05-01 06:15:40 +00:00
assert result["data"] == {
config_flow.CONF_EXTRA_ARGUMENTS: "",
config_flow.CONF_RTSP_TRANSPORT: list(config_flow.RTSP_TRANSPORTS)[1],
config_flow.CONF_USE_WALLCLOCK_AS_TIMESTAMPS: option_value,
config_flow.CONF_ENABLE_WEBHOOKS: option_value,
2020-05-01 06:15:40 +00:00
}
async def test_discovered_by_dhcp_updates_host(hass: HomeAssistant) -> None:
"""Test dhcp updates existing host."""
config_entry, _camera, device = await setup_onvif_integration(hass)
device.profiles = device.async_get_profiles()
registry = dr.async_get(hass)
devices = dr.async_entries_for_config_entry(registry, config_entry.entry_id)
assert len(devices) == 1
device = devices[0]
assert device.model == "TestModel"
assert device.connections == {(dr.CONNECTION_NETWORK_MAC, MAC)}
assert config_entry.data[CONF_HOST] == "1.2.3.4"
await hass.config_entries.async_unload(config_entry.entry_id)
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_DHCP}, data=DHCP_DISCOVERY
)
await hass.async_block_till_done()
assert result["type"] == FlowResultType.ABORT
assert result["reason"] == "already_configured"
assert config_entry.data[CONF_HOST] == DHCP_DISCOVERY.ip
async def test_discovered_by_dhcp_does_nothing_if_host_is_the_same(
hass: HomeAssistant,
) -> None:
"""Test dhcp update does nothing if host is the same."""
config_entry, _camera, device = await setup_onvif_integration(hass)
device.profiles = device.async_get_profiles()
registry = dr.async_get(hass)
devices = dr.async_entries_for_config_entry(registry, config_entry.entry_id)
assert len(devices) == 1
device = devices[0]
assert device.model == "TestModel"
assert device.connections == {(dr.CONNECTION_NETWORK_MAC, MAC)}
assert config_entry.data[CONF_HOST] == DHCP_DISCOVERY_SAME_IP.ip
await hass.config_entries.async_unload(config_entry.entry_id)
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_DHCP}, data=DHCP_DISCOVERY_SAME_IP
)
await hass.async_block_till_done()
assert result["type"] == FlowResultType.ABORT
assert result["reason"] == "already_configured"
assert config_entry.data[CONF_HOST] == DHCP_DISCOVERY_SAME_IP.ip
async def test_discovered_by_dhcp_does_not_update_if_already_loaded(
hass: HomeAssistant,
) -> None:
"""Test dhcp does not update existing host if its already loaded."""
config_entry, _camera, device = await setup_onvif_integration(hass)
device.profiles = device.async_get_profiles()
registry = dr.async_get(hass)
devices = dr.async_entries_for_config_entry(registry, config_entry.entry_id)
assert len(devices) == 1
device = devices[0]
assert device.model == "TestModel"
assert device.connections == {(dr.CONNECTION_NETWORK_MAC, MAC)}
assert config_entry.data[CONF_HOST] == "1.2.3.4"
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_DHCP}, data=DHCP_DISCOVERY
)
await hass.async_block_till_done()
assert result["type"] == FlowResultType.ABORT
assert result["reason"] == "already_configured"
assert config_entry.data[CONF_HOST] != DHCP_DISCOVERY.ip
async def test_discovered_by_dhcp_does_not_update_if_no_matching_entry(
hass: HomeAssistant,
) -> None:
"""Test dhcp does not update existing host if there are no matching entries."""
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_DHCP}, data=DHCP_DISCOVERY
)
await hass.async_block_till_done()
assert result["type"] == FlowResultType.ABORT
assert result["reason"] == "no_devices_found"
def _get_schema_default(schema, key_name):
"""Iterate schema to find a key."""
for schema_key in schema:
if schema_key == key_name:
return schema_key.default()
raise KeyError(f"{key_name} not found in schema")
async def test_form_reauth(hass: HomeAssistant) -> None:
"""Test reauthenticate."""
entry, _, _ = await setup_onvif_integration(hass)
result = await hass.config_entries.flow.async_init(
DOMAIN,
context={"source": config_entries.SOURCE_REAUTH, "entry_id": entry.entry_id},
data=entry.data,
)
assert result["type"] == FlowResultType.FORM
assert result["step_id"] == "reauth_confirm"
assert (
_get_schema_default(result["data_schema"].schema, CONF_USERNAME)
== entry.data[CONF_USERNAME]
)
with patch(
"homeassistant.components.onvif.config_flow.get_device"
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device, patch(
"homeassistant.components.onvif.async_setup_entry",
return_value=True,
) as mock_setup_entry:
setup_mock_onvif_camera(mock_onvif_camera, auth_failure=True)
setup_mock_device(mock_device)
result2 = await hass.config_entries.flow.async_configure(
result["flow_id"],
{
config_flow.CONF_USERNAME: "new-test-username",
config_flow.CONF_PASSWORD: "new-test-password",
},
)
await hass.async_block_till_done()
assert result2["type"] == FlowResultType.FORM
assert result2["step_id"] == "reauth_confirm"
assert result2["errors"] == {config_flow.CONF_PASSWORD: "auth_failed"}
assert result2["description_placeholders"] == {
"error": "not authorized (subcodes:NotAuthorized)"
}
with patch(
"homeassistant.components.onvif.config_flow.get_device"
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device, patch(
"homeassistant.components.onvif.async_setup_entry",
return_value=True,
) as mock_setup_entry:
setup_mock_onvif_camera(mock_onvif_camera)
setup_mock_device(mock_device)
result3 = await hass.config_entries.flow.async_configure(
result2["flow_id"],
{
config_flow.CONF_USERNAME: "new-test-username",
config_flow.CONF_PASSWORD: "new-test-password",
},
)
await hass.async_block_till_done()
assert result3["type"] == FlowResultType.ABORT
assert result3["reason"] == "reauth_successful"
assert len(mock_setup_entry.mock_calls) == 1
assert entry.data[config_flow.CONF_USERNAME] == "new-test-username"
assert entry.data[config_flow.CONF_PASSWORD] == "new-test-password"
async def test_flow_manual_entry_updates_existing_user_password(
hass: HomeAssistant,
) -> None:
"""Test that the existing username and password can be updated via manual entry."""
entry, _, _ = await setup_onvif_integration(hass)
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
) as mock_discovery, patch(
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(mock_onvif_camera, two_profiles=True)
# no discovery
mock_discovery.return_value = []
setup_mock_device(mock_device)
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={"auto": False},
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: "new_password",
},
)
await hass.async_block_till_done()
assert result["type"] == data_entry_flow.FlowResultType.ABORT
assert result["reason"] == "already_configured"
assert entry.data[config_flow.CONF_USERNAME] == USERNAME
assert entry.data[config_flow.CONF_PASSWORD] == "new_password"
assert len(mock_setup_entry.mock_calls) == 1
Handle AttributeError from wrong port in ONVIF config flow (#92272) * Handle AttributeError from wrong port in ONVIF config flow fixes ``` 2023-04-29 19:17:22.289 ERROR (MainThread) [aiohttp.server] Error handling request Traceback (most recent call last): File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request resp = await request_handler(request) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle resp = await handler(request) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/ban.py", line 80, in ban_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/auth.py", line 235, in auth_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/view.py", line 146, in handle result = await result File "/Users/bdraco/home-assistant/homeassistant/components/config/config_entries.py", line 180, in post return await super().post(request, flow_id) File "/Users/bdraco/home-assistant/homeassistant/components/http/data_validator.py", line 72, in wrapper result = await method(view, request, data, *args, **kwargs) File "/Users/bdraco/home-assistant/homeassistant/helpers/data_entry_flow.py", line 110, in post result = await self._flow_mgr.async_configure(flow_id, data) File "/Users/bdraco/home-assistant/homeassistant/data_entry_flow.py", line 271, in async_configure result = await self._async_handle_step( File "/Users/bdraco/home-assistant/homeassistant/data_entry_flow.py", line 367, in _async_handle_step result: FlowResult = await getattr(flow, method)(user_input) File "/Users/bdraco/home-assistant/homeassistant/components/onvif/config_flow.py", line 233, in async_step_configure errors, description_placeholders = await self.async_setup_profiles() File "/Users/bdraco/home-assistant/homeassistant/components/onvif/config_flow.py", line 277, in async_setup_profiles await device.update_xaddrs() File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/onvif/client.py", line 433, in update_xaddrs capabilities = await devicemgmt.GetCapabilities({"Category": "All"}) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/zeep/proxy.py", line 64, in __call__ return await self._proxy._binding.send_async( File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/zeep/wsdl/bindings/soap.py", line 164, in send_async return self.process_reply(client, operation_obj, response) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/zeep/wsdl/bindings/soap.py", line 204, in process_reply doc = parse_xml(content, self.transport, settings=client.settings) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/zeep/loader.py", line 51, in parse_xml docinfo = elementtree.getroottree().docinfo AttributeError: NoneType object has no attribute getroottree ``` * port * Revert "port" This reverts commit 4693f3f33af18af66672dbd5ce6774f35ba28316. * misfire
2023-04-30 01:17:56 +00:00
async def test_flow_manual_entry_wrong_port(hass: HomeAssistant) -> None:
"""Test that we get a useful error with the wrong port."""
result = await hass.config_entries.flow.async_init(
config_flow.DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "user"
with patch(
"homeassistant.components.onvif.config_flow.get_device"
) as mock_onvif_camera, patch(
"homeassistant.components.onvif.config_flow.WSDiscovery"
Handle AttributeError from wrong port in ONVIF config flow (#92272) * Handle AttributeError from wrong port in ONVIF config flow fixes ``` 2023-04-29 19:17:22.289 ERROR (MainThread) [aiohttp.server] Error handling request Traceback (most recent call last): File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request resp = await request_handler(request) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle resp = await handler(request) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/ban.py", line 80, in ban_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/auth.py", line 235, in auth_middleware return await handler(request) File "/Users/bdraco/home-assistant/homeassistant/components/http/view.py", line 146, in handle result = await result File "/Users/bdraco/home-assistant/homeassistant/components/config/config_entries.py", line 180, in post return await super().post(request, flow_id) File "/Users/bdraco/home-assistant/homeassistant/components/http/data_validator.py", line 72, in wrapper result = await method(view, request, data, *args, **kwargs) File "/Users/bdraco/home-assistant/homeassistant/helpers/data_entry_flow.py", line 110, in post result = await self._flow_mgr.async_configure(flow_id, data) File "/Users/bdraco/home-assistant/homeassistant/data_entry_flow.py", line 271, in async_configure result = await self._async_handle_step( File "/Users/bdraco/home-assistant/homeassistant/data_entry_flow.py", line 367, in _async_handle_step result: FlowResult = await getattr(flow, method)(user_input) File "/Users/bdraco/home-assistant/homeassistant/components/onvif/config_flow.py", line 233, in async_step_configure errors, description_placeholders = await self.async_setup_profiles() File "/Users/bdraco/home-assistant/homeassistant/components/onvif/config_flow.py", line 277, in async_setup_profiles await device.update_xaddrs() File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/onvif/client.py", line 433, in update_xaddrs capabilities = await devicemgmt.GetCapabilities({"Category": "All"}) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/zeep/proxy.py", line 64, in __call__ return await self._proxy._binding.send_async( File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/zeep/wsdl/bindings/soap.py", line 164, in send_async return self.process_reply(client, operation_obj, response) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/zeep/wsdl/bindings/soap.py", line 204, in process_reply doc = parse_xml(content, self.transport, settings=client.settings) File "/Users/bdraco/home-assistant/venv/lib/python3.10/site-packages/zeep/loader.py", line 51, in parse_xml docinfo = elementtree.getroottree().docinfo AttributeError: NoneType object has no attribute getroottree ``` * port * Revert "port" This reverts commit 4693f3f33af18af66672dbd5ce6774f35ba28316. * misfire
2023-04-30 01:17:56 +00:00
) as mock_discovery, patch(
"homeassistant.components.onvif.ONVIFDevice"
) as mock_device:
setup_mock_onvif_camera(mock_onvif_camera, wrong_port=True)
# no discovery
mock_discovery.return_value = []
setup_mock_device(mock_device)
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={"auto": False},
)
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
await hass.async_block_till_done()
assert len(mock_setup_entry.mock_calls) == 0
assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "configure"
assert result["errors"] == {"port": "no_onvif_service"}
assert result["description_placeholders"] == {}
setup_mock_onvif_camera(mock_onvif_camera, two_profiles=True)
with patch(
"homeassistant.components.onvif.async_setup_entry", return_value=True
) as mock_setup_entry:
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
},
)
await hass.async_block_till_done()
assert len(mock_setup_entry.mock_calls) == 1
assert result["title"] == f"{NAME} - {MAC}"
assert result["data"] == {
config_flow.CONF_NAME: NAME,
config_flow.CONF_HOST: HOST,
config_flow.CONF_PORT: PORT,
config_flow.CONF_USERNAME: USERNAME,
config_flow.CONF_PASSWORD: PASSWORD,
}