gitea

Commit Graph

Author	SHA1	Message	Date
TheFox0x7	0fde8ecd55	Enable testifylint rules (#34075 ) enable testifylint rules disabled in: https://github.com/go-gitea/gitea/pull/34054	2025-03-31 01:53:48 -04:00
wxiaoguang	8820191476	Improve template helper functions: string/slice (#24266 ) Follow #23328 The improvements: 1. The `contains` functions are covered by tests 2. The inconsistent behavior of `containGeneric` is replaced by `StringUtils.Contains` and `SliceUtils.Contains` 3. In the future we can move more help functions into XxxUtils to simplify the `helper.go` and reduce unnecessary global functions. FAQ: 1. Why it's called `StringUtils.Contains` but not `strings.Contains` like Golang? Because our `StringUtils` is not Golang's `strings` package. There will be our own string functions. --------- Co-authored-by: silverwind <me@silverwind.io>	2023-04-22 14:16:22 -04:00
wxiaoguang	36c0840cf1	Merge template functions "dict/Dict/mergeinto" (#23932 ) One of the steps in #23328 Before there were 3 different but similar functions: dict/Dict/mergeinto The code was just copied & pasted, no test. This PR defines a new stable `dict` function, it covers all the 3 old functions behaviors, only +160 -171 Future developers do not need to think about or guess the different dict functions, just use one: `dict` Why use `dict` but not `Dict`? Because there are far more `dict` than `Dict` in code already ......	2023-04-07 09:39:08 -05:00

Author

SHA1

Message

Date

TheFox0x7

0fde8ecd55

Enable testifylint rules (#34075 )

enable testifylint rules disabled in:
https://github.com/go-gitea/gitea/pull/34054

2025-03-31 01:53:48 -04:00

wxiaoguang

8820191476

Improve template helper functions: string/slice (#24266 )

Follow #23328

The improvements:

1. The `contains` functions are covered by tests
2. The inconsistent behavior of `containGeneric` is replaced by
`StringUtils.Contains` and `SliceUtils.Contains`
3. In the future we can move more help functions into XxxUtils to
simplify the `helper.go` and reduce unnecessary global functions.

FAQ:

1. Why it's called `StringUtils.Contains` but not `strings.Contains`
like Golang?

Because our `StringUtils` is not Golang's `strings` package. There will
be our own string functions.

---------

Co-authored-by: silverwind <me@silverwind.io>

2023-04-22 14:16:22 -04:00

wxiaoguang

36c0840cf1

Merge template functions "dict/Dict/mergeinto" (#23932 )

One of the steps in #23328


Before there were 3 different but similar functions: dict/Dict/mergeinto

The code was just copied & pasted, no test.

This PR defines a new stable `dict` function, it covers all the 3 old
functions behaviors, only +160 -171


Future developers do not need to think about or guess the different dict
functions, just use one: `dict`

Why use `dict` but not `Dict`? Because there are far more `dict` than
`Dict` in code already ......

2023-04-07 09:39:08 -05:00

3 Commits (4b19e292b954cdbebd1097b0e3d6e53da263b87f)