drupal/modules
Dries Buytaert aed1b0ca9e - Patch #5347 by JonBob:
Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:

Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.

Advantages of this refactoring:
- I can use it for book.module to remove the extra viewing path.
- The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
- We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
- The attachment.module people could use it to append their attachments in a list after the node.
- Gabor could use it instead of his filter perversion for his "articles in a series" module.
- A little less code in each view hook.
- The content hook is no longer needed, so that means even less code.

Disadvantages:
- Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
- Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).

Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
2004-07-30 13:37:26 +00:00
..
aggregator - Patch #8531 by drumm: took this date parser from MagpieRSS (conveniently GPL). The main benefit here is that timezones are handled properly (I have been noticing increasing complaints about that). I tested with a few feeds of different time formats and time zones and everything appeared correctly in my site's local time. Making this another function adds the benefit of parsability by other RSS (or other contexts) and RSS extension handling functions, where the W3C DTF is recomended. 2004-07-26 18:42:31 +00:00
archive - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
block - 'add block' -> 'add' 2004-07-10 16:06:49 +00:00
blog - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
blogapi - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents. In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch. 2004-07-13 20:40:46 +00:00
book - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
comment - Patch #7466 by TDobes: comments module would add a link of register even if "user_register" was set to 0. 2004-07-14 05:44:36 +00:00
drupal - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly: 2004-07-04 16:50:02 +00:00
filter - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
forum - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
help - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
locale - Patch #9481 by JonBob: fixed small typo in help text. 2004-07-25 14:35:11 +00:00
menu - Patch 9543 by JonBob: use drupal_goto() in menu administration. 2004-07-25 18:31:41 +00:00
node - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
page - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
path - Small code simplifications. 2004-07-13 07:10:56 +00:00
ping Tabs patch! 2004-06-18 15:04:37 +00:00
poll - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
profile - Patch #9478 by JonBob: allow printf-style arguments in pager_query. 2004-07-25 14:25:42 +00:00
search - Alternative fix for search module bug. 2004-07-28 20:32:21 +00:00
statistics - Simplified referrer links. Suggested by Morbus. 2004-06-30 21:00:41 +00:00
story - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents. In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch. 2004-07-13 20:40:46 +00:00
system System.module improvements: 2004-07-22 02:13:13 +00:00
taxonomy - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
throttle - Patch #8681 by stefan: fixed some broken URLs and help texts. 2004-06-20 19:49:14 +00:00
tracker - Patch #9478 by JonBob: allow printf-style arguments in pager_query. 2004-07-25 14:25:42 +00:00
user - Patch #9547 by Eric: fixed avatar/picture upload bug. 2004-07-28 20:18:11 +00:00
watchdog - Patch #8952 by Morbus: watchdog module beautifications. 2004-07-03 14:10:09 +00:00
admin.module Tabs patch! 2004-06-18 15:04:37 +00:00
aggregator.module - Patch #8531 by drumm: took this date parser from MagpieRSS (conveniently GPL). The main benefit here is that timezones are handled properly (I have been noticing increasing complaints about that). I tested with a few feeds of different time formats and time zones and everything appeared correctly in my site's local time. Making this another function adds the benefit of parsability by other RSS (or other contexts) and RSS extension handling functions, where the W3C DTF is recomended. 2004-07-26 18:42:31 +00:00
archive.module - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
block.module - 'add block' -> 'add' 2004-07-10 16:06:49 +00:00
blog.module - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
blogapi.module - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents. In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch. 2004-07-13 20:40:46 +00:00
book.module - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
comment.module - Patch #7466 by TDobes: comments module would add a link of register even if "user_register" was set to 0. 2004-07-14 05:44:36 +00:00
drupal.module - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly: 2004-07-04 16:50:02 +00:00
filter.module - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
forum.module - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
help.module - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
locale.module - Patch #9481 by JonBob: fixed small typo in help text. 2004-07-25 14:35:11 +00:00
menu.module - Patch 9543 by JonBob: use drupal_goto() in menu administration. 2004-07-25 18:31:41 +00:00
node.module - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
page.module - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
path.module - Small code simplifications. 2004-07-13 07:10:56 +00:00
ping.module Tabs patch! 2004-06-18 15:04:37 +00:00
poll.module - Patch #5347 by JonBob: 2004-07-30 13:37:26 +00:00
profile.module - Patch #9478 by JonBob: allow printf-style arguments in pager_query. 2004-07-25 14:25:42 +00:00
queue.module - Moving the title.module from core to contrib as discussed on the mailing list. 2004-07-07 20:18:22 +00:00
search.module - Alternative fix for search module bug. 2004-07-28 20:32:21 +00:00
statistics.module - Simplified referrer links. Suggested by Morbus. 2004-06-30 21:00:41 +00:00
story.module - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents. In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch. 2004-07-13 20:40:46 +00:00
system.module System.module improvements: 2004-07-22 02:13:13 +00:00
taxonomy.module - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
throttle.module - Patch #8681 by stefan: fixed some broken URLs and help texts. 2004-06-20 19:49:14 +00:00
tracker.module - Patch #9478 by JonBob: allow printf-style arguments in pager_query. 2004-07-25 14:25:42 +00:00
user.module - Patch #9547 by Eric: fixed avatar/picture upload bug. 2004-07-28 20:18:11 +00:00
watchdog.module - Patch #8952 by Morbus: watchdog module beautifications. 2004-07-03 14:10:09 +00:00