#!/bin/bash # # This script performs code quality checks. # # @internal # This script is not covered by Drupal core's backwards compatibility promise. # It exists only for core development purposes. # # The script makes the following checks: # - Spell checking. # - File modes. # - No changes to core/node_modules directory. # - PHPCS checks PHP and YAML files. # - Eslint checks JavaScript files. # - Checks .es6.js and .js files are equivalent. # - Stylelint checks CSS files. # - Checks .pcss.css and .css files are equivalent. # cSpell:disable # Searches an array. contains_element() { local e for e in ${@:2}; do [[ "$e" == "$1" ]] && return 0; done return 1 } CACHED=0 DRUPALCI=0 BRANCH="" while test $# -gt 0; do case "$1" in -h|--help) echo "Drupal code quality checks" echo " " echo "options:" echo "-h, --help show brief help" echo "--branch BRANCH creates list of files to check by comparing against a branch" echo "--cached checks staged files" echo "--drupalci a special mode for DrupalCI" echo " " echo "Example usage: sh ./core/scripts/dev/commit-code-check.sh --branch 9.2.x" exit 0 ;; --branch) BRANCH="$2" if [[ "$BRANCH" == "" ]]; then printf "The --branch option requires a value. For example: --branch 9.2.x\n" exit; fi shift 2 ;; --cached) CACHED=1 shift ;; --drupalci) DRUPALCI=1 shift ;; *) break ;; esac done # Set up variables to make colored output simple. Color output is disabled on # DrupalCI because it is breaks reporting. # @todo https://www.drupal.org/project/drupalci_testbot/issues/3181869 if [[ "$DRUPALCI" == "1" ]]; then red="" green="" reset="" DRUPAL_VERSION=$(php -r "include 'vendor/autoload.php'; print preg_replace('#\.[0-9]+-dev#', '.x', \Drupal::VERSION);") else red=$(tput setaf 1 && tput bold) green=$(tput setaf 2) reset=$(tput sgr0) fi # Gets list of files to check. if [[ "$BRANCH" != "" ]]; then FILES=$(git diff --name-only $BRANCH HEAD); elif [[ "$CACHED" == "0" ]]; then # For DrupalCI patch testing or when running without --cached or --branch, # list of all changes in the working directory. FILES=$(git ls-files --other --modified --exclude-standard --exclude=vendor) else # Check staged files only. if git rev-parse --verify HEAD >/dev/null 2>&1 then AGAINST=HEAD else # Initial commit: diff against an empty tree object AGAINST=4b825dc642cb6eb9a060e54bf8d69288fbee4904 fi FILES=$(git diff --cached --name-only $AGAINST); fi if [[ "$FILES" == "" ]] && [[ "$DRUPALCI" == "1" ]]; then # If the FILES is empty we might be testing a merge request on DrupalCI. We # need to diff against the Drupal branch or tag related to the Drupal version. printf "Creating list of files to check by comparing branch to %s\n" "$DRUPAL_VERSION" # On DrupalCI there's a merge commit so we can compare to HEAD~1. FILES=$(git diff --name-only HEAD~1 HEAD); fi TOP_LEVEL=$(git rev-parse --show-toplevel) # Build up a list of absolute file names. ABS_FILES= for FILE in $FILES; do ABS_FILES="$ABS_FILES $TOP_LEVEL/$FILE" done # Exit early if there are no files. if [[ "$ABS_FILES" == "" ]]; then printf "There are no files to check. If you have staged a commit use the --cached option.\n" exit; fi; # This script assumes that composer install and yarn install have already been # run and all dependencies are updated. FINAL_STATUS=0 DEPENDENCIES_NEED_INSTALLING=0 # Ensure PHP development dependencies are installed. # @todo https://github.com/composer/composer/issues/4497 Improve this to # determine if dependencies in the lock file match the installed versions. # Using composer install --dry-run is not valid because it would depend on # user-facing strings in Composer. if ! [[ -f 'vendor/bin/phpcs' ]]; then printf "Drupal's PHP development dependencies are not installed. Run 'composer install' from the root directory.\n" DEPENDENCIES_NEED_INSTALLING=1; fi cd "$TOP_LEVEL/core" # Ensure JavaScript development dependencies are installed. yarn check -s 2>/dev/null if [ "$?" -ne "0" ]; then printf "Drupal's JavaScript development dependencies are not installed. Run 'yarn install' inside the core directory.\n" DEPENDENCIES_NEED_INSTALLING=1; fi if [ $DEPENDENCIES_NEED_INSTALLING -ne 0 ]; then exit 1; fi # Check all files for spelling in one go for better performance. yarn run -s spellcheck -c $TOP_LEVEL/core/.cspell.json $ABS_FILES if [ "$?" -ne "0" ]; then # If there are failures set the status to a number other than 0. FINAL_STATUS=1 printf "\nCSpell: ${red}failed${reset}\n" else printf "\nCSpell: ${green}passed${reset}\n" fi cd "$TOP_LEVEL" # Add a separator line to make the output easier to read. printf "\n" printf -- '-%.0s' {1..100} printf "\n" for FILE in $FILES; do STATUS=0; # Print a line to separate spellcheck output from per file output. printf "Checking %s\n" "$FILE" printf "\n" # Ensure the file still exists (i.e. is not being deleted). if [ -a $FILE ]; then if [ ${FILE: -3} != ".sh" ]; then # Ensure the file has the correct mode. STAT="$(stat -f "%A" $FILE 2>/dev/null)" if [ $? -ne 0 ]; then STAT="$(stat -c "%a" $FILE 2>/dev/null)" fi if [ "$STAT" -ne "644" ]; then printf "${red}check failed:${reset} file $FILE should be 644 not $STAT\n" STATUS=1 fi fi fi # Don't commit changes to vendor. if [[ "$FILE" =~ ^vendor/ ]]; then printf "${red}check failed:${reset} file in vendor directory being committed ($FILE)\n" STATUS=1 fi # Don't commit changes to core/node_modules. if [[ "$FILE" =~ ^core/node_modules/ ]]; then printf "${red}check failed:${reset} file in core/node_modules directory being committed ($FILE)\n" STATUS=1 fi ############################################################################ ### PHP AND YAML FILES ############################################################################ if [[ -f "$TOP_LEVEL/$FILE" ]] && [[ $FILE =~ \.(inc|install|module|php|profile|test|theme|yml)$ ]]; then # Test files with phpcs rules. vendor/bin/phpcs "$TOP_LEVEL/$FILE" --runtime-set installed_paths "$TOP_LEVEL/vendor/drupal/coder/coder_sniffer" --standard="$TOP_LEVEL/core/phpcs.xml.dist" PHPCS=$? if [ "$PHPCS" -ne "0" ]; then # If there are failures set the status to a number other than 0. STATUS=1 else printf "PHPCS: $FILE ${green}passed${reset}\n" fi fi ############################################################################ ### JAVASCRIPT FILES ############################################################################ if [[ -f "$TOP_LEVEL/$FILE" ]] && [[ $FILE =~ \.js$ ]] && [[ ! $FILE =~ ^core/tests/Drupal/Nightwatch ]] && [[ ! $FILE =~ ^core/assets/vendor/jquery.ui/ui ]]; then # Work out the root name of the JavaScript so we can ensure that the ES6 # version has been compiled correctly. if [[ $FILE =~ \.es6\.js$ ]]; then BASENAME=${FILE%.es6.js} COMPILE_CHECK=1 else BASENAME=${FILE%.js} # We only need to compile check if the .es6.js file is not also # changing. This is because the compile check will occur for the # .es6.js file. This might occur if the compile scripts have changed. contains_element "$BASENAME.es6.js" "${FILES[@]}" HASES6=$? if [ "$HASES6" -ne "0" ]; then COMPILE_CHECK=1 else COMPILE_CHECK=0 fi fi if [[ "$COMPILE_CHECK" == "1" ]] && [[ -f "$TOP_LEVEL/$BASENAME.es6.js" ]]; then cd "$TOP_LEVEL/core" yarn run build:js --check --file "$TOP_LEVEL/$BASENAME.es6.js" CORRECTJS=$? if [ "$CORRECTJS" -ne "0" ]; then # No need to write any output the yarn run command will do this for # us. STATUS=1 fi # Check the coding standards. if [[ -f ".eslintrc.passing.json" ]]; then node ./node_modules/eslint/bin/eslint.js --quiet --config=.eslintrc.passing.json "$TOP_LEVEL/$BASENAME.es6.js" CORRECTJS=$? if [ "$CORRECTJS" -ne "0" ]; then # No need to write any output the node command will do this for us. STATUS=1 fi fi cd $TOP_LEVEL else # If there is no .es6.js file then there should be unless the .js is # not really Drupal's. if ! [[ "$FILE" =~ ^core/assets/vendor ]] && ! [[ "$FILE" =~ ^core/scripts/js ]] && ! [[ "$FILE" =~ ^core/scripts/css ]] && ! [[ "$FILE" =~ core/postcss.config.js ]] && ! [[ -f "$TOP_LEVEL/$BASENAME.es6.js" ]]; then printf "${red}FAILURE${reset} $FILE does not have a corresponding $BASENAME.es6.js\n" STATUS=1 fi fi elif [[ -f "$TOP_LEVEL/$FILE" ]] && [[ $FILE =~ \.js$ ]] && [[ $FILE =~ ^core/assets/vendor/jquery.ui/ui ]]; then ## Check for minified file changes. if [[ $FILE =~ -min\.js$ ]]; then BASENAME=${FILE%-min.js} contains_element "$BASENAME.js" "${FILES[@]}" HASSRC=$? if [ "$HASSRC" -ne "0" ]; then COMPILE_CHECK=1 else ## Source was also changed and will be checked. COMPILE_CHECK=0 fi else ## Check for source changes. BASENAME=${FILE%.js} COMPILE_CHECK=1 fi if [[ "$COMPILE_CHECK" == "1" ]] && [[ -f "$TOP_LEVEL/$BASENAME.js" ]]; then cd "$TOP_LEVEL/core" yarn run build:jqueryui --check --file "$TOP_LEVEL/$BASENAME.js" CORRECTJS=$? if [ "$CORRECTJS" -ne "0" ]; then # The yarn run command will write any error output. STATUS=1 fi cd $TOP_LEVEL else # If there is no .js source file if ! [[ -f "$TOP_LEVEL/$BASENAME.js" ]]; then printf "${red}FAILURE${reset} $FILE does not have a corresponding $BASENAME.js\n" STATUS=1 fi fi else # Check coding standards of Nightwatch files. if [[ -f "$TOP_LEVEL/$FILE" ]] && [[ $FILE =~ \.js$ ]]; then cd "$TOP_LEVEL/core" # Check the coding standards. if [[ -f ".eslintrc.passing.json" ]]; then node ./node_modules/eslint/bin/eslint.js --quiet --config=.eslintrc.passing.json "$TOP_LEVEL/$FILE" CORRECTJS=$? if [ "$CORRECTJS" -ne "0" ]; then # No need to write any output the node command will do this for us. STATUS=1 fi fi cd $TOP_LEVEL fi fi ############################################################################ ### CSS FILES ############################################################################ if [[ -f "$TOP_LEVEL/$FILE" ]] && [[ $FILE =~ \.css$ ]]; then # Work out the root name of the CSS so we can ensure that the PostCSS # version has been compiled correctly. if [[ $FILE =~ \.pcss\.css$ ]]; then BASENAME=${FILE%.pcss.css} COMPILE_CHECK=1 else BASENAME=${FILE%.css} # We only need to compile check if the .pcss.css file is not also # changing. This is because the compile check will occur for the # .pcss.css file. This might occur if the compiled stylesheets have # changed. contains_element "$BASENAME.pcss.css" "${FILES[@]}" HASPOSTCSS=$? if [ "$HASPOSTCSS" -ne "0" ]; then COMPILE_CHECK=1 else COMPILE_CHECK=0 fi fi # PostCSS if [[ "$COMPILE_CHECK" == "1" ]] && [[ -f "$TOP_LEVEL/$BASENAME.pcss.css" ]]; then cd "$TOP_LEVEL/core" yarn run build:css --check --file "$TOP_LEVEL/$BASENAME.pcss.css" CORRECTCSS=$? if [ "$CORRECTCSS" -ne "0" ]; then # No need to write any output the yarn run command will do this for # us. STATUS=1 fi cd $TOP_LEVEL fi fi if [[ -f "$TOP_LEVEL/$FILE" ]] && [[ $FILE =~ \.css$ ]] && [[ -f "core/node_modules/.bin/stylelint" ]]; then BASENAME=${FILE%.css} # We only need to use stylelint on the .pcss.css file. So if this CSS file # has a corresponding .pcss don't do stylelint. if [[ $FILE =~ \.pcss\.css$ ]] || [[ ! -f "$TOP_LEVEL/$BASENAME.pcss.css" ]]; then cd "$TOP_LEVEL/core" node_modules/.bin/stylelint "$TOP_LEVEL/$FILE" if [ "$?" -ne "0" ]; then STATUS=1 else printf "STYLELINT: $FILE ${green}passed${reset}\n" fi cd $TOP_LEVEL fi fi if [[ "$STATUS" == "1" ]]; then FINAL_STATUS=1 # There is no need to print a failure message. The fail will be described # already. else printf "%s ${green}passed${reset}\n" "$FILE" fi # Print a line to separate each file's checks. printf "\n" printf -- '-%.0s' {1..100} printf "\n" done if [[ "$FINAL_STATUS" == "1" ]] && [[ "$DRUPALCI" == "1" ]]; then printf "${red}Drupal code quality checks failed.${reset}\n" printf "To reproduce this output locally:\n" printf "* Apply the change as a patch\n" printf "* Run this command locally: sh ./core/scripts/dev/commit-code-check.sh\n" printf "OR:\n" printf "* From the merge request branch\n" printf "* Run this command locally: sh ./core/scripts/dev/commit-code-check.sh --branch %s\n" "$DRUPAL_VERSION" fi exit $FINAL_STATUS