Commit Graph

375 Commits (4.7.8)

Author SHA1 Message Date
Gerhard Killesreiter afc5cd2227 #93678 by chx: book module not updating the database properly. Backport from HEAD 2006-12-01 10:11:36 +00:00
Gerhard Killesreiter 612fbbb429 #26552 by Heine. Add child page to unpublished book nodes doesn't work, so remove the link. backport from HEAD 2006-12-01 09:47:39 +00:00
Gerhard Killesreiter 15f9079457 #72467, Fix long links in forum/book navigation, patch by m3avrck 2006-11-22 10:41:36 +00:00
Gerhard Killesreiter f8c318a7be #84117, Book outlining fails with PostgreSQL error, patch by mlsawle
Greetings from BarCamp Brussels
2006-09-24 10:36:24 +00:00
Gerhard Killesreiter 69a4462e67 #75465, patch by chx, fix docs for book_location_down 2006-09-05 10:20:00 +00:00
Gerhard Killesreiter be8f24a209 #39124, previously entered log message is shown by default, patch by dww, backport from HEAD 2006-08-17 09:14:41 +00:00
Dries Buytaert 38a79a8382 - Patch #71014 by fgm: fixed the parent navigation link. 2006-07-03 14:44:39 +00:00
Gerhard Killesreiter a3d0771646 #71613 by keve, fixing some PHP notices in the book module.
, backport from Head
2006-07-02 21:08:00 +00:00
Gerhard Killesreiter 67b20793b7 #69151, book_export_html is not themeable and the html page title is not set., patch by Flanker, backport from HEAD. 2006-06-26 19:21:45 +00:00
Dries Buytaert fc50f96c96 - Patch #67229 by dww and chx: cleaned up book_load(). 2006-06-05 09:18:41 +00:00
Gerhard Killesreiter 8e64b0fb7b #66991, infinite recursion in book_location_down() when there are multiple revisions, patch by dww, modified 2006-06-03 09:22:12 +00:00
Gerhard Killesreiter 380108496f #46290 by Neil, Egon, et al: when deleting a book page under 'orphan pages' we are returned to the homepage, backport from HEAD 2006-05-24 11:41:07 +00:00
Dries Buytaert f896bd4535 - Patch #60224 by rkerr: one page book showing another book in navigation links. 2006-05-13 10:02:47 +00:00
Gerhard Killesreiter 031235d206 #61696, missing t(), patch by Zen 2006-05-03 19:19:03 +00:00
Dries Buytaert d071f99172 - Removing trailing whitespace. 2006-04-17 20:48:26 +00:00
Gerhard Killesreiter b61d9c3e7b #58539, removed duplicate menu item, patch by Markus Petrux 2006-04-13 15:10:23 +00:00
Gerhard Killesreiter 002fee7aae #56105, remove title validation, already enforced by #required, patch by Moshe 2006-03-27 18:02:48 +00:00
Gerhard Killesreiter 3052c49e09 #53826, Book export: db_rewrite breaks sql query., patch by puregin 2006-03-26 19:35:05 +00:00
Gerhard Killesreiter 4a689a99b9 #55493, Editing an existing book page kills Drupal, patch by chx 2006-03-23 21:20:59 +00:00
Gerhard Killesreiter 5cfdac2448 #54565, cannot remove pages from book outline. Patch by Zen. 2006-03-18 13:09:56 +00:00
Steven Wittens 729c464d00 #50987: book next link breaks with php 5.1 2006-03-14 15:43:49 +00:00
Steven Wittens e74aa7eeb6 #53956: Don't allow moving away top-level book pages if you cannot move them back. 2006-03-14 15:36:25 +00:00
Gerhard Killesreiter 0e3f8f97eb #11206, Editing a top level book page inadvertently changes parent, patch by chx. 2006-03-14 09:21:49 +00:00
Dries Buytaert edce458e2f - Patch #50821 by Zen/merlinofchaos: convert book.module to form API so the forms can be altered/themed. 2006-03-02 08:44:52 +00:00
Steven Wittens 514b12c427 - #47844: Book module doesn't delete table entry for nodes added to outline. 2006-03-01 19:19:05 +00:00
Dries Buytaert 3603fe1bd8 - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) 2006-02-21 18:46:54 +00:00
Dries Buytaert 7f299b7a9b - Patch #49131 by puregin: refine book permissions. 2006-02-14 19:25:02 +00:00
Dries Buytaert 3b27048623 - Patch #47098 by JonBob: fixed book navigation divs when book has no child pages. 2006-02-09 07:27:11 +00:00
Dries Buytaert 1f206ca2fe - Patch #47066 by Zen: removed dead code. 2006-02-01 14:40:20 +00:00
Dries Buytaert 15ff8c8e32 - Patch #46827 by wulff: fixed incorrect links. 2006-01-29 07:50:45 +00:00
Dries Buytaert 30d59fd52c - Patch #46400 by m3avrck: clean up book navigation markup + UI improvements. (Hint: the forum module has previous and next links too.) 2006-01-27 18:57:13 +00:00
Dries Buytaert 3c6066cffa - Patch #45706 by markus: keep up with CSS improvements. 2006-01-24 08:22:12 +00:00
Dries Buytaert 4267ab5ea9 - Patch #45706 by markus: keeping up with CSS improvements. 2006-01-22 07:32:55 +00:00
Dries Buytaert 8c02d4ec93 - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:

# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
  $form[$key]['#weight'] = $count/1000;
}

The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).

Consider the following pseudo example:

$form['game_title'] = array(
    '#type' => 'textfield',
    ...
    );
$form['game_description'] = array(
    '#type' => 'textarea',
    ...
    );
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;

Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).

The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert e84a98a22b - Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API. 2006-01-19 08:54:41 +00:00
Dries Buytaert 52507806eb - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. 2006-01-18 19:29:17 +00:00
Dries Buytaert 4e35060451 - Patch 42591 by Simon/me: fixed problem with deleting forum and book revisions. 2005-12-31 13:04:40 +00:00
Dries Buytaert 922a46d281 - Patch #34920 by Morbus/webchick/tangent: fixed order of form fields. 2005-12-15 16:24:40 +00:00
Dries Buytaert c4c5ce122d - Patch #31323 by Gerhard: delete extra data when a revision is deleted. 2005-12-05 16:07:18 +00:00
Dries Buytaert 28fdb3975e - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick. 2005-12-05 09:11:33 +00:00
Dries Buytaert 26bd449860 - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'. 2005-12-02 15:21:01 +00:00
Dries Buytaert 17ec644763 - Patch #1482 by djun: we're moving the DocBook output to a contributed module. It's not a core feature. 2005-11-30 13:16:53 +00:00
Dries Buytaert f5d3fa1008 - Patch #38296 by Tobias Maier: fixed bug with book links. 2005-11-24 19:24:38 +00:00
Dries Buytaert d4692d569c - Patch #35644 by webchick: fixed the sizes of the textareas on the node edit forms. 2005-11-23 16:18:28 +00:00
Dries Buytaert dba3e800cd - Patch #38611 by Neil: redo book administration.
The book module's current administration is actually a patchwork of one form per book page crammed into a table with another form at the bottom. This simply didn't work.
2005-11-23 10:22:41 +00:00
Dries Buytaert cba99db42b - Patch #38296 by Ber: generate rel-tags for book pages. Makes it easier to browse in some browsers. 2005-11-22 15:11:40 +00:00
Dries Buytaert aeed4cd8e4 - Patch #35644 by webchick: forms API simplificiations. 2005-11-12 11:26:16 +00:00
Steven Wittens 85492ae9a5 #36791: node_validate was called twice 2005-11-12 02:54:13 +00:00
Dries Buytaert a8b218827a - Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! / 2005-11-01 10:17:34 +00:00
Dries Buytaert ef7d2c8a9f - Patch #34920 by tangent: reorganized the node submission form a bit. 2005-10-28 14:04:20 +00:00