Commit Graph

401 Commits (4.5.2)

Author SHA1 Message Date
Dries Buytaert ccab3ee80b - Improved the input checking. 2004-12-28 11:04:14 +00:00
Steven Wittens d0755828dc #14757: Fix XSS vulnerability due to entity usage. 2004-12-25 14:57:32 +00:00
Dries Buytaert e4f1b30dd5 - Patch #13647 by Goba:
1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
   2. Removed t() functions from user contributed content.
2004-11-29 17:59:53 +00:00
Dries Buytaert 57ab8a9baf - Patch #13405 by Moshe (and jhrigs):
+ Fixed bug with previous commit.

   + Move functions into bootstrap.inc so that statistics_exit() works for cached pages.  (Does this close any issues?)
2004-11-25 06:12:35 +00:00
Dries Buytaert f060e498a8 - Patch #13121 by Goba: valid_url() should allow the use of '+' in URLs. 2004-11-18 19:22:53 +00:00
Dries Buytaert c3c4906b9e - Patch #12096 by Axel: fixed problem with plurals for some languages. 2004-10-27 18:24:10 +00:00
Dries Buytaert 469b35bb0c - Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output.
Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
2004-10-19 18:00:34 +00:00
Steven Wittens b3451d0274 Adding a note about the usage of form_hidden inside form_checkbox and form_checkboxes. 2004-10-13 17:21:06 +00:00
Dries Buytaert 0261efc8fd - Patch #11531 by killes: it was not possible to deselect all choices of a form_checkboxes array. 2004-10-13 17:08:50 +00:00
Dries Buytaert 5f28d97a0f - Patch #11271 by Ber: fixed form_radios() to generate valid XHTML code. This makes the code generated by the poll module XHTML compliant.
- Similarly, I updated form_checkboxes() to generate valid XHTML code.
2004-10-12 19:55:53 +00:00
Dries Buytaert 503c784557 - Simplified/reorganized version of patch #9620 by Jeremy: fixed errors when writing to cache. 2004-10-04 22:04:07 +00:00
Steven Wittens aded584102 Adding a note about drupal_eval() acting like a variable sandbox. 2004-09-16 16:12:21 +00:00
Dries Buytaert 3079ffeafe - Made it possible for the i18n module to hook in. 2004-09-15 09:54:32 +00:00
Steven Wittens b75c1e1c8b Replace hardcoded <html lang="en"> with a locale dependant one. This is especially important for asian sites where this has an effect on font selection. 2004-09-09 13:36:01 +00:00
Dries Buytaert b84b6e42cf - Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments. 2004-09-09 05:51:08 +00:00
Steven Wittens 51cf18e531 - #9292: Make Drupal (somewhat) PHP5 compatible. xtemplate is still horribly broken. 2004-08-22 17:03:42 +00:00
Dries Buytaert 47b72af612 - Patch #6809 by TDobes: fixed the textarea hook so WYSIWYG editors are made possible again.
TODO: apply the documentation and htmlarea module patches.
2004-08-21 17:06:51 +00:00
Dries Buytaert 7736eb4995 - Patch #10166 by jvandyk: bugfix: valid_url() believed that URLs with encoded spaces in them (eg. http://example.org/my%20file.html ) are not valid. 2004-08-21 17:02:48 +00:00
Dries Buytaert f311646b1e - Patch #10195 by JonBob: bugfix: common.inc used the function ob_get_clean() which is only available in PHP >= 4.3. 2004-08-21 16:44:05 +00:00
Dries Buytaert 6ea5c56ded - Theme system changes. Please consult http://drupal.org/node/view/9576 for details. 2004-08-20 07:51:27 +00:00
Dries Buytaert 83a739bd89 - Code improvements by Stefan: made all status messages consistent (and easier to translate). 2004-08-18 19:57:27 +00:00
Dries Buytaert 78b052a6af - The upload (filehandler) module has landed! 2004-08-17 21:35:26 +00:00
Dries Buytaert eeb2b17b7b - Bugfix: include the xmlrpc library. 2004-08-17 18:40:59 +00:00
Dries Buytaert cea07ecac6 - Patch #6806 by UnConeD: prefixed form IDs with 'edit-' so they won't clash
with other IDs.  Also makes things a tad more consistent.
2004-08-12 21:56:48 +00:00
Dries Buytaert 1831e1b690 - New locale module thanks to Gerhard, Goba, Marco, Kristjan and others.
The new locale module provides every functionality on the web interface, so you don't need to edit the configuration files or add columns, when you add a new language. This module is an integration of the old locale and localegettext modules, plus a bunch of logic to parse Gettext Portable Object files (opposed to Machine Object files, as supported by localegettext).

  Note: I made some minor changes to the context-sensitive help texts and to some of the status messages.
2004-08-11 11:26:20 +00:00
Steven Wittens 660f99287d The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
2004-08-10 18:34:29 +00:00
Steven Wittens 88221c2f67 #7646 and more:
- Users who have not edited their account yet would be reset to GMT rather than the sitewide timezone.
- Users who chose GMT (zero timezone) on a site with a non-zero timezone as default would have incorrect timezone.
2004-08-10 01:30:09 +00:00
Dries Buytaert 9bad647d76 - Patch #9819 by JonBob: fixed XHTML bug - make sure the <div> is always closed. 2004-08-06 20:18:25 +00:00
Dries Buytaert 9bbdb71ee4 - Patch #9330: ucfirst() gives problem when used with multibyte charset.
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
Dries Buytaert a52cf8297a - Patch #7458 by killes: conditionally include xmlrpc.inc. 2004-08-04 20:36:24 +00:00
Steven Wittens 6c73823b10 Fixing a rather nasty bug with page cache:
The headers stored for cached pages ended in a newline, which caused header("") to get called when serving the page.
On some PHP versions (happens on 4.3.3 at least, but not in 5.0), PHP adds a blank header to the HTTP request (i.e. just \r\n) which ends HTTP headers prematurely and adds a newline at the beginning of the page.

This was not an issue before because we output HTML. Now that we have GZip compression, this bug caused corruption of the output. :P
*phew*
2004-07-29 01:41:33 +00:00
Steven Wittens edc2f13d82 - #9287: More doxygen/documentation fixes by JonBob 2004-07-22 16:06:54 +00:00
Steven Wittens b8d653f1e8 - Fixing bad strpos usage (have to use the ===/!== operators to check for 'false' in this case) 2004-07-21 15:30:35 +00:00
Dries Buytaert 50d78e9855 - Patch #9238 by JonBob: added code and Doxygen comments to common.inc and
bootstrap.inc.
2004-07-13 07:21:14 +00:00
Steven Wittens a080ce5f0f Slightly improved code in drupal_xml_parser_create. 2004-07-12 21:38:41 +00:00
Steven Wittens 77c0b577da Now Drupal tries iconv, recode and mbstring to convert unknown XML encodings to UTF-8. It also throws a friendlier error message when none of these extensions is installed. 2004-07-12 21:35:31 +00:00
Dries Buytaert 323d9fe054 - Call 'exit' hook when drupal_goto() is called. Also necessary for the
devel.module.
2004-07-11 07:31:11 +00:00
Dries Buytaert 02ae1ce670 - Many form_ functions called theme('form_element') with the wrong parameters!
- Fixed order of parameters in form_checkboxes() (plural).
2004-07-08 11:31:12 +00:00
Dries Buytaert fe2b3e7c00 - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00
Dries Buytaert f3aa87122e - Textarea's did not have error handling support yet. 2004-07-04 06:19:41 +00:00
Dries Buytaert 9986cb36b5 - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
Steven Wittens 6a00c7c2f2 - Preventing caching of page when status messages are present (needed for redirects after form submission to work properly)
- Double-quotes to Single-quotes
2004-06-28 20:00:53 +00:00
Dries Buytaert 77ec01f592 - Patch #8344 by Kjartan: drupal_http_request() did not always handle EOLs
correctly.
2004-06-21 20:14:41 +00:00
Dries Buytaert 090743bdba - Patch #8670 by asimmonds: more spelling fixes. 2004-06-21 20:05:37 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Kjartan Mannes 7cd54567bd - Commiting patch #8288: Let modules pass $attributes to form_checkboxes() and form_radios(). 2004-06-04 18:10:05 +00:00
Dries Buytaert c0b85a5721 - Patch #4950 by Stefan (and Morbus): made watchdog messages translatable. 2004-06-02 19:01:40 +00:00
Kjartan Mannes c3463a22ae - Removing early experimental tab code that slipped in.
- Fixing a copy paste error in file.inc.
- Some double => single quote changes.
2004-06-02 18:26:44 +00:00
Dries Buytaert fbbf510511 - Patch #8105 by mathias: made the menu system aware of path aliases. 2004-06-01 21:58:46 +00:00
Dries Buytaert 7f08110a5e - Improved form handling.
+ Introduced two new functions:
      1. form_set_error($name, $message): files an error against the form
         element with the specified  $name.
      2. form_has_errors(): returns true if errors has been filed against
         form elements.

  + Updated the form handling:
       1. The form_ functions will add 'class="error"' when a form field
          has been found to be erroneous.
       2. The error message is passed to theme_form_element() when the
          particular form field has been found to be erroneous.

  + I updated the user and profile module to take advantage of these new
    functions.

  + IMPORTANT: the _user() hook changed.  The 'validate' case should no
    longer retun an error message when something goes wrong but should
    set it with form_set_error().
2004-05-31 09:40:56 +00:00