Commit Graph

235 Commits (f45ae901c93f03387160f60067768b7188fe3178)

Author SHA1 Message Date
Dries 854ad21158 - Patch #1479652 by Psikik: convert image style config filenames/keys from plural to singular. 2012-03-15 21:32:34 -04:00
Jennifer Hodgdon ca921c5781 Revert of #1479652 commit b287d6ee1a - there were files missing from the commit 2012-03-15 11:48:21 -07:00
Dries b287d6ee1a - Patch #1479652 by Psikik: convert image style config filenames/keys from plural to singular. 2012-03-15 12:45:22 -04:00
catch aab8b66a29 Issue #1373142 by sun, beejeebus, aspilicious, amateescu: Use the Testing profile. Speed up testbot by 50%. 2012-03-13 12:16:40 +09:00
catch b9e9244171 Issue #965300 by Gábor Hojtsy, xjm: Change LANGUAGE_NONE to LANGUAGE_NOT_SPECIFIED; add LANGUAGE_NOT_APPLICABLE and LANGUAGE_MULTIPLE. 2012-03-09 00:10:59 +09:00
Jennifer Hodgdon 6464289abc Issue #1444650 by damiankloip: Make documentation of theme_image_style clearer 2012-03-06 10:03:47 -08:00
Greg Dunlap 1bc549de8f Merge remote-tracking branch 'origin/8.x' into 8.x-file-config 2012-02-29 19:47:35 -08:00
Jennifer Hodgdon aedceb6950 Issue #1360790 by KrisBulman, beltofte, stBorchert: Update CSS to use lowercase hex colors not uppercase 2012-02-29 08:56:15 -08:00
webchick 157cdc5895 Revert "Issue #1446366 by xjm: Multiple web test classes mislabeled as unit tests."
This reverts commit 9bda29ee1b.
2012-02-29 00:22:10 -08:00
webchick 9bda29ee1b Issue #1446366 by xjm: Multiple web test classes mislabeled as unit tests. 2012-02-29 00:08:18 -08:00
Greg Dunlap bdd013ea2a Merge remote-tracking branches 'origin/8.x' and 'origin/8.x-file-config' into 8.x-file-config 2012-02-22 14:29:38 -08:00
Dries a58940f111 - Patch #1222194 by Gábor Hojtsy, plach: rename global to (). 2012-02-22 08:37:04 -05:00
Greg Dunlap eb6ea697b8 Renamed unset back to clear because unset is a reserved word which is the whole reason I didn't name it unset in the first place 2012-02-17 14:15:16 -08:00
Greg Dunlap c256f64104 Renamed clear() to unset() 2012-02-17 14:09:59 -08:00
effulgentsia e607acf4a2 Fixed ImageAdminStylesUnitTest. 2012-02-16 18:17:13 -08:00
Greg Dunlap dafa899ab5 More whitespace cleanup 2012-02-16 13:12:02 -08:00
Greg Dunlap 3f9c931860 Cleaning up whitespace 2012-02-16 13:08:44 -08:00
Greg Dunlap 803af70955 Fixed problem with ieid getting erased on image style update 2012-02-16 12:36:07 -08:00
sun 2b316b6a51 Fixed ImageDimensionsUnitTest does not apply weights to image effects, so effects are not saved in expected order. 2012-02-14 12:26:29 -08:00
sun 7f7d3555ac Removed wonky code in image_effect_save() that seemingly and bogusly tries to retain previously existing properties of an image effect. 2012-02-14 12:26:01 -08:00
sun 40cc21c89d Fixed Image module tests. Added many critical todos:
- Config values are not casted to strings (despite promised).
- Config keys are not casted to strings (although promised, too).
- XML can be invalid and not parse-able for many reasons.
- Config keys are not validated/sanitized.
- config()->clear() should really be ->unset().
- Configuration must not be additionally cached by a module in any way (static cache / database cache).
- Some modules invoke drupal_alter() on configuration (e.g., image styles).
- Need a way to list config object names/suffixes _after_ a specified prefix.
- Need a way to determine whether a config object exists.
- Some modules might have a valid use-case for retrieving/listing config objects using a wildcard within the name (instead of only searching by prefix).
- The key of a retrieved value is unknown; since you only get the value.  Configuration values (or sub-values) may be passed forward to another function/callback, and thus, that function no longer knows about the key of the value. (unless the key is contained in the value, which is a very very wonky duplication)
- Config keys must not contain periods (within a specific key).
2012-02-14 12:25:39 -08:00
sun 588cfd8be5 Fixed ImageDimensionsUnitTest. 2012-02-14 12:18:56 -08:00
Greg Dunlap 251697b6a3 Fixed broken function signature in image_effect_delete() 2012-02-13 16:48:42 -08:00
Greg Dunlap fbd6af0b1a Adding in changes to theme_image_style() that had somehow not gotten merged in from core previously 2012-02-13 16:45:19 -08:00
Greg Dunlap 85306e2ff1 Just removed the default style tests altogether. Default styles are no longer any different than custom styles 2012-02-13 19:31:39 -05:00
Greg Dunlap b92e4eac3d Removed tests that made sure we couldnt edit default styles without overriding (no longer applicable) 2012-02-13 19:29:51 -05:00
Greg Dunlap 495aef8fb1 Removed test that made sure we couldn't delete default image styles since that no longer applies 2012-02-13 19:28:29 -05:00
Greg Dunlap 6f1946a393 Cleaning up some notices and incorrect function signatures for tests 2012-02-13 19:18:14 -05:00
Greg Dunlap a8313cf422 Merge remote-tracking branch 'core/8.x' into 8.x-file-config 2012-02-12 11:24:16 -05:00
Dries 26bf1f5b64 - Patch #1159258 by Deciphered: fixed image_file_move() flushes new URI not source URI. 2012-02-05 08:59:33 -05:00
Greg Dunlap a5b4c2500a Merge from core for PSR-0 2012-01-25 21:01:35 +01:00
catch 2f0d691cb1 Issue #278425 by andypost, OnkelTem, chx, c960657, droplet et al: Fixed Using basename() is not locale safe. 2012-01-18 13:10:02 +09:00
catch 8a87e13ad5 Issue #1398740 by TravisCarden: Fixed Typo in status message: 'The %style has been revert to its defaults.' 2012-01-12 22:31:36 +09:00
catch 1878eb1534 Issue #1357918 by Gábor Hojtsy: Change language schema to refer to langcode. 2012-01-11 00:29:08 +09:00
sun e312880573 Fixed coding style, comments, and some trivial issues. 2012-01-08 02:29:22 +01:00
Greg Dunlap 0a64591815 Fixed rename of image styles so the old style actually disappears 2012-01-08 00:20:55 +01:00
Greg Dunlap 6f6703996a Fixing another merge issue, missing the change from define->const in image.module 2012-01-07 23:02:07 +01:00
Greg Dunlap cdc4bc1c64 Merging from core 2012-01-07 22:12:13 +01:00
Greg Dunlap 9875cf1a26 Added deleting of styles 2012-01-07 21:55:51 +01:00
Greg Dunlap dbd6ffc8f0 Changed delete() to clear() for more clarity 2012-01-07 20:33:55 +01:00
Greg Dunlap 333b09e7ba Added ability to delete image effects from a style 2012-01-07 16:36:41 +01:00
Greg Dunlap 83c9c95815 Fixed copy paste stupidity in when adding an effect with no configuration 2012-01-07 15:24:24 +01:00
Greg Dunlap b566a13233 Removed some more override/default functions 2012-01-07 15:16:19 +01:00
Greg Dunlap 2293ba6716 Removed some more override/default functions 2012-01-07 15:15:49 +01:00
Greg Dunlap cd58ba59d7 Refactored image_effect_save() to always take a the name of its image style 2012-01-07 15:15:26 +01:00
Greg Dunlap b76387f216 Saving image styles into an effect now working 2012-01-07 15:07:20 +01:00
Greg Dunlap cc50837569 Work in progress 2012-01-07 10:43:37 +01:00
Greg Dunlap 5ed90e0fcd Referring to wrong key in image_effect_save() was causing errors 2012-01-06 18:06:51 +01:00
Greg Dunlap a644a0ae58 Fixed mismatched tags 2012-01-06 18:06:00 +01:00
Greg Dunlap f4f99fb8c9 First shot at new effect saving 2012-01-06 18:05:49 +01:00
Greg Dunlap c020c7040a Changed the generated names to more proper machine-name-like things 2012-01-05 14:07:46 +01:00
Greg Dunlap 9d9a4a39bb Placeholder 2012-01-02 16:50:04 +01:00
Greg Dunlap 71e37598e3 Removed default storage from image_styles() since its not used anymore 2012-01-02 15:29:02 +01:00
Greg Dunlap f58babd65d Removed style name paramater from image_effect_definition_load(). Its only purpose was to check if a style was module-provided or not. 2012-01-02 14:43:20 +01:00
Greg Dunlap 87eeab7381 Removed revert callback since it no longer applies 2012-01-02 14:22:48 +01:00
Greg Dunlap 7f1db5526a Fixed duplicated checking to work on name instead of isid 2012-01-02 14:00:06 +01:00
Greg Dunlap 3e0afc9db6 Fixed a couple problems caused by uninitialized vars 2012-01-02 13:54:55 +01:00
Greg Dunlap 1aedb7da51 Fixed stray notice sometimes when viewing a style with no effects 2012-01-02 13:48:19 +01:00
Greg Dunlap 42be9566b9 Made image_style_save() use new config system 2012-01-02 12:13:15 +01:00
catch 98b1cdc3f8 Issue #1353030 by BTMash, jenlampton, theborg: Added Increase length of "alt" and "title" text for images. 2011-12-23 12:16:56 +09:00
catch a3ebad0633 Issue #1346032 by xjm, aspilicious: Fixed Ordering of hook_entity_delete() is inconsistent. 2011-12-17 21:43:37 +09:00
Dries 9c29ac79af - Patch #1059884 by bfroehle, sun, casey: Drop function_exists() for 'callback' functions. 2011-12-15 12:33:38 -05:00
Nathaniel 528a78d03c Issue #1015916 by BTMash, jenlampton, theborg, Aron Novak, christefano, realityloop, xjm, Kevin Hankens: Fixed Image field 'title' allows more data than database column size. 2011-12-13 12:21:08 +09:00
Greg Dunlap 93f5bba083 Got image effect editing working 2011-12-12 16:14:01 +01:00
Greg Dunlap cc2e098366 Adding ieid (aka fake machine name) to the default config files. We need them there for saving later (see next commit) 2011-12-12 15:49:42 +01:00
Greg Dunlap 1c7f323769 Fixed improperly keyed effect array 2011-12-12 15:26:23 +01:00
Greg Dunlap 0ebaba20fa Fixing image_styles() to match new xml format 2011-12-12 15:15:16 +01:00
Greg Dunlap 1dcc2a16c6 Fixed mismatched tag 2011-12-12 14:08:02 +01:00
Greg Dunlap ea2c8fcf4a Fixed mismatched tag 2011-12-12 14:07:04 +01:00
Greg Dunlap f82d8b0010 Modified image style XML 2011-12-07 11:51:53 +01:00
Greg Dunlap 4272029053 updated image_effect_load() 2011-12-03 16:12:44 +01:00
Greg Dunlap 3510b99e6a Got styles overview working 2011-12-03 16:06:48 +01:00
Greg Dunlap b035fb4f46 Massively simplified image_style_load() since and no longer apply 2011-12-02 16:18:24 +01:00
Greg Dunlap a803505f4a Starting to work through image style edit form 2011-12-02 16:06:52 +01:00
Greg Dunlap aea01c1c9d Removed image_image_default_styles() which will no longer be used 2011-12-02 15:19:07 +01:00
Greg Dunlap 794e62f999 Removed 'Settings' column from image style listing since we don't use it anymore 2011-12-02 15:12:20 +01:00
Greg Dunlap f480afe9f4 Starting to convert image styles to CMI. Ported image_styles() function 2011-12-02 14:45:45 +01:00
Nathaniel 23e7a3cf40 Issue #1338428 by jbrown, BTMash, Tor Arne Thune: Fixed image_dimensions_scale() and image_scale_effect() are ungrokable and buggy. 2011-12-01 16:59:16 +09:00
Greg Dunlap 9032509c26 Merge from corepocalypse 2011-11-30 11:46:45 +01:00
catch efe0a73b29 Issue #334024 by klausi, catch, beejeebus, sun: Use const keyword to define constants instead of define(). 2011-11-29 18:56:53 +09:00
Nathaniel 1b4dfed494 Issue #1025796 by jthorson, Rob Loach, tim.plunkett, alex_ustinov: Fixed Rename path to uri in image functions. 2011-11-25 12:09:40 +09:00
Nathan Haug f434037c0e Issue #22336 by quicksketch, scor, boombatower, and rfay. Move all core Drupal files under a core subdirectory. 2011-11-01 12:48:40 +09:00
Nathan Haug 06fb770bd3 Issue #22336 by quicksketch, scor, boombatower, and rfay. Move all core Drupal files under a core subdirectory. 2011-11-01 12:48:40 +09:00
Nathaniel 906a6db347 Revert "Issue #22336 by quicksketch, rfay, scor, Rob Loach, boombatower, tstoeckler, kbahey: Move all core Drupal files under a /core folder to improve usability and upgrades."
This reverts commit f0a16bf2a4.
2011-11-01 12:32:15 +09:00
Nathaniel f0a16bf2a4 Issue #22336 by quicksketch, rfay, scor, Rob Loach, boombatower, tstoeckler, kbahey: Move all core Drupal files under a /core folder to improve usability and upgrades. 2011-11-01 12:25:12 +09:00