Commit Graph

780 Commits (f3d419b74e72604279b0ad2a0b30ce505728f01b)

Author SHA1 Message Date
Dries Buytaert eee72bfa95 - Patch 4859: new drupal_unpack() consolidates duplicate code and makes it
easy to show avatars next to nodes and comments.  Patch by Moshe.  As a
  showcase, maybe Xtemplate should have an option to enable/disable avatars?
2004-01-13 19:25:37 +00:00
Kjartan Mannes 75685d8c3d - Fixing bug #5091: Inconsistent download method defaults. 2004-01-13 10:33:02 +00:00
Dries Buytaert 5fa33b2962 - Made l() add 'class="active"' to the active/current URL. 2004-01-12 22:53:43 +00:00
Dries Buytaert a8b8c247db - Patch #5021: clean up URLs in _help texts. Patch by UnConeD. 2004-01-11 20:31:26 +00:00
Dries Buytaert 6f80df7762 - Fixed bug 4745: undefined warning in sess_read(). 2004-01-11 20:03:36 +00:00
Dries Buytaert ee305ae144 Round 3 of aggregator improvements:
- Added support for new tags:
   + Optinal feed image: <image> tag.
   + Dublin core dates: <dc:date> <dcterms:created>, <dcterms:issued>,
     <dcterms:modified>.
 - Usability improvements:
   + On the administration page, made the feed/bundle titles link
     to the feeds/bundles' pages.  On the feed/bundle's page, made
     the 'Last updated' field link to the administration page.
   + Moved the 'syndication' menu one level down.
 - Updated some content sensitive help.
 - Further improved themeability.
 - Fixed some invalid HTML.
2004-01-11 15:05:21 +00:00
Steven Wittens f78cb9932b - Fixed ability to override default HTTP headers in drupal_http_request().
- Fixed issue with drupal_get_path_alias(): should return false for non-aliased URLs.
2004-01-07 20:43:26 +00:00
Dries Buytaert 94f6e94ffd - Many excellent news aggregator improvements by Kjartan:
+ Added drupal_http_request().
    + Replaced rssfeeds with OPML feed subscription list.
    + Added support for pubDate.
    + Added support for conditional gets using ETag and Last-Modified.
2004-01-07 19:52:10 +00:00
Dries Buytaert 56a637fefa - Fixed bug #5004: missing <title>-tag in the example theme. 2004-01-07 18:42:02 +00:00
Kjartan Mannes 0d7e205062 - New and updated doxygen comments. 2004-01-06 19:52:14 +00:00
Steven Wittens b817bdb302 - Improved XML encoding fix. There is now a function drupal_xml_parser_create():
/**
 * Wrapper around xml_parser_create() which extracts the encoding from the XML
 * data first and sets the output encoding to UTF-8. This function should be
 * used instead of xml_parser_create(), because PHP's XML parser doesn't check
 * the input encoding itself.
 *
 * This is also where unsupported encodings should be converted.
 * Callers should take this into account: $data might have been changed after
 * the call.
 *
 * @param $data The XML data which will be parsed later.
 */
2004-01-06 12:09:42 +00:00
Steven Wittens c2151b5248 Committed filter separation patch: all filter-related things are now in filter.module (which is a required module).
To do this cleanly, I reorganised some bits of system.module: there is now a generic handler available for simple variable-get/set based configuration pages. Look at filter_admin() or system_view() for example usage.

(based on the patch by Goba)
2004-01-05 19:19:05 +00:00
Dries Buytaert daaeef0e8c - Partial patch #4927: mass URL aliasing by Goba. 2004-01-05 18:23:21 +00:00
Kjartan Mannes 6387508d23 - Fixing doxygen comment. 2004-01-02 23:12:44 +00:00
Dries Buytaert f6082cda98 - Fixed bug 4916: users can have disabled themes. Modified patch by Mathias.
1. Remove the theme object.  There is no need to keep it around since meta
      information for a theme can be retrieved via list_themes().  All we really
      need is the theme name.

   2. Check if the user selected theme is enabled during theme initialization.
      This is the easiest place to put the check and doesn't mess with the user's
      settings.  Their database profile will still contain the disabled theme
      selection, but they will be rendering the default admin-selected theme
      until their chosen theme is once again activated.
2004-01-02 16:24:28 +00:00
Dries Buytaert 604064b523 - Patch #4858: search module did not remember the search filter. Patch by
Kjartan.
2004-01-02 12:15:37 +00:00
Dries Buytaert e8c7d2e092 - Made it possible to set and display multiple status messages. Modified patch by
Kjartan.
2003-12-30 12:10:51 +00:00
Dries Buytaert 21a0e8b904 - Updated code to use new semantics of url() and l(). 2003-12-29 19:49:11 +00:00
Dries Buytaert be2f405818 - Added $fragment identifier to url() and l(). Patch by Goba. 2003-12-29 19:10:26 +00:00
Dries Buytaert 059e5cca08 - Fixed a weird typo introduced by the <b> -> <strong> patches and indented
the code a bit better.
2003-12-29 17:47:12 +00:00
Dries Buytaert 0fc11d5719 - Fixed typo introduced by the <b> -> <strong> patches. This might need a better
fix.
2003-12-29 17:42:43 +00:00
Dries Buytaert 80f34e5ab0 - XHTML improvements: <b> -> <strong>. Patch by Stefan. 2003-12-29 17:14:27 +00:00
Dries Buytaert 41d28852f3 - Fixed glitch with form_radio(). Reported by Kjartan. 2003-12-29 12:44:30 +00:00
Dries Buytaert 81b21bc068 - Removed the ID from radio buttons: we'll need to rethink this a bit. 2003-12-29 11:16:45 +00:00
Dries Buytaert 9eba2ac77f - Removed the id= from checkboxes: it is acting weird in some cases. :oI 2003-12-28 00:13:22 +00:00
Kjartan Mannes 2639c1d42f - Improved Doxygen documentation. 2003-12-27 21:29:20 +00:00
Kjartan Mannes 41d2b2a349 - Fixed fileuploads for nodes failing without preview. 2003-12-27 19:21:48 +00:00
Kjartan Mannes 46f8f14322 - Fixed switch in file_create_url().
- Fixed profile module not extracting mime type.
- Improved file matching in profile module.
2003-12-27 14:28:23 +00:00
Dries Buytaert 15f289a8f0 - Added file handling. Work by Kjartan. 2003-12-26 23:03:21 +00:00
Dries Buytaert fb45b6b7df - Removed the ID from radio buttons for now: duplicate IDs confuse the browser. 2003-12-26 14:52:29 +00:00
Dries Buytaert 01f252ab7d - Refactored form_radios() such that less HTML code is emitted and such that
the options are not rendered in bold.
2003-12-24 12:40:28 +00:00
Dries Buytaert 2dcb890477 - Fixed bug #4771: variable_get(site_name, ...) -> variable_get('site_name', ...); 2003-12-22 22:54:59 +00:00
Dries Buytaert 7883ea6e1e - Accessibility improvement: changed a <b>-tag to a <strong>-tag, used to
indicated the current page.
2003-12-22 17:30:43 +00:00
Dries Buytaert 770174b299 - Updated documentation, small bug fix and small improvements to the <label>
tags.

  To be discussed and investigated: when a form element has no title an empty
  <label> tag will be emitted (eg. "remember me" checkbox).  This doesn't make
  sense but is our best option for now.
2003-12-22 15:38:07 +00:00
Dries Buytaert 0439e3495c - Fixed password field. 2003-12-22 15:06:46 +00:00
Dries Buytaert 54a74abaa3 - Accessibility improvements: made the <label>-tags use the 'for'-attribute. 2003-12-22 14:45:00 +00:00
Kjartan Mannes c96a130e36 - Getting the fix rght. 2003-12-19 13:44:08 +00:00
Kjartan Mannes 81565fda5d - Fixing magic_gpc fix. 2003-12-19 10:52:37 +00:00
Dries Buytaert 23c7a4aa5d - Fixed bug 4703: don't display the help text when the user has no access
rights for a page.  That is, only return the help text if an active
  handler exists.
2003-12-18 21:13:17 +00:00
Kjartan Mannes 3d9e2f2c76 - Fixing wrong superglobal usage. 2003-12-18 13:58:59 +00:00
Dries Buytaert 09b660a608 - Small update 2003-12-18 08:18:06 +00:00
Dries Buytaert aa2f6162b2 - Fixed typo: $outpout -> $output. Fixed bug 4690. 2003-12-18 05:54:59 +00:00
Dries Buytaert 928c113b82 Patch by Kjartan:
- Adds possibility to hide menu item when it has no children. (Fixes the
    node/add problem when user doesn't have access to create any node
    types.)
  - More doxygen comments.
2003-12-17 22:15:35 +00:00
Kjartan Mannes 3e3f397202 - Type in comment block. 2003-12-16 21:18:51 +00:00
Dries Buytaert 670a292277 - Reworked 404 (page not found) handling. Patch by walkah. You can specify a
custom 404 page in the administration page.  As a result, error.php could be
  removed.
2003-12-16 21:06:34 +00:00
Dries Buytaert f229a8c04c - Patch 161 by Gordon: adds new form_button() function with a more generic version
of form_submit() which allows the creation of HTML buttons.
2003-12-15 19:58:53 +00:00
Dries Buytaert 67fe17164a - Bugfix: removed incorrect print statements from theme.inc. 2003-12-13 17:52:50 +00:00
Dries Buytaert 4d54978a4b - Small change to the default theme. 2003-12-13 17:46:44 +00:00
Dries Buytaert 009b1afe5c Patch by Kjartan:
+ Simplified cache logic in drupal_get_path_map().
 + Added check to see if errors should be reported to error_handler().
 + Use proper db_query() syntax in throttle(), and use $_ENV instead of
   getenv().
 + Changed fix_gpc_magic() to use array_walk (C functions will always be
   faster), and renamed _fix_gpc_magic_array() to _fix_gpc_magic().
 + Renamed $node in array2object() to $array.
 + Renamed $node in object2array() to $object.
 + Minor other coding method tweaks.
2003-12-13 14:59:55 +00:00
Dries Buytaert af69e63653 - Patch by Kjartan:
+ Changed drupal_page_header(): converts the If-Modified-Since header into a
    timestamp and compares against the cache data.  Ignore If-Modified-Since
    and ETag headers if they are present but empty.

  + Few minor other code cleanups.
2003-12-13 14:10:23 +00:00
Dries Buytaert 1c0155bc9d - Fixed race condition in session handler. Patch by Kjartan. 2003-12-13 13:00:47 +00:00
Dries Buytaert f153bcb9bb - Simplified the way the 'real path' is resolved. 2003-12-12 19:44:57 +00:00
Dries Buytaert 53167d2e51 - Small improvement to make request_uri() work on multiple platforms. 2003-12-11 21:28:49 +00:00
Dries Buytaert b1ef96931a - Moved the watchdog() function to the bootsrap file. Patch by Moshe. 2003-12-10 23:09:31 +00:00
Kjartan Mannes 84c7e91a2d - Fixed <title> extraction deleting body.
- Fixed metaWeblog/Blogger incompatibilities in blogger.editPost and
  blogger.getRecentPosts.
- Fixed coding style deviations.
- Fixed access checks, now requires maintain personal blog.
- Fixed taxonomy integration.
- Fixed blogger.getUserInfo
- Improved user login/access error messages.
2003-12-09 23:38:32 +00:00
Dries Buytaert 712a30b520 - Improvements by Goba:
+ removes the lots of pagers and indirect pager themeing
  + add the theme_pager() function, which should be called as
    theme("pager", ...) to get a pager.
2003-12-08 18:30:20 +00:00
Dries Buytaert 3904790e03 - Tidied up the DoxyGen comments. Patch by Kjartan. 2003-12-08 06:32:19 +00:00
Dries Buytaert bea3dbb775 - Patch 0185 by Jeremy: made it possible to automatically disable modules when
under heave load.
2003-12-07 18:25:09 +00:00
Dries Buytaert d45bf0f1e7 - Patch 185 by Ax: fixed undefined variables, synchronized xtemplate with sf, etc. 2003-12-04 20:53:19 +00:00
Dries Buytaert 4e2c0b250e - Introduced a drupal_set_message() and drupal_get_message() function.
Contributed themes and modules need to be updated:
   - modules: status() is no more; use drupal_set_message() instead.
   - themes: use drupal_get_message() to check for status messages and
     visualize them.
2003-12-01 13:45:33 +00:00
Dries Buytaert 733d286b89 - Made it possible to auto-throttle blocks. That is, blocks can be
configured to be disabled when under excessive load.  Patch by Jeremy.
2003-11-28 20:03:00 +00:00
Dries Buytaert 8f00019551 - Renamed 'Content-length' to 'Content-Length. Fixes bug #4323 2003-11-28 11:41:11 +00:00
Dries Buytaert 70fe2520bc Fixed typo. Patch by Manuel. 2003-11-27 13:31:13 +00:00
Dries Buytaert b55975d61c - Doxygen improvements. Patch by Ax. 2003-11-26 16:17:13 +00:00
Dries Buytaert c0494c0a2b - Committed phase 4 of JonBob's menu system changes. 2003-11-25 19:26:21 +00:00
Dries Buytaert 2df7214a09 - Rollbacked Ax's theme.inc changes as they failed to apply correctly. 2003-11-24 22:54:49 +00:00
Dries Buytaert 06045ff7fc Patch by Ax to fixe and improve to the core doxygen PHPdoc:
* fixes all doxygen warnings [#]_ in the current code base
    + changes @param style from phpDocumentor (@param type $var desc) to doxygen (@param $var desc)
    + documents all undocumented parameters
    + escapes / fixes html warnings
    + fixes @defgroup in theme.inc
  * adds more groupings [#]_
    + drupal_{set|get}_title, drupal_{set|get}_breadcrumb
    + pager.inc: pager_api (pager_query(), pager_display()), pager pieces
  * adds a new group "themeable" which contains all themeable functions.
2003-11-24 22:46:03 +00:00
Dries Buytaert af5bc7cdef - Made the Xtemplate theme degrade gracefully when CSS is disabled. 2003-11-24 22:39:48 +00:00
Dries Buytaert 26735ac5dd - Committed phase 3 of JonBob's menu changes. Adds an API for modules to
define titles and breadcrumbs for their pages, and updates the theme
  system to display them.
2003-11-23 10:41:04 +00:00
Dries Buytaert e4d791fe0d - Menu fix by Jonathan. 2003-11-21 19:08:46 +00:00
Dries Buytaert 980637265c - Block and theme improvements. Patch by Ax.
+ block_list() (in block.module): returns an array of block objects for
     $region.
   + theme_blocks() (in theme.inc): uses block_list() and theme("block") to
     actually render them.

  Advantages:
   + Decouples blocks content and layout, allows block_list() to be used
     for non-output purposes (think "pull").
   + Unifies naming in theme.inc: render_blocks()) didn't really fit there.
   + Puts block_list() in blocks.module where it logically belongs.

- Removed some cruft from the Xtemplate theme.  Patch by Ax.
2003-11-19 16:13:07 +00:00
Kjartan Mannes 2ffa04f5f2 - Fixes bug #4100: First visit to site results in 'access denied' page.
- Fixed sess_write().
- Removed dead code in index.php.
2003-11-18 23:37:48 +00:00
Dries Buytaert a0640e66b7 - Improved module loading when serving cached pages. Moshe's bootstrap patch.
- Used legend and fieldset tags for the configuration page.
2003-11-18 19:44:36 +00:00
Dries Buytaert 7a2514e789 - Small improvement to the default style emitted by theme_form_element(). 2003-11-17 19:24:39 +00:00
Dries Buytaert fff2f548ac - Improved form items: added <label> tags to improve accessibility and added
theme_form_element() function to improve themeability.  I left form_item()
  and the calls to form_item() intact for now.
2003-11-17 19:16:55 +00:00
Dries Buytaert 36bb57555c - table(...) -> theme("table", ...) 2003-11-13 19:52:54 +00:00
Kjartan Mannes 22d3f6bd06 - Spell checked the comments. 2003-11-10 09:49:05 +00:00
Dries Buytaert 36da307e45 - Improvement: made sure that the example theme uses the misc/drupal.css stylesheet. 2003-11-10 09:03:53 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert 00ee7f747b - Removed the "return" link from the node submission confirmation page. 2003-11-09 17:25:11 +00:00
Dries Buytaert c79eb8c990 - Bugfix: made theme_footer() call theme_closure() instead of itself. Patch by Bart. 2003-11-09 17:11:26 +00:00
Dries Buytaert 1f273dac01 - Committed stage 1 of the theme system improvements.
Some TODO's:
   * The sidebars of theme Marvin and theme UnConeD look unstyled.
   * CSS-ify theme UnConeD so we can remove the class around the functions.
   * Rewrite theme_init() not to use a class and simplify theme()
     accordingly.
2003-11-08 11:56:33 +00:00
Dries Buytaert 92995414b4 - Committed stage 1 of the menu callbacks improvements. Patch by Jonathan. 2003-11-08 09:56:22 +00:00
Dries Buytaert 00d638ca57 - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.

- Usability improvement: introduced a form_group() function and updated
  the node and comment module to take advantage of it.  Patch #149 by
  Eric Farris.
2003-11-06 18:27:58 +00:00
Dries Buytaert ed774ccdee - Improvement: better HTML/CSS for the example theme. Patch by Adrian Simons. 2003-11-04 19:05:14 +00:00
Dries Buytaert ec33266795 - Improvement: made it possible to disable the comment controls and reworded some of the configuration settings.
- Improvement: removed a left-over from Drupal 4.2.0 (dead code).

- Improvement: replaced hard-coded XHTML around the XML icons with class="xml-icon".

- Improvement: removed the custom navigation menus shown at the top of the "user information page" and integrated them in the new navigation block.  The "my account" link in the navigation menu will unfold.  Also removed the "delete account" link/functionality (for now).

- Improvement: fix for "magic quotes" settings.  Patch by Steven.  I also removed check_php_settings().

- Improvement: block themability improvements.  Modified patch from Ax and Steve/CodeMonkeyX.

- Fixed bug #2617: editing user information does not work.  Patch by Kjartan.
2003-10-31 19:34:03 +00:00
Kjartan Mannes fa37f47d0b - Fixing typo that Dries didn't notice I told him about. 2003-10-27 21:50:16 +00:00
Dries Buytaert 7b0ddafc38 - Bugfix: fixed SQL errors with tablesort when 'order' is invalid.
Patch by Kjartan.  Fixes bug #2613.
2003-10-27 21:45:55 +00:00
Dries Buytaert 72ae2d3995 - Bugfix: renamed the 'statistics' table to 'node_counter' as 'statistics' is
a reserved SQL keyword.  Required for both PostgreSQL and MSSQL.  Patch by
  Adrian.

- Bugfix: renamed the 'path' table to 'url_alias' as 'path' is a reserved SQL
  keyword.  Required for both PostgreSQL and MSSQL.  Patch by Adrian.
2003-10-22 20:20:35 +00:00
Dries Buytaert 742410aafd - Bugfix: prefix not prepended to sequences. Fixes bug #3639.
Make sure to write:

    db_next_id({table}_field);

  instead of:

    db_next_id(table_field);
2003-10-22 13:03:32 +00:00
Dries Buytaert 6958037da6 - Bugfix: made the "Default front page" setting work with URL aliases. Patch
by Matt.
2003-10-20 07:47:18 +00:00
Dries Buytaert 17e92817c5 - Bugfix: added missing . which stopped the Example theme's DOCTYPE from being
emitted.  Reported by Robert Castelo.
2003-10-19 20:38:58 +00:00
Dries Buytaert 880842885b - Fixed bug #3637: made comment module settings translatable. Patch #13 by Moshe.
- Fixed bug #3642: removed duplicate settings from user page.  Patch #14 by Moshe.

- Fixed bug #3503: added 'forum topic' link to the 'create content' menu.  Patch
  by Gobar.  I think this might be more intuitive and consistent code-wise; I don't
  want to introduce small hacks.

- Cache improvement: small cache improvement to prevent SQL errors.  Patch by
  Jeremy.
2003-10-16 17:29:26 +00:00
Dries Buytaert 53f538fe1d - Usability improvement: improved consistency and themability of the search form. 2003-10-15 15:12:50 +00:00
Dries Buytaert 9fdd894105 - Replaced some dead wood. 2003-10-14 21:56:41 +00:00
Dries Buytaert 5d684e108e - Bugfix: stopped the menu system from generating empty lists (<ul></ul>). Patch
by Nick (CodeMonkeyX).

- Bugfix: anonymous users could not change comment settings.  Patch by Bart.

- Bugfix: the comment control form always showed "order by date - newest first",
  no matter what order you selected.  Patch by Bart.

- Small usability improvement: only display comment controls when there are
  comments to show.  Patch by Bart.
2003-10-14 18:08:33 +00:00
Dries Buytaert 162ca6eb98 - Bugfix: the search result type names (node, user, comment) were not
translatable in the search page output.  Patch by Gabor.
2003-10-13 21:28:05 +00:00
Dries Buytaert e688dfe6db - Fixed prefix problem with the book module. Patch by Moshe.
- Usability improvements to the user module: removed some redundant menu
  items by taking advantage of the column sorting, added status messages
  and so on.  Patch by Moshe plus some fixes.

- Made the profile module use the table() function.  Patch by Moshe.

- Fixed breadcrumb spacing.  Patch by Moshe.

- Fixed colspan problem with node overview table.  Patch by Stefan.

- Fixed inconsistency with table sorting.  Patch 0122 by Al.
2003-10-13 19:18:39 +00:00
Dries Buytaert 0f44d7d6cd - Committed part 3 of Michael's help system improvements: removed the $help
parameter from the menu() function.
2003-10-09 19:24:09 +00:00
Dries Buytaert 9285275387 - Small code improvement 2003-10-09 18:51:15 +00:00