Commit Graph

293 Commits (e8fdcb2c3b5bd12accdee05cc6af404de27f3eb7)

Author SHA1 Message Date
Dries Buytaert a7f12c0326 - Patch #251263 by catch: fixing up many code style issues in the tests. 2008-04-25 18:26:02 +00:00
Dries Buytaert af474609e3 - Added a test framework to Drupal along with a first batch of tests for
Drupal core!  This is an important milestone for the project so enable
  the module and check it out ... :)

  Thanks to Rok Žlender, Károly Négyesi, Jimmy Berry, Kevin Bridges, Charlie
  Gordon, Douglas Hubler, Miglius Alaburda, Andy Kirkham, Dimitri13, Kieran
  Lal, Moshe Weitzman, and the many other people that helped with testing
  over the past years and that drove this home.

  It all works but it is still rough around the edges (i.e. documentation
  is still being written, the coding style is not 100% yet, a number of
  tests still fail) but we spent the entire weekend working on it in Paris
  and made a ton of progress.  The best way to help and to get up to speed,
  is to start writing and contributing some tests ... as well as fixing
  some of the failures.

  For those willing to help with improving the test framework, here are
  some next steps and issues to resolve:

    - How to best approach unit tests and mock functions?
    - How to test drupal_mail() and drupal_http_request()?
    - How to improve the admin UI so we have a nice progress bar?
    - How best to do code coverage?
    - See http://g.d.o/node/10099 for more ...
2008-04-20 18:24:07 +00:00
Dries Buytaert 56d2664a90 - Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators. 2008-04-14 17:48:46 +00:00
Dries Buytaert 79b016d915 - Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php.  The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:

    block-user-0.tpl.php --> block-user-navigation.tpl.php
    block-user-1.tpl.php --> block-user-login.tpl.php

  You get the picture.
2008-04-10 10:28:23 +00:00
Dries Buytaert f5d4287cd5 - Patch #214271 by recidive: improved schema identation. 2008-03-15 12:31:29 +00:00
Dries Buytaert 584f3e886a - Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page. 2008-02-20 13:46:43 +00:00
Dries Buytaert b05db1f176 - Patch #221384 by webernet: update core compatibility to Drupal 7. 2008-02-18 19:19:49 +00:00
Gábor Hojtsy f5a85afc2e #211053 by momendo: poll submission and editing field columns fixed 2008-01-22 07:47:57 +00:00
Dries Buytaert c08e279859 - Patch #209236 by traxer: added a validation function for the poll form. 2008-01-15 07:57:46 +00:00
Gábor Hojtsy 33f455d2df #153998 by David_Rothstein and myself: clean up permissions in book, blog, blogapi, forum and locale modules 2008-01-09 09:51:35 +00:00
Dries Buytaert 52f95c981b - Patch #202078 by chx: fixed poll AHAH problem with caching. 2008-01-04 08:04:45 +00:00
Gábor Hojtsy 195fe364d2 #203582 by David_Rothstein: some core hook_access() implementations are not using the passed in account 2008-01-01 17:46:30 +00:00
Gábor Hojtsy 07d32d0521 #204996 by chx: poll bar theme gets NULL as default, so use that here as well 2007-12-31 12:28:32 +00:00
Dries Buytaert f04d4d17dd - Patch #204996 by chx: fixed access check and warning in poll module. 2007-12-31 08:48:41 +00:00
Dries Buytaert c8b1ddf26a - Patch #164532 by catch, pwolanin, David Strauss, et al.: improve table indicies for common queries. 2007-12-18 12:59:22 +00:00
Gábor Hojtsy cf790b5a09 #67895 patch by myself, tested by JirkaRybka and blackdog: move poll votes with poll options, when an option is removed, instead of dropping all old votes, solving an old data loss bug 2007-12-17 21:58:38 +00:00
Gábor Hojtsy b6532a4fdb #200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed 2007-12-14 18:08:50 +00:00
Gábor Hojtsy 723c490089 Although #64388 is not applicable here, a db_rewrite_sql() was missing from the counter query on the poll page, so fixed that 2007-12-14 09:50:41 +00:00
Gábor Hojtsy ef5fd34577 #189025 by AjK: fix two small E_ALL bugs in poll.module 2007-12-14 09:24:08 +00:00
Gábor Hojtsy c6d841c096 #197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc 2007-12-13 09:34:40 +00:00
Gábor Hojtsy 5622bce2d5 #198579 by webernet and hswong3i: a huge set of coding style fixes, including:
- whitespaces at end of lines
 - indentation
 - control structure usage
 - whitespace in empty lines
 - phpdoc comment formatting
2007-12-08 14:06:23 +00:00
Gábor Hojtsy d83289f857 #196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions 2007-12-06 09:58:34 +00:00
Dries Buytaert 7a47bef514 - Patch #162381 by Heine et al: properly escape strings. 2007-11-28 10:29:21 +00:00
Dries Buytaert 9a96837b89 - Patch #163246 by keith smith, freso, O Govinda, catch, webchick et al: fixed minor spelling issues and fixed spacing issues. 2007-11-26 16:36:44 +00:00
Gábor Hojtsy a960d4d618 #120960 by blakehall, JirkaRybka, catch: improve usability of content editing permission names 2007-11-26 11:44:04 +00:00
Gábor Hojtsy 73d88aa929 #189009 by AjK: edit own poll permission was missing from poll module (although available for other content types) 2007-11-05 16:28:25 +00:00
Dries Buytaert 1cf05b0019 - Patch #89196 by catch, keith, earnie, webchick et al: string massaging. 2007-10-25 15:32:56 +00:00
Gábor Hojtsy 2cc43fffd4 #184198 by Eaton: move button title change in polls to the theme, so it does not interfere with the cached form 2007-10-22 09:25:33 +00:00
Gábor Hojtsy b94f2716cf #184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed 2007-10-21 18:59:02 +00:00
Gábor Hojtsy b64adf07c8 #182645 by scor: clean up concatenations to be in line with core coding standards 2007-10-19 10:19:03 +00:00
Gábor Hojtsy ba5fce22ca #184199 by quicksketch: proper weights for poll form fields, so the fields are not reordered 2007-10-17 19:36:12 +00:00
Dries Buytaert a745b0f68b - Patch #155870 by quicksketch et al: AHAH-ification of the poll module. 2007-10-17 12:34:16 +00:00
Dries Buytaert b274bf87f3 - Patch #182950: fieldset massaging for usability. 2007-10-12 14:10:18 +00:00
Gábor Hojtsy 0ada4f136a #72487 by chx, pwolanin and moshe weitzman: let node_access() work on arbitrary users, so independent user access checks can be done in a request 2007-10-11 16:37:43 +00:00
Gábor Hojtsy 8cf6fefe54 #164983 by multiple contributors: document the core database schemas 2007-10-10 11:39:35 +00:00
Dries Buytaert 39706e3c51 - Patch #150245 by webchick, bjaspan, ralf, Arancaytar et al: move the .schema files into .install files to prevent mistakes. 2007-10-05 14:43:26 +00:00
Gábor Hojtsy e3ad7751a3 #172642 by dvessel: block theme file name suggestion for poll nodes 2007-09-06 12:18:01 +00:00
Dries Buytaert e0c1342316 - Patch #172836 by Crell: split poll module. 2007-09-05 08:33:16 +00:00
Gábor Hojtsy c84d7a5071 #170677 by chx: roll back poll data loading to the load operation 2007-08-30 17:01:42 +00:00
Dries Buytaert 5e73b66f3a - Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches. 2007-08-26 07:46:11 +00:00
Gábor Hojtsy 801756e7e6 #111127 by chx: cache node_load(), so heavy operations loading data from external sources and only invoked once (note that you should do everything dynamic in the view op, not the load op) 2007-08-25 09:25:49 +00:00
Gábor Hojtsy 323fa356bd #110511 by bjaspan: poll listing page should have a 'count_sql' because the original query uses group by, so it is not countable properly 2007-08-09 10:37:41 +00:00
Gábor Hojtsy f23c24c8a3 #164935 by Ralf Stamm: standardize CVS Id tags in files:
- always include CVS Id tags in all files
 - add a new line after the CVS Id, if more code or phpdoc follows in the same code block
 - fix bogus Id tags previously added
2007-08-07 08:39:36 +00:00
Dries Buytaert c70b19a91b - Patch #163723 by Eaton and Frando: fix default page.tpl markup (and removed some whitespace). 2007-08-02 20:08:53 +00:00
Dries Buytaert d31f65a93c - Patch #162871 by merlinofchaos: poll module cleanup + tplified the module. 2007-08-02 10:46:53 +00:00
Dries Buytaert e59852d336 - Rollback of patch #147723: delete API. Talked to Steven and Gabor and we
unanimously agreed to rollback the deletion API.  We all support the
  features this patch added, yet not its actual design and implementation.
  After some talk, we decided that it would be better for Drupal -- in the
  long term -- not to go with a solution that isn't 100%. We also recognize
  that in the short term, this patch would have been useful addition. So
  let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Gábor Hojtsy 9e6ef53c2c #154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array 2007-06-30 19:46:58 +00:00
Steven Wittens 38a1300df2 #147723: Deletion API (by hunmonk). Woop woop. 2007-06-22 05:44:21 +00:00
Dries Buytaert 29eb5a6284 - Patch #146910 by dww: only allow enabling modules with the same Drupal core compatibility version. 2007-06-08 05:50:58 +00:00
Dries Buytaert 1fe90cba4f - Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments 2007-06-04 07:22:23 +00:00