Commit Graph

207 Commits (e601933f6fbfc2302fc6287bf5a9db16e46ea68c)

Author SHA1 Message Date
webchick 5e4fb4fcd5 Issue #2154589 by Wim Leers: Edit breaks when the entity title is promoted to the page title (discovered by backporting). 2013-12-19 10:22:19 -08:00
Dries ebad0cd942 Issue #2075185 by Wim Leers: When an entity is in-place edited (i.e. saved), other instances of that entity on the same page are not updated (no propagation). 2013-12-18 14:41:13 -05:00
Nathaniel Catchpole a6cdd740f8 Issue #1954892 by dawehner, David_Rothstein, tim.plunkett: Replace 'theme callback' and hook_custom_theme() with a clean theme negotiation system. 2013-12-17 11:03:15 +00:00
webchick c5ec897acf Issue #2055937 by Wim Leers, jessebeach: Introduce error handling to in-place editing; if an AJAX request to commit changes fails, the user cannot recover. 2013-12-13 23:19:04 -08:00
Alex Pott dd663c405e Issue #2031725 by fgm, fago, vladan.me, Nebel54, Berdir: Move all entity display interfaces to the core component. 2013-12-12 23:34:44 +00:00
webchick a5bff94dc6 Issue #2149933 by nod_: Improve Edit module JS to use .find(...) instead of .is(':has(...)'). 2013-12-10 23:03:58 -08:00
webchick b8288cf90a Revert "Issue #2149933 by effulgentsia: Improve Edit module JS to use .find(...) instead of .is(':has(...)')."
Wrong commit credit.

This reverts commit af335ce5c7.
2013-12-10 23:03:36 -08:00
webchick af335ce5c7 Issue #2149933 by effulgentsia: Improve Edit module JS to use .find(...) instead of .is(':has(...)'). 2013-12-10 23:03:17 -08:00
webchick 46f4289e8a Issue #2137005 by jessebeach: Don't hide comments during in-place editing of an Article; position the entity toolbar more intelligently. 2013-12-10 23:00:36 -08:00
Dries 258b9a310c Issue #2149599 by Wim Leers: Fix minor bugs and minor coding standards violations in edit.module, discovered by backporting. 2013-12-10 17:01:45 -05:00
Dries 7d36579df3 Issue #2133889 by Wim Leers: Clean up Edit: rename EditorDecorationView to FieldDecorationView. 2013-12-10 17:00:13 -05:00
Dries 1069bef402 Issue #2141055 by Wim Leers: When multiple instances of the same entity on one page, only the first can be edited. 2013-12-10 16:54:38 -05:00
Nathaniel Catchpole 77dec69a5a Issue #2148797 by Gábor Hojtsy, yched, effulgentsia: field_language() always NULL for non-configurable fields (=> in-place editing of node title fails). 2013-12-10 13:56:39 +00:00
Alex Pott 560e5afd66 Issue #2145007 by tim.plunkett, h3rj4n: Convert form_set_error() in FormBase classes to use FormErrorInterface. 2013-12-10 00:45:01 +00:00
Alex Pott cdac25ee08 Issue #2143263 by plopesc | yched: Remove "Field" prefix from FieldDefinitionInterface methods. 2013-12-09 19:19:58 -04:00
Nathaniel Catchpole e8c263c4a5 Issue #2112239 by amateescu: Convert base field and property definitions. 2013-12-06 10:56:29 +00:00
webchick 8e7a2905ef Issue #2135689 by Wim Leers: Clean up edit.module to match coding standards. 2013-12-03 21:18:34 -08:00
Jennifer Hodgdon 80fbd33d97 Issue #2145077 by TR, longwave: Fix about a zillion spelling errors, mostly in comments 2013-12-03 07:54:20 -08:00
Nathaniel Catchpole dcc8a0c392 Issue #2084279 by herom, andypost, David Hernández, dawehner, Xano: Remove plugin.manager.entity service in favor of entity.manager. 2013-12-03 12:07:05 +00:00
Nathaniel Catchpole 15fded0c84 Issue #1988612 by effulgentsia, yched, Wim Leers, Berdir, Pancho: Apply formatters and widgets to rendered entity base fields, starting with node.title. 2013-12-03 11:53:16 +00:00
webchick 9bcaedec15 Issue #2047229 by fago, smiletrl, Berdir, effulgentsia, amateescu: Make use of classes for entity field and data definitions. 2013-11-27 13:55:54 -08:00
webchick b413088e68 Issue #2120335 by Wim Leers: Edit module only supports view modes, field_view_field() with a array is not supported. 2013-11-23 20:02:22 -08:00
webchick df1a669b77 Issue #2131851 by tim.plunkett: Form errors must be specific to a form and not a global. 2013-11-23 12:57:04 -08:00
webchick afa2377dca Issue #2134929 by Wim Leers: Clean up Edit: rename EntityView to EntityDecorationView. 2013-11-22 19:13:41 -08:00
Nathaniel Catchpole 172cd2652a Revert "Issue #1954892 by dawehner, tim.plunkett, David_Rothstein, effulgentsia: Replace 'theme callback' and hook_custom_theme() with a clean theme negotiation system."
This reverts commit fc04601c35.
2013-11-22 13:56:50 +00:00
Nathaniel Catchpole fc04601c35 Issue #1954892 by dawehner, tim.plunkett, David_Rothstein, effulgentsia: Replace 'theme callback' and hook_custom_theme() with a clean theme negotiation system. 2013-11-19 12:24:14 +00:00
webchick 0871544264 Issue #2133869 by Wim Leers: Clean up Edit's data- attributes. 2013-11-13 07:26:44 -08:00
webchick b810cf1dbd Issue #2133871 by Wim Leers: Remove dead code from Edit: Drupal.edit.AppView.enableEditor. 2013-11-13 07:24:27 -08:00
webchick cf59aaf8fb Issue #2133877 by Wim Leers: Clean up Edit's AppView variable names. 2013-11-13 07:23:33 -08:00
webchick 64c97584c4 Issue #2133897 by Wim Leers: Clean up Edit: don't pass AJAX URLs from the server to the client through drupalSettings, use Drupal.url() instead. 2013-11-13 07:06:05 -08:00
webchick 8a68d25d9a Issue #2133907 by Wim Leers: Clean up Edit's in-place editors: consistent naming, library naming and file naming. 2013-11-13 07:04:04 -08:00
webchick 4399709181 Issue #2066535 by tim.plunkett, jsst, Berdir: Add EntityManagerInterface and stop typehinting with EntityManager. 2013-10-30 16:09:40 -07:00
Nathaniel Catchpole 9d5aefb739 Issue #2048223 by dawehner, ParisLiakos, herom, fubhy, damiankloip, vijaycs85, joelpittet, tim.plunkett: Add $account argument to AccessCheckInterface::access() method and use the current_user() service. 2013-10-30 17:31:44 +00:00
Nathaniel Catchpole 2280ad5dec Issue #2083387 by Gábor Hojtsy, Wim Leers: Make it possible to use in-place editing on entities rendered by a custom render pipeline (e.g. Views). 2013-10-30 11:56:14 +00:00
Alex Pott 840e20aec6 Issue #2097691 by plopesc, amateescu: Move FIELD_CARDINALITY_UNLIMITED constant to FieldDefinitionInterface. 2013-10-26 09:26:00 -07:00
Alex Pott 82eb2924cf Issue #2112807 by tim.plunkett: Move the form builder functions in form.inc to a form service. 2013-10-25 15:54:34 -07:00
Alex Pott 3ded2216b0 Issue #2115145 by Berdir | effulgentsia: Move field type plugins to Plugin/Field/FieldType. 2013-10-19 09:12:13 +01:00
Alex Pott c1027b9d1a Issue #2050835 by Berdir | yched: Move Widget, Formatter, and FieldType plugin types to the Core\Field system. 2013-10-18 12:57:37 +01:00
Alex Pott b201c0546c Issue #2111209 by Xano: Fixed Rename FormInterface::getFormID() to FormInterface::getFormId(). 2013-10-16 13:37:27 +01:00
Jennifer Hodgdon fa841b8092 Issue #2105065 by tim.plunkett, dawehner: Standards cleanup for null and other types in API docs 2013-10-15 09:48:37 -07:00
webchick 005ca8a43d Issue #2108691 by Gábor Hojtsy, linclark, Wim Leers: Two PHPUnit tests not being run. 2013-10-11 07:35:40 -07:00
webchick 7a17c82533 Issue #1993894 by mgifford, Jelle_S, Wim Leers | jessebeach: Contextual quick edit toggle should be a <a role='button'> not a <a> because it tracks on/off state. 2013-10-11 07:34:17 -07:00
webchick ea72375a15 Issue #2107199 by Wim Leers: Allow Close(Modal)DialogCommand to remove the dialog from the DOM, document how client-side dialogs can do that too. 2013-10-10 08:32:35 -07:00
webchick 9f6d0920f6 Issue #2089397 by jessebeach, swentel, Wim Leers: Fixed Double 'Quick edit' contextual link. 2013-10-10 07:53:15 -07:00
webchick 1a1ba935cf Revert "Issue #2089397 by swentel, Wim Leers: Fixed Double 'Quick edit' contextual link."
Wrong commit message.

This reverts commit 9bc576cded.
2013-10-10 07:52:48 -07:00
webchick 9bc576cded Issue #2089397 by swentel, Wim Leers: Fixed Double 'Quick edit' contextual link. 2013-10-10 07:52:28 -07:00
webchick 03416ef5e3 Issue #2088815 by Gábor Hojtsy: Fixed Quick edit of taxonomy term field looses new terms if switching out/back to field. 2013-10-10 07:34:06 -07:00
Nathaniel Catchpole 36a7dd83bb Issue #1901100 by Gábor Hojtsy, jessebeach, Wim Leers: Make Edit module work with TempStore, so revisions are not saved on all atomic field edits. 2013-10-09 11:35:13 +01:00
webchick ccd257a9e7 Issue #2063401 by dawehner, damiankloip, tim.plunkett: Replace the default _access_checks()(access mode) with ALL instead of ANY. 2013-10-08 23:26:38 -07:00
webchick fdf3858b27 Issue #2057973 by aspilicious, Wim Leers: Don't add Edit module's data- attributes on pseudo fields (as used e.g. by Display Suite). 2013-10-05 00:33:07 -07:00
webchick 5b24f7bcdd Issue #2080217 by Wim Leers, tkoleary, Bojhan: Polish entity toolbar visually. 2013-10-05 00:14:39 -07:00
Alex Pott bcc5763239 Issue #1953408 by swentel, aspilicious, andypost, yched: Remove ArrayAccess BC layer from field config entities. 2013-10-04 08:55:32 +01:00
webchick 4f59f9746f Issue #2049207 by dlu, blakehall, janstoeckler, ramlev, Moderate | Cottser: Replace .tpl.php with .html.twig in documentation. 2013-10-03 15:08:29 -07:00
Alex Pott 3cee107ce5 Issue #2100329 by cosmicdreams: Use \Drupal instead of Drupal to make IDEs and static code analyse tools happy. 2013-10-03 12:26:25 +01:00
Alex Pott 691a576259 Issue #1994140 by Berdir, yched, fgm, smiletrl: Unify entity field access and Field API access. 2013-09-30 15:14:06 +02:00
webchick ee74914b50 Issue #2040021 by Wim Leers, tim.plunkett: Fixed In-place editing of nodes does not create new revisions (when the content type is configured to create new revisions by default). 2013-09-22 01:10:04 +02:00
webchick 34078b7291 Issue #2058843 by rteijeiro, jessebeach: Be consistent with respect to which strings within JS code should be overriddable via drupalSettings. 2013-09-22 01:05:50 +02:00
webchick deebed44b2 Issue #2087231 by tim.plunkett, pwolanin: Add a PluginBase in the Core namespace with t() as a helper method. 2013-09-18 18:48:18 -07:00
webchick 8347b04c34 Issue #2051097 follow-up by tim.plunkett: Remove silly spacing errors. 2013-09-15 22:06:19 -07:00
webchick 7cfa38d01a Issue #2051097 by dawehner, Manuel Garcia, tlattimore, neclimdul: Change 'pattern' to 'path' in *.routing.yml files. 2013-09-15 21:47:28 -07:00
webchick 5bb0d5e667 Issue #2053489 by chx, tim.plunkett: Standardize on \Drupal throughout core. 2013-09-15 20:58:10 -07:00
webchick 99670f0847 Issue #1981368 by tim.plunkett, Crell, webchick: Convert all routes to 'module_name().foo_bar()' naming convention. 2013-09-15 12:59:49 -07:00
webchick 0451a6d700 Issue #2083811 by yched, plach: Remove langcode nesting for fields in entity structures. 2013-09-12 22:35:51 -07:00
webchick d009cac09c Issue #2074037 by Wim Leers, effulgentsia: Add drupalPostUrl() — drupalPost()/drupalPostAjax() are for forms only, D8 JS performs non-form HTTP requests. 2013-09-11 12:41:33 -07:00
webchick e05902e5da Issue #2084513 by donquixote, EclipseGc: Annotation class loading could be more elegant. 2013-09-11 12:36:35 -07:00
Alex Pott cd882b6389 Issue #2061983 by InternetDevels, rhm50: Replace user_access() calls with ->hasPermission() in edit module. 2013-09-09 18:12:52 +02:00
Nathaniel Catchpole 085a24e07f Issue #2067017 by damiankloip: Remove usage of DRUPAL_CORE_COMPATIBILITY/VERSION constants. 2013-09-05 10:48:11 +01:00
webchick ee3542fa8c Issue #2078333 by Wim Leers | dcrocks: Fixed Blank links in tool menus because routes are automatically added to the Tools menu. 2013-09-04 10:16:22 -07:00
webchick 455749e07a Issue #2078847 by andypost: Clean-up the rest of 'plugin.manager.entity' to 'entity.manager'. 2013-09-02 13:10:01 -07:00
Alex Pott 7742cc3563 Issue #2057869 by dawehner, jibran: Provide an alias for 'plugin.manager.entity' called 'entity.manager'. 2013-09-01 13:24:15 +01:00
Nathaniel Catchpole 613a370a5b Issue #2057589 by smiletrl, tim.plunkett, alexpott, dawehner: Rename ControllerInterface to ContainerInjectionInterface. 2013-09-01 09:04:33 +01:00
Nathaniel Catchpole c7994001cc Issue #1497374 by yched, chx, amateescu, plach, Damien Tournoud, fago, swentel: Switch from Field-based storage to Entity-based storage. 2013-09-01 07:20:49 +01:00
webchick 61e213fe48 Issue #2047659 by Wim Leers, dawehner: Add test coverage for edit module access checkers. 2013-08-30 23:46:12 -07:00
webchick 8bd23e4bdd Issue #2065393 by dlu: Find 'use Drupal' and replace with inline references to \Drupal. 2013-08-30 23:28:33 -07:00
webchick fb7f2c7c85 Issue #2077313 by Berdir: Remove unecessary BC decorator code from edit.module. 2013-08-30 10:17:52 -07:00
Alex Pott cc249ad399 Issue #2067285 by LSU_JBob: Fixed The entity in-place editing toolbar appears above the Drupal dialog. 2013-08-29 01:46:18 +01:00
webchick 690e51d545 Issue #1872296 by nod_, Wim Leers, jessebeach: Edit should use core-provided Dialog (instead of its own). 2013-08-28 01:59:51 -07:00
Alex Pott 52771351f9 Issue #1758622 by klausi, fago, das-peter, Pancho, Berdir, yched: Provide the options list of an entity field. 2013-08-27 14:10:25 +01:00
webchick 5b001b81da Issue #2031385 by Wim Leers, Thomas Brekelmans: Fixed Editor's in-place editing AJAX endpoint broken because of #1043198 and routing system bug. 2013-08-19 08:45:11 -07:00
webchick 523fb85533 Issue #1847002 by tim.plunkett, effulgentsia, msonnabaum: Move entity type classes from Drupal$provider\Plugin\Core\Entity to Drupal$provider\Entity. 2013-08-18 14:16:19 -07:00
Nathaniel Catchpole 1c1774112c Issue #2047993 by plopesc: Remove current uses of field_info_*_types() / field_info_*_settings(). 2013-08-01 14:35:00 +01:00
Alex Pott d88a2be443 Issue #2043379 by tim.plunkett: Allow plugins to be discovered in any directory. 2013-07-25 00:57:30 +02:00
Nathaniel Catchpole bab8bdd98e Issue #2033433 by Wim Leers: Clean up edit controller. 2013-07-24 09:50:06 +01:00
Nathaniel Catchpole 22a6d8ccec Issue #2012382 by damiankloip: Improve efficiency of access checker matching on routes. 2013-07-15 10:22:26 +01:00
Alex Pott 5207055bc6 Issue #2032393 by effulgentsia: Limit APIs to FieldDefinitionInterface when FieldInstance isn't needed. 2013-07-10 20:28:14 +01:00
Dries 8d206bf531 Issue #1901100 by Gábor Hojtsy, jessebeach, Wim Leers: Make Edit module work with TempStore, so revisions are not saved on all atomic field edits. 2013-07-02 14:38:28 -04:00
Dries d988a30f87 Issue #1810370 by plach, kfritsche, berdir, alexpott, xjm, chx: Entity Translation API improvements. 2013-06-30 20:09:38 -04:00
Dries e924593126 Issue #1678002 by jessebeach, Wim Leers, Gábor Hojtsy: Edit should provide a usable entity-level toolbar for saving fields. 2013-06-29 17:42:22 -04:00
Dries 95cbbbcd43 Issue #1879120 by quicksketch, Wim Leers, larowlan, frega: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms. 2013-06-28 13:41:52 -04:00
Alex Pott 4586ea128d Issue #2014821 by amateescu, swentel: Introduce form modes UI and their configuration entity. 2013-06-27 22:24:39 +01:00
Alex Pott 2de46154c9 Issue #1981306 by aspilicious, andypost, pcambra, swentel, amateescu: Drop procedural usage of fields in [a-e] modules. 2013-06-18 12:38:11 +02:00
Alex Pott da1b134af1 Issue #1363112 by mparker17, mgifford, tlattimore, Jacine, dcmouyard, bowersox, ry5n, ahdiaz: Simplify names of 'element-x' helper classes. 2013-06-17 21:58:27 +02:00
Alex Pott d9f7b3a35b Issue #1950632 by effulgentsia, Wim Leers, amateescu, yched: Create a FieldDefinitionInterface, decoupled from and config entities, and use it for formatters and widgets. 2013-06-16 10:27:11 +02:00
Alex Pott 3b61f06bf9 Issue #2019481 by nod_: JavaScript AJAX commands object is borked: it is shared among all Drupal.ajax instances, preventing scoped overrides. 2013-06-14 15:37:00 +02:00
Alex Pott 984940b8f2 Issue #1985344 by tim.plunkett, swentel: Add a dedicated @FieldFormatter annotation. 2013-06-14 01:03:32 +02:00
Alex Pott 71a4ab13e2 Issue #1972514 by Wim Leers, effulgentsia, Gábor Hojtsy, ekl1773: Fixed Impossible to set attributes for all entities. 2013-06-12 16:57:44 +01:00
Alex Pott ba80bc317b Issue #2006278 by Wim Leers: Remove leftover 'module' annotation keys and plugin manager processDefinition() to deal with disabled modules during tests. 2013-06-12 16:23:04 +01:00
Alex Pott c65c6440a5 Issue #2011998 by David_Rothstein: String-parsing in hook_custom_theme() should be replaced with theme callbacks (for now). 2013-06-10 14:03:14 +01:00
Alex Pott 94e5ba411b Issue #2009002 by Floydm: Replace theme() with drupal_render() in edit module. 2013-06-09 17:52:52 +01:00
Alex Pott e0db7ebac1 Issue #1999344 by aaronott: Use Symfony Request for edit module. 2013-06-09 15:10:06 +01:00