Commit Graph

803 Commits (e57b926e8d4385e399731159bd90f862962a86ab)

Author SHA1 Message Date
Dries Buytaert 73010a5215 - Fix by darix: fixed content type settings broken by berkes' last patch. 2005-07-07 13:30:50 +00:00
Dries Buytaert d96e7e0bbb - Patches by Ber: move user settings and node settings to admin/settings. 2005-07-03 16:41:42 +00:00
Dries Buytaert 2c10ff4b5f - Fixed problems with filter formats and problem with XML-RPC server. 2005-06-29 19:53:14 +00:00
Dries Buytaert 58aee8cdad - Patch #25603 by Stefan: made the sizes of forms consistent.
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert 5c8843704c - Patch #18213 by chx: boostrap system. Modified to work with HEAD, tidied
up the documentation a little.

  chx: can you double-check whether the global $conf variable is secure?
       (That is, make sure it can't be send using the URL or something.)
2005-06-22 20:19:58 +00:00
Dries Buytaert f3a9a99570 - Patch #25121 by Robrecht J.: changed itemized lists with hardcoded CSS to definition lists. 2005-06-21 18:58:27 +00:00
Dries Buytaert e550f84162 - Patch #16204 by Thox: committed the collapsible form elements patch.
NOTE: this patch works well, but the improved node edit form still has
        some rough edges.  It is important that we continue to improve
        usability.  Give it a try.
2005-06-21 09:45:45 +00:00
Dries Buytaert 8436082fe1 - Removing some whitespace 2005-06-06 14:07:04 +00:00
Steven Wittens c928f9c1bb - #18836: Cleanup teaser generation code, and refine handling of PHP code teasers. 2005-06-01 03:42:47 +00:00
Steven Wittens 5257b684ff - #18836: Cleanup teaser generation code, and refine handling of PHP code teasers. 2005-06-01 03:32:22 +00:00
Steven Wittens a597354bcb - Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags. 2005-05-31 21:14:27 +00:00
Dries Buytaert d0390be0bd - Patch #18275 by Steven: "create content" menu displays extraneous links.
(Not sure if this needs to be backported to DRUPAL-4-6.)
2005-05-26 19:29:48 +00:00
Steven Wittens cbd6837b40 - #18406: make node_page 404 on meaningless nids 2005-05-25 07:14:00 +00:00
Steven Wittens 09354344e0 - Sort admin-content by descending node date. This got lost in the refinement-filter patch. 2005-05-25 03:51:00 +00:00
Steven Wittens 58bddf8abc * cue Star Wars theme tune *
Return of the JavaScript!

- #22519: form_autocomplete(): Ajax based autocompletion. Currently used for user names and folksonomy tags.
2005-05-24 06:00:22 +00:00
Dries Buytaert a5489b7b1c - Patch by chx: added a db_rewrite_sql() in node_load() just to make sure. 2005-05-17 20:24:33 +00:00
Dries Buytaert a76a1e1f3f - Patch 20910 by chx: centralize print theme page. 2005-04-24 16:34:36 +00:00
Dries Buytaert 9802b20a17 - Patch #20188 by Goba: Node_feed() instructs the nodeapi view call it invokes to deal with the body of the node, but afterwards it only uses the teaser to generate the feed. So the nodeapi hook should be called with teaser processing in mind. This simple patch fixes that. 2005-04-11 16:39:19 +00:00
Dries Buytaert 91e8b1b1e4 - Removed weird phpdoc line 2005-04-05 07:25:11 +00:00
Dries Buytaert a3e9b35afc - Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook. 2005-04-01 15:55:02 +00:00
Dries Buytaert 7bdcba1720 - Patch #19739 by Uwe: corrected many typo's in the documentation and code comments 2005-03-31 21:18:08 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Steven Wittens 54dfc577ba - #19353: Fix 'submit' button behaviour wrt optional previewing and form errors. 2005-03-27 21:34:50 +00:00
Steven Wittens d8fad6e24f - #17343: Fix safari CSS issues with node admin. 2005-03-27 15:54:44 +00:00
Steven Wittens 576c60803d - #19405: Fix SQL in comment block for anonymous users. 2005-03-24 22:09:31 +00:00
Steven Wittens 1185839923 - #19089: Remove depency on taxonomy.module by node.module (kjartan) 2005-03-18 18:46:23 +00:00
Steven Wittens e17490b653 - #12401: Non-admins should obey workflow wrt revisions. 2005-03-18 08:14:37 +00:00
Dries Buytaert 49240b6b1e - Patch #18216: fixed nodeapi settings hook. 2005-03-07 21:58:13 +00:00
Dries Buytaert 0f7be2573e - Bumped the RSS version from 0.92 to 2.0 2005-03-07 21:52:57 +00:00
Dries Buytaert 77f7aa0211 - Patch #18418 by chx: jonbob node_access_view_all patch changed the return value of node_access_where_sql to empty which breaks nicely all queries which are still using this function. This is a good incentive to upgrade to db_rewrite_sql, yes, but I think it causes confusion, 'cos it is not really trivial why the query suddenly not works. Let's make it trivial -- rename it _node_access_where_sql, it is no longer a function to be called from outside. node_access_join_sql similarly. 2005-03-05 11:05:07 +00:00
Steven Wittens 96eb9c6f9f #18226: Non-admins were not obeying workflow. 2005-03-04 00:48:22 +00:00
Steven Wittens 198ec98f75 #18329: Unify confirmation messages (and make them themable) 2005-03-03 20:51:27 +00:00
Dries Buytaert 3123d7e6ec - Patch #18045 by JonBob: the node type admin page uses an unclear callback name, and uses arg() where it is not necessary. The attached patch cleans this up by unifying node_types() with node_types_configure(). 2005-03-01 20:07:48 +00:00
Dries Buytaert a4befbb68b - Patch #18123 by chx: the $return['distinct'] in the past should have been module_implements('node_grants') but after JonBob's node_access_view_all_nodes, that part happens only if node_grants is in effect, so it is simplified to 1. 2005-03-01 20:01:40 +00:00
Steven Wittens ff386b90bb #17747: PGSQL improvements 2005-02-28 18:00:59 +00:00
Steven Wittens 538a3071de - #17870: Add preview CSS class to node preview (drumm) 2005-02-27 02:54:24 +00:00
Dries Buytaert 1e15bed312 - Patch #17687 by Gerhard: removed some cruft. 2005-02-21 19:47:44 +00:00
Steven Wittens bb08146c67 - Fixing broken search after sql rewrite patches
- Minor code style fixes.
2005-02-19 22:24:24 +00:00
Dries Buytaert d6b553c256 - Patch #16558 by JonBob: improved performance of node access checks. 2005-02-18 18:40:05 +00:00
Dries Buytaert 892d828629 - Fixed broken colspan. Reported by asimmonds. 2005-02-14 21:28:08 +00:00
Dries Buytaert 95f4d9751e - Fixed broken colspan. 2005-02-11 19:10:28 +00:00
Dries Buytaert 470fe1c1fd - Patch #16960 by Goba: fixed content type options. 2005-02-10 20:58:03 +00:00
Dries Buytaert 08e7c8b3a7 - Patch #16246 by Moshe: "Here is a patch for node.module since thta hunk failed last time. Note that I've removed the 'delete' link since it doesn't work and is mostly obsolete with the 'mass delete' feature. I've also added smart destination andling to the 'url alias delete' feature." 2005-02-10 19:30:08 +00:00
Steven Wittens 95907f0c2e - Fixing broken drupal_goto() after node submission on PHP5. 2005-02-04 20:48:37 +00:00
Steven Wittens 7fe195a07e - PHP5 fix due object references: node previewing should not put node output into form. 2005-02-04 20:14:05 +00:00
Steven Wittens ab816b6d6d - Fix warning due to old session variable. 2005-02-02 01:03:25 +00:00
Steven Wittens d56cf2b59c #10296: Clean up admin - content:
- Mass-delete functionality (with confirmation)
- Flexible filtering for the overview table based on status, type and taxonomy.
- Missing drupal_goto's
- Clean up watchdog messages
- Remove some dead code
2005-02-02 00:55:59 +00:00
Dries Buytaert 7931c778d7 - Patch #16513 by James (slightly modified): export categories and enclosures to RSS feeds (and made RSS feeds extensible).
NOTE: this needs to be documented.
2005-02-01 14:09:31 +00:00
Dries Buytaert 96c039680a - Patch #16111 by chx: fixed some bugs in the db_rewrite_sql() code. 2005-01-31 20:45:10 +00:00
Dries Buytaert 59c2208ea6 - Patch #16253 by Goba: incremental improvements to the new content markers.
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
Dries Buytaert 993ea0c6c5 - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. 2005-01-29 22:02:37 +00:00
Dries Buytaert c0f06fbe67 - Patch #6025 by Jeremy: avoid data to get lost when two users are editing a node at the same time. 2005-01-27 14:45:42 +00:00
Dries Buytaert 7415e0b1c8 - Patch #16192 by Neil: moved the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module. 2005-01-26 22:59:41 +00:00
Dries Buytaert 173f528f59 - Modified patch #14170 by Neil: improved default workflow (default node type) configuration page.
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
2005-01-24 21:20:16 +00:00
Dries Buytaert 9cd36863b0 - I had to modify chx's patch/change because it did not work with PHP5. Please double-check. 2005-01-23 16:20:10 +00:00
Dries Buytaert 898e02252d - Patch #16026 by chx: fixed node-level permissions. 2005-01-23 15:45:38 +00:00
Steven Wittens a332228326 Documenting a tricky regexp. 2005-01-22 22:33:20 +00:00
Steven Wittens 4e6ceaae99 - Another code style fix. 2005-01-19 01:51:58 +00:00
Steven Wittens 09bd156ba2 - Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes).
- Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
2005-01-19 01:46:25 +00:00
Steven Wittens 86af977eca - #15500: Fix tracker not showing nodes without comments.
- Tiny code style fix
2005-01-19 01:12:14 +00:00
Steven Wittens e7edb55d63 - The real code fixes ;) 2005-01-17 19:00:03 +00:00
Steven Wittens a1579a3aee - Reversing bad commit, sorry everyone. 2005-01-17 18:56:11 +00:00
Steven Wittens b45bd13d44 - Various code style fixes 2005-01-17 00:41:35 +00:00
Dries Buytaert 971a0e24aa - Patch #14731 by chx: made it possible to rewrite node queries. 2005-01-16 18:44:49 +00:00
Steven Wittens 92bc08b5b9 - Make the search settings page more user-friendly. 2005-01-11 09:41:49 +00:00
Steven Wittens 8655d4368a - Fixing a couple of watchdog() calls. 2005-01-09 12:58:53 +00:00
Dries Buytaert 64b100d19a - Patch #13260 by UnConeD: watchdog module improvements.
We added a 'severity' column to watchdog():
    watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);

    * Specify a severity in case you are reporting a warning or error.
    * The $link-parameter is now the fourth parameter instead of the third.

  TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
Dries Buytaert 1dbe0dc2ee - Patch #14917 by UnConeD/Steven:
1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.

2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.

3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
2004-12-31 09:30:12 +00:00
Dries Buytaert 05ede21745 - Patch #6308 by gordon: allow node_submit() to be used by external interfaces. 2004-12-26 20:10:02 +00:00
Steven Wittens 61b174e7d2 #11548: node.module - Ensure that only valid fields are saved 2004-12-24 06:44:11 +00:00
Dries Buytaert fde5f1bf6f - Patch #14709 by matteo: added missing call to the nodeapi's 'view' hook. 2004-12-23 23:26:14 +00:00
Steven Wittens 9f7b16ada9 #12793: Remove dependency of node.module on search.module. 2004-12-20 14:34:41 +00:00
Dries Buytaert 2b17b3a966 - Patch #13907 by Neil: less ways to set the page title.
* Less logic in theme code.
   * Encourages use of the menu system.
   * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
   * Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert 6e3eb60aab - Removed some cruft: left-over xxx_help_page() functions. 2004-12-11 14:13:24 +00:00
Dries Buytaert 60352821bf - Refactored the queue module: removed the queue module's field from the node table. With help from Gerhard.
- Slight addition to INSTALL.txt with regard to PHP versions.

- Updated/reworded some node type descriptions as per Boris' suggestions.

- Adding missing {} around a table name in update.php.
2004-12-07 16:55:38 +00:00
Steven Wittens 2afd987398 Search: indexing should invoke nodeapi to catch all user-visible data (e.g. file attachment names). 2004-12-02 06:44:55 +00:00
Dries Buytaert b83b34018f - Patch #10697 by matteo: avoid that administrators can create nodes with the wrong node type. 2004-11-29 12:49:17 +00:00
Dries Buytaert e1cf88e7f8 - Modified patch #11840 by Stefan: added conctext-sensitive help text to the 'revision'-page. 2004-11-27 10:02:06 +00:00
Dries Buytaert 30110a8770 - Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link().
TODO:
    1. Update theme upgrade instructions in the handbook: node_link() is gone.
    2. Remove page_link() just like we removed node_link().
2004-11-23 23:11:59 +00:00
Dries Buytaert 9574766ad8 - Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency. 2004-11-23 22:20:41 +00:00
Dries Buytaert fa97839088 - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
2004-11-21 08:25:17 +00:00
Steven Wittens dc32e54f31 Search.module:
- Caching index statistics
- Minor code cleanup
2004-11-18 21:28:34 +00:00
Steven Wittens 90e67a3acb Search indexing bug: last updated timestamp needs to take last comment timestamp into account. 2004-11-18 21:16:30 +00:00
Dries Buytaert 38c91a8d95 - Patch #8506 by Gerhard: added basic node_load() caching. 2004-11-17 22:14:43 +00:00
Dries Buytaert 9979aceab0 - Patch #12783 by Stefan: various small consistency/usability improvements. 2004-11-15 11:16:39 +00:00
Dries Buytaert 40f6197c5b - Patch #11940 by kps: if the user is not allowed to view a newly submitted node, redirect him to the main page. 2004-11-15 09:55:28 +00:00
Dries Buytaert 14353d18ad - Slightly modified the API of node_title_list(): it will no longer call comment_num_all() for each node. Instead, it checks for the availability of the node_comment field, available through the node_comment_statistics table. If updated the Doxygen comments accordingly.
People were using node_title_list() without realizing it would do numereous database queries.  This change greatly reduces the number of database queries required to render the node statistics block as well as to render the forum block (coming up next).

  If your module is using node_title_list() and you want the number of comments to be shown as title attributes, chances are you have to update your SQL query to join node_comment_statistics.
2004-11-04 21:02:30 +00:00
Dries Buytaert b6eee48c88 - Patch #12232 by Steven: more search improvements:
+ When a comment is posted, a node needs to be re-indexed. Luckily, we can use node_comment_statistics for this easily.
   + When a node is deleted, it should be deleted from the search index as well.
   + The search wipe didn't properly remove links to nodes from the index.
   + Section url was faulty in _help.
   + Minor code rearrangement.
2004-11-04 06:47:03 +00:00
Dries Buytaert bd6ae69345 - Patch by Steven:
+ Display 'friendly' name rather than module name in search watchdog
     messages.
   + Remove left-over from search_total table.
   + Add index wipe button to the admin
   + Moved the admin to admin/settings/search
   + Prevented menu bug when node modules update the breadcrumb in view
     (thanks JonBob).
   + Changed search_total table's word key to PRIMARY.
2004-11-03 16:46:58 +00:00
Dries Buytaert b3adcf05a3 - Patch #11875 by Neil Drumm: block module configuration improvements.
The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.

Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.

The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.

An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
2004-10-31 07:34:47 +00:00
Dries Buytaert 8daed9cbf3 - Patch #12232 by Steven/UnConed: search module improvements.
1) Clean up the text analyser: make it handle UTF-8 and all sorts of characters. The word splitter now does intelligent splitting into words and supports all Unicode characters. It has smart handling of acronyms, URLs, dates, ...

2) It now indexes the filtered output, which means it can take advantage of HTML tags. Meaningful tags (headers, strong, em, ...) are analysed and used to boost certain words scores. This has the side-effect of allowing the indexing of PHP nodes.

3) Link analyser for node links. The HTML analyser also checks for links. If they point to a node on the current site (handles path aliases) then the link's words are counted as part of the target node. This helps bring out commonly linked FAQs and answers to the top of the results.

4) Index comments along with the node. This means that the search can make a difference between a single node/comment about 'X' and a whole thread about 'X'. It also makes the search results much shorter and more relevant (before this patch, comments were even shown first).

5) We now keep track of total counts as well as a per item count for a word. This allows us to divide the word score by the total before adding up the scores for different words, and automatically makes noisewords have less influence than rare words. This dramatically improves the relevancy of multiword searches. This also makes the disadvantage of now using OR searching instead of AND searching less problematic.

6) Includes support for text preprocessors through a hook. This is required to index Chinese and Japanese, because these languages do not use spaces between words. An external utility can be used to split these into words through a simple wrapper module. Other uses could be spell checking (although it would have no UI).

7) Indexing is now regulated: only a certain amount of items will be indexed per cron run. This prevents PHP from running out of memory or timing out. This also makes the reindexing required for this patch automatic. I also added an index coverage estimate to the search admin screen.

8) Code cleanup! Moved all the search stuff from common.inc into search.module, rewired some hooks and simplified the functions used. The search form and results now also use valid XHTML and form_ functions. The search admin was moved from search/configure to admin/search for consistency.

9) Improved search output: we also show much more info per item: date, author, node type, amount of comments and a cool dynamic excerpt à la Google. The search form is now much more simpler and the help is only displayed as tips when no search results are found.

10) By moving all search logic to SQL, I was able to add a pager to the search results. This improves usability and performance dramatically.
2004-10-31 03:03:27 +00:00
Steven Wittens f46a82da51 #7607: Sort node types in node/add by translated names. 2004-10-29 00:51:49 +00:00
Dries Buytaert 10f329c057 - Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output.
Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
2004-10-19 18:02:31 +00:00
Dries Buytaert 7ebd772f41 - Patch #10664 by TDobes: fixed collapsed comments + updated the code comments. 2004-10-16 07:22:26 +00:00
Dries Buytaert 2510f322a1 - Modified patch #10613 by killes: generate a 'page not found'-page when a requested node does not exist. I modified the patch to avoid duplicate 'not found'-checking in the second bulk. 2004-10-12 20:01:25 +00:00
Dries Buytaert abcfd21927 - Code improvement: removed some redundant code from the node module. 2004-10-10 11:17:24 +00:00
Dries Buytaert 50bf139960 - Fixed bug #11405: unchecking the "publish" box in the default workflow admin page (admin/node/configure/defaults) did not cause the default workflow to change. This was caused by the fact that node_validate() forced the value of the status field to "1". 2004-10-09 16:27:59 +00:00
Dries Buytaert 503c784557 - Simplified/reorganized version of patch #9620 by Jeremy: fixed errors when writing to cache. 2004-10-04 22:04:07 +00:00
Steven Wittens dbead89c1f Part of #11280: node_preview() should only generate a teaser if none is present (e.g. provided by a module like excerpt.module). 2004-10-04 20:34:23 +00:00
Steven Wittens 1298d2b9c9 Modified version of #10230: Put placement of filter format selector in a module's hands, and move it below the relevant textarea. 2004-09-28 19:13:03 +00:00
Dries Buytaert 4f5164c980 - Patch #10977 by Gerhard: added missing node access controls for RSS feeds. 2004-09-21 18:43:54 +00:00
Dries Buytaert 293c283c3b - Patch #10884 by killes: node_access_where_sql() lost a parameter. 2004-09-20 20:06:29 +00:00
Dries Buytaert 8ae5e4417a - Bugfix: it was not possible to delete nodes. Reported by Philippe. 2004-09-20 12:05:31 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Steven Wittens a82b5143cf Removing useless 'read more' title attribute, as discussed. 2004-09-14 21:03:23 +00:00
Steven Wittens 93f193d7ad #8424: more meaningful link title=".." attributes for node_title_list(). 2004-09-14 02:28:37 +00:00
Steven Wittens b75c1e1c8b Replace hardcoded <html lang="en"> with a locale dependant one. This is especially important for asian sites where this has an effect on font selection. 2004-09-09 13:36:01 +00:00
Dries Buytaert b84b6e42cf - Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments. 2004-09-09 05:51:08 +00:00
Dries Buytaert 3f894f81e9 - Bugfix: removed bogus $name parameters.
TODO: when 'previewing' an existing node, the breadcrumb trail is incorrect.
2004-09-08 20:51:45 +00:00
Steven Wittens c76d5db8bd Node.module: teaser autogeneration should not overwrite user/module-supplied teaser data.
(makes excerpt.module possible)
2004-09-06 13:26:00 +00:00
Steven Wittens cdb6aa723b - #10342: PHP5 fix with undefined array. 2004-08-25 16:41:30 +00:00
Steven Wittens ad13675a4f - Fixing bug with PHP5 patch. 2004-08-23 00:44:02 +00:00
Steven Wittens 51cf18e531 - #9292: Make Drupal (somewhat) PHP5 compatible. xtemplate is still horribly broken. 2004-08-22 17:03:42 +00:00
Dries Buytaert 8b8a2bd634 - Patch #10187 by JonBob: bugfix: added missing permission check. 2004-08-21 16:04:12 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Dries Buytaert 83a739bd89 - Code improvements by Stefan: made all status messages consistent (and easier to translate). 2004-08-18 19:57:27 +00:00
Dries Buytaert 78b052a6af - The upload (filehandler) module has landed! 2004-08-17 21:35:26 +00:00
Dries Buytaert 451821abe7 - Patch #10110 by JonBob: code improvement: looks like we have an artifact from before clean URLs in node.module. This patch removes the global variable $mod, which is no longer set and not necessary here anyway. 2004-08-16 18:31:44 +00:00
Dries Buytaert 2f33b939c5 - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter. 2004-08-16 18:02:48 +00:00
Dries Buytaert ef07dd08f4 - Patch #10102 by Gerhard: removing some cruft from the node module! 2004-08-16 17:51:12 +00:00
Steven Wittens fc99c57d87 #6732: fixing bug 'once anonymous always anoymous' (nodes). 2004-08-14 17:05:32 +00:00
Steven Wittens cb36ef37cc #10033: by Jonbob, make sure no filter check is done until the first preview. 2004-08-13 18:17:10 +00:00
Steven Wittens 441b63accd Moving all legacy handlers into legacy.module. 2004-08-12 15:12:26 +00:00
Dries Buytaert 543d8b7208 - Patch #9972 by njivy: modified node_feed() for the instances where locale is not enabled. Without this patch, reset(array_keys($languages['name'])) throws an error. 2004-08-12 05:44:11 +00:00
Dries Buytaert 1831e1b690 - New locale module thanks to Gerhard, Goba, Marco, Kristjan and others.
The new locale module provides every functionality on the web interface, so you don't need to edit the configuration files or add columns, when you add a new language. This module is an integration of the old locale and localegettext modules, plus a bunch of logic to parse Gettext Portable Object files (opposed to Machine Object files, as supported by localegettext).

  Note: I made some minor changes to the context-sensitive help texts and to some of the status messages.
2004-08-11 11:26:20 +00:00
Steven Wittens 660f99287d The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
2004-08-10 18:34:29 +00:00
Dries Buytaert 821c6d2d17 - Patch #9812 by Adrian: fixed some PostgreSQL/ANSI SQL compabitibility
problems created by the new comment and node access permissions code.
2004-08-06 21:00:43 +00:00
Dries Buytaert b47e4e16d3 - Patch #9794 by JonBob: a bug introduced late in the review process makes individual node views inaccessible to users who should have permission. This does not affect node listings, so was missed. 2004-08-05 20:26:25 +00:00
Dries Buytaert c6b1eaa20d - Patch #9775 by TDobes: consistency operation. Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view". 2004-08-05 05:40:53 +00:00
Dries Buytaert 07ae0fad65 - Patch #9497 by gordon: made <!--break--> work even when the teaser length
is set to unlimited and fixed up some code comments.
2004-08-04 21:19:12 +00:00
Dries Buytaert c0f6fccac3 - Patch #7336 by TDobes: in various parts of Drupal, we use the title attribute for links to provide a slightly more detailed explanation as to the purpose of a link or where it goes. 2004-08-03 18:01:48 +00:00
Dries Buytaert 202eee42a9 - Patch #9543 by JonBob: added node-level access control! 2004-07-31 09:30:09 +00:00
Dries Buytaert aed1b0ca9e - Patch #5347 by JonBob:
Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:

Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.

Advantages of this refactoring:
- I can use it for book.module to remove the extra viewing path.
- The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
- We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
- The attachment.module people could use it to append their attachments in a list after the node.
- Gabor could use it instead of his filter perversion for his "articles in a series" module.
- A little less code in each view hook.
- The content hook is no longer needed, so that means even less code.

Disadvantages:
- Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
- Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).

Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
2004-07-30 13:37:26 +00:00
Dries Buytaert df2e5ef505 - Patch #8942 by Morbus: when testing under devel.module, the "SELECT timestamp from {history}" SQL statement is executed multiple times in two different functions. This duplicated code should be placed in a function, and that's been done already with node_last_visited() - the remaining code was just never updated to use the new routine. This patch changes the old code to use node_last_visited, and also modifies node_last_visited() to cache the result of the database call. 2004-07-13 20:44:13 +00:00
Dries Buytaert ac5b5616c0 - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
Dries Buytaert 898bdeffaf - Marked required fields on the node (story, book, page, blog) and comment
forms using the $required argument of the form_ functions.

- Replaced all Optional's and Required's from the taxonomy forms with proper
  use of the form_ functions.

Please check your contributed modules too!
2004-07-08 15:24:30 +00:00
Steven Wittens d615cb245e - Added revisions tab to node view (when needed)
- Updated node.module to use drupal_goto after submission: this allows people to refresh after submission without any problems.
2004-07-04 19:24:52 +00:00
Dries Buytaert fe2b3e7c00 - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00
Dries Buytaert 353c05d015 - Made it possible to edit blog posts and made the blog module use tabs. 2004-07-04 10:30:42 +00:00
Dries Buytaert 9986cb36b5 - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
Dries Buytaert e288b4ddb1 - Patch #8747 by JonBob: extended and standardized node.module Doxygen
comments, and made formatting and quote usage more consistent.
2004-06-22 20:24:27 +00:00
Dries Buytaert 090743bdba - Patch #8670 by asimmonds: more spelling fixes. 2004-06-21 20:05:37 +00:00
Dries Buytaert bfa7d178a9 - Patch #8713 by stefan: changed some 'node's to 'post's. Usability improvement. 2004-06-21 20:01:49 +00:00
Dries Buytaert c2d7419f23 - Patch #8681 by stefan: fixed some broken URLs and help texts. 2004-06-20 19:49:14 +00:00
Dries Buytaert efed4cfc70 - Patch #8679 by asimmonds: fixed spelling mistakes. 2004-06-20 08:27:03 +00:00
Dries Buytaert cbc230a36c - Patch #7696 by TDobes: renamed 'static' to 'sticky' which is a more
logical name.  Requires a database upgrade.
2004-06-19 10:39:36 +00:00
Dries Buytaert 71c99bb213 - Patch #8619 by TDobes: fixed typo in watchdog message. 2004-06-19 10:10:11 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Dries Buytaert 5ad73c8eb6 - Partial patch #8284 by jseng: made the RSS auto-discovery URL absolute even though that is not strictly necessary. 2004-06-17 18:46:41 +00:00
Steven Wittens 4d91449dd9 Quick improvement to autoteaser generation:
added double-width dot and comma, and right-to-left question mark as sentence boundaries.
2004-06-10 14:40:55 +00:00
Dries Buytaert c0b85a5721 - Patch #4950 by Stefan (and Morbus): made watchdog messages translatable. 2004-06-02 19:01:40 +00:00
Dries Buytaert aa3f05d819 - Patch #7096 by bylund: fixed a bug with the node filters at the node administration page (administration > content) 2004-05-03 17:38:40 +00:00
Dries Buytaert 2ca7eb7152 - Patch #6612 by JonBob: extended the node API with new hooks. 2004-04-28 20:23:30 +00:00
Dries Buytaert 33eb82e16f - Patch #6444 by Junyor: allow modules to change the 'changed' timestamp of nodes. 2004-04-24 07:41:49 +00:00
Dries Buytaert 7231c88a32 - Added support for 403 handling. Patch by JonBob. As a side benefit,
administrators will be able to define a custom 403 page, just as they
  can define 404 pages now.

  This needs to be documented in the "Changes since / migrating to ..."
  pages.
2004-04-21 13:56:38 +00:00
Dries Buytaert 10bdb51c37 - Patch by JonBob/Jonathan: reworked the menu system so that menus are
configurable!  Menu items can be disabled, repositioned, added and
  so on.

  Upgrading to requires you to run update.php.

  This functionality depricates some of the 'navigation modules' in the
  contributions repository.  Furthermore, modules can now 'suggest'
  menu items and site adminstrators can choose to enable them.  Modules
  in the contributions repository should try to take advantage of this.
2004-04-15 20:49:42 +00:00
Steven Wittens a083daf841 Truncate UTF-8 patch. Introduced a new function truncate_utf8() for chopping off strings at unsure locations, without risking incomplete UTF-8 data. 2004-04-15 14:07:08 +00:00
Steven Wittens 767141c49e Missing semi-colon for HTML entity. 2004-04-05 01:10:48 +00:00
Dries Buytaert 142dd6ba43 Patch #5588 by bylund: XHTML improvements: <i> -> <em> and <b> -> <strong>. 2004-03-20 13:29:06 +00:00
Dries Buytaert 2101f6c454 - Rewrote the profile module:
+ Added a 'created' field to the users table and renamed the 'timestamp'
     fied to 'changed' (cfr. node table).  Update.php will try to determine
     a 'created' timestamp for existing users.

   + The profile module no longer uses serialized data but has its own set
     of tables.  Known existing profile data is migrated by these new tables.
       TODO: migrate the birthday field.

   + The profile fields can be grouped, and within each group, profile fields
     can be sorted using weights.

   + The profile pages can be themed.

   + The profiles can be browsed based on certain properties/settings.

   + Change the _user hook: (i) 'private_view' and 'public_view' are merged
     into 'view' as there are no private fields and (ii) 'edit_form' has
     been renamed to 'edit'.

   + Avatar handling has been refactored and is now part of the user module.
     The users table has a dedicted 'picture' field.

   + Simplified the way themes should use display/visualize pictures or
     avatars.

   + Made it possible for administrators to replace or delete avatars.

   + ...

  I hope this make for a good base to build on collectively.
2004-03-11 20:33:59 +00:00
Dries Buytaert ccc9276f45 - Patch #4902 by Goba: fix URLs in RSS feeds.
+ Make all channel links absolute.
   + Always set the $base_url as xml:base, thus providing a solid base for
     relative URLs.
2004-03-06 16:17:48 +00:00
Dries Buytaert 744405e316 - Patch 6140 by Goba: fix the 'read more'-link behavior. 2004-03-06 10:57:53 +00:00
Dries Buytaert 0f980c24bc - Removed broken throttle. 2004-03-01 19:45:33 +00:00
Dries Buytaert c73305f6d6 - Patch #6129 by Goba: fixed dependencies on search module. 2004-02-29 17:16:27 +00:00
Dries Buytaert df2c033729 - Patch 6066 by Adrian: PostgreSQL does not return 'affected rows' when doing
a select statement.  Even though PEAR supports this functionality, it fails
  silently when using PostgreSQL.  We use the db_num_rows() function instead
  to return the amount of rows returned.  (According to Killes, the MySQL
  manual also states that it should not return affected rows on a 'select'
  statement.)
2004-02-26 17:55:14 +00:00
Steven Wittens b109518bc1 - Added a short note about the node-trim-length setting. Many people seem to expect that changing it updates existing teasers too. 2004-02-19 11:57:54 +00:00
Dries Buytaert 634893f298 - Patch 5683 by JonBob: changes the multiple type delimiter from / to -. 2004-02-16 18:33:37 +00:00
Dries Buytaert 4b0b2d02ee - Patch by Steven: removed redundant permission checks. These are no longer
required thanks to the new 404 handling.
2004-02-15 20:09:46 +00:00
Dries Buytaert b5c18e8a17 - Patch 5592 by Goba: introduced a new function, drupal_map_assoc(). 2004-02-12 19:37:04 +00:00
Dries Buytaert f137b26979 - Patch 4902 by Goba:
+ only adds an optional parameter to url() and l(), so individual links
    can be set to be absolute
  + modifies drupal_goto() to accept the parameters of url() without the
    $absolute parameter, so cleaner invocations can be used
  + rework of some code in node_feed, making it much better to look at
    (the current code uses foreach with an immediate brake to get the first
    key of the associative array, geeeeez)
  + added xml:base to the rss tag generated by node_feed()
  + set all user mail URLs to be absolute
  + fix a small fragmented URL in user.module
2004-02-11 19:21:14 +00:00
Dries Buytaert a333c05d74 - Patch by Gerhard: fixed instance of format_plural 2004-02-11 05:58:54 +00:00
Steven Wittens 5abbc3971f - Improved welcome message 2004-02-09 00:56:23 +00:00
Kjartan Mannes 97c2aa2bda - Modified format_date() to handle timezones properly. 2004-02-08 21:42:59 +00:00
Dries Buytaert 325f9891b2 - Added a welcome message written by Steven. 2004-02-08 21:16:03 +00:00
Kjartan Mannes 016a8f6830 - Removing timezone fix that crept in. 2004-02-08 20:38:53 +00:00
Kjartan Mannes bc407492e8 - Fixed codying style, typos, osbolete help. 2004-02-08 20:36:13 +00:00
Dries Buytaert 3e5d749838 - Fixed problem with multiple node types. Patch by JonBob. 2004-02-06 19:11:59 +00:00
Steven Wittens d3d8839764 Rolling back a couple of incorrect replacements in Dries' double-to-single-quotes patch. 2004-02-02 02:05:20 +00:00
Dries Buytaert c1559f66b5 - Changed 1100+ double quotes to single quotes. 2004-02-01 22:13:59 +00:00
Dries Buytaert eec20988bf - Patch #5575 by Stefan: fixed invalid XHTML code in the node and taxonomy module. 2004-02-01 21:51:28 +00:00
Dries Buytaert 252cf676ae - Patch #5526 by Kjartan: cleaned up node_page(), show a 404 when the node
could not be found.
2004-01-31 10:39:35 +00:00
Kjartan Mannes 63eccc5ebb - Modified node and comments to not be marked as new when they are 30 days old. 2004-01-29 22:00:31 +00:00
Dries Buytaert 1687dd07c9 - Patch 5049 by JonBob: allow a module to define multiple node types. 2004-01-27 18:47:07 +00:00
Dries Buytaert 66190b1787 - Patch #5393 by Goba: changes the search hook return value, and requires an array
containing two elements, the first being the requested title, and the second being
  the result list. Advantages:
    * Cleaner search code in common.inc
    * Po extraction is possible and works fine
    * No hardcoded exceptions for node and comment modules, since any module can
      return results in order of relevance (or another order)
2004-01-26 19:22:22 +00:00
Dries Buytaert b85eb11e11 Patch 5287 by Stefan: multiline help texts should become inside a single $output. 2004-01-23 18:42:43 +00:00
Dries Buytaert 860a5cc388 - Removed the $help parameter from the _form hook. The help, typically
submission guidelines, should be emmitted using the _help hook.
2004-01-17 09:07:00 +00:00
Dries Buytaert 6fc2070a22 Patch 5114 by Kjartan:
- Adds drupal_set_header() and drupal_get_headers().
 - Cache now stores custom headers.
 - Replace theme_head() with drupal_get_html_head(), added drupal_set_html_head().
 - Added RSS autodiscover links to node, blog and taxonomy pages.
2004-01-14 22:30:09 +00:00
Dries Buytaert eee72bfa95 - Patch 4859: new drupal_unpack() consolidates duplicate code and makes it
easy to show avatars next to nodes and comments.  Patch by Moshe.  As a
  showcase, maybe Xtemplate should have an option to enable/disable avatars?
2004-01-13 19:25:37 +00:00
Dries Buytaert a8b8c247db - Patch #5021: clean up URLs in _help texts. Patch by UnConeD. 2004-01-11 20:31:26 +00:00
Dries Buytaert 5ac59aacd2 - Applied patch #4949: node_prepare() wastes resources. Patch by Goba. 2004-01-11 20:16:26 +00:00
Dries Buytaert ee305ae144 Round 3 of aggregator improvements:
- Added support for new tags:
   + Optinal feed image: <image> tag.
   + Dublin core dates: <dc:date> <dcterms:created>, <dcterms:issued>,
     <dcterms:modified>.
 - Usability improvements:
   + On the administration page, made the feed/bundle titles link
     to the feeds/bundles' pages.  On the feed/bundle's page, made
     the 'Last updated' field link to the administration page.
   + Moved the 'syndication' menu one level down.
 - Updated some content sensitive help.
 - Further improved themeability.
 - Fixed some invalid HTML.
2004-01-11 15:05:21 +00:00
Dries Buytaert bd9064a6ca - Fixed bug #4965: typo in the help text. 2004-01-06 18:35:12 +00:00
Steven Wittens c2151b5248 Committed filter separation patch: all filter-related things are now in filter.module (which is a required module).
To do this cleanly, I reorganised some bits of system.module: there is now a generic handler available for simple variable-get/set based configuration pages. Look at filter_admin() or system_view() for example usage.

(based on the patch by Goba)
2004-01-05 19:19:05 +00:00
Dries Buytaert a9ef18266e - Patch 4916: improved preparation of $node->teaser and $node->body. Patch by
Goba.
2004-01-02 16:30:09 +00:00
Dries Buytaert 01d17d4aca - Patch #4093: only invoke check_output() once for performance's sake. Patch
by Goba.
2004-01-02 09:50:12 +00:00
Steven Wittens 51208885de General filtering improvements
- Re-added STYLE/ON*= filtering (this got lost a while ago due to reorganisation)
- Added form_group's to node.module's filter options
- Fixed incorrect filter usage in poll.module
2003-12-30 14:02:36 +00:00
Dries Buytaert 80f34e5ab0 - XHTML improvements: <b> -> <strong>. Patch by Stefan. 2003-12-29 17:14:27 +00:00
Dries Buytaert 6ab859555c - Usability improvements to the 'create content' section. Patch by Goba. 2003-12-22 11:55:49 +00:00
Dries Buytaert d5c8026454 - Updated the calls to menu() to use MENU_HIDE instead of 1 2003-12-17 22:27:23 +00:00
Dries Buytaert 928c113b82 Patch by Kjartan:
- Adds possibility to hide menu item when it has no children. (Fixes the
    node/add problem when user doesn't have access to create any node
    types.)
  - More doxygen comments.
2003-12-17 22:15:35 +00:00
Kjartan Mannes d8d2d69b82 - Fixed missing pager_display -> theme('pager'). 2003-12-08 19:32:06 +00:00
Dries Buytaert 712a30b520 - Improvements by Goba:
+ removes the lots of pagers and indirect pager themeing
  + add the theme_pager() function, which should be called as
    theme("pager", ...) to get a pager.
2003-12-08 18:30:20 +00:00
Dries Buytaert ea1acde1d5 - Usability improvement: just print a status message after a node
submission/update instead of using a separate page.  Patch 186 by Moshe.
2003-12-08 18:01:41 +00:00
Dries Buytaert 3904790e03 - Tidied up the DoxyGen comments. Patch by Kjartan. 2003-12-08 06:32:19 +00:00
Kjartan Mannes 0c80c55e91 - Fixed node_form() so it doesn't re-run node_validate() when there are no
errors and it has already been checked.
2003-12-06 19:15:38 +00:00
Dries Buytaert dcc3e24188 - Fixed bug #4457: make sure to cut of the teaser after the </p> tag, not
before the </p> tag.
2003-12-04 22:48:06 +00:00
Dries Buytaert 4e2c0b250e - Introduced a drupal_set_message() and drupal_get_message() function.
Contributed themes and modules need to be updated:
   - modules: status() is no more; use drupal_set_message() instead.
   - themes: use drupal_get_message() to check for status messages and
     visualize them.
2003-12-01 13:45:33 +00:00
Dries Buytaert c0494c0a2b - Committed phase 4 of JonBob's menu system changes. 2003-11-25 19:26:21 +00:00
Dries Buytaert 26735ac5dd - Committed phase 3 of JonBob's menu changes. Adds an API for modules to
define titles and breadcrumbs for their pages, and updates the theme
  system to display them.
2003-11-23 10:41:04 +00:00
Dries Buytaert 4bdac4333b - Patch by JonBob:
Phase 2 of the menu system integration project. This unifies the interface
  used by admin and non-admin pages, and deprecates the _page hook in favor of
  explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
  as a result of this patch; they will return in the phase 3 patch, printed
  by the theme.
2003-11-20 21:51:23 +00:00
Dries Buytaert 36bb57555c - table(...) -> theme("table", ...) 2003-11-13 19:52:54 +00:00
Dries Buytaert df44729306 - Made the revisions a separate page/tab. 2003-11-11 16:25:10 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert 00ee7f747b - Removed the "return" link from the node submission confirmation page. 2003-11-09 17:25:11 +00:00
Dries Buytaert 432852fbb8 - Bugfix: added missing t() function. Patch by Goba. 2003-11-07 19:26:10 +00:00
Dries Buytaert ef0fa006ed - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.
2003-11-07 19:03:35 +00:00
Dries Buytaert 00d638ca57 - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.

- Usability improvement: introduced a form_group() function and updated
  the node and comment module to take advantage of it.  Patch #149 by
  Eric Farris.
2003-11-06 18:27:58 +00:00
Dries Buytaert ec33266795 - Improvement: made it possible to disable the comment controls and reworded some of the configuration settings.
- Improvement: removed a left-over from Drupal 4.2.0 (dead code).

- Improvement: replaced hard-coded XHTML around the XML icons with class="xml-icon".

- Improvement: removed the custom navigation menus shown at the top of the "user information page" and integrated them in the new navigation block.  The "my account" link in the navigation menu will unfold.  Also removed the "delete account" link/functionality (for now).

- Improvement: fix for "magic quotes" settings.  Patch by Steven.  I also removed check_php_settings().

- Improvement: block themability improvements.  Modified patch from Ax and Steve/CodeMonkeyX.

- Fixed bug #2617: editing user information does not work.  Patch by Kjartan.
2003-10-31 19:34:03 +00:00
Dries Buytaert 8f9a19b340 - Bugfix: fixed problem with queue module. Fixes bug #3839. 2003-10-29 17:42:11 +00:00
Dries Buytaert 0a59c41f8c - Bugfix: corrected broken HTML in the documentation. 2003-10-23 15:04:13 +00:00
Dries Buytaert 72ae2d3995 - Bugfix: renamed the 'statistics' table to 'node_counter' as 'statistics' is
a reserved SQL keyword.  Required for both PostgreSQL and MSSQL.  Patch by
  Adrian.

- Bugfix: renamed the 'path' table to 'url_alias' as 'path' is a reserved SQL
  keyword.  Required for both PostgreSQL and MSSQL.  Patch by Adrian.
2003-10-22 20:20:35 +00:00
Dries Buytaert 742410aafd - Bugfix: prefix not prepended to sequences. Fixes bug #3639.
Make sure to write:

    db_next_id({table}_field);

  instead of:

    db_next_id(table_field);
2003-10-22 13:03:32 +00:00
Dries Buytaert 1fb82a6ebc - Bugfix/improvement: the revision table was not using table(). Fixes bug
#3635.
2003-10-21 18:34:54 +00:00
Dries Buytaert 2977a8cd3d - Some documentation fixes by Mark Coady. 2003-10-15 15:07:47 +00:00
Dries Buytaert e688dfe6db - Fixed prefix problem with the book module. Patch by Moshe.
- Usability improvements to the user module: removed some redundant menu
  items by taking advantage of the column sorting, added status messages
  and so on.  Patch by Moshe plus some fixes.

- Made the profile module use the table() function.  Patch by Moshe.

- Fixed breadcrumb spacing.  Patch by Moshe.

- Fixed colspan problem with node overview table.  Patch by Stefan.

- Fixed inconsistency with table sorting.  Patch 0122 by Al.
2003-10-13 19:18:39 +00:00
Dries Buytaert 1a5fcacdd9 - Committed part 3 of Michael's help system improvements: removed the $help
parameter from the menu() function.
2003-10-09 18:53:22 +00:00
Dries Buytaert 9d501cf822 - Removed duplicate information. Fixes bug 3511. 2003-10-08 17:35:19 +00:00
Dries Buytaert 22c889e7c0 - Help system improvements: eliminated the _system hook. Patch by Michael.
- Bloggerapi module fixes.  Patch by Kjartan.

- Coding style fixes.  Patch by Michael.
2003-10-07 18:16:41 +00:00
Dries Buytaert 058971c33b - Help improvements and translation improvements from Michael. Thanks! 2003-10-03 14:55:27 +00:00
Kjartan Mannes 463ccb4df6 - Fixed bug #3398: Error in SQL query in node.module (syndicate block) 2003-10-01 13:06:48 +00:00
Dries Buytaert 5a667eb580 - Url aliasing improvements. Patch by Matt. See mailing list for more
information.
2003-09-30 17:01:34 +00:00
Dries Buytaert 32e8d77cd6 - Associate a callback with the menu links! (This callback is not yet being
called but will be as soon the remaining links have been transformed to use
  the menu system.)

- Made sure the menu does not render links with no callback and no children.
  Like this, the 'create content' link is not being shown when the user has
  no permission to add any content.
2003-09-28 17:53:04 +00:00
Dries Buytaert c8b28009cd - Made sure all menu items can be translated. Path by Goba. 2003-09-28 15:18:55 +00:00
Dries Buytaert cc3ec29e87 - Committed Goba's translation fixes. 2003-09-28 14:11:49 +00:00
Dries Buytaert fe09d5a786 - Committed Al's new admin link texts. Remarks:
1) As explained by Al, there is still a glitch with the 'create content'
     menu.
  2) The user module part of the patch did not apply due to Kjartan's earlier
     patch.
2003-09-27 06:00:43 +00:00
Dries Buytaert f104d3cc12 - Committed the admin menu integration patch. Thanks Adrian, Stefan and others. 2003-09-26 10:04:09 +00:00
Dries Buytaert 586455b56e - Added a pubDate for each item. Patch by Neil. 2003-09-24 19:08:27 +00:00
Dries Buytaert 027f52541b - Rollback of some node API changes. Patch by Jonathan. 2003-09-23 17:57:26 +00:00
Dries Buytaert a4bc9fff9f - Rollback of some node API changes. Patch by Jonathan. 2003-09-23 16:54:19 +00:00
Dries Buytaert 00a62647bc - Committed Nick's _content improvements. 2003-09-20 15:11:41 +00:00
Dries Buytaert 2fbc7fcf27 - Committed a partial administration page integration patch. 2003-09-19 07:41:55 +00:00
Dries Buytaert e20f59d99a - Jonathan's "HTML filter" improvements.
> If turning on both filters is bad, we shouldn't allow the user to
> select both, should we? The attached patch folds the Escape HTML option
> into the same dropdown as the Filter HTML option, preventing both from
> being activated.
2003-09-16 18:34:39 +00:00
Dries Buytaert 62f939944f - Added 'escape HTML' option to the filters. Patch by Gabor Hojtsy. 2003-09-16 17:35:02 +00:00
Dries Buytaert d9cb4522bd - Book module improvements. This commit changes the behavior of the "view"
hook.  See mailing list for details; search for a mail with the subject:
  '[IMPORTANT] behavior of "view" hook changed'.  Modified patch from Nick.
2003-09-15 15:58:20 +00:00
Dries Buytaert 9fbab016f9 - Tidied up the usage of module_invoke() and module_invoke_all(). Patch by
Jonathan Chaffer.
2003-09-14 18:33:16 +00:00
Dries Buytaert 36a553c6e3 - Remove node_invoke_all as it has a misleading name and is redundant with
module_invoke_all.  Patch by Jonathan Chaffer.
2003-09-13 14:52:59 +00:00
Dries Buytaert ee35d9136e - Made the forum module's breadcrumb navigation fully themable. Patch by Nick.
- Changed 'pubdate' to 'pubDate'.  Patch by Kristjan.

- Fixed in Xtemplate theme; don't use return value of node_url() raw and uncut.
  Patch by me.
2003-09-12 18:13:22 +00:00
Dries Buytaert b9633dcded - Patch by Bart Jansen:
<quote>

  This adds session support for anonymous users and fixes a bug/typo.

    1. changed rid for user #0 from 0 to 1 (rid 1 == anonymous user) to make
       inner join work.

    2. replaced "if ($user .." by "if ($user->uid .." because now $user is
       always set (my previous change probably caused this).

    3. db_next_id("user_uid") -> db_next_id("users_uid");
  </quote>

  I repeat:

  "This adds session support for anonymous users and fixes a bug/typo."
2003-09-10 19:30:34 +00:00
Dries Buytaert e406d3054e - Added support for the optional <pubdate> element in our node RSS feeds. This
could help reduce the number of HTTP requests and fixes some annoyances with
  RSS clients.
2003-09-09 19:05:08 +00:00
Dries Buytaert 8e657f64ef - Gerhard's uid 0 patches. These patches bring various performance
improvements.  Requires a database update.
2003-09-09 18:18:43 +00:00
Dries Buytaert 6f4e902e3b - Corrected the form description of the URL aliasing; don't add a trailing
slash.  Reported by Stefan.
2003-08-30 07:40:19 +00:00
Dries Buytaert 93fb265d47 - Removed a debug statement. 2003-08-26 07:13:08 +00:00
Dries Buytaert 8a6ba5f1d0 - More mass-operation fixes. 2003-08-26 07:12:06 +00:00
Dries Buytaert f58a88dd26 - Fixed a couple of bugs with the mass node operations. 2003-08-26 07:05:11 +00:00
Dries Buytaert e98fe741a9 - Updated the node module to take advantage of the new help system. Patch by
Michael.
2003-08-23 18:25:35 +00:00
Dries Buytaert 4e2ee96d4c - Removed left-overs from the rating module. Patch by Gerhard. Updated the
PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.
2003-08-22 17:06:44 +00:00
Dries Buytaert 2bc440112b - Forgot to remove a debug statement. Thanks Bart. 2003-08-21 17:42:00 +00:00
Dries Buytaert 8d013b1666 - Applied Moshe's tablesort patch! Note that I changed the arrow images
because those of Moshe where not identical.
2003-08-21 15:47:50 +00:00
Kjartan Mannes 48805032c8 - Applied modified version of almaw's 0064 patch: form item attributes.
- Applied modified version of mathias' 0073 patch: node form name.
  $params["options"] is now an array so some contrib modules might
  need minor changes.

- Applied mathhias' 0074 patch: missing access check on who is new
  block.
2003-08-12 20:37:16 +00:00
Dries Buytaert 442f5b0757 - Added missing translation functions. Patch #78 by Stefan. Merged by hand
as the patch no longer applied.

- Fixed broken "view post" URL on administration page.  Reported by Bart.
2003-08-12 19:09:44 +00:00
Dries Buytaert d42158ce66 - Added more filters and support for "mass-operations" to the node overview page
in the admin section.  Comments?
2003-08-02 06:49:32 +00:00
Dries Buytaert 498f13c002 - If $node->path has been initialized (via a form for example), node_url will return it. This is not good because path could still be null (empty). Patch by Matt Westgate. 2003-07-31 09:56:29 +00:00
Dries Buytaert 869d8c6707 - Fixed broken links in the versioning system. Patch by Bart Jansens. 2003-07-31 09:50:33 +00:00
Dries Buytaert e278e46f49 - Applied Moshe's 007 patch: "read more" and author optimizations. 2003-07-26 13:18:49 +00:00
Dries Buytaert c39562ae03 - Fixed node_save() and user_save() bug introduced by table prefix changes.
Modified patches from Gerhard.

- Changed the order of the checks in node_teaser().  Patch from Kobus.
2003-07-21 15:36:05 +00:00
Dries Buytaert 8759ca7368 - Commited the URL aliasing patch. Thanks Matt.
This update requires you to run update.php!
2003-07-16 20:14:26 +00:00
Dries Buytaert 1252d51264 - Changed some INNER JOINs back to LEFT JOINs. Patch by Gerhard. Not tested
by me.
2003-07-16 07:58:02 +00:00
Dries Buytaert 22b6d2f30c - Performance improvement: changed a fair amount of "left joins" to "inner
joins".  Patch by Gerhard.
2003-07-12 22:21:55 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert d017514eba - Improvement: made it possible to translate the forum module. Patch #53 by Stefan.
- Improvement: some small changes to the user module to ease translation and to make things slightly more consistent.  This should be a better alternative for patch #54.

- Improvement: increase the maxlength of the node title.  This should fix bug #2018 and #2176.
2003-07-02 17:09:09 +00:00
Dries Buytaert dc15ba06e0 - Improvement: don't perform XSS checks for trusted users. Trusted users
are those that have the "bypass input data check" permission set.  Should
  address bug #2147.

- Improvement: simplified index.php and modules/admin.module.

- Bugfix: fixed broken links in bloggerapi documentation.  Patch by Chris
  Johnson.  Fixes bug #2030.

- Bugfix: fixed the date shown on a book module preview.  Reported as part
  of bug #2097.

- Bugfix: fixed broken URL in the book module documentation.
2003-07-01 17:54:22 +00:00
Dries Buytaert 886ae2bf15 - Fixed some "search related" bugs introduced by Moshe's latest patch.
Fixes bug #2127.
2003-06-30 19:18:47 +00:00
Dries Buytaert f4df719502 - Reworked the CXX checking; now, _any_ user input will be checked
and the request will be terminated when something suspicious is
detected.  This will be logged in the watchdog.  With help from Marco.

- Fixed translation issue in the archive module.  Patch by Gerhard.

- Removed dead parameter from variable_get().  Patch by Chris Johnson.
Fixes bug #2111.

- Improved input checking of taxonomy module.  Patch by Gerhard.
Fixes bug #2112.
2003-06-27 17:48:20 +00:00
Dries Buytaert 1f91ef891e - Bugfix: fixed bug #1627. 2003-06-24 18:26:32 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert d95499bf03 - Bugfix: small Xtemplate fixes. Patch by Ax. (Slightly modified.)
- Bugfix: block patch fix.  Patch by Gerhard.

- Bugfix: fixed broken URL in ping.  Patch by Gerhard.

  (This should fix the problems shown on http://www.blo.gs/info.php?id=1515.)

- Improvement: added better password generator.  Patch #1 by Al.  Fixes bug
  #1935.

- Improvement: performance improvement to the blog module.  Patch by Marco.
2003-06-13 17:34:18 +00:00
Dries Buytaert 643d2731e7 - Fixed two broken links in the "administration > content management >
post overview" page.
2003-06-08 17:40:13 +00:00
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert 8f783f69dd - Removed a redundant check_query().
- Removed a bogus check_input().
2003-06-06 21:06:08 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 3151a1cb71 - Usability improvements to the node form. Patch by Al. Will incorporate
some of Moshe's node form work later on.

TODO:

- I just spotted a problem with the promote field; it does not seem to be
  "sticky" when you click the preview button.  I checked and this was also
  the case prior to applying this patch.
2003-06-03 20:33:56 +00:00
Dries Buytaert 882c3f6d2d Removed node_get_node_from_nid() and modified node_load() to take an optional 2nd arguments to return a specified revision. Patch be Kjartan. 2003-06-01 06:32:55 +00:00
Dries Buytaert b7a0a744c6 - Committed Al's rollback fixes and the title improvements. Thanks again. 2003-05-31 12:34:11 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert c7bc17103a - Fixed braino. Reported by Remco as bug #1787. 2003-05-28 15:07:25 +00:00
Dries Buytaert b9e8016fc1 - Fixed validate problem. Patch by Ax. 2003-05-26 21:31:18 +00:00
Dries Buytaert d8f78a7c95 - Removed check_output() from the theme system layer. 2003-05-26 19:50:39 +00:00
Dries Buytaert 102cbe5ee2 - Undid Kjartan's latest change (it breaks the feeds) and fixed it properly. 2003-05-25 07:08:21 +00:00
Kjartan Mannes 94fd74096c - Moved the theme("header") call in node_page outside the access check so the
page renders properly when a user does not have access to content.
2003-05-24 23:13:58 +00:00
Dries Buytaert 45d5aad6df - Updated Drupal to use "on output" filters. Derived from Gerhard's patch. 2003-05-24 16:26:13 +00:00
Dries Buytaert 9863dd5a71 - Fixed typo in URL(). Patch by Al.
- Added a filter option to disable/enable the rewrite_old_urls() filter.
  See task #1542.
2003-05-23 21:59:44 +00:00
Dries Buytaert b5e644d6b0 - Some fields can be passed through the $_GET array (eg. to make the "blog
it" modules work).  Patch by Ax.
2003-05-19 18:36:58 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert 7aa28ea114 - Added an option to make "node previews" optional. Patch by n8. See
"site configuration > modules > node".
2003-05-10 13:54:38 +00:00
Dries Buytaert 54459cc01a - Fixed the function prototypes of the newly introduced theme_user_list(),
theme_node_list(), and theme_menu_list().  This will fix the excessive
  gap between lists and avoids generating empty <b></b> constructs.
2003-05-02 20:44:14 +00:00
Dries Buytaert 2d6408dff3 - Committed Adrian's item patch. It would be nice if one or more of the
standard themes could be updated to demonstrate the possibilities.
2003-04-29 20:48:50 +00:00
Dries Buytaert a956de78b9 - Fixed some PHP "notices". 2003-04-21 14:55:03 +00:00
Dries Buytaert 3c2dc18c82 - Fixed bug #1545: incorrect sequence tables on PostgreSQL. Patch by Neil.
In addition, I have updated update.php so it makes the corresponding
  changes for MySQL users.
2003-04-20 20:33:28 +00:00
Dries Buytaert 2de4c1c643 - Node API improvements by Moshe:
"implemented pieces of kjartan's original nodeAPI patch. the mingling
  of other modules into node.module logic decreases (a good thing). for
  example, the string "taxonomy" now appears nowhere in node.module

  - moved the saving of taxonomy terms when submitting a node out of
  node.module and into taxonomy.module

  - moved the deletion of comments while deleting a node out of
  node.module and into comment.module

  - improved usability of node forms by including node type in the title
  of the box and page"
2003-04-15 19:50:04 +00:00
Dries Buytaert 70f5b8649b A batch of changes:
- Renamed '---' to '<!--break-->'.

- Removed hard-coded call to the statistics module from the node module.
  Patch by Gerhard.

- Removed tables from poll module.  Modified patch by Al.  Changes to Al's
  patch are:
    "polltext" -> "poll-text"
    "pollfg"   -> "poll-foreground"
    "pollbg"   -> "poll-background"

- Changed some 'statistics.foo's to 's.foo's.  Patch by Gary.

[If this closes any bug reports, please update them on drupal.org.]
2003-04-14 18:44:59 +00:00
Dries Buytaert 4742ba3549 - Fixed some SQL query directives. 2003-03-29 16:30:40 +00:00
Dries Buytaert 297bc73f81 - Bugfix: deleting a node should flush the cache. 2003-03-16 21:47:15 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert dc19b22fb8 - Modified patch of Moshe. Enhances the tracker module so it displayes recent
*nodes* in addition to comments.  This will be helpful for tracking down new
  book nodes, blog posts, news items, and other stuff which isn't interesting
  enough to be promoted to the home page.
2003-03-14 20:41:27 +00:00
Kjartan Mannes 7c63dbccc8 - Fixing typos. 2003-03-11 08:43:59 +00:00
Kjartan Mannes b5ba5e22e1 - Added another security layer.
- Modified some moderation logic to make it more workable.
2003-03-10 12:01:26 +00:00
Kjartan Mannes 5a646024db - Ahem , trailing spaces. 2003-03-09 17:21:22 +00:00
Kjartan Mannes 1421c878d1 - Moved moderation logic back into node module.
* After having a chat with Dries we have agreed on the logics (or
      more specifically he told me how its supposed to work). The queue
      module is just a method to make moderation public, but its not
      necessarily the only way. This brings the power back.
- Minor interface tweaks (names, case changes, etc).
- Fixed error that would show when you tried to view the profile of a
  blocked user.
2003-03-09 17:19:50 +00:00
Kjartan Mannes a0deb476fa - Changed _nodeapi("conf") to _nodeapi("settings").
- Changed node settings page to use table().
- Minor code beautification here and there.
2003-03-08 14:35:42 +00:00
Kjartan Mannes 831ee21303 - Renamed "form.admin" to "form admin".
- Added node_admin_settings() to let users set node defaults.
    * Added _nodeapi("conf")
- Modified form_checkbox() to unset options. (Modified the patch from Ax.)
- Removed the _save() hook.
- Fixed a logical flaw in field_get() and field_set() which would break
  moderation.
- Moved some admin menus around and cleaned up some typos.
2003-03-07 22:11:44 +00:00
Dries Buytaert d659fedb38 - Removed the path_uri() function in favor of the $base_url variable and
fixes a handful of bugs introduced by the clean URL patch.
2003-03-07 06:37:30 +00:00
Dries Buytaert 6ccb8438bc - Fixed the "adminster" link at the bottom of every node's display. Patch
by Al.
2003-03-02 20:51:57 +00:00
Dries Buytaert 91dfef65af - Fixed some typos spotted by Al Maw. 2003-02-25 19:52:32 +00:00
Dries Buytaert b1f4758455 - Fixed typo. Patch by Garym. (Something went wrong with my earlier commit.) 2003-02-23 21:36:29 +00:00
Dries Buytaert 20e8bc12ca *** empty log message *** 2003-02-23 21:30:52 +00:00
Dries Buytaert 277ceae515 - New menu houskeeping. Prototyped by Zbynek.
The following modules need updating:
    * glossary module
    * feed module (Breyten's version)
    * mailhandler module
    * notify module
    * project module
    * smileys module
    * admin module
    * style module
    * taxonomy_dhtml module

  To avoid unexpected problems menu_add() is deprecated (it will print an
  error message when used) and menu() should be used instead.
2003-02-20 22:44:51 +00:00
Kjartan Mannes dd329e1d95 - Added function node_invoke_all($hook, &$node, $op, $arg = 0).
- Added a _nodeapi hook that in time will replace the _node hook. Trying
  to make as few changes to existing code as possible until the new api
  is stabilized.
- Modified node_form() to add administration options from other modules
  using the _nodeapi hook.
- Modified node_save() to fetch which fields should be saved to the node
  table from the _nodeapi hook.
- Moved comment and queue options from node_form() and node_save() to
  the modules _nodeapi hooks.
2003-02-16 14:57:35 +00:00
Dries Buytaert 83f5d82876 - Everything is using theme("function") now instead of $theme->function(). 2003-02-15 11:39:56 +00:00
Dries Buytaert e90f3b883b - See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html. 2003-02-11 20:01:17 +00:00
Dries Buytaert 9281d0cdd7 - Applied Alastair's date patch.
- Removed all instances of '$user->nodes'.

- Committed Moshe's taxonomy patch - minus the node_compact_list() bit.  It needs a bit more thought/work.  This patch changes the links of taxonomy pages/feeds so update your custom code and themes accordingly!

Themes should now use "taxonomy_link("taxonomy terms", $node)" to get an array of taxonomy term links.  The old construct is deprecated and should be changed.

// old theme blob:
if (function_exists("taxonomy_node_get_terms")) {
  foreach (taxonomy_node_get_terms($node->nid) as $term) {
    $terms[] = l($term->name, NULL, array(), "or=$term->tid");
  }
}

// new theme blob:
if (module_exist("taxonomy")) {
  $terms = taxonomy_link("taxonomy terms", $node);
}

// old URL:
http://foo.com/index.php?or=1,2

// new URL:
http://foo.com/?q=taxonomy/page/or/1,2
2003-02-09 17:39:40 +00:00
Dries Buytaert 10cb57a0b7 - Removed redundant code. 2003-02-02 21:05:34 +00:00
Dries Buytaert 2e6e1efbae - Renamed "Allow HTML tags" to "Filter HTML tags" for clarity. Reported by
Ax.
2003-01-29 23:15:10 +00:00
Dries Buytaert 37fe442d89 - Moved the filter()s back to the individual node modules as it used to be. 2003-01-23 18:11:19 +00:00
Dries Buytaert 637004c539 - Tidied up XHTML. Patch by Ulf.
- Added missing t() function.  Patch by Stefan.
2003-01-23 09:24:20 +00:00
Dries Buytaert d268783669 - Small improvement to the admin menu based on feedback from Michael. 2003-01-14 20:33:42 +00:00
Dries Buytaert 0fba793aff - Fixed a typo that caused quite a few redundant SQL queries. 2003-01-12 15:29:28 +00:00
Dries Buytaert 6334ee2093 - Code improvement: forgot to update an URL to the clean URL scheme. 2003-01-09 21:55:51 +00:00
Dries Buytaert 89b2069e4d - Clean URL patch. 2003-01-06 19:51:01 +00:00
Dries Buytaert 8a63646576 - Added an extra parameter to watchdog() which lets you specifiy an "action"
or "operation" link.

- Made the main page of the administration section show an overview of all
  watchdog entries with such action link.

- Fixed typo in PostgreSQL database scheme.
2003-01-04 11:03:15 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert 5598417c3f - Some small improvements/fixes to the node system. Suggested by Marco. 2002-12-30 13:02:47 +00:00
Dries Buytaert 24af61ede4 - Put back the node table paging. 2002-12-29 12:20:08 +00:00
Dries Buytaert 14158fbc6b - Added table rendering functions. As an example, I changed the node module
to take advantage of it.
2002-12-29 12:03:08 +00:00
Dries Buytaert 2254160642 - Added a "submit new content" link to the admin page. Suggested by Amy.
(Temporary solution only - probably needs better integration?)
2002-12-27 14:21:53 +00:00
Dries Buytaert 22fa9ed70a - Refactored the administration pages. 2002-12-24 15:40:32 +00:00
Dries Buytaert ca07ff36d6 - Fixed typo: "Allow users comments" -> "Allow user comments"
- By default, "Allow user comments" is set to "read-write".
2002-12-24 14:39:08 +00:00
Kjartan Mannes ca743aa6fd - fixing doctype in rss feeds. 2002-12-21 19:36:27 +00:00
Dries Buytaert c10ce14d1e - Switched the "short version" and the "long version" on the preview page.
- Removed a broken filter which caused some line breaks to be stripped.

- It is now possible to create short teasers and the '---' delimiter can
  be outside the allowed range but not more than a factor two.

- Fine-tuned teaser extraction in absence of the '---' delimiter.
2002-12-21 18:53:39 +00:00
Dries Buytaert 70c21f7ee0 - Added DOCTYPE. 2002-12-15 21:08:02 +00:00
Dries Buytaert 99d84c9330 - Committed Marco's pager improvements.
- Fixed another annoyance with editing content.
2002-12-14 11:55:54 +00:00
Dries Buytaert 9c11b14dc6 - Bugfixes by Marco.
- Attempt to fix linebreak handling.
2002-12-12 22:31:39 +00:00
Dries Buytaert 7ce686c152 o Permission improvements:
+ Removed the "post content" permission and replaced it by more fine-grained permissions such as "maintain static pages", "maintain personal blog", "maintain stories", etc.

o Usability improvements to teasers:

   + Teaser forms are no more.  Teasers are extracted automatically but can also be instructed using a delimiter "---".  Furthermore, when a post it too short for a teaser, the user won't be bother with teaser stuff anymore.

   + Added an option to set the teaser length, or to disable teasers all together.

   + When previewing a post, both the short (if any) and the full version of a post are shown.  This addresses a common complaint; for example, when writing a book page there was no way you could preview the short version of your post.

   + Forum posts can be teasered now.  This is particularly helpful in the context of drupal.org where we promote forum topics.

o Bugfix: replaced all PHP short tags (<?) with long tags (<?php).

o Bugfix: removed hard-coded dependence on comment module.

o Bugfix: when the queue module was disabled, it was not possible to approve updated book pages.

o Bugfix: applied modified version of Marco's node_teaser() fix.
2002-12-10 20:35:20 +00:00
Dries Buytaert dcbb71f4e5 - Fixed node revisions. 2002-12-02 21:37:08 +00:00
Dries Buytaert ab143d6870 - Fixed "Allow user comments: disabled" no longer works and so on. Patch by
Marco.
2002-12-02 18:47:12 +00:00
Dries Buytaert 8fa5440bb4 - Applied Jeremy's statistics module patches:
+ Fixed "recent users" title/timestamps.
   + Added statistics_node_delete() function.

- Applied Jeremy's node module patches:
   + Added call to statistics_node_delete().
   + Fixed call to taxonomy_node_delete().
2002-11-26 19:39:07 +00:00
Dries Buytaert 9e32c2e960 Patch based on work of Kjartan:
- Changed cache API.

- Fixed caching bug in comment.module.  Odd this hasn't been reported yet.

- Fixed caching bug in forum.module.

- Fixed caching bug in system.module.

- Fixed caching bug in block.module.

- Simplified caching support in forum.module thanks to improved cache API.
2002-11-17 06:42:52 +00:00
Dries Buytaert a6c8b10d8e Applied Moshe's patches:
- Adds more title info to each line in the block: now showing author and number of comments in a unified way accross all modules.

- Added pager support to blog module.

- Blog module now uses standard node view, not its own hack which is more theme friendly (http://www.drupal.org/node.php?id=133).

- Blog module now uses node_feed() function for making RSS feeds. since all feeds are now consolidated, a couple tweaks to node_feed() and format_rss_* would lead us to support new RSS formats easily.

- Fixed bugs where unpublished entries were displayed.
2002-11-11 20:59:28 +00:00
Kjartan Mannes 211d65b94f - Fixing read more link showing when teaser is empty. 2002-11-10 17:41:15 +00:00