f9c539aa21
Issue #1414412 by pillarsdotnet, MrHaroldA, droplet: Fixed Skip #conjunction key in __clone() method of core/includes/database/query.inc.
2012-03-07 10:34:16 -08:00
1bc549de8f
Merge remote-tracking branch 'origin/8.x' into 8.x-file-config
2012-02-29 19:47:35 -08:00
bdb71c6fa7
Merge remote branch 'crell/dbtngtng' into 8.x
2012-03-01 12:22:48 +09:00
a9cabde4e3
Cleaning up some todos
2012-02-22 21:28:37 -08:00
13db511a47
Stramlined read code slightly
2012-02-22 12:02:03 -08:00
e666688a1f
Exceptions now successfully being caught when db is missing
2012-02-22 12:01:25 -08:00
cc3d5edc53
Removed throw_exception because apparently that's not the problem after all
2012-02-22 10:55:30 -08:00
612c29cff6
Added an exception handler to config->get() which handles situations where the db is not in place, allowing us to remove a call to db_table_exists() which should improve cached performance a bit
2012-02-22 01:07:21 -08:00
b537f79f47
Docblock for clear()
2012-02-17 14:17:29 -08:00
eb6ea697b8
Renamed unset back to clear because unset is a reserved word which is the whole reason I didn't name it unset in the first place
2012-02-17 14:15:16 -08:00
c256f64104
Renamed clear() to unset()
2012-02-17 14:09:59 -08:00
aa0e17824b
Added docblock for castValue
2012-02-17 14:08:21 -08:00
208af9fec5
Chainable config()->set().
2012-02-16 14:28:51 -08:00
112afc273a
Removing extra blank lines
2012-02-16 13:17:07 -08:00
4f0f3c876f
Fixed missing type casting for configuration values.
2012-02-14 12:25:52 -08:00
40cc21c89d
Fixed Image module tests. Added many critical todos:
...
- Config values are not casted to strings (despite promised).
- Config keys are not casted to strings (although promised, too).
- XML can be invalid and not parse-able for many reasons.
- Config keys are not validated/sanitized.
- config()->clear() should really be ->unset().
- Configuration must not be additionally cached by a module in any way (static cache / database cache).
- Some modules invoke drupal_alter() on configuration (e.g., image styles).
- Need a way to list config object names/suffixes _after_ a specified prefix.
- Need a way to determine whether a config object exists.
- Some modules might have a valid use-case for retrieving/listing config objects using a wildcard within the name (instead of only searching by prefix).
- The key of a retrieved value is unknown; since you only get the value. Configuration values (or sub-values) may be passed forward to another function/callback, and thus, that function no longer knows about the key of the value. (unless the key is contained in the value, which is a very very wonky duplication)
- Config keys must not contain periods (within a specific key).
2012-02-14 12:25:39 -08:00
64eb1643d0
Fixed coding style.
2012-02-14 12:19:43 -08:00
3e65c6d1a1
Added @todo for $config->name property.
2012-02-14 12:16:43 -08:00
598cb86d2d
Added DrupalConfigStorageInterface::writeToFile().
...
write() called into copyToFile() previously, which needlessly re-loaded the configuration data from the active storage, whereas the data is already available.
2012-02-14 12:13:10 -08:00
b068ec4031
Instantiate SignedFileStorage object only once per config object.
2012-02-14 12:10:10 -08:00
00e4f78537
Expanded the comment on ->get() to be more explicit about string conversions
2012-02-13 14:15:40 -05:00
0810f57d8a
Merge branch '8.x-file-config' of git.drupal.org:sandbox/heyrocker/1145636 into 8.x-file-config
2012-02-13 13:56:57 -05:00
9485cf0ce8
Adding ability to return NULL if a value is not found
2012-02-13 13:02:02 -05:00
f71138695f
Fixed configuration file directory not setup for tests.
2012-02-13 18:53:07 +01:00
9689b0be06
Fully qualify path to PHP's Exception in our namespaced code.
2012-02-11 23:23:54 -05:00
a8df28f40d
Made config->delete() also blank out the internal data array to prevent people retrieving the data after deletion
2012-02-13 10:30:12 -05:00
5674c60a31
Removed getData() function since this is now replicated in get()
2012-02-13 09:42:41 -05:00
c0d37effeb
Removed todo that no longer applies
2012-02-12 14:00:59 -05:00
79c10d633d
Converting config system to PSR-0
2012-02-12 11:17:29 -05:00
b9131de629
Clean up exception naming with a new interface.
2012-02-02 23:17:31 -06:00
a7c6328d17
Merge remote-tracking branch 'core/8.x' into 8.x-file-config
2012-02-01 14:02:58 +01:00
037faa8fbf
Issue #1400748 by Crell, jbrown, plach: Proposal for unified namespace organization.
2012-02-01 12:23:30 +09:00
49839784e7
Add file docblocks to new DB files.
2012-01-28 18:27:11 -06:00
5a5c830761
Rename transaction use statement.
2012-01-28 17:54:14 -06:00
e9453d8b04
Merge branch '1400748-namespaces' into dbtngtng
2012-01-28 17:51:18 -06:00
24390d5857
Add empty stub files for Postgres.
2012-01-28 17:43:54 -06:00
03bd99a28b
Update documentation blocks for fully qualified class names.
2012-01-28 17:40:14 -06:00
a6b6fa5b91
Fix logic in Logger backtrace scanning now that the code is not in the includes directory anymore.
2012-01-28 16:44:35 -06:00
a731ac1df9
Merge branch '1400748-namespaces' into dbtngtng
2012-01-26 23:48:06 -06:00
808c88bd82
Add new readme file for the lib directory itself that specifies PSR-0.
2012-01-25 09:01:39 -06:00
fc73713158
Minor language tweaks.
2012-01-25 09:01:12 -06:00
f4a58c3f3a
Move Postgres code to PSR-0.
2012-01-23 21:16:26 -06:00
92286713d5
Move database files to the new lib directory and update code accordingly.
2012-01-22 23:56:07 -06:00
8b8c2a9463
refs #1400748 by Crell: Update docblocks and the installer for the new namespaces.
2012-01-22 22:25:13 -06:00
8b0adb6e1e
refs #1400748 by Crell: Add README files to document the purpose of various core directories.
2012-01-22 21:24:00 -06:00
7048b2195f
refs #1400748 by Crell: Move Cache subsystem to the Core namespace.
2012-01-22 21:05:01 -06:00
0cb703be45
refs #1400748 by Crell: Move Drupal and Symfony code to core/lib and core/vendor respectively.
2012-01-22 20:56:35 -06:00
webchick
Greg Dunlap
Nathaniel
sun
justinrandell
Larry Garfield